X-Git-Url: https://gerrit.fd.io/r/gitweb?p=csit.git;a=blobdiff_plain;f=resources%2Flibraries%2Fpython%2FTrafficScriptExecutor.py;h=7b5368fa9f7c8cdf67942322e055f6bf7f404d6e;hp=58d48d3ca90f1801902bcda7f9ec2ff25b697322;hb=da799981f5373b09398319df12e77e2efc75caa6;hpb=61b9af12c182d40cbeede66c2c9ec52c616fab03 diff --git a/resources/libraries/python/TrafficScriptExecutor.py b/resources/libraries/python/TrafficScriptExecutor.py index 58d48d3ca9..7b5368fa9f 100644 --- a/resources/libraries/python/TrafficScriptExecutor.py +++ b/resources/libraries/python/TrafficScriptExecutor.py @@ -1,4 +1,4 @@ -# Copyright (c) 2016 Cisco and/or its affiliates. +# Copyright (c) 2018 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -13,9 +13,7 @@ """Traffic script executor library.""" -from robot.api import logger - -from resources.libraries.python.constants import Constants +from resources.libraries.python.Constants import Constants from resources.libraries.python.ssh import SSH __all__ = ['TrafficScriptExecutor'] @@ -30,7 +28,7 @@ class TrafficScriptExecutor(object): :param string: String to escape. :type string: str - :return: Escaped string. + :returns: Escaped string. :rtype: str """ return string.replace('"', '\\"').replace("$", "\\$") @@ -55,7 +53,6 @@ class TrafficScriptExecutor(object): :raises RuntimeError: ARP reply timeout. :raises RuntimeError: Traffic script execution failed. """ - logger.trace("{}".format(timeout)) ssh = SSH() ssh.connect(node) cmd = ("cd {}; " + @@ -65,12 +62,9 @@ class TrafficScriptExecutor(object): "resources/traffic_scripts/{} {}") \ .format(Constants.REMOTE_FW_DIR, script_file_name, script_args) - (ret_code, stdout, stderr) = ssh.exec_command_sudo( - 'sh -c "{}"'.format(TrafficScriptExecutor._escape(cmd)), + ret_code, stdout, stderr = ssh.exec_command_sudo( + 'sh -c "{cmd}"'.format(cmd=TrafficScriptExecutor._escape(cmd)), timeout=timeout) - logger.debug("stdout: {}".format(stdout)) - logger.debug("stderr: {}".format(stderr)) - logger.debug("ret_code: {}".format(ret_code)) if ret_code != 0: if "RuntimeError: ICMP echo Rx timeout" in stderr: raise RuntimeError("ICMP echo Rx timeout") @@ -103,7 +97,7 @@ class TrafficScriptExecutor(object): :type dst_mac: str :type src_ip: str :type dst_ip: str - :return: Traffic script arguments string. + :returns: Traffic script arguments string. :rtype: str """ args = ('--rx_if {0} --tx_if {1} --src_mac {2} --dst_mac {3} --src_ip'