X-Git-Url: https://gerrit.fd.io/r/gitweb?p=csit.git;a=blobdiff_plain;f=resources%2Flibraries%2Fpython%2FVatExecutor.py;h=1d0a2133c0194eccce0b2bd12cc00ff01a90ef38;hp=0e40266f1c539c4a7bac4d5fc8b536f989dd96a1;hb=669d320bc64e41f879c047a39a66b8ec99bf4b1e;hpb=da799981f5373b09398319df12e77e2efc75caa6 diff --git a/resources/libraries/python/VatExecutor.py b/resources/libraries/python/VatExecutor.py index 0e40266f1c..1d0a2133c0 100644 --- a/resources/libraries/python/VatExecutor.py +++ b/resources/libraries/python/VatExecutor.py @@ -21,7 +21,7 @@ from robot.api import logger from resources.libraries.python.ssh import SSH, SSHTimeout from resources.libraries.python.Constants import Constants -from resources.libraries.python.VatHistory import VatHistory +from resources.libraries.python.PapiHistory import PapiHistory __all__ = ['VatExecutor'] @@ -74,7 +74,7 @@ class VatExecutor(object): self._script_name = None def execute_script(self, vat_name, node, timeout=120, json_out=True, - copy_on_execute=False): + copy_on_execute=False, history=True): """Execute VAT script on remote node, and store the result. There is an option to copy script from local host to remote host before execution. Path is defined automatically. @@ -87,11 +87,13 @@ class VatExecutor(object): :param json_out: Require JSON output. :param copy_on_execute: If true, copy the file from local host to remote before executing. + :param history: If true, add command to history. :type vat_name: str :type node: dict :type timeout: int :type json_out: bool :type copy_on_execute: bool + :type history: bool :raises SSHException: If cannot open connection for VAT. :raises SSHTimeout: If VAT execution is timed out. :raises RuntimeError: If VAT script execution fails. @@ -107,9 +109,12 @@ class VatExecutor(object): if copy_on_execute: ssh.scp(vat_name, vat_name) remote_file_path = vat_name - with open(vat_name, 'r') as vat_file: - for line in vat_file: - VatHistory.add_to_vat_history(node, line.replace('\n', '')) + if history: + with open(vat_name, 'r') as vat_file: + for line in vat_file: + PapiHistory.add_to_papi_history(node, + line.replace('\n', ''), + papi=False) else: remote_file_path = '{0}/{1}/{2}'.format(Constants.REMOTE_FW_DIR, Constants.RESOURCES_TPL_VAT, @@ -247,7 +252,7 @@ class VatTerminal(object): self._tty, 'sudo -S {0}{1}'.format(Constants.VAT_BIN_NAME, json_text), self.__VAT_PROMPT) - except Exception: + except Exception: #pylint: disable=broad-except continue else: break @@ -283,7 +288,7 @@ class VatTerminal(object): :returns: Command output in python representation of JSON format or None if not in JSON mode. """ - VatHistory.add_to_vat_history(self._node, cmd) + PapiHistory.add_to_papi_history(self._node, cmd, papi=False) logger.debug("Executing command in VAT terminal: {0}".format(cmd)) try: out = self._ssh.interactive_terminal_exec_command(self._tty, cmd, @@ -301,10 +306,9 @@ class VatTerminal(object): raise RuntimeError("More instances of VPP running on node " "{0}. VAT command {1} execution failed.". format(self._node['host'], cmd)) - else: - raise RuntimeError("VPP not running on node {0}. VAT command " - "{1} execution failed.". - format(self._node['host'], cmd)) + raise RuntimeError("VPP not running on node {0}. VAT command " + "{1} execution failed.". + format(self._node['host'], cmd)) logger.debug("VAT output: {0}".format(out)) if self.json: