PAPI stats: Use list as argument to ls 26/31826/2
authorVratko Polak <vrpolak@cisco.com>
Tue, 30 Mar 2021 14:31:26 +0000 (16:31 +0200)
committerVratko Polak <vrpolak@cisco.com>
Tue, 30 Mar 2021 14:31:26 +0000 (16:31 +0200)
commit0d65bbb9619720ecc6bca1529acfb3a5239d9719
tree32feba37ff8a9ea237b126d04b9f86eb2c4f8deb
parent33f1fd4e8066802d596c2e59387a384788c21315
PAPI stats: Use list as argument to ls

In the VPP PAPI stats code, the "ls" argument has always [0]
been named "patterns", suggesting it expects a list of strings.
In the CSIT utility we have always [1] been using it wrong
(passing a single string), but it happened to work
as VPP code had a workaround [2] for that.
This workaround that got removed by accident in [3],
and will be reintroduced in [4].

This change fixes occasional failures in CSIT
(if merged sooner than [4]), mainly useful
in aviding such failures during bisection.

[0] https://gerrit.fd.io/r/c/vpp/+/14584/4/src/vpp-api/python/vpp_papi/vpp_stats.py#122
[1] https://gerrit.fd.io/r/c/csit/+/18419/13/resources/tools/papi/vpp_papi_provider.py#181
[2] https://gerrit.fd.io/r/c/vpp/+/14584/4/src/vpp-api/python/vpp_papi/vpp_stats.py#64
[3] https://gerrit.fd.io/r/c/vpp/+/31678
[4] https://gerrit.fd.io/r/c/vpp/+/31817

Change-Id: Ic0f9d906be064b386b67154ba738646c4362aa2b
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
resources/tools/papi/vpp_papi_provider.py

©2016 FD.io a Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation. Linux is a registered trademark of Linus Torvalds.
Please see our privacy policy and terms of use.