PapiExecutor always verifies 70/20170/50
authorVratko Polak <vrpolak@cisco.com>
Tue, 9 Jul 2019 10:17:09 +0000 (12:17 +0200)
committerDave Wallace <dwallacelf@gmail.com>
Fri, 12 Jul 2019 13:00:49 +0000 (13:00 +0000)
commit33fb34665214bbbd0a4b3154169b21c2da01f69b
tree9ebb70889824451cf8411875159a6fafd70b60ac
parentccfe499e2a27f2caf234ecbb2ec948120810eab6
PapiExecutor always verifies

Do not support returning unverified replies anymore.
Basically, ".get_replies().verify_replies()" is now just ".get_replies()".
This allows fairly large simplifications both at call sites
and in PapiExecutor.py

+ Rename get_dumps to get_details.
+ Introduce get_reply and get_sw_if_index.
+ Rename variables holding get_*() value,
  + e.g. get_stats() value is stored to variable named "stats".
  + Rename "item" of subsequent loop to hint the type instead.
  + Rename "details" function argument to "verbose".
+ Process reply details in place, instead of building new list.
  - Except hybrid blocks which can return both list or single item.
  - Except human readable text building blocks.
+ Rename most similar names to sw_if_index.
  - Except "vpp_sw_index" and some function names.
+ Use single run_cli_cmd from PapiExecutor.
+ Do not chain methods over multiple lines.
  + Small space gain is not worth readability loss.
+ Include minor code and docstrings improvement.
+ Add some TODOs.

Change-Id: Ib2110a3d2101a74d5837baab3a58dc46aafc6ce3
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
20 files changed:
resources/libraries/python/Classify.py
resources/libraries/python/IPUtil.py
resources/libraries/python/IPsecUtil.py
resources/libraries/python/IPv6Util.py
resources/libraries/python/InterfaceUtil.py
resources/libraries/python/L2Util.py
resources/libraries/python/Memif.py
resources/libraries/python/NATUtil.py
resources/libraries/python/PapiExecutor.py
resources/libraries/python/ProxyArp.py
resources/libraries/python/PythonThree.py [new file with mode: 0644]
resources/libraries/python/Tap.py
resources/libraries/python/TestConfig.py
resources/libraries/python/VPPUtil.py
resources/libraries/python/VhostUser.py
resources/libraries/python/VppCounters.py
resources/libraries/python/ssh.py
resources/libraries/python/telemetry/SPAN.py
resources/libraries/python/topology.py
resources/libraries/robot/performance/performance_configuration.robot

©2016 FD.io a Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation. Linux is a registered trademark of Linus Torvalds.
Please see our privacy policy and terms of use.