Fix various pylint 1.5.4 warnings 87/12187/7
authorVratko Polak <vrpolak@cisco.com>
Thu, 26 Apr 2018 13:15:51 +0000 (15:15 +0200)
committerPeter Mikus <pmikus@cisco.com>
Fri, 4 May 2018 09:35:22 +0000 (09:35 +0000)
commit5e7be479eacd4d1085cab152c35dcb6433a146ed
tree0d91e7ae63856c3d3d4588654abfd6ed8fa8a76a
parentceb7c2545cda1bc7fe3d4bf35cdf75253efe8c6d
Fix various pylint 1.5.4 warnings

+ DUTSetup.py:424 Else clause on loop without a break statement
+ InterfaceUtil.py:400 Else clause on loop without a break statement
+ QemuUtils.py:564 Wrong continued indentation
+ SetupDPDKTest.py: Locally enabling broad-except
+ VatExecutor.py: Catching too general exception Exception
+ ssh.py:95 No exception type(s) specified.
+ HTTPRequest.py: Tolerate HTTPCodes.OK
+ multiple: Drop ":returns: None" from docstrings.

There are still several warnings present:
- R0902(too-many-instance-attributes)
- R0912(too-many-branches)
- R0913(too-many-arguments)
- R0914(too-many-locals)
- R0915(too-many-statements)
- R0401(cyclic-import)

And there are multiple blocks of similar lines,
mainly across various Setup*Test.py files:
- R0801(duplicate-code)

Change-Id: I582575cb52b85d69d268e6374852f6e74bb71052
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
17 files changed:
resources/libraries/python/DPDK/DPDKTools.py
resources/libraries/python/DPDK/L2fwdTest.py
resources/libraries/python/DPDK/L3fwdTest.py
resources/libraries/python/DPDK/SetupDPDKTest.py
resources/libraries/python/DUTSetup.py
resources/libraries/python/HTTPRequest.py
resources/libraries/python/InterfaceUtil.py
resources/libraries/python/L2Util.py
resources/libraries/python/PacketVerifier.py
resources/libraries/python/QemuUtils.py
resources/libraries/python/SFC/SFCTest.py
resources/libraries/python/SFC/VerifyPacket.py
resources/libraries/python/TLDK/UdpTest.py
resources/libraries/python/VatExecutor.py
resources/libraries/python/ssh.py
resources/tools/topology/update_topology.py
resources/traffic_scripts/honeycomb/read_vpp_version.py