Add comments for some tag exclusions 68/20068/6
authorVratko Polak <vrpolak@cisco.com>
Wed, 12 Jun 2019 10:28:45 +0000 (12:28 +0200)
committerPeter Mikus <pmikus@cisco.com>
Fri, 14 Jun 2019 20:29:52 +0000 (20:29 +0000)
Change-Id: I9daa70e433a2942d29c4e64856cb76d31f94a6f3
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
resources/libraries/bash/function/common.sh

index 52f6f08..810500e 100644 (file)
@@ -675,7 +675,14 @@ function select_tags () {
             test_tag_array+=("!vts")
             ;;
         *"3n-hsw"*)
             test_tag_array+=("!vts")
             ;;
         *"3n-hsw"*)
+            # TODO: Introduce NOIOMMU version of AVF tests.
+            # TODO: Make (both) AVF tests work on Haswell,
+            # or document why (some of) it is not possible.
+            # https://github.com/FDio/vpp/blob/master/src/plugins/avf/README.md
             test_tag_array+=("!drv_avf")
             test_tag_array+=("!drv_avf")
+            # All cards have access to QAT. But only one card (xl710)
+            # resides in same NUMA as QAT. Other cards must go over QPI
+            # which we do not want to even run.
             test_tag_array+=("!ipsechwNOTnic_intel-xl710")
             ;;
         *)
             test_tag_array+=("!ipsechwNOTnic_intel-xl710")
             ;;
         *)