author Vratko Polak Thu, 14 Jan 2021 12:34:08 +0000 (13:34 +0100) committer Tibor Frank Mon, 18 Jan 2021 05:32:14 +0000 (05:32 +0000)
Previously, they used sloped lines connecting reported points.
But HdrHistogram reports only the upper bound of percentile.
Example: If all samples are 10us,
HdrHistogram reports a single value at 100%.

This change attempts to show the whole intervals (0%-100% for the example)
as a series (vertically connected) of horizontal lines.
Hover also shows percentiles as intervals.

Change-Id: Id7bbff7b1c29d7f62472041340fde88903363cfa
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

index 05f525c..dd00939 100644 (file)
@@ -1,4 +1,4 @@
-# Copyright (c) 2020 Cisco and/or its affiliates.
+# Copyright (c) 2021 Cisco and/or its affiliates.
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at:
@@ -173,6 +173,7 @@ def plot_hdrh_lat_by_percentile(plot, input_data):

for color, graph in enumerate(graphs):
for idx, direction in enumerate((u"direction1", u"direction2")):
+                    previous_x = 0.0
xaxis = list()
yaxis = list()
hovertext = list()
@@ -190,14 +191,23 @@ def plot_hdrh_lat_by_percentile(plot, input_data):
percentile = item.percentile_level_iterated_to
if percentile > 99.9999999:
continue
+                        xaxis.append(previous_x)
+                        yaxis.append(item.value_iterated_to)
+                        hovertext.append(
+                            f"<b>{desc[graph]}</b><br>"
+                            f"Direction: {(u'W-E', u'E-W')[idx % 2]}<br>"
+                            f"Percentile: {previous_x:.5f}-{percentile:.5f}%<br>"
+                            f"Latency: {item.value_iterated_to}uSec"
+                        )
xaxis.append(percentile)
yaxis.append(item.value_iterated_to)
hovertext.append(
f"<b>{desc[graph]}</b><br>"
f"Direction: {(u'W-E', u'E-W')[idx % 2]}<br>"
-                            f"Percentile: {percentile:.5f}%<br>"
+                            f"Percentile: {previous_x:.5f}-{percentile:.5f}%<br>"
f"Latency: {item.value_iterated_to}uSec"
)
+                        previous_x = percentile
plgo.Scatter(
x=xaxis,
@@ -208,7 +218,8 @@ def plot_hdrh_lat_by_percentile(plot, input_data):
showlegend=bool(idx),
line=dict(
color=COLORS[color],
-                                dash=u"dash" if idx % 2 else u"solid"
+                                dash=u"solid",
+                                width=1 if idx % 2 else 2
),
hovertext=hovertext,
hoverinfo=u"text"
@@ -328,6 +339,8 @@ def plot_hdrh_lat_by_percentile_x_log(plot, input_data):

for color, graph in enumerate(graphs):
for idx, direction in enumerate((u"direction1", u"direction2")):
+                    previous_x = 0.0
+                    prev_perc = 0.0
xaxis = list()
yaxis = list()
hovertext = list()
@@ -345,14 +358,25 @@ def plot_hdrh_lat_by_percentile_x_log(plot, input_data):
percentile = item.percentile_level_iterated_to
if percentile > 99.9999999:
continue
-                        xaxis.append(100.0 / (100.0 - percentile))
+                        xaxis.append(previous_x)
+                        yaxis.append(item.value_iterated_to)
+                        hovertext.append(
+                            f"<b>{desc[graph]}</b><br>"
+                            f"Direction: {(u'W-E', u'E-W')[idx % 2]}<br>"
+                            f"Percentile: {prev_perc:.5f}-{percentile:.5f}%<br>"
+                            f"Latency: {item.value_iterated_to}uSec"
+                        )
+                        next_x = 100.0 / (100.0 - percentile)
+                        xaxis.append(next_x)
yaxis.append(item.value_iterated_to)
hovertext.append(
f"<b>{desc[graph]}</b><br>"
f"Direction: {(u'W-E', u'E-W')[idx % 2]}<br>"
-                            f"Percentile: {percentile:.5f}%<br>"
+                            f"Percentile: {prev_perc:.5f}-{percentile:.5f}%<br>"
f"Latency: {item.value_iterated_to}uSec"
)
+                        previous_x = next_x
+                        prev_perc = percentile