PapiHistory: Use repr strings for argument values 18/20818/4
authorVratko Polak <vrpolak@cisco.com>
Wed, 24 Jul 2019 07:49:05 +0000 (09:49 +0200)
committerVratko Polak <vrpolak@cisco.com>
Tue, 6 Aug 2019 08:40:42 +0000 (08:40 +0000)
Composite arguments frequently do not have valid __str__ method
so the values were not visible.

Change-Id: If302934cb227f212580bb2f5c277a755ace51bcf
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
resources/libraries/python/PapiHistory.py

index 6a4f913..c4ee4ee 100644 (file)
@@ -51,6 +51,8 @@ class PapiHistory(object):
     def add_to_papi_history(node, csit_papi_command, papi=True, **kwargs):
         """Add command to PAPI command history on DUT node.
 
+        Repr strings are used for argument values.
+
         The argument name 'csit_papi_command' must be unique enough as it cannot
         be repeated in kwargs.
 
@@ -84,7 +86,7 @@ class PapiHistory(object):
         if papi:
             args = list()
             for key, val in kwargs.iteritems():
-                args.append("{key}={val}".format(key=key, val=val))
+                args.append("{key}={val!r}".format(key=key, val=val))
             item = "{cmd}({args})".format(cmd=csit_papi_command,
                                           args=",".join(args))
         else:

©2016 FD.io a Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation. Linux is a registered trademark of Linus Torvalds.
Please see our privacy policy and terms of use.