From: Vratko Polak Date: Tue, 1 Jun 2021 09:09:58 +0000 (+0200) Subject: ASTF: Fix syntax error in stop X-Git-Url: https://gerrit.fd.io/r/gitweb?p=csit.git;a=commitdiff_plain;h=3793e1525f12ca1bdbd2140254eae31535818c27 ASTF: Fix syntax error in stop When ASTF suites were introduced, they already edited [0] actions to avoid explicit stop. Then a refactor [1] introduced the syntax error, but as stop never run, we didnot see it as a failure. Finally another refactor [2] caused the stop to be called again, exposing the syntax error. As a related issue, pylint script was not updated to check files in GPL directory until [3]. [0] https://gerrit.fd.io/r/c/csit/+/28205/8/tests/vpp/perf/ip4/2n1l-10ge2p1x710-ethip4udp-ip4base-h1024-p63-s64512-ndrpdr.robot#84 [1] https://gerrit.fd.io/r/c/csit/+/28208/179/GPL/tools/trex/trex_astf_stop.py#102 [2] https://gerrit.fd.io/r/c/csit/+/32030/37/resources/libraries/robot/performance/performance_utils.robot#518 [3] https://gerrit.fd.io/r/c/csit/+/32504 Change-Id: Ibd20b43cb263170d9f17255ff1bcd20f09c42cb5 Signed-off-by: Vratko Polak --- diff --git a/GPL/tools/trex/trex_astf_stop.py b/GPL/tools/trex/trex_astf_stop.py index b214d58a2f..1db122ba0f 100644 --- a/GPL/tools/trex/trex_astf_stop.py +++ b/GPL/tools/trex/trex_astf_stop.py @@ -109,8 +109,8 @@ def main(): f"frame_loss={total_lost}; " f"latency_stream_0(usec)=-1/-1/-1; " f"latency_stream_1(usec)=-1/-1/-1; " - f"latency_hist_stream_0={}; " - f"latency_hist_stream_1={}; " + f"latency_hist_stream_0=; " + f"latency_hist_stream_1=; " )