From: Vratko Polak Date: Mon, 8 Feb 2021 10:31:57 +0000 (+0100) Subject: Latency graphs: Do not hardcode x range X-Git-Url: https://gerrit.fd.io/r/gitweb?p=csit.git;a=commitdiff_plain;h=7c0d519483e2c5e5a0c9997ed01408200b64370b Latency graphs: Do not hardcode x range + Compute it from PERCENTILE_MAX. + Use slightly higher PERCENTILE_MAX to avoid rounding errors. + Add a comment why slightly higher value is needed. Change-Id: Ic54378d94568efbb8c78a889424f931591ef42db Signed-off-by: Vratko Polak --- diff --git a/resources/tools/presentation/generator_plots.py b/resources/tools/presentation/generator_plots.py index 7298babe53..4ceeebc7d1 100644 --- a/resources/tools/presentation/generator_plots.py +++ b/resources/tools/presentation/generator_plots.py @@ -62,7 +62,8 @@ COLORS = ( REGEX_NIC = re.compile(r'(\d*ge\dp\d\D*\d*[a-z]*)-') # This value depends on latency stream rate (9001 pps) and duration (5s). -PERCENTILE_MAX = 99.9995 +# Keep it slightly higher to ensure rounding errors to not remove tick mark. +PERCENTILE_MAX = 99.999501 def generate_plots(spec, data): @@ -398,7 +399,8 @@ def plot_hdrh_lat_by_percentile_x_log(plot, input_data): ) layout[u"title"][u"text"] = f"Latency: {name}" - layout[u"xaxis"][u"range"] = [0, 5.302] + x_max = log(100.0 / (100.0 - PERCENTILE_MAX), 10) + layout[u"xaxis"][u"range"] = [0, x_max] fig.update_layout(layout) # Create plot