csit.git
3 years agoRelease notes: Tput tests and jumbo ipsec 80/31280/5
Vratko Polak [Mon, 15 Feb 2021 09:33:59 +0000 (10:33 +0100)]
Release notes: Tput tests and jumbo ipsec

+ Also randomized profiles.

Change-Id: I8eefedca65129d8ebbd6f08b68e5884c930b1dc4
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
3 years agoReport: Add 2n-clx cx556a Latency graphs 62/31262/1
Tibor Frank [Mon, 15 Feb 2021 09:57:15 +0000 (10:57 +0100)]
Report: Add 2n-clx cx556a Latency graphs

Change-Id: I026ebb96874c55059e230d6e4db2424c341c04c6
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 7a3ffd6d385159609fe9ee8b8c575aa4fa4d891a)

3 years agoReport: Fix spec for Latency by percentile: 2n-clx MLX 56/31256/1
Tibor Frank [Fri, 12 Feb 2021 13:17:23 +0000 (14:17 +0100)]
Report: Fix spec for Latency by percentile: 2n-clx MLX

Change-Id: Ic782ef76d35b3349a04f57578c070b2f49e4ca7f
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 7d3f4273f0be2eec74eb1a2bed6d1f06ee5f3459)

3 years agoReport: re-group RND tests 95/31195/1
Tibor Frank [Fri, 12 Feb 2021 12:56:53 +0000 (13:56 +0100)]
Report: re-group RND tests

Change-Id: If45709086b850b6cccc44645ab195fd77296e5e3
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 1c32c469514179f2a77ad2049c5e6ebf1c30bea8)

3 years agoMethodology: Added packet flow ordering 94/31194/1
Vratko Polak [Tue, 9 Feb 2021 16:16:21 +0000 (17:16 +0100)]
Methodology: Added packet flow ordering

Change-Id: If0f0397c2ace9112490e017ec8d18cfbf1dffbc5
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Maciek Konstantynowicz <mkonstan@cisco.com>
(cherry picked from commit 26328f390e81f7bcfd536fb7faabaa224d82f857)

3 years agoReport: Add data 93/31193/1
Tibor Frank [Thu, 11 Feb 2021 11:51:34 +0000 (12:51 +0100)]
Report: Add data

Change-Id: Ia5c7e127c0063c4c1c8d265936361a68c4646f04
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 42a4834d143fe480d70aaed3c1ebb9eb9681d53e)

3 years agoJob specs: Add -tput tests to iterative 92/31192/1
Tibor Frank [Thu, 11 Feb 2021 12:01:01 +0000 (13:01 +0100)]
Job specs: Add -tput tests to iterative

- Not touching coverage yet.
+ Trending stuff should be handled already by symlinks.
+ Adding to anywhere with -pps tests.
+ Only nat44ed version.
 + Because ip4base is stateless.
 + So -tput will have the same behavior and results as -pps.
+ Test counts and run duration estimates updated.

Change-Id: I4e7ce7e9974c995ccf0a21300fa041031ca81cfc
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit df0c31ceb15da3542f15941e1569e471d0f22007)

3 years agoReport: Add 2n-clx Mellanox tests and graphs 90/31190/1
Tibor Frank [Thu, 11 Feb 2021 09:04:07 +0000 (10:04 +0100)]
Report: Add 2n-clx Mellanox tests and graphs

Change-Id: Ib947d47b31138ac816acefee03429d454511dd05
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 87cd7f3983eade6f27a848b23409c95e4a35b631)

3 years agoReport: vpp device i40e known issue 89/31189/1
Juraj Linkeš [Wed, 10 Feb 2021 13:46:46 +0000 (14:46 +0100)]
Report: vpp device i40e known issue

Add the i40e PF/VF race condition known issue to the known issues list.

Change-Id: I1eb4dcea118036dec3f3715f0d08d124f2a9ad1c
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
(cherry picked from commit a0775ecebbef2caa05ae2ad1e0b666f178acfc02)

3 years agoReport: Add data 88/31188/1
Tibor Frank [Wed, 10 Feb 2021 12:12:05 +0000 (13:12 +0100)]
Report: Add data

Change-Id: I6803f9694c0260817d93258b4cb99cdd47dea9ef
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 1aebe29b8da1fc1ce77cbdda8da410b18fef74c0)

3 years agoMethodology: Add NAT44ed tput tests 87/31187/1
Vratko Polak [Tue, 9 Feb 2021 17:18:12 +0000 (18:18 +0100)]
Methodology: Add NAT44ed tput tests

Change-Id: I22a38ca98cb0aa4bac9a03d3943e807c26ce4474
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 24012f71b90d48dbaab941a8815427bbf54ba5c1)

3 years agoReport: Small fixes 86/31186/1
Tibor Frank [Wed, 10 Feb 2021 10:35:45 +0000 (11:35 +0100)]
Report: Small fixes

Change-Id: I30c51b2fb71322df042d76394dfa223615f2d206
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 72f18772740b0dde1ed6e44d740f8456ce0546e9)

3 years agoReport: Update release note section 85/31185/1
pmikus [Mon, 8 Feb 2021 11:39:24 +0000 (11:39 +0000)]
Report: Update release note section

- Infra update
- Cleanup

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: Ib8fe70fdbbaeabfbb9f2e96fc8a9ab87a8e63f35
(cherry picked from commit 60b531215d36e2402b1b6c768bd4fd4d4b210fd0)

3 years agoReport: Add data 83/31183/1
Tibor Frank [Wed, 10 Feb 2021 06:24:07 +0000 (07:24 +0100)]
Report: Add data

Change-Id: Id7f398a3d4080d3780ac9684ae2e925d7eb59c86
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit d56509e3e8e1109e75362fe7c2bf1f4fa805efed)

3 years agoReport: Hide nat44 tput tests 81/31181/1
Tibor Frank [Tue, 9 Feb 2021 14:08:08 +0000 (15:08 +0100)]
Report: Hide nat44 tput tests

Change-Id: Ia01a4a7b0b70547655ab9c6e463040bc97f1727f
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit cf2a4f97f261a8ab27578232e9f419968e8a1fb1)

3 years agoReport: Add latency graphs for NAT44 tput tests 80/31180/1
Tibor Frank [Tue, 9 Feb 2021 10:30:58 +0000 (11:30 +0100)]
Report: Add latency graphs for NAT44 tput tests

Change-Id: I296b7fdd99daa8ac2692843dbf8a73ab98b8c1ff
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit d517fd2f0363ef4b0d857f8a4437fb0a39d7d144)

3 years agoReport: Add NAT44 tput tests 79/31179/1
Tibor Frank [Tue, 9 Feb 2021 06:57:19 +0000 (07:57 +0100)]
Report: Add NAT44 tput tests

Change-Id: Ie5a92818db14ccacb61ac126e75aa14e114eadc7
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit ddaf1688aa8dbb6f9a6e463faaf62c752c53a394)

3 years agoFIX: Nic selection 53/31153/1
pmikus [Mon, 8 Feb 2021 11:43:51 +0000 (11:43 +0000)]
FIX: Nic selection

- Buggy unnoticed for quite some time

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: I7d2387186e0250b80d664e2f004f909fd80c7bfa
(cherry picked from commit 127eb76dfeca04e123b0d7cc229c4a71ee3f2f9a)

3 years agoLatency graphs: Do not hardcode x range 52/31152/1
Vratko Polak [Mon, 8 Feb 2021 10:31:57 +0000 (11:31 +0100)]
Latency graphs: Do not hardcode x range

+ Compute it from PERCENTILE_MAX.
+ Use slightly higher PERCENTILE_MAX to avoid rounding errors.
+ Add a comment why slightly higher value is needed.

Change-Id: Ic54378d94568efbb8c78a889424f931591ef42db
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 7c0d519483e2c5e5a0c9997ed01408200b64370b)

3 years agoTraffic generator: Force ramp-up in next test 48/31148/2
Vratko Polak [Fri, 5 Feb 2021 15:14:27 +0000 (16:14 +0100)]
Traffic generator: Force ramp-up in next test

The behavior was already documented, just not implemented properly.

Change-Id: Ib8c232c004e91032e1230e86dda9f70bdfab43ad
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 28ed095b73c4a01ed73c93b3b80da22a4bcca907)

3 years agojob-spec: fix report_coverage/2n-tx2/l2-04.md 51/31151/1
Tibor Frank [Mon, 8 Feb 2021 09:05:10 +0000 (10:05 +0100)]
job-spec: fix report_coverage/2n-tx2/l2-04.md

- replace eth-l2bdbasemaclrn-macip-iacl1sl-10kflows by
  eth-l2bdbasemaclrn-macip-iacl50sl-10kflows

Change-Id: Ieaaea1e59533059ceaffe1e3c767d51b4ab7c8d0
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 2925ed78ef21456cf6f8dfbe4afed6ea0307ed20)

3 years agoreport: add 2n-tx2 phy testbed diagram and update description 50/31150/1
Maciek Konstantynowicz [Tue, 2 Feb 2021 12:00:21 +0000 (12:00 +0000)]
report: add 2n-tx2 phy testbed diagram and update description

Change-Id: Ibd935b2f81c266037711b31d7b76384133b9d45f
Signed-off-by: Maciek Konstantynowicz <mkonstan@cisco.com>
(cherry picked from commit b6cac504fa90b85b94317238082885759ca28348)

3 years agoReport: Add data 47/31147/1
Tibor Frank [Mon, 8 Feb 2021 08:41:43 +0000 (09:41 +0100)]
Report: Add data

Change-Id: I578755b72bc2a4ef310b9c14193de2f995803453
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit e61e873dd9252b6824cbc3c37bafccf85813a7a1)

3 years agoReport: Add data 46/31146/1
Tibor Frank [Fri, 5 Feb 2021 19:36:00 +0000 (20:36 +0100)]
Report: Add data

Change-Id: I10953162634f21b3f2952fca3abded2c12e397c6
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 15c18ac54d1794da1a9a4a1c12e10a46426e8a65)

3 years agoReport: Various fixes 43/31143/1
Tibor Frank [Fri, 5 Feb 2021 13:28:06 +0000 (14:28 +0100)]
Report: Various fixes

Change-Id: Ib3fcf5b9a839ce397970761c717310da9c8a63b7
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 5cbe9912f188bcad4956b212dfed12af5dccf065)

3 years agoNAT44ed: Add pure throuhput bidir tests 63/31063/3
Vratko Polak [Fri, 5 Feb 2021 10:46:40 +0000 (11:46 +0100)]
NAT44ed: Add pure throuhput bidir tests

+ With ramp-up, without reset, with session verification.
+ Uses the same profile as pps tests.
+ Ramp up duration is not specified, as duration is computed.
+ Timeout tracking with automated ramp-up.
 + Correct computation of next duration.
 + Checking both early and late sessions.
 + No loss measurement also acts as a ramp-up.
+ Return ReceiveRateMeasurement from send_traffic_on_tg_internal,
  as that is needed for detecting whether trial is ok as ramp up.
- Udp needs quite low ramp-up rate after recent regression.
 - Max scale has higher rate (so failing) to avoid session timeouts.
+ Bump copyright year.

Change-Id: I50c928659cd5b985b490a2e5fb69c5cd790600b0
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit b26fe6de7965f6621b54a80a938f82afe95aa585)

3 years agoReport: Set range of x-axis for latency graphs, add data 42/31142/1
Tibor Frank [Fri, 5 Feb 2021 09:44:24 +0000 (10:44 +0100)]
Report: Set range of x-axis for latency graphs, add data

Change-Id: Ibfa1d6d0fb851b8c2d55c0cc749307efb36a5a03
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 0c02e000ae58474120246c484cf5458a76510288)

3 years agoTrending: RND tests 41/31141/1
Tibor Frank [Fri, 5 Feb 2021 08:28:48 +0000 (09:28 +0100)]
Trending: RND tests

Change-Id: Iafd66841e81898e4d835b9ebabb1496c170e7ff4
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 340c20a3f3908d832ad093349e1ccb14060e8035)

3 years agoReport: Add data 39/31139/1
Tibor Frank [Fri, 5 Feb 2021 07:42:12 +0000 (08:42 +0100)]
Report: Add data

Change-Id: I26eaa7c336d3873cc33a7be5e2ee4da7e8f50603
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit f60c0957d9d66a19a05c06e27839401f7ec97829)

3 years agoReport: Set the range of x-axis fro Latency graphs 73/31073/1
Tibor Frank [Thu, 4 Feb 2021 13:19:00 +0000 (14:19 +0100)]
Report: Set the range of x-axis fro Latency graphs

Change-Id: I2807dc920805c8a59a97ddbd92ad17e4372826db
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 879b31f02fb4df52016d7465e21377121dfbb515)

3 years agoReport: Add 2n-clx rnd latency graphs 72/31072/1
Tibor Frank [Thu, 4 Feb 2021 08:48:30 +0000 (09:48 +0100)]
Report: Add 2n-clx rnd latency graphs

Change-Id: I7c8c6d2129cc67a7a9f635f0b6ebea53ffa6e158
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit eecc9da92caae82e9e9a608c41fd0b192780fe4c)

3 years agoReport: Add data 71/31071/1
Tibor Frank [Thu, 4 Feb 2021 08:42:42 +0000 (09:42 +0100)]
Report: Add data

Change-Id: I9a09d6077f0c3acbd42b79220aec69dcd9490359
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 2e769b838081d49868ea793f8c38318f5a1a6cef)

3 years agoReport: Add data 70/31070/1
Tibor Frank [Thu, 4 Feb 2021 07:16:47 +0000 (08:16 +0100)]
Report: Add data

Change-Id: I5243c2b2a9669df4bc57f4d606b4bf0df3d9580c
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 29ce700b9cf1a6b275f13fc3975991289b062e53)

3 years agoReport: Latency graphs 69/31069/1
Tibor Frank [Wed, 3 Feb 2021 16:03:54 +0000 (17:03 +0100)]
Report: Latency graphs

Change-Id: I5ca267827a549f7378c289e7db1d3bb89f5482eb
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit df3b53935c5db2e53cf8e72ca2ef5be995071e69)

3 years agoTrending: Add IPv4 and IPv6 rnd tests 68/31068/1
Tibor Frank [Wed, 3 Feb 2021 14:28:56 +0000 (15:28 +0100)]
Trending: Add IPv4 and IPv6 rnd tests

Change-Id: Ie90b88466575c33c2c45e8fb9c2b0c42dc795aa6
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 38b98cea69a149ac5b1be23f0dbad79e7e1cb01c)

3 years agoReport: Add RND Latency graphs, add data 66/31066/1
Tibor Frank [Wed, 3 Feb 2021 06:30:41 +0000 (07:30 +0100)]
Report: Add RND Latency graphs, add data

Change-Id: I9882b19a87e0d7437471ac5e5f7986d69fe2ce34
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit b5073afc4a941ea33ce874e016fe86384ae7a60d)

3 years agoReport: Fix spec 65/31065/1
Tibor Frank [Tue, 2 Feb 2021 20:58:16 +0000 (21:58 +0100)]
Report: Fix spec

Change-Id: I2c7e98c05543e878a6a220fe8d4ffbb15eaa1997
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 9387a7bd3187faa7c1e75daa084bda5564c74d94)

3 years agoReport: Add RND tests 64/31064/1
Tibor Frank [Tue, 2 Feb 2021 20:36:52 +0000 (21:36 +0100)]
Report: Add RND tests

Change-Id: I43289d4dde371984698b0d1a16e8dd65fc33f84e
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 50a4e5e45f5e6e18f2dac6aee69adb85ef4d12c4)

3 years agoTrending: Fix nat44 tests in NDRPDR trending 61/31061/1
Tibor Frank [Tue, 2 Feb 2021 18:05:07 +0000 (19:05 +0100)]
Trending: Fix nat44 tests in NDRPDR trending

Change-Id: Iab49c4e55d4cb3ad1e1c5399a406de6e9e8fbed1
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 45423631acb4ddc58f20fffa096b46724de75ee8)

3 years agoReport: Add data 60/31060/1
Tibor Frank [Tue, 2 Feb 2021 11:43:49 +0000 (12:43 +0100)]
Report: Add data

Change-Id: I97bdba256d5886c0ffdd42d4427038bd3b443043
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit b4cc5ae04a3cefa5e4a3b6819003c223299b61b2)

3 years agoAdd suites with randomized ip6 profiles 21/30821/2
Vratko Polak [Mon, 18 Jan 2021 15:59:42 +0000 (16:59 +0100)]
Add suites with randomized ip6 profiles

+ Replace pair of traffic profiles (2n and 3n) with single nodeless one.
+ Compared to incremental suites, randomized ones add IP6_RND tag.

Change-Id: I2f0dfc9e04bbcd0f88e95b92edf2da2c73faaab6
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit ad98ea70cf435d104b6a4f0090575e137660da77)

3 years agoReport: Synchronize report spec with master 30/31030/1
Tibor Frank [Mon, 1 Feb 2021 09:08:25 +0000 (10:08 +0100)]
Report: Synchronize report spec with master

Signed-off-by: Tibor Frank <tifrank@cisco.com>
Change-Id: Iaaa64ad82319a8176bf25693815136851925d38b

3 years agoReport: Add 2101.release data 59/31059/1
Tibor Frank [Mon, 1 Feb 2021 08:52:48 +0000 (09:52 +0100)]
Report: Add 2101.release data

Change-Id: Ic4587cb7f6fb5f2ee3d70169ad03d02d1721bd62
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 1a82cf21d8ec419543fd46bbce3d64528fbb6bb4)

3 years agoFix: Slack API key 52/31052/2
pmikus [Fri, 29 Jan 2021 13:12:43 +0000 (13:12 +0000)]
Fix: Slack API key

- Clearly we must implement key storage vault to avoid storing key in
.tfstate

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: Iea2db10e4cd59c29a0c74ee92cbddc7d261bd6a7
(cherry picked from commit 101d3251d3f30f894a9143f8c1062761f3ed8337)
(cherry picked from commit 6b4b75acf819a8a7c68d0f57365bbd6e0b4d3933)

3 years agoFix: Slack key workaround 40/31040/2
pmikus [Fri, 29 Jan 2021 10:03:46 +0000 (10:03 +0000)]
Fix: Slack key workaround

- Todo: Deploy hashi vault.

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: Ib02f00039bd4cbb4725ea3fec56184b7928208ad
(cherry picked from commit 993696b15c5f5b63c5d206fd9cc9b32c4af4e2dd)
(cherry picked from commit 3715b48d91e15d0f961963acb641abce67a101d1)

3 years agoInfra: Monitoring capability 38/31038/1
pmikus [Thu, 7 Jan 2021 14:27:38 +0000 (14:27 +0000)]
Infra: Monitoring capability

+ Monitoring SOA
  + Nomad alertmanager job
  + Nomad prometheus job
  + Nomad grafana job

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: I0b32e9c87276ba1a2d4a5322816f3473c737eae2
(cherry picked from commit a44eef233de959c5679602dc6cd1ed866d6abc14)
(cherry picked from commit 2856c0a0c19319de146a93c27e106351faf1926c)
(cherry picked from commit 6717a3bc8b5fb81c1a19964fd367878230331457)

3 years agoInfra: Remove Consul TLS on clients (Nomad conflict) 91/30991/1
pmikus [Thu, 28 Jan 2021 08:47:01 +0000 (08:47 +0000)]
Infra: Remove Consul TLS on clients (Nomad conflict)

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: I7c825150a19dd783a255fcc5cbd31b91c6b0b2cf
(cherry picked from commit 474163bc78aa418595b227c81056987b1114104d)
(cherry picked from commit dae934efdf9c773b90cc4a9595d217dd55035561)
(cherry picked from commit ba5dcdbecd4c009c832c2a186a58566a5ef4dc81)

3 years agoInfra: Remove unwanted terraform output 87/30987/2
pmikus [Thu, 28 Jan 2021 08:37:12 +0000 (08:37 +0000)]
Infra: Remove unwanted terraform output

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: Id6ed065d05c20b6305abfecb8e79bacb86c5b85a
(cherry picked from commit 6cc6235c7a693d7d4c22bb8a067924372bad6faf)
(cherry picked from commit 95a7a55f4b7f77a1af8ddd8a8088896b7c8bcae5)

3 years agoInfra: Terraform vpp_device module 85/30985/1
pmikus [Thu, 28 Jan 2021 08:24:35 +0000 (08:24 +0000)]
Infra: Terraform vpp_device module

+ Convert to module
+ Fix memory limit

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: I95285faabbf7bad7fcb7f3b0c9b4e79641c6b95c
(cherry picked from commit 2afd8f4fe26ae1f1d183ecac8f9daa85f68bc634)
(cherry picked from commit 7c90b6a0f1d0e14f64364d0213e473d447980d05)
(cherry picked from commit 7a760c915e1d905f6cc0b2ef99ad293e3e5e290d)

3 years agoInfra: Adjust vpp_device x86 memory layout 82/30982/1
pmikus [Thu, 28 Jan 2021 07:38:34 +0000 (07:38 +0000)]
Infra: Adjust vpp_device x86 memory layout

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: I43b3b891b270903419b7fcf132813563306b6e10
(cherry picked from commit f6882e6231ef0a39d137862d1fb5b75f8eddd9c4)
(cherry picked from commit d04cbd87772bf94648f130ce356ad53406760485)
(cherry picked from commit 66946b2e17f15f09f03f2c1e646aa8fc844d614b)

3 years agoInfra: Align Nomad settings across cluster 79/30979/1
pmikus [Thu, 28 Jan 2021 07:22:24 +0000 (07:22 +0000)]
Infra: Align Nomad settings across cluster

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: Id362e47ecee9fd4eac8332978d81f33656880d66
(cherry picked from commit d69b5158e2c4ef0bae7acb1f99c103607a4d7b2a)
(cherry picked from commit 45cb36933587e92ceb901725134d0eaeece82104)
(cherry picked from commit db5da5b55359cf824ca1a06371622d9094d9cebc)

3 years agorls2101: Update VPP_STABLE_VER files to release version 76/30976/2
Tibor Frank [Thu, 28 Jan 2021 05:02:37 +0000 (05:02 +0000)]
rls2101: Update VPP_STABLE_VER files to release version

Change-Id: I1b4ceae9027f2d439c29058f4a19f0a28a698c0d
Signed-off-by: Tibor Frank <tifrank@cisco.com>
3 years agojob-specs: Add rnd tests 14/30914/1
Tibor Frank [Wed, 27 Jan 2021 19:23:53 +0000 (20:23 +0100)]
job-specs: Add rnd tests

Change-Id: I877f46608853401c5226845737ace691e3f393b1
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 3354bdb7f7c183322c886ab1c89c8f3bbf42366b)

3 years agoReport: Add data 09/30909/1
Tibor Frank [Wed, 27 Jan 2021 11:59:44 +0000 (12:59 +0100)]
Report: Add data

Change-Id: Ie90bdf03bb4190e199bfdcb440125caea7bfdef8
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit d6615bce0d5ac4cb88bbeec584fa7094a6db2c06)

3 years agoReport: Fix reconfig graphs 08/30908/1
Tibor Frank [Wed, 27 Jan 2021 09:54:59 +0000 (10:54 +0100)]
Report: Fix reconfig graphs

Change-Id: Id8d4930937e502bd8b4b54145437a9e7f668ace5
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 3f8cd3759d371a5ac2df46cfb981cc3a599574ea)

3 years agoReport: Improve reconf graphs 07/30907/1
Tibor Frank [Wed, 27 Jan 2021 06:03:01 +0000 (07:03 +0100)]
Report: Improve reconf graphs

Change-Id: Ic935c946123c4dcc9daa608c523767b9aca36ef3
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 7d7ec5e661abec4dda2546843addf1a71580e97e)

3 years agoTrending: Add GENEVE tests 06/30906/1
Tibor Frank [Tue, 26 Jan 2021 13:56:27 +0000 (14:56 +0100)]
Trending: Add GENEVE tests

Change-Id: I5e20f6351dd3854eef075e1bf954dab5aee61698
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 5e996684dd0c95089256631c696e4fb9e72e21a2)

3 years agoReport: Add GENEVE tests 04/30904/1
Tibor Frank [Tue, 26 Jan 2021 13:20:23 +0000 (14:20 +0100)]
Report: Add GENEVE tests

Change-Id: Ic6ede53c94c47159d0fde658e2eef309b9d39371
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 1e3c01e0e458d62ed228e8d6a916c24992304252)

3 years agorls2101: Update VPP_STABLE_VER files 03/30903/2
Tibor Frank [Mon, 25 Jan 2021 13:34:27 +0000 (13:34 +0000)]
rls2101: Update VPP_STABLE_VER files

Change-Id: I4db975fab589594f7551217b64adfe13cf628f65
Signed-off-by: Tibor Frank <tifrank@cisco.com>
3 years agoReport: Add data 99/30899/1
Tibor Frank [Mon, 25 Jan 2021 08:45:06 +0000 (09:45 +0100)]
Report: Add data

Change-Id: I234b42fa5a402a27d210da9ebc247ca5291d1877
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 88bbb1908b4aa58163374c983b4b8e85e78460d5)

3 years agoHdrh latency graphs: Do not skip the last value 98/30898/1
Vratko Polak [Thu, 21 Jan 2021 11:44:11 +0000 (12:44 +0100)]
Hdrh latency graphs: Do not skip the last value

Linear x axis does not need any skipping.
For logarithmic axis, descrease from 100% to avoid infinity.
Currently using a fixed PERCENTILE_MAX value.
Added a comment on when to change that value.

Change-Id: Ic10a19532455e597272efdb4542e43d09ce49d5c
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit d4f12e6931c7fdf84043d8fb2f71e2f38965f26b)

3 years agoReport: add geneve to perf release notes 35/30835/1
Jan Gelety [Mon, 11 Jan 2021 01:34:17 +0000 (02:34 +0100)]
Report: add geneve to perf release notes

Change-Id: I0473bda59edf874119a474fb2e84177e19f58d02
Signed-off-by: Jan Gelety <jgelety@cisco.com>
(cherry picked from commit 67d3b2a44d49dd2c4a1b2f722849f57432787137)

3 years agoReport: Add data 34/30834/1
Tibor Frank [Fri, 22 Jan 2021 11:25:19 +0000 (12:25 +0100)]
Report: Add data

Change-Id: I1d5031780b1bef169509058233e02624d7afecb7
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 0c489b1767a031837f320c1fb5e45947ac82ea4d)

3 years agoReport: vpp-device release notes 33/30833/1
Jan Gelety [Sun, 10 Jan 2021 20:56:40 +0000 (21:56 +0100)]
Report: vpp-device release notes

Change-Id: Ieacb9e4fac471cbe5cd28288341695352426c134
Signed-off-by: Jan Gelety <jgelety@cisco.com>
(cherry picked from commit 7b9b65a3af83267a4e6a36fc98996aaa05060a87)

3 years agoReconf: Fix bidir/unidir mismatch 31/30831/1
Vratko Polak [Thu, 21 Jan 2021 10:15:56 +0000 (11:15 +0100)]
Reconf: Fix bidir/unidir mismatch

Results if NDR search is in TPS (so unidir) since
https://gerrit.fd.io/r/c/csit/+/28208

The bug was causing all reconf tests report zero loss,
as they used half of NDR load during reconfiguration.

+ Small improvements to descriptions of other traffic keywords.

Change-Id: Ib9af5861cc09e698eb762feb3f0a019571d17962
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 293a88b56179094f655178b838b84844a672390d)

3 years agoTrending: Fix bugs in 2n-tx2 30/30830/1
Tibor Frank [Thu, 21 Jan 2021 06:09:02 +0000 (07:09 +0100)]
Trending: Fix bugs in 2n-tx2

Change-Id: I5522e2cb37b9e319bfde009297525179da2e50f7
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 7f7f2fd7363637d0da626a28bb8a0b357d314a9d)

3 years agoReport: Add data 28/30828/1
Tibor Frank [Thu, 21 Jan 2021 09:25:33 +0000 (10:25 +0100)]
Report: Add data

Change-Id: I09a695d9c747d4bb6826d27283ab0aa172fc0d30
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 9e08f1dfb125d092a48f92c764f52ae97f8a9995)

3 years agoTrending: Add 2n-tx2 27/30827/1
Tibor Frank [Tue, 19 Jan 2021 19:12:09 +0000 (20:12 +0100)]
Trending: Add 2n-tx2

Change-Id: Id2d0248128eee6a5b0969c7f27aae946ed47bbaa
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 3fc6ce9f08f0a1c1293dfc032fdddfe5e3f7eb16)

3 years agoacl: add L2BD dev tests 25/30825/1
Martin Balaz [Thu, 10 Sep 2020 16:18:48 +0000 (18:18 +0200)]
acl: add L2BD dev tests

Signed-off-by: Martin Balaz <martin.balaz@pantheon.tech>
Change-Id: I70127d8dd2241b70511f31842eb8a9e3cbafdc4b
Signed-off-by: Jan Gelety <jgelety@cisco.com>
(cherry picked from commit 0f3baca2366f969de6b5d3b889c1b05f72995ec2)

3 years agojob_specs: add geneve tests 24/30824/1
Jan Gelety [Sun, 10 Jan 2021 13:34:01 +0000 (14:34 +0100)]
job_specs: add geneve tests

Geneve tests added to report_iterative and report_coverage job
specifications.

- tests with 1024 geneve tunnels added only to report_coverage jobs
  until fast PAPI is finished

Change-Id: I11a12d3c626dd2daf6287440131795daa7f75e48
Signed-off-by: Jan Gelety <jgelety@cisco.com>
(cherry picked from commit 3d0d137bf45e1cd3c7aa06480f5ea08175a6df01)

3 years agoTox: Improve tox.ini 22/30822/1
Vratko Polak [Mon, 18 Jan 2021 13:35:17 +0000 (14:35 +0100)]
Tox: Improve tox.ini

Just stylistic improvements, no functional change.

+ Use "ignore_outcome = true" instead of "|| true".
+ Document and apply recommended ordering within testenv definition.
+ Fix some typos.

Change-Id: I004f12fbdf6dbeb555daa7cd111938b7eeef20b3
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 52a39f861bb645831130ef109a14e629be9bde7a)

3 years agoReport: Add data 20/30820/1
Tibor Frank [Wed, 20 Jan 2021 08:16:08 +0000 (09:16 +0100)]
Report: Add data

Change-Id: Ie7450076891e1041b5635f8ea714f94909b6d407
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 216c68cc8b010642c4de21673b7d8e18006767e2)

3 years agoReport: Add ip6 latency graphs 19/30819/1
Tibor Frank [Tue, 19 Jan 2021 18:00:47 +0000 (19:00 +0100)]
Report: Add ip6 latency graphs

Change-Id: Ic53214b0a0360bdb6d62d100fc7b9c8e15fb8397
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 5e0fe5a28969dfc9fe36415a065122a668d5a273)

3 years agoReport: Add data, 2n-tx2 latency graphs 17/30817/1
Tibor Frank [Tue, 19 Jan 2021 12:26:34 +0000 (13:26 +0100)]
Report: Add data, 2n-tx2 latency graphs

Change-Id: Idd9396c0f260355e3b7b90839bd4b1f64d8b0644
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 4bc1e70ad02b198a7b9ea32b72da3ae98978e8c5)

3 years agoJob specs: Add some ipsec reconf to iterative 16/30816/1
Vratko Polak [Tue, 19 Jan 2021 11:04:08 +0000 (12:04 +0100)]
Job specs: Add some ipsec reconf to iterative

We now have more time for 3n-hsw testbeds.
Added only scales of 4, 1000 and 60000 tunnels.

Change-Id: I283a816e1440a9fe1f0dea13f954f92b457ea788
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit be5833232791a24921e7e9695e53efcbd7ff248e)

3 years agoReport: Add data 55/30755/1
Tibor Frank [Tue, 19 Jan 2021 06:12:35 +0000 (07:12 +0100)]
Report: Add data

Change-Id: I1b7314affd08d12b67212affb2ef89f64d1347ee
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit f5863d6213bf0066b9647a7dde10d56bd7260f80)

3 years agoRandom flows: Use seeds again and increase limit. 54/30754/2
Vratko Polak [Wed, 13 Jan 2021 18:38:50 +0000 (19:38 +0100)]
Random flows: Use seeds again and increase limit.

TRex does mix seeds when distributing over workers,
but it is multiplicative [0], so zero is the only bad value.

Limit restricts the cycle length of PRNG (by resetting [1] the seed).
We want the cycle as long as possible.

[0] https://github.com/cisco-system-traffic-generator/trex-core/blob/v2.73/src/stx/stl/trex_stl_stream_vm.h#L1616
[1] https://github.com/cisco-system-traffic-generator/trex-core/blob/v2.73/src/stx/stl/trex_stl_stream_vm.h#L313-L314

Change-Id: I33a29496f0853ef60d592c988f81a9d1109b5878
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit eedb7dff222d2590ac2cb5a5e67dc7d90317f05c)

3 years ago2101: Update VPP_STABLE_VER_ files 03/30803/2
Tibor Frank [Mon, 18 Jan 2021 14:31:20 +0000 (15:31 +0100)]
2101: Update VPP_STABLE_VER_ files

Signed-off-by: Tibor Frank <tifrank@cisco.com>
Change-Id: Ica196e6a309e4dc2fdfb51b7faed72a627311991

3 years agoReport: Remove slider for Latency graphs 53/30753/1
Tibor Frank [Mon, 18 Jan 2021 15:30:28 +0000 (16:30 +0100)]
Report: Remove slider for Latency graphs

Change-Id: I86b9af8e2ebbf27cd8d93c9a04901dce874fa9d6
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 69264aed8d43f3c4a8342dd7584f80336108c879)

3 years agoReport: Fix specification 51/30751/1
Tibor Frank [Mon, 18 Jan 2021 13:57:45 +0000 (14:57 +0100)]
Report: Fix specification

Change-Id: Ida7035fd130f566215f222d9cd7e98beb583af94
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 4d04d11497eb87f94d6ac4982e4b17ae0f48d811)

3 years agojob-specs: Fix hoststack 50/30750/1
Tibor Frank [Mon, 18 Jan 2021 13:52:38 +0000 (14:52 +0100)]
job-specs: Fix hoststack

Change-Id: I1e450ec00621c7d0bd5a2fd91491c31eae3481f4
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit e4d7b3b4d4185e97443830e7e9fb0f570031a376)

3 years agoReport: Add data, add 2n-tx2 49/30749/1
Tibor Frank [Mon, 18 Jan 2021 09:43:14 +0000 (10:43 +0100)]
Report: Add data, add 2n-tx2

Change-Id: Ic2f8e03c16c432479139648cad7982a962193bc4
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit caef25a1412689fc0906e024e9b26c547ecfc5bd)

3 years agoReport: add 2n-tx2 static content 47/30747/2
Juraj Linkeš [Fri, 15 Jan 2021 12:09:43 +0000 (13:09 +0100)]
Report: add 2n-tx2 static content

Change-Id: I476ac52d64999f6d3ca3ee726f018f36693ac921
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
(cherry picked from commit 7f0abbb8f56342fc09b09beb47661f4d55b7eb62)

3 years agoPAL: Improve latency graphs 48/30748/1
Vratko Polak [Thu, 14 Jan 2021 12:34:08 +0000 (13:34 +0100)]
PAL: Improve latency graphs

Previously, they used sloped lines connecting reported points.
But HdrHistogram reports only the upper bound of percentile.
Example: If all samples are 10us,
HdrHistogram reports a single value at 100%.

This change attempts to show the whole intervals (0%-100% for the example)
as a series (vertically connected) of horizontal lines.
Hover also shows percentiles as intervals.

Change-Id: Id7bbff7b1c29d7f62472041340fde88903363cfa
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 826d80373dbd20bc1feac2403e9cade9e5633336)

3 years agoAdd 3n ip4-rnd tests 40/30740/2
Vratko Polak [Thu, 14 Jan 2021 15:08:25 +0000 (16:08 +0100)]
Add 3n ip4-rnd tests

+ Rename traffic profiles to avoid mentioning number of nodes.
+ Improve 2n rnd suite documentation slightly.

This is a manual cherry-pick of https://gerrit.fd.io/r/c/csit/+/27679

Change-Id: I82d6fb6a99133163a58d56f2acf8a7b9568ee77c
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
3 years agoLicense: Update block replacer 44/30744/1
Vratko Polak [Wed, 13 Jan 2021 09:02:51 +0000 (10:02 +0100)]
License: Update block replacer

... so it replaces also long (older) form of GPL license.
This way replacing to apache and back ensures GPL has (newer) short form.

Change-Id: I34efd83a91e54b2b2bbb3c4429d1b82397a1e8f8
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 193fc1732fdacf424d36bbb979037ba261457cb4)

3 years agoLicense: Wrap GPL block to 80 characters 41/30741/2
Vratko Polak [Tue, 12 Jan 2021 16:22:01 +0000 (17:22 +0100)]
License: Wrap GPL block to 80 characters

The original license block was adapted from
https://wiki.fd.io/view/TSC/Proposed_Header_Python_Test_Scripts
resulting in a line longer than 80 chars,
but those are reported (although not blocked) by tox verify job.

As the text from wiki was not used in verbatim
(it uses c-style comment block),
minor formatting change like this should not be a big deal.

+ Bump copyright year.

Change-Id: I55e3a0232639b448b1a6d7b1f3af84d903a8d0a5
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 624e580159dc056035d7e962582e86a000f8c3d6)

3 years agoperf: GENEVE tunnel test, l3 mode 58/30758/2
Jan Gelety [Thu, 3 Dec 2020 15:22:41 +0000 (16:22 +0100)]
perf: GENEVE tunnel test, l3 mode

Jira: CSIT-1768

Change-Id: I888ae1a5754fa07297d4cdf65c2be0e3e49d89a5
Signed-off-by: Jan Gelety <jgelety@cisco.com>
(cherry picked from commit 6962831a1f1905e50a3d663c0cf3ce8c2873ecc9)

Change-Id: I6496ae773b176b2abfedab843110d6f870c62888
Signed-off-by: Jan Gelety <jgelety@cisco.com>
3 years ago2101: Update the stable ver files to rc2 56/30756/2
Tibor Frank [Thu, 14 Jan 2021 06:16:03 +0000 (07:16 +0100)]
2101: Update the stable ver files to rc2

Signed-off-by: Tibor Frank <tifrank@cisco.com>
Change-Id: Ibec19f45e307af8b6c92d76ed0da126650973c3b

3 years agoReport: Add data 42/30742/1
Tibor Frank [Thu, 14 Jan 2021 06:38:16 +0000 (07:38 +0100)]
Report: Add data

Change-Id: I3ac0e892ef3f2b0a23b42465565d28f5d5027dae
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit ef5c30213bb28824a55f4ebbcade6410ee8d2461)

3 years agojob_specs: fix 2n-tx2 ip6 iacldst job specs 37/30737/1
Juraj Linkeš [Wed, 13 Jan 2021 16:00:58 +0000 (17:00 +0100)]
job_specs: fix 2n-tx2 ip6 iacldst job specs

Change-Id: Id0f74dd289a05c84f6f0723adcd678f02c7464fa
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
(cherry picked from commit 55eb33d7469ec635755d0942c74ff798f9f3d498)

3 years agoReport: Fix plots 36/30736/1
Tibor Frank [Wed, 13 Jan 2021 15:18:03 +0000 (16:18 +0100)]
Report: Fix plots

Change-Id: I70a7929400d7fba144a3669fc9d8aff003695f55
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 81958d4bc5ec4803be0726d94564680e2a0f9a5c)

3 years agojob_specs: update 2n-tx2 coverage specs 28/30728/2
Juraj Linkeš [Wed, 13 Jan 2021 14:40:55 +0000 (15:40 +0100)]
job_specs: update 2n-tx2 coverage specs

Start out with l2, l3, classifier and acl tests.

Change-Id: I8fc390c77e410e4f4832b4412114253dd34a5fbb
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
3 years agoReport: Add data 15/30715/1
Tibor Frank [Wed, 13 Jan 2021 13:47:55 +0000 (14:47 +0100)]
Report: Add data

Change-Id: Ia6f46cd9dbf83e6376f635b3e250708bdfba80be
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 98a94315dae63bd19c7bc16ce50b3219386aa34c)

3 years agoReport: Add data 10/30710/1
Tibor Frank [Wed, 13 Jan 2021 06:50:35 +0000 (07:50 +0100)]
Report: Add data

Change-Id: I23dd384edd107facdc8e54275c1acded5a9935fd
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 7a26d43c4f71869695ba19ce58f9afac9a1d176d)

3 years agoReport: Add data 09/30709/1
Tibor Frank [Tue, 12 Jan 2021 11:58:01 +0000 (12:58 +0100)]
Report: Add data

Change-Id: I70153753ccc69597dc2c69133b3828cd76174468
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 1899cf849e938512df8bac9ea7cb6479732dda42)

3 years agoAdd 2n-tx2 job specs 08/30708/2
Tibor Frank [Tue, 12 Jan 2021 10:15:56 +0000 (10:15 +0000)]
Add 2n-tx2 job specs

Change-Id: I992c1466b2226337a043b46e1bdba82de2dc2368
Signed-off-by: Tibor Frank <tifrank@cisco.com>
3 years agoReport: Add data 07/30707/1
Tibor Frank [Tue, 12 Jan 2021 06:48:31 +0000 (07:48 +0100)]
Report: Add data

Change-Id: I648732e98941b562c31a9db735332bd215d65870
Signed-off-by: Tibor Frank <tifrank@cisco.com>
(cherry picked from commit 1b141f8090e9b067dce9d182a81aa530213d4a66)

3 years agotests: add 2n1l l2 acl tests, update 2n-tx2 specs 06/30706/2
Juraj Linkeš [Thu, 7 Jan 2021 15:25:31 +0000 (16:25 +0100)]
tests: add 2n1l l2 acl tests, update 2n-tx2 specs

Modify initialize L2BD ACL keywords to be usable for both 2-node and
3-node topologies and update testsuites accordingly.
Add the missing macip T-rex profile.
Add classifier tests to 2n-tx2 job specs.

Change-Id: I17b84b8fc18ef9a6f275ae0238a0665ac2017f01
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
(cherry picked from commit 9d510d595f73d26e3f7c6646fa6530e8f252f790)

3 years agoInfra: Increase shm-size 05/30705/1
pmikus [Mon, 11 Jan 2021 08:33:05 +0000 (08:33 +0000)]
Infra: Increase shm-size

Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: Ib9dfb8623757fd23fd8b49b5e04ed86e202ada66
(cherry picked from commit 2f4b14bc83437afcc242190a121ba47a6d10bd09)