From c6c0ad58319508dd1d17a0b87b55c4dc543a29cf Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Wed, 18 Oct 2023 09:13:32 +0200 Subject: [PATCH] fix(tox): move dependency to requirements.txt Two reasons. Most importantly, executor image creation scripts will now see the pylint version used in tox job. Additionally, this makes it easier for people to run pylint locally (without checking all files as tox does). Change-Id: I89f1d428e676e27d6f35c79ca9c22224c4c99a3e Signed-off-by: Vratko Polak --- requirements.txt | 3 +++ tox.ini | 4 +--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/requirements.txt b/requirements.txt index a4766e1fc6..398d6896ed 100644 --- a/requirements.txt +++ b/requirements.txt @@ -44,6 +44,9 @@ jsonschema==4.18.4 rfc3339-validator==0.1.4 rfc3987==1.3.8 +# Dependencies for some tox checkers (not tox setup itself). +pylint==3.0.1 + # Other PIP freeze dependencies. attrs==23.1.0 bcrypt==4.0.1 diff --git a/tox.ini b/tox.ini index ce0f9be16b..1d4cad11d5 100644 --- a/tox.ini +++ b/tox.ini @@ -78,9 +78,7 @@ commands = bash {[tox]script_dir}/new_line.sh ignore_outcome = true setenv = PYTHONPATH = {toxinidir} basepython = python3 -deps = - pylint==3.0.1 - -r ./requirements.txt +deps = -r ./requirements.txt whitelist_externals = /bin/bash commands = bash {[tox]script_dir}/pylint.sh -- 2.16.6