From daa48bd849e20b1452928b561398d23bad5bcc6b Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Thu, 9 Apr 2020 17:00:56 +0200 Subject: [PATCH] Do not set seeds in -rnd profiles From trending it seems like TRex threads use thread-local PRNGs, resulting in multiple packets (one from each thread) for the same flow. Hopefully, without a seed set, each thread will pick a different seed. We are risking some threads will still pick the same seed occasionally, but I doubt TRex API has a better way to prevent this issue. Change-Id: Ie6ed42669d6e2463627760f89d2426d4e6bf0155 Signed-off-by: Vratko Polak --- .../traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd10000.py | 6 ++---- .../traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd100000.py | 6 ++---- .../traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd1000000.py | 6 ++---- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd10000.py b/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd10000.py index 321b12c115..16627f0884 100644 --- a/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd10000.py +++ b/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd10000.py @@ -81,8 +81,7 @@ class TrafficStreams(TrafficStreamsBaseClass): min_value=self.p1_dst_start_ip, max_value=self.p1_dst_end_ip, size=4, - limit=10000, - seed=0x0000 + limit=10000 ), STLVmWrFlowVar( fv_name=u"dst", @@ -102,8 +101,7 @@ class TrafficStreams(TrafficStreamsBaseClass): min_value=self.p2_dst_start_ip, max_value=self.p2_dst_end_ip, size=4, - limit=10000, - seed=0x0000 + limit=10000 ), STLVmWrFlowVar( fv_name=u"dst", diff --git a/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd100000.py b/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd100000.py index 1e181c966e..751528d10c 100644 --- a/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd100000.py +++ b/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd100000.py @@ -81,8 +81,7 @@ class TrafficStreams(TrafficStreamsBaseClass): min_value=self.p1_dst_start_ip, max_value=self.p1_dst_end_ip, size=4, - limit=100000, - seed=0x0000 + limit=100000 ), STLVmWrFlowVar( fv_name=u"dst", @@ -101,8 +100,7 @@ class TrafficStreams(TrafficStreamsBaseClass): min_value=self.p2_dst_start_ip, max_value=self.p2_dst_end_ip, size=4, - limit=100000, - seed=0x0000 + limit=100000 ), STLVmWrFlowVar( fv_name=u"dst", diff --git a/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd1000000.py b/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd1000000.py index d7e74abf68..58ab03516c 100644 --- a/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd1000000.py +++ b/resources/traffic_profiles/trex/trex-sl-2n-ethip4-ip4dst-rnd1000000.py @@ -81,8 +81,7 @@ class TrafficStreams(TrafficStreamsBaseClass): min_value=self.p1_dst_start_ip, max_value=self.p1_dst_end_ip, size=4, - limit=1000000, - seed=0x0000 + limit=1000000 ), STLVmWrFlowVar( fv_name=u"dst", @@ -101,8 +100,7 @@ class TrafficStreams(TrafficStreamsBaseClass): min_value=self.p2_dst_start_ip, max_value=self.p2_dst_end_ip, size=4, - limit=1000000, - seed=0x0000 + limit=1000000 ), STLVmWrFlowVar( fv_name=u"dst", -- 2.16.6