From e3e4de9a122f15fd72e1005951849d1440067d2e Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Tue, 26 May 2020 13:57:08 +0200 Subject: [PATCH] Soak: Fix failure condition Previously, number of directions was not taken into account. Also, ideally PLRsearch never reports value under the hard minimum, so successful results are now required to be more than 10% better. Change-Id: I8622726b97bd1da3e139c8044a2932837fc268b7 Signed-off-by: Vratko Polak --- resources/libraries/robot/performance/performance_utils.robot | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/libraries/robot/performance/performance_utils.robot b/resources/libraries/robot/performance/performance_utils.robot index 0db0f3c140..834de552e1 100644 --- a/resources/libraries/robot/performance/performance_utils.robot +++ b/resources/libraries/robot/performance/performance_utils.robot @@ -172,7 +172,7 @@ | | ... | Find boundaries for troughput (of given target loss ratio) | | ... | using PLRsearch algorithm. | | ... | Display results as formatted test message. -| | ... | Fail if computed lower bound is below minimal rate. +| | ... | Fail if computed lower bound 110% of the minimal rate or less. | | ... | Input rates are understood as uni-directional, | | ... | reported result contains aggregate rates. | | ... | Currently, the min_rate value is hardcoded to match test teardowns. @@ -205,8 +205,8 @@ | | ... | traffic_directions=${traffic_directions} | | ${lower} | ${upper} = | Display result of soak search | | ... | ${average} | ${stdev} -| | Should Not Be True | ${lower} < ${min_rate} -| | ... | Lower bound ${lower} is below unidirectional minimum ${min_rate}. +| | Should Not Be True | 1.1 * ${traffic_directions} * ${min_rate} > ${lower} +| | ... | Lower bound ${lower} too small for unidirectional minimum ${min_rate}. | Display single bound | | [Documentation] -- 2.16.6