From f7452e826cd83fc5ded28c1268f6f4aab252ca2d Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Mon, 27 Jan 2020 14:17:24 +0100 Subject: [PATCH] Increase min_rate for NDRPDR tests Latency measurements break for loads less than 9 kpps per direction. Setting min_rate to 90 kpps prevents 10% latency trial from breaking. 90 kpps should be enough for any type of test. When some test finds a lower value, this patch will make the fail with a message saying the loss rate at minimal load is too high (instead of a cryptic error from 10% measurement without this patch). Change-Id: I97b8428aa5044da23343b86447857b3a101f6baa Signed-off-by: Vratko Polak --- resources/libraries/robot/performance/performance_utils.robot | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/resources/libraries/robot/performance/performance_utils.robot b/resources/libraries/robot/performance/performance_utils.robot index 1ed7a148e5..68238668a2 100644 --- a/resources/libraries/robot/performance/performance_utils.robot +++ b/resources/libraries/robot/performance/performance_utils.robot @@ -34,7 +34,9 @@ | | ... | Fail if a resulting lower bound has too high loss fraction. | | ... | Input rates are understood as uni-directional, | | ... | reported result contains aggregate rates. -| | ... | Currently, the min_rate value is hardcoded to match test teardowns. +| | ... | Currently, the min_rate value is hardcoded to 90kpps, +| | ... | allowing measurement at 10% of the discovered rate +| | ... | without breaking latency streams. | | | | ... | *Test (or broader scope) variables read:* | | ... | - traffic_profile - Name of module defining traffc for measurements. @@ -69,7 +71,7 @@ | | ... | ${latency_duration}=${PERF_TRIAL_LATENCY_DURATION} | | | | ${result} = | Perform optimized ndrpdr search | ${frame_size} -| | ... | ${traffic_profile} | ${10000} | ${max_rate} +| | ... | ${traffic_profile} | ${90000} | ${max_rate} | | ... | ${packet_loss_ratio} | ${final_relative_width} | | ... | ${final_trial_duration} | ${initial_trial_duration} | | ... | ${number_of_intermediate_phases} | timeout=${timeout} -- 2.16.6