Imported Upstream version 17.05

[deb_dpdk.git] / devtools / check-git-log.sh

diff --git a/scripts/check-git-log.sh b/devtools/check-git-log.sh
similarity index 88%
rename from scripts/check-git-log.sh
rename to devtools/check-git-log.sh
index 5f8a9fc..910daba 100755 (executable)
--- a/scripts/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -47,12 +47,18 @@ if [ "$1" = '-h' -o "$1" = '--help' ] ; then
        exit
 fi
 
+selfdir=$(dirname $(readlink -f $0))
 range=${1:-origin/master..}
+# convert -N to HEAD~N.. in order to comply with git-log-fixes.sh getopts
+if printf -- $range | grep -q '^-[0-9]\+' ; then
+       range="HEAD$(printf -- $range | sed 's,^-,~,').."
+fi
 
 commits=$(git log --format='%h' --reverse $range)
 headlines=$(git log --format='%s' --reverse $range)
 bodylines=$(git log --format='%b' --reverse $range)
 fixes=$(git log --format='%h %s' --reverse $range | grep -i ': *fix' | cut -d' ' -f1)
+stablefixes=$($selfdir/git-log-fixes.sh $range | sed '/(N\/A)$/d'  | cut -d' ' -f2)
 tags=$(git log --format='%b' --reverse $range | grep -i -e 'by *:' -e 'fix.*:')
 bytag='\(Reported\|Suggested\|Signed-off\|Acked\|Reviewed\|Tested\)-by:'
 
@@ -81,7 +87,7 @@ bad=$(for commit in $commits ; do
        if [ $(echo "$drvgrp" | wc -l) -gt 1 ] ; then
                echo "$headline" | grep -v '^drivers:'
        elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then
-               echo "$headline" | grep -v "^$drvgrp"
+               echo "$headline" | grep -v "^drivers/$drvgrp"
        else
                echo "$headline" | grep -v "^$drv"
        fi
@@ -107,28 +113,31 @@ bad=$(echo "$headlines" | grep --color=always \
 
 # check headline uppercase (Rx/Tx, VF, L2, MAC, Linux, ARM...)
 bad=$(echo "$headlines" | grep -E --color=always \
-       -e '\<(rx|tx|RX|TX)\>' \
-       -e '\<[pv]f\>' \
-       -e '\<[hsf]w\>' \
-       -e '\<l[234]\>' \
+       -e ':.*\<(rx|tx|RX|TX)\>' \
+       -e ':.*\<[pv]f\>' \
+       -e ':.*\<[hsf]w\>' \
+       -e ':.*\<l[234]\>' \
        -e ':.*\<api\>' \
        -e ':.*\<arm\>' \
        -e ':.*\<armv7\>' \
        -e ':.*\<armv8\>' \
+       -e ':.*\<crc\>' \
        -e ':.*\<dma\>' \
        -e ':.*\<freebsd\>' \
        -e ':.*\<linux\>' \
        -e ':.*\<lro\>' \
+       -e ':.*\<lsc\>' \
        -e ':.*\<mac\>' \
        -e ':.*\<mtu\>' \
        -e ':.*\<nic\>' \
+       -e ':.*\<nvm\>' \
        -e ':.*\<numa\>' \
        -e ':.*\<pci\>' \
        -e ':.*\<pmd\>' \
        -e ':.*\<rss\>' \
-       -e ':.*\<tile-gx\>' \
-       -e ':.*\<tilegx\>' \
-       -e ':.*\<vlan\>' \
+       -e ':.*\<tso\>' \
+       -e ':.*\<[Vv]lan\>' \
+       -e ':.*\<vsi\>' \
        | sed 's,^,\t,')
 [ -z "$bad" ] || printf "Wrong headline lowercase:\n$bad\n"
 
@@ -164,12 +173,6 @@ bad=$(echo "$tags" |
        sed 's,^.,\t&,')
 [ -z "$bad" ] || printf "Wrong tag:\n$bad\n"
 
-# check blank line after last Fixes: tag
-bad=$(echo "$bodylines" |
-       sed -n 'N;/\nFixes:/D;/\n$/D;/^Fixes:/P' |
-       sed 's,^.,\t&,')
-[ -z "$bad" ] || printf "Missing blank line after 'Fixes' tag:\n$bad\n"
-
 # check missing Fixes: tag
 bad=$(for fix in $fixes ; do
        git log --format='%b' -1 $fix | grep -q '^Fixes: ' ||
@@ -191,3 +194,10 @@ bad=$(for fixtag in $fixtags ; do
        printf "$fixtag" | grep -v "^$good$"
 done | sed 's,^,\t,')
 [ -z "$bad" ] || printf "Wrong 'Fixes' reference:\n$bad\n"
+
+# check Cc: stable@dpdk.org for fixes
+bad=$(for fix in $stablefixes ; do
+       git log --format='%b' -1 $fix | grep -qi '^Cc: *stable@dpdk.org' ||
+               git log --format='\t%s' -1 $fix
+done)
+[ -z "$bad" ] || printf "Is it candidate for Cc: stable@dpdk.org backport?\n$bad\n"