Imported Upstream version 16.11
[deb_dpdk.git] / drivers / net / pcap / rte_eth_pcap.c
index 7b7126b..0162f44 100644 (file)
@@ -1,7 +1,7 @@
 /*-
  *   BSD LICENSE
  *
- *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
  *   Copyright(c) 2014 6WIND S.A.
  *   All rights reserved.
  *
  */
 
 #include <time.h>
-#include <rte_mbuf.h>
-#include <rte_ethdev.h>
-#include <rte_malloc.h>
-#include <rte_memcpy.h>
-#include <rte_string_fns.h>
-#include <rte_cycles.h>
-#include <rte_kvargs.h>
-#include <rte_dev.h>
 
 #include <net/if.h>
 
 #include <pcap.h>
 
+#include <rte_cycles.h>
+#include <rte_ethdev.h>
+#include <rte_kvargs.h>
+#include <rte_malloc.h>
+#include <rte_mbuf.h>
+#include <rte_vdev.h>
+
 #define RTE_ETH_PCAP_SNAPSHOT_LEN 65535
 #define RTE_ETH_PCAP_SNAPLEN ETHER_MAX_JUMBO_FRAME_LEN
 #define RTE_ETH_PCAP_PROMISC 1
 #define RTE_ETH_PCAP_TIMEOUT -1
+
 #define ETH_PCAP_RX_PCAP_ARG  "rx_pcap"
 #define ETH_PCAP_TX_PCAP_ARG  "tx_pcap"
 #define ETH_PCAP_RX_IFACE_ARG "rx_iface"
 
 #define ETH_PCAP_ARG_MAXLEN    64
 
+#define RTE_PMD_PCAP_MAX_QUEUES 16
+
 static char errbuf[PCAP_ERRBUF_SIZE];
 static unsigned char tx_pcap_data[RTE_ETH_PCAP_SNAPLEN];
 static struct timeval start_time;
 static uint64_t start_cycles;
 static uint64_t hz;
 
+struct queue_stat {
+       volatile unsigned long pkts;
+       volatile unsigned long bytes;
+       volatile unsigned long err_pkts;
+};
+
 struct pcap_rx_queue {
        pcap_t *pcap;
        uint8_t in_port;
        struct rte_mempool *mb_pool;
-       volatile unsigned long rx_pkts;
-       volatile unsigned long rx_bytes;
-       volatile unsigned long err_pkts;
+       struct queue_stat rx_stat;
        char name[PATH_MAX];
        char type[ETH_PCAP_ARG_MAXLEN];
 };
@@ -78,36 +84,29 @@ struct pcap_rx_queue {
 struct pcap_tx_queue {
        pcap_dumper_t *dumper;
        pcap_t *pcap;
-       volatile unsigned long tx_pkts;
-       volatile unsigned long tx_bytes;
-       volatile unsigned long err_pkts;
+       struct queue_stat tx_stat;
        char name[PATH_MAX];
        char type[ETH_PCAP_ARG_MAXLEN];
 };
 
-struct rx_pcaps {
-       unsigned num_of_rx;
-       pcap_t *pcaps[RTE_PMD_RING_MAX_RX_RINGS];
-       const char *names[RTE_PMD_RING_MAX_RX_RINGS];
-       const char *types[RTE_PMD_RING_MAX_RX_RINGS];
-};
-
-struct tx_pcaps {
-       unsigned num_of_tx;
-       pcap_dumper_t *dumpers[RTE_PMD_RING_MAX_TX_RINGS];
-       pcap_t *pcaps[RTE_PMD_RING_MAX_RX_RINGS];
-       const char *names[RTE_PMD_RING_MAX_RX_RINGS];
-       const char *types[RTE_PMD_RING_MAX_RX_RINGS];
-};
-
 struct pmd_internals {
-       struct pcap_rx_queue rx_queue[RTE_PMD_RING_MAX_RX_RINGS];
-       struct pcap_tx_queue tx_queue[RTE_PMD_RING_MAX_TX_RINGS];
+       struct pcap_rx_queue rx_queue[RTE_PMD_PCAP_MAX_QUEUES];
+       struct pcap_tx_queue tx_queue[RTE_PMD_PCAP_MAX_QUEUES];
        int if_index;
        int single_iface;
 };
 
-const char *valid_arguments[] = {
+struct pmd_devargs {
+       unsigned int num_of_queue;
+       struct devargs_queue {
+               pcap_dumper_t *dumper;
+               pcap_t *pcap;
+               const char *name;
+               const char *type;
+       } queue[RTE_PMD_PCAP_MAX_QUEUES];
+};
+
+static const char *valid_arguments[] = {
        ETH_PCAP_RX_PCAP_ARG,
        ETH_PCAP_TX_PCAP_ARG,
        ETH_PCAP_RX_IFACE_ARG,
@@ -116,11 +115,10 @@ const char *valid_arguments[] = {
        NULL
 };
 
-static int open_single_tx_pcap(const char *pcap_filename, pcap_dumper_t **dumper);
-static int open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap);
-static int open_single_iface(const char *iface, pcap_t **pcap);
+static struct ether_addr eth_addr = {
+       .addr_bytes = { 0, 0, 0, 0x1, 0x2, 0x3 }
+};
 
-static struct ether_addr eth_addr = { .addr_bytes = { 0, 0, 0, 0x1, 0x2, 0x3 } };
 static const char *drivername = "Pcap PMD";
 static struct rte_eth_link pmd_link = {
                .link_speed = ETH_SPEED_NUM_10G,
@@ -130,15 +128,12 @@ static struct rte_eth_link pmd_link = {
 };
 
 static int
-eth_pcap_rx_jumbo(struct rte_mempool *mb_pool,
-                 struct rte_mbuf *mbuf,
-                 const u_char *data,
-                 uint16_t data_len)
+eth_pcap_rx_jumbo(struct rte_mempool *mb_pool, struct rte_mbuf *mbuf,
+               const u_char *data, uint16_t data_len)
 {
-       struct rte_mbuf *m = mbuf;
-
        /* Copy the first segment. */
        uint16_t len = rte_pktmbuf_tailroom(mbuf);
+       struct rte_mbuf *m = mbuf;
 
        rte_memcpy(rte_pktmbuf_append(mbuf, len), data, len);
        data_len -= len;
@@ -178,7 +173,7 @@ eth_pcap_gather_data(unsigned char *data, struct rte_mbuf *mbuf)
 
        while (mbuf) {
                rte_memcpy(data + data_len, rte_pktmbuf_mtod(mbuf, void *),
-                          mbuf->data_len);
+                       mbuf->data_len);
 
                data_len += mbuf->data_len;
                mbuf = mbuf->next;
@@ -186,11 +181,9 @@ eth_pcap_gather_data(unsigned char *data, struct rte_mbuf *mbuf)
 }
 
 static uint16_t
-eth_pcap_rx(void *queue,
-               struct rte_mbuf **bufs,
-               uint16_t nb_pkts)
+eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       unsigned i;
+       unsigned int i;
        struct pcap_pkthdr header;
        const u_char *packet;
        struct rte_mbuf *mbuf;
@@ -210,17 +203,17 @@ eth_pcap_rx(void *queue,
                packet = pcap_next(pcap_q->pcap, &header);
                if (unlikely(packet == NULL))
                        break;
-               else
-                       mbuf = rte_pktmbuf_alloc(pcap_q->mb_pool);
+
+               mbuf = rte_pktmbuf_alloc(pcap_q->mb_pool);
                if (unlikely(mbuf == NULL))
                        break;
 
                /* Now get the space available for data in the mbuf */
-               buf_size = (uint16_t)(rte_pktmbuf_data_room_size(pcap_q->mb_pool) -
-                               RTE_PKTMBUF_HEADROOM);
+               buf_size = rte_pktmbuf_data_room_size(pcap_q->mb_pool) -
+                               RTE_PKTMBUF_HEADROOM;
 
                if (header.caplen <= buf_size) {
-                       /* pcap packet will fit in the mbuf, go ahead and copy */
+                       /* pcap packet will fit in the mbuf, can copy it */
                        rte_memcpy(rte_pktmbuf_mtod(mbuf, void *), packet,
                                        header.caplen);
                        mbuf->data_len = (uint16_t)header.caplen;
@@ -241,8 +234,9 @@ eth_pcap_rx(void *queue,
                num_rx++;
                rx_bytes += header.caplen;
        }
-       pcap_q->rx_pkts += num_rx;
-       pcap_q->rx_bytes += rx_bytes;
+       pcap_q->rx_stat.pkts += num_rx;
+       pcap_q->rx_stat.bytes += rx_bytes;
+
        return num_rx;
 }
 
@@ -261,11 +255,9 @@ calculate_timestamp(struct timeval *ts) {
  * Callback to handle writing packets to a pcap file.
  */
 static uint16_t
-eth_pcap_tx_dumper(void *queue,
-               struct rte_mbuf **bufs,
-               uint16_t nb_pkts)
+eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       unsigned i;
+       unsigned int i;
        struct rte_mbuf *mbuf;
        struct pcap_tx_queue *dumper_q = queue;
        uint16_t num_tx = 0;
@@ -275,7 +267,8 @@ eth_pcap_tx_dumper(void *queue,
        if (dumper_q->dumper == NULL || nb_pkts == 0)
                return 0;
 
-       /* writes the nb_pkts packets to the previously opened pcap file dumper */
+       /* writes the nb_pkts packets to the previously opened pcap file
+        * dumper */
        for (i = 0; i < nb_pkts; i++) {
                mbuf = bufs[i];
                calculate_timestamp(&header.ts);
@@ -292,8 +285,7 @@ eth_pcap_tx_dumper(void *queue,
                                          tx_pcap_data);
                        } else {
                                RTE_LOG(ERR, PMD,
-                                       "Dropping PCAP packet. "
-                                       "Size (%d) > max jumbo size (%d).\n",
+                                       "Dropping PCAP packet. Size (%d) > max jumbo size (%d).\n",
                                        mbuf->pkt_len,
                                        ETHER_MAX_JUMBO_FRAME_LEN);
 
@@ -313,9 +305,10 @@ eth_pcap_tx_dumper(void *queue,
         * we flush the pcap dumper within each burst.
         */
        pcap_dump_flush(dumper_q->dumper);
-       dumper_q->tx_pkts += num_tx;
-       dumper_q->tx_bytes += tx_bytes;
-       dumper_q->err_pkts += nb_pkts - num_tx;
+       dumper_q->tx_stat.pkts += num_tx;
+       dumper_q->tx_stat.bytes += tx_bytes;
+       dumper_q->tx_stat.err_pkts += nb_pkts - num_tx;
+
        return num_tx;
 }
 
@@ -323,11 +316,9 @@ eth_pcap_tx_dumper(void *queue,
  * Callback to handle sending packets through a real NIC.
  */
 static uint16_t
-eth_pcap_tx(void *queue,
-               struct rte_mbuf **bufs,
-               uint16_t nb_pkts)
+eth_pcap_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       unsigned i;
+       unsigned int i;
        int ret;
        struct rte_mbuf *mbuf;
        struct pcap_tx_queue *tx_queue = queue;
@@ -342,18 +333,16 @@ eth_pcap_tx(void *queue,
 
                if (likely(mbuf->nb_segs == 1)) {
                        ret = pcap_sendpacket(tx_queue->pcap,
-                                             rte_pktmbuf_mtod(mbuf, u_char *),
-                                             mbuf->pkt_len);
+                                       rte_pktmbuf_mtod(mbuf, u_char *),
+                                       mbuf->pkt_len);
                } else {
                        if (mbuf->pkt_len <= ETHER_MAX_JUMBO_FRAME_LEN) {
                                eth_pcap_gather_data(tx_pcap_data, mbuf);
                                ret = pcap_sendpacket(tx_queue->pcap,
-                                                     tx_pcap_data,
-                                                     mbuf->pkt_len);
+                                               tx_pcap_data, mbuf->pkt_len);
                        } else {
                                RTE_LOG(ERR, PMD,
-                                       "Dropping PCAP packet. "
-                                       "Size (%d) > max jumbo size (%d).\n",
+                                       "Dropping PCAP packet. Size (%d) > max jumbo size (%d).\n",
                                        mbuf->pkt_len,
                                        ETHER_MAX_JUMBO_FRAME_LEN);
 
@@ -369,16 +358,84 @@ eth_pcap_tx(void *queue,
                rte_pktmbuf_free(mbuf);
        }
 
-       tx_queue->tx_pkts += num_tx;
-       tx_queue->tx_bytes += tx_bytes;
-       tx_queue->err_pkts += nb_pkts - num_tx;
+       tx_queue->tx_stat.pkts += num_tx;
+       tx_queue->tx_stat.bytes += tx_bytes;
+       tx_queue->tx_stat.err_pkts += nb_pkts - num_tx;
+
        return num_tx;
 }
 
+/*
+ * pcap_open_live wrapper function
+ */
+static inline int
+open_iface_live(const char *iface, pcap_t **pcap) {
+       *pcap = pcap_open_live(iface, RTE_ETH_PCAP_SNAPLEN,
+                       RTE_ETH_PCAP_PROMISC, RTE_ETH_PCAP_TIMEOUT, errbuf);
+
+       if (*pcap == NULL) {
+               RTE_LOG(ERR, PMD, "Couldn't open %s: %s\n", iface, errbuf);
+               return -1;
+       }
+
+       return 0;
+}
+
+static int
+open_single_iface(const char *iface, pcap_t **pcap)
+{
+       if (open_iface_live(iface, pcap) < 0) {
+               RTE_LOG(ERR, PMD, "Couldn't open interface %s\n", iface);
+               return -1;
+       }
+
+       return 0;
+}
+
+static int
+open_single_tx_pcap(const char *pcap_filename, pcap_dumper_t **dumper)
+{
+       pcap_t *tx_pcap;
+
+       /*
+        * We need to create a dummy empty pcap_t to use it
+        * with pcap_dump_open(). We create big enough an Ethernet
+        * pcap holder.
+        */
+       tx_pcap = pcap_open_dead(DLT_EN10MB, RTE_ETH_PCAP_SNAPSHOT_LEN);
+       if (tx_pcap == NULL) {
+               RTE_LOG(ERR, PMD, "Couldn't create dead pcap\n");
+               return -1;
+       }
+
+       /* The dumper is created using the previous pcap_t reference */
+       *dumper = pcap_dump_open(tx_pcap, pcap_filename);
+       if (*dumper == NULL) {
+               RTE_LOG(ERR, PMD, "Couldn't open %s for writing.\n",
+                       pcap_filename);
+               return -1;
+       }
+
+       return 0;
+}
+
+static int
+open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap)
+{
+       *pcap = pcap_open_offline(pcap_filename, errbuf);
+       if (*pcap == NULL) {
+               RTE_LOG(ERR, PMD, "Couldn't open %s: %s\n", pcap_filename,
+                       errbuf);
+               return -1;
+       }
+
+       return 0;
+}
+
 static int
 eth_dev_start(struct rte_eth_dev *dev)
 {
-       unsigned i;
+       unsigned int i;
        struct pmd_internals *internals = dev->data->dev_private;
        struct pcap_tx_queue *tx;
        struct pcap_rx_queue *rx;
@@ -400,12 +457,12 @@ eth_dev_start(struct rte_eth_dev *dev)
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
                tx = &internals->tx_queue[i];
 
-               if (!tx->dumper && strcmp(tx->type, ETH_PCAP_TX_PCAP_ARG) == 0) {
+               if (!tx->dumper &&
+                               strcmp(tx->type, ETH_PCAP_TX_PCAP_ARG) == 0) {
                        if (open_single_tx_pcap(tx->name, &tx->dumper) < 0)
                                return -1;
-               }
-
-               else if (!tx->pcap && strcmp(tx->type, ETH_PCAP_TX_IFACE_ARG) == 0) {
+               } else if (!tx->pcap &&
+                               strcmp(tx->type, ETH_PCAP_TX_IFACE_ARG) == 0) {
                        if (open_single_iface(tx->name, &tx->pcap) < 0)
                                return -1;
                }
@@ -421,17 +478,15 @@ eth_dev_start(struct rte_eth_dev *dev)
                if (strcmp(rx->type, ETH_PCAP_RX_PCAP_ARG) == 0) {
                        if (open_single_rx_pcap(rx->name, &rx->pcap) < 0)
                                return -1;
-               }
-
-               else if (strcmp(rx->type, ETH_PCAP_RX_IFACE_ARG) == 0) {
+               } else if (strcmp(rx->type, ETH_PCAP_RX_IFACE_ARG) == 0) {
                        if (open_single_iface(rx->name, &rx->pcap) < 0)
                                return -1;
                }
        }
 
 status_up:
-
        dev->data->dev_link.link_status = ETH_LINK_UP;
+
        return 0;
 }
 
@@ -443,7 +498,7 @@ status_up:
 static void
 eth_dev_stop(struct rte_eth_dev *dev)
 {
-       unsigned i;
+       unsigned int i;
        struct pmd_internals *internals = dev->data->dev_private;
        struct pcap_tx_queue *tx;
        struct pcap_rx_queue *rx;
@@ -496,6 +551,7 @@ eth_dev_info(struct rte_eth_dev *dev,
                struct rte_eth_dev_info *dev_info)
 {
        struct pmd_internals *internals = dev->data->dev_private;
+
        dev_info->driver_name = drivername;
        dev_info->if_index = internals->if_index;
        dev_info->max_mac_addrs = 1;
@@ -507,10 +563,9 @@ eth_dev_info(struct rte_eth_dev *dev,
 }
 
 static void
-eth_stats_get(struct rte_eth_dev *dev,
-               struct rte_eth_stats *igb_stats)
+eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
-       unsigned i;
+       unsigned int i;
        unsigned long rx_packets_total = 0, rx_bytes_total = 0;
        unsigned long tx_packets_total = 0, tx_bytes_total = 0;
        unsigned long tx_packets_err_total = 0;
@@ -518,42 +573,44 @@ eth_stats_get(struct rte_eth_dev *dev,
 
        for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
                        i < dev->data->nb_rx_queues; i++) {
-               igb_stats->q_ipackets[i] = internal->rx_queue[i].rx_pkts;
-               igb_stats->q_ibytes[i] = internal->rx_queue[i].rx_bytes;
-               rx_packets_total += igb_stats->q_ipackets[i];
-               rx_bytes_total += igb_stats->q_ibytes[i];
+               stats->q_ipackets[i] = internal->rx_queue[i].rx_stat.pkts;
+               stats->q_ibytes[i] = internal->rx_queue[i].rx_stat.bytes;
+               rx_packets_total += stats->q_ipackets[i];
+               rx_bytes_total += stats->q_ibytes[i];
        }
 
        for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
                        i < dev->data->nb_tx_queues; i++) {
-               igb_stats->q_opackets[i] = internal->tx_queue[i].tx_pkts;
-               igb_stats->q_obytes[i] = internal->tx_queue[i].tx_bytes;
-               igb_stats->q_errors[i] = internal->tx_queue[i].err_pkts;
-               tx_packets_total += igb_stats->q_opackets[i];
-               tx_bytes_total += igb_stats->q_obytes[i];
-               tx_packets_err_total += igb_stats->q_errors[i];
+               stats->q_opackets[i] = internal->tx_queue[i].tx_stat.pkts;
+               stats->q_obytes[i] = internal->tx_queue[i].tx_stat.bytes;
+               stats->q_errors[i] = internal->tx_queue[i].tx_stat.err_pkts;
+               tx_packets_total += stats->q_opackets[i];
+               tx_bytes_total += stats->q_obytes[i];
+               tx_packets_err_total += stats->q_errors[i];
        }
 
-       igb_stats->ipackets = rx_packets_total;
-       igb_stats->ibytes = rx_bytes_total;
-       igb_stats->opackets = tx_packets_total;
-       igb_stats->obytes = tx_bytes_total;
-       igb_stats->oerrors = tx_packets_err_total;
+       stats->ipackets = rx_packets_total;
+       stats->ibytes = rx_bytes_total;
+       stats->opackets = tx_packets_total;
+       stats->obytes = tx_bytes_total;
+       stats->oerrors = tx_packets_err_total;
 }
 
 static void
 eth_stats_reset(struct rte_eth_dev *dev)
 {
-       unsigned i;
+       unsigned int i;
        struct pmd_internals *internal = dev->data->dev_private;
+
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
-               internal->rx_queue[i].rx_pkts = 0;
-               internal->rx_queue[i].rx_bytes = 0;
+               internal->rx_queue[i].rx_stat.pkts = 0;
+               internal->rx_queue[i].rx_stat.bytes = 0;
        }
+
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
-               internal->tx_queue[i].tx_pkts = 0;
-               internal->tx_queue[i].tx_bytes = 0;
-               internal->tx_queue[i].err_pkts = 0;
+               internal->tx_queue[i].tx_stat.pkts = 0;
+               internal->tx_queue[i].tx_stat.bytes = 0;
+               internal->tx_queue[i].tx_stat.err_pkts = 0;
        }
 }
 
@@ -584,9 +641,11 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
 {
        struct pmd_internals *internals = dev->data->dev_private;
        struct pcap_rx_queue *pcap_q = &internals->rx_queue[rx_queue_id];
+
        pcap_q->mb_pool = mb_pool;
        dev->data->rx_queues[rx_queue_id] = pcap_q;
        pcap_q->in_port = dev->data->port_id;
+
        return 0;
 }
 
@@ -597,15 +656,16 @@ eth_tx_queue_setup(struct rte_eth_dev *dev,
                unsigned int socket_id __rte_unused,
                const struct rte_eth_txconf *tx_conf __rte_unused)
 {
-
        struct pmd_internals *internals = dev->data->dev_private;
+
        dev->data->tx_queues[tx_queue_id] = &internals->tx_queue[tx_queue_id];
+
        return 0;
 }
 
 static const struct eth_dev_ops ops = {
        .dev_start = eth_dev_start,
-       .dev_stop =     eth_dev_stop,
+       .dev_stop = eth_dev_stop,
        .dev_close = eth_dev_close,
        .dev_configure = eth_dev_configure,
        .dev_infos_get = eth_dev_info,
@@ -625,33 +685,23 @@ static const struct eth_dev_ops ops = {
 static int
 open_rx_pcap(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
+       unsigned int i;
        const char *pcap_filename = value;
-       struct rx_pcaps *pcaps = extra_args;
+       struct pmd_devargs *rx = extra_args;
        pcap_t *pcap = NULL;
 
-       for (i = 0; i < pcaps->num_of_rx; i++) {
+       for (i = 0; i < rx->num_of_queue; i++) {
                if (open_single_rx_pcap(pcap_filename, &pcap) < 0)
                        return -1;
 
-               pcaps->pcaps[i] = pcap;
-               pcaps->names[i] = pcap_filename;
-               pcaps->types[i] = key;
+               rx->queue[i].pcap = pcap;
+               rx->queue[i].name = pcap_filename;
+               rx->queue[i].type = key;
        }
 
        return 0;
 }
 
-static int
-open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap)
-{
-       if ((*pcap = pcap_open_offline(pcap_filename, errbuf)) == NULL) {
-               RTE_LOG(ERR, PMD, "Couldn't open %s: %s\n", pcap_filename, errbuf);
-               return -1;
-       }
-       return 0;
-}
-
 /*
  * Opens a pcap file for writing and stores a reference to it
  * for use it later on.
@@ -659,63 +709,23 @@ open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap)
 static int
 open_tx_pcap(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
+       unsigned int i;
        const char *pcap_filename = value;
-       struct tx_pcaps *dumpers = extra_args;
+       struct pmd_devargs *dumpers = extra_args;
        pcap_dumper_t *dumper;
 
-       for (i = 0; i < dumpers->num_of_tx; i++) {
+       for (i = 0; i < dumpers->num_of_queue; i++) {
                if (open_single_tx_pcap(pcap_filename, &dumper) < 0)
                        return -1;
 
-               dumpers->dumpers[i] = dumper;
-               dumpers->names[i] = pcap_filename;
-               dumpers->types[i] = key;
-       }
-
-       return 0;
-}
-
-static int
-open_single_tx_pcap(const char *pcap_filename, pcap_dumper_t **dumper)
-{
-       pcap_t *tx_pcap;
-       /*
-        * We need to create a dummy empty pcap_t to use it
-        * with pcap_dump_open(). We create big enough an Ethernet
-        * pcap holder.
-        */
-
-       if ((tx_pcap = pcap_open_dead(DLT_EN10MB, RTE_ETH_PCAP_SNAPSHOT_LEN))
-                       == NULL) {
-               RTE_LOG(ERR, PMD, "Couldn't create dead pcap\n");
-               return -1;
-       }
-
-       /* The dumper is created using the previous pcap_t reference */
-       if ((*dumper = pcap_dump_open(tx_pcap, pcap_filename)) == NULL) {
-               RTE_LOG(ERR, PMD, "Couldn't open %s for writing.\n", pcap_filename);
-               return -1;
+               dumpers->queue[i].dumper = dumper;
+               dumpers->queue[i].name = pcap_filename;
+               dumpers->queue[i].type = key;
        }
 
        return 0;
 }
 
-/*
- * pcap_open_live wrapper function
- */
-static inline int
-open_iface_live(const char *iface, pcap_t **pcap) {
-       *pcap = pcap_open_live(iface, RTE_ETH_PCAP_SNAPLEN,
-                       RTE_ETH_PCAP_PROMISC, RTE_ETH_PCAP_TIMEOUT, errbuf);
-
-       if (*pcap == NULL) {
-               RTE_LOG(ERR, PMD, "Couldn't open %s: %s\n", iface, errbuf);
-               return -1;
-       }
-       return 0;
-}
-
 /*
  * Opens an interface for reading and writing
  */
@@ -723,15 +733,15 @@ static inline int
 open_rx_tx_iface(const char *key, const char *value, void *extra_args)
 {
        const char *iface = value;
-       struct rx_pcaps *pcaps = extra_args;
+       struct pmd_devargs *tx = extra_args;
        pcap_t *pcap = NULL;
 
        if (open_single_iface(iface, &pcap) < 0)
                return -1;
 
-       pcaps->pcaps[0] = pcap;
-       pcaps->names[0] = iface;
-       pcaps->types[0] = key;
+       tx->queue[0].pcap = pcap;
+       tx->queue[0].name = iface;
+       tx->queue[0].type = key;
 
        return 0;
 }
@@ -742,17 +752,17 @@ open_rx_tx_iface(const char *key, const char *value, void *extra_args)
 static inline int
 open_rx_iface(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
+       unsigned int i;
        const char *iface = value;
-       struct rx_pcaps *pcaps = extra_args;
+       struct pmd_devargs *rx = extra_args;
        pcap_t *pcap = NULL;
 
-       for (i = 0; i < pcaps->num_of_rx; i++) {
+       for (i = 0; i < rx->num_of_queue; i++) {
                if (open_single_iface(iface, &pcap) < 0)
                        return -1;
-               pcaps->pcaps[i] = pcap;
-               pcaps->names[i] = iface;
-               pcaps->types[i] = key;
+               rx->queue[i].pcap = pcap;
+               rx->queue[i].name = iface;
+               rx->queue[i].type = key;
        }
 
        return 0;
@@ -764,53 +774,33 @@ open_rx_iface(const char *key, const char *value, void *extra_args)
 static int
 open_tx_iface(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
+       unsigned int i;
        const char *iface = value;
-       struct tx_pcaps *pcaps = extra_args;
+       struct pmd_devargs *tx = extra_args;
        pcap_t *pcap;
 
-       for (i = 0; i < pcaps->num_of_tx; i++) {
+       for (i = 0; i < tx->num_of_queue; i++) {
                if (open_single_iface(iface, &pcap) < 0)
                        return -1;
-               pcaps->pcaps[i] = pcap;
-               pcaps->names[i] = iface;
-               pcaps->types[i] = key;
+               tx->queue[i].pcap = pcap;
+               tx->queue[i].name = iface;
+               tx->queue[i].type = key;
        }
 
        return 0;
 }
 
 static int
-open_single_iface(const char *iface, pcap_t **pcap)
-{
-       if (open_iface_live(iface, pcap) < 0) {
-               RTE_LOG(ERR, PMD, "Couldn't open interface %s\n", iface);
-               return -1;
-       }
-
-       return 0;
-}
-
-static int
-rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
-               const unsigned nb_tx_queues,
-               const unsigned numa_node,
+pmd_init_internals(const char *name, const unsigned int nb_rx_queues,
+               const unsigned int nb_tx_queues,
                struct pmd_internals **internals,
-               struct rte_eth_dev **eth_dev,
-               struct rte_kvargs *kvlist)
+               struct rte_eth_dev **eth_dev)
 {
        struct rte_eth_dev_data *data = NULL;
-       unsigned k_idx;
-       struct rte_kvargs_pair *pair = NULL;
+       unsigned int numa_node = rte_socket_id();
 
-       for (k_idx = 0; k_idx < kvlist->count; k_idx++) {
-               pair = &kvlist->pairs[k_idx];
-               if (strstr(pair->key, ETH_PCAP_IFACE_ARG) != NULL)
-                       break;
-       }
-
-       RTE_LOG(INFO, PMD,
-                       "Creating pcap-backed ethdev on numa socket %u\n", numa_node);
+       RTE_LOG(INFO, PMD, "Creating pcap-backed ethdev on numa socket %u\n",
+               numa_node);
 
        /* now do all data allocation - for eth_dev structure
         * and internal (private) data
@@ -819,33 +809,22 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
        if (data == NULL)
                goto error;
 
-       *internals = rte_zmalloc_socket(name, sizeof(**internals), 0, numa_node);
+       *internals = rte_zmalloc_socket(name, sizeof(**internals), 0,
+                       numa_node);
        if (*internals == NULL)
                goto error;
 
        /* reserve an ethdev entry */
-       *eth_dev = rte_eth_dev_allocate(name, RTE_ETH_DEV_VIRTUAL);
+       *eth_dev = rte_eth_dev_allocate(name);
        if (*eth_dev == NULL)
                goto error;
 
-       /* check length of device name */
-       if ((strlen((*eth_dev)->data->name) + 1) > sizeof(data->name))
-               goto error;
-
        /* now put it all together
         * - store queue data in internals,
         * - store numa_node info in eth_dev
         * - point eth_dev_data to internals
         * - and point eth_dev structure to new eth_dev_data structure
         */
-       /* NOTE: we'll replace the data element, of originally allocated eth_dev
-        * so the rings are local per-process */
-
-       if (pair == NULL)
-               (*internals)->if_index = 0;
-       else
-               (*internals)->if_index = if_nametoindex(pair->value);
-
        data->dev_private = *internals;
        data->port_id = (*eth_dev)->data->port_id;
        snprintf(data->name, sizeof(data->name), "%s", (*eth_dev)->data->name);
@@ -853,9 +832,11 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
        data->nb_tx_queues = (uint16_t)nb_tx_queues;
        data->dev_link = pmd_link;
        data->mac_addrs = &eth_addr;
-       strncpy(data->name,
-               (*eth_dev)->data->name, strlen((*eth_dev)->data->name));
 
+       /*
+        * NOTE: we'll replace the data element, of originally allocated
+        * eth_dev so the rings are local per-process
+        */
        (*eth_dev)->data = data;
        (*eth_dev)->dev_ops = &ops;
        (*eth_dev)->driver = NULL;
@@ -874,13 +855,14 @@ error:
 }
 
 static int
-rte_eth_from_pcaps_common(const char *name, struct rx_pcaps *rx_queues,
-               const unsigned nb_rx_queues, struct tx_pcaps *tx_queues,
-               const unsigned nb_tx_queues, const unsigned numa_node,
-               struct rte_kvargs *kvlist, struct pmd_internals **internals,
-               struct rte_eth_dev **eth_dev)
+eth_from_pcaps_common(const char *name, struct pmd_devargs *rx_queues,
+               const unsigned int nb_rx_queues, struct pmd_devargs *tx_queues,
+               const unsigned int nb_tx_queues, struct rte_kvargs *kvlist,
+               struct pmd_internals **internals, struct rte_eth_dev **eth_dev)
 {
-       unsigned i;
+       struct rte_kvargs_pair *pair = NULL;
+       unsigned int k_idx;
+       unsigned int i;
 
        /* do some parameter checking */
        if (rx_queues == NULL && nb_rx_queues > 0)
@@ -888,105 +870,84 @@ rte_eth_from_pcaps_common(const char *name, struct rx_pcaps *rx_queues,
        if (tx_queues == NULL && nb_tx_queues > 0)
                return -1;
 
-       if (rte_pmd_init_internals(name, nb_rx_queues, nb_tx_queues, numa_node,
-                       internals, eth_dev, kvlist) < 0)
+       if (pmd_init_internals(name, nb_rx_queues, nb_tx_queues, internals,
+                       eth_dev) < 0)
                return -1;
 
        for (i = 0; i < nb_rx_queues; i++) {
-               (*internals)->rx_queue[i].pcap = rx_queues->pcaps[i];
-               snprintf((*internals)->rx_queue[i].name,
-                       sizeof((*internals)->rx_queue[i].name), "%s",
-                       rx_queues->names[i]);
-               snprintf((*internals)->rx_queue[i].type,
-                       sizeof((*internals)->rx_queue[i].type), "%s",
-                       rx_queues->types[i]);
-       }
-       for (i = 0; i < nb_tx_queues; i++) {
-               (*internals)->tx_queue[i].dumper = tx_queues->dumpers[i];
-               snprintf((*internals)->tx_queue[i].name,
-                       sizeof((*internals)->tx_queue[i].name), "%s",
-                       tx_queues->names[i]);
-               snprintf((*internals)->tx_queue[i].type,
-                       sizeof((*internals)->tx_queue[i].type), "%s",
-                       tx_queues->types[i]);
-       }
+               struct pcap_rx_queue *rx = &(*internals)->rx_queue[i];
+               struct devargs_queue *queue = &rx_queues->queue[i];
 
-       return 0;
-}
-
-static int
-rte_eth_from_pcaps_n_dumpers(const char *name,
-               struct rx_pcaps *rx_queues,
-               const unsigned nb_rx_queues,
-               struct tx_pcaps *tx_queues,
-               const unsigned nb_tx_queues,
-               const unsigned numa_node,
-               struct rte_kvargs *kvlist)
-{
-       struct pmd_internals *internals = NULL;
-       struct rte_eth_dev *eth_dev = NULL;
-       int ret;
+               rx->pcap = queue->pcap;
+               snprintf(rx->name, sizeof(rx->name), "%s", queue->name);
+               snprintf(rx->type, sizeof(rx->type), "%s", queue->type);
+       }
 
-       ret = rte_eth_from_pcaps_common(name, rx_queues, nb_rx_queues,
-                       tx_queues, nb_tx_queues, numa_node, kvlist,
-                       &internals, &eth_dev);
+       for (i = 0; i < nb_tx_queues; i++) {
+               struct pcap_tx_queue *tx = &(*internals)->tx_queue[i];
+               struct devargs_queue *queue = &tx_queues->queue[i];
 
-       if (ret < 0)
-               return ret;
+               tx->dumper = queue->dumper;
+               tx->pcap = queue->pcap;
+               snprintf(tx->name, sizeof(tx->name), "%s", queue->name);
+               snprintf(tx->type, sizeof(tx->type), "%s", queue->type);
+       }
 
-       /* using multiple pcaps/interfaces */
-       internals->single_iface = 0;
+       for (k_idx = 0; k_idx < kvlist->count; k_idx++) {
+               pair = &kvlist->pairs[k_idx];
+               if (strstr(pair->key, ETH_PCAP_IFACE_ARG) != NULL)
+                       break;
+       }
 
-       eth_dev->rx_pkt_burst = eth_pcap_rx;
-       eth_dev->tx_pkt_burst = eth_pcap_tx_dumper;
+       if (pair == NULL)
+               (*internals)->if_index = 0;
+       else
+               (*internals)->if_index = if_nametoindex(pair->value);
 
        return 0;
 }
 
 static int
-rte_eth_from_pcaps(const char *name,
-               struct rx_pcaps *rx_queues,
-               const unsigned nb_rx_queues,
-               struct tx_pcaps *tx_queues,
-               const unsigned nb_tx_queues,
-               const unsigned numa_node,
-               struct rte_kvargs *kvlist,
-               int single_iface)
+eth_from_pcaps(const char *name, struct pmd_devargs *rx_queues,
+               const unsigned int nb_rx_queues, struct pmd_devargs *tx_queues,
+               const unsigned int nb_tx_queues, struct rte_kvargs *kvlist,
+               int single_iface, unsigned int using_dumpers)
 {
        struct pmd_internals *internals = NULL;
        struct rte_eth_dev *eth_dev = NULL;
        int ret;
 
-       ret = rte_eth_from_pcaps_common(name, rx_queues, nb_rx_queues,
-                       tx_queues, nb_tx_queues, numa_node, kvlist,
-                       &internals, &eth_dev);
+       ret = eth_from_pcaps_common(name, rx_queues, nb_rx_queues,
+               tx_queues, nb_tx_queues, kvlist, &internals, &eth_dev);
 
        if (ret < 0)
                return ret;
 
-       /* store wether we are using a single interface for rx/tx or not */
+       /* store weather we are using a single interface for rx/tx or not */
        internals->single_iface = single_iface;
 
        eth_dev->rx_pkt_burst = eth_pcap_rx;
-       eth_dev->tx_pkt_burst = eth_pcap_tx;
+
+       if (using_dumpers)
+               eth_dev->tx_pkt_burst = eth_pcap_tx_dumper;
+       else
+               eth_dev->tx_pkt_burst = eth_pcap_tx;
 
        return 0;
 }
 
-
 static int
-rte_pmd_pcap_devinit(const char *name, const char *params)
+pmd_pcap_probe(const char *name, const char *params)
 {
-       unsigned numa_node, using_dumpers = 0;
-       int ret;
+       unsigned int is_rx_pcap = 0, is_tx_pcap = 0;
        struct rte_kvargs *kvlist;
-       struct rx_pcaps pcaps = {0};
-       struct tx_pcaps dumpers = {0};
+       struct pmd_devargs pcaps = {0};
+       struct pmd_devargs dumpers = {0};
+       int single_iface = 0;
+       int ret;
 
        RTE_LOG(INFO, PMD, "Initializing pmd_pcap for %s\n", name);
 
-       numa_node = rte_socket_id();
-
        gettimeofday(&start_time, NULL);
        start_cycles = rte_get_timer_cycles();
        hz = rte_get_timer_hz();
@@ -1003,29 +964,39 @@ rte_pmd_pcap_devinit(const char *name, const char *params)
 
                ret = rte_kvargs_process(kvlist, ETH_PCAP_IFACE_ARG,
                                &open_rx_tx_iface, &pcaps);
+
                if (ret < 0)
                        goto free_kvlist;
-               dumpers.pcaps[0] = pcaps.pcaps[0];
-               dumpers.names[0] = pcaps.names[0];
-               dumpers.types[0] = pcaps.types[0];
-               ret = rte_eth_from_pcaps(name, &pcaps, 1, &dumpers, 1,
-                               numa_node, kvlist, 1);
-               goto free_kvlist;
+
+               dumpers.queue[0] = pcaps.queue[0];
+
+               single_iface = 1;
+               pcaps.num_of_queue = 1;
+               dumpers.num_of_queue = 1;
+
+               goto create_eth;
        }
 
        /*
         * We check whether we want to open a RX stream from a real NIC or a
         * pcap file
         */
-       if ((pcaps.num_of_rx = rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG))) {
+       pcaps.num_of_queue = rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG);
+       if (pcaps.num_of_queue)
+               is_rx_pcap = 1;
+       else
+               pcaps.num_of_queue = rte_kvargs_count(kvlist,
+                               ETH_PCAP_RX_IFACE_ARG);
+
+       if (pcaps.num_of_queue > RTE_PMD_PCAP_MAX_QUEUES)
+               pcaps.num_of_queue = RTE_PMD_PCAP_MAX_QUEUES;
+
+       if (is_rx_pcap)
                ret = rte_kvargs_process(kvlist, ETH_PCAP_RX_PCAP_ARG,
                                &open_rx_pcap, &pcaps);
-       } else {
-               pcaps.num_of_rx = rte_kvargs_count(kvlist,
-                               ETH_PCAP_RX_IFACE_ARG);
+       else
                ret = rte_kvargs_process(kvlist, ETH_PCAP_RX_IFACE_ARG,
                                &open_rx_iface, &pcaps);
-       }
 
        if (ret < 0)
                goto free_kvlist;
@@ -1034,35 +1005,38 @@ rte_pmd_pcap_devinit(const char *name, const char *params)
         * We check whether we want to open a TX stream to a real NIC or a
         * pcap file
         */
-       if ((dumpers.num_of_tx = rte_kvargs_count(kvlist,
-                       ETH_PCAP_TX_PCAP_ARG))) {
+       dumpers.num_of_queue = rte_kvargs_count(kvlist, ETH_PCAP_TX_PCAP_ARG);
+       if (dumpers.num_of_queue)
+               is_tx_pcap = 1;
+       else
+               dumpers.num_of_queue = rte_kvargs_count(kvlist,
+                               ETH_PCAP_TX_IFACE_ARG);
+
+       if (dumpers.num_of_queue > RTE_PMD_PCAP_MAX_QUEUES)
+               dumpers.num_of_queue = RTE_PMD_PCAP_MAX_QUEUES;
+
+       if (is_tx_pcap)
                ret = rte_kvargs_process(kvlist, ETH_PCAP_TX_PCAP_ARG,
                                &open_tx_pcap, &dumpers);
-               using_dumpers = 1;
-       } else {
-               dumpers.num_of_tx = rte_kvargs_count(kvlist,
-                               ETH_PCAP_TX_IFACE_ARG);
+       else
                ret = rte_kvargs_process(kvlist, ETH_PCAP_TX_IFACE_ARG,
                                &open_tx_iface, &dumpers);
-       }
 
        if (ret < 0)
                goto free_kvlist;
 
-       if (using_dumpers)
-               ret = rte_eth_from_pcaps_n_dumpers(name, &pcaps, pcaps.num_of_rx,
-                               &dumpers, dumpers.num_of_tx, numa_node, kvlist);
-       else
-               ret = rte_eth_from_pcaps(name, &pcaps, pcaps.num_of_rx, &dumpers,
-                       dumpers.num_of_tx, numa_node, kvlist, 0);
+create_eth:
+       ret = eth_from_pcaps(name, &pcaps, pcaps.num_of_queue, &dumpers,
+               dumpers.num_of_queue, kvlist, single_iface, is_tx_pcap);
 
 free_kvlist:
        rte_kvargs_free(kvlist);
+
        return ret;
 }
 
 static int
-rte_pmd_pcap_devuninit(const char *name)
+pmd_pcap_remove(const char *name)
 {
        struct rte_eth_dev *eth_dev = NULL;
 
@@ -1085,16 +1059,16 @@ rte_pmd_pcap_devuninit(const char *name)
        return 0;
 }
 
-static struct rte_driver pmd_pcap_drv = {
-       .type = PMD_VDEV,
-       .init = rte_pmd_pcap_devinit,
-       .uninit = rte_pmd_pcap_devuninit,
+static struct rte_vdev_driver pmd_pcap_drv = {
+       .probe = pmd_pcap_probe,
+       .remove = pmd_pcap_remove,
 };
 
-PMD_REGISTER_DRIVER(pmd_pcap_drv, eth_pcap);
-DRIVER_REGISTER_PARAM_STRING(eth_pcap,
-       "rx_pcap=<string> "
-       "tx_pcap=<string> "
-       "rx_iface=<ifc> "
-       "tx_iface=<ifc> "
-       "iface=<ifc>");
+RTE_PMD_REGISTER_VDEV(net_pcap, pmd_pcap_drv);
+RTE_PMD_REGISTER_ALIAS(net_pcap, eth_pcap);
+RTE_PMD_REGISTER_PARAM_STRING(net_pcap,
+       ETH_PCAP_RX_PCAP_ARG "=<string> "
+       ETH_PCAP_TX_PCAP_ARG "=<string> "
+       ETH_PCAP_RX_IFACE_ARG "=<ifc> "
+       ETH_PCAP_TX_IFACE_ARG "=<ifc> "
+       ETH_PCAP_IFACE_ARG "=<ifc>");