Binary API generator improvements
[govpp.git] / binapigen / generate_test.go
index 5a2a07a..46cc5eb 100644 (file)
 package binapigen
 
 import (
+       "git.fd.io/govpp.git/examples/binapi/interfaces"
+       "git.fd.io/govpp.git/examples/binapi/ip_types"
        "os"
+       "strings"
        "testing"
 
        . "github.com/onsi/gomega"
@@ -25,14 +28,13 @@ import (
 
 const testOutputDir = "test_output_directory"
 
-func GenerateFromFile(apiDir, outputDir string, opts Options) error {
-       // parse API files
-       apifiles, err := vppapi.ParseDir(apiDir)
+func GenerateFromFile(file, outputDir string, opts Options) error {
+       apifile, err := vppapi.ParseFile(file)
        if err != nil {
                return err
        }
 
-       g, err := New(opts, apifiles)
+       g, err := New(opts, []*vppapi.File{apifile})
        if err != nil {
                return err
        }
@@ -40,7 +42,7 @@ func GenerateFromFile(apiDir, outputDir string, opts Options) error {
                if !file.Generate {
                        continue
                }
-               GenerateBinapiFile(g, file, outputDir)
+               GenerateBinapi(g, file, outputDir)
                if file.Service != nil {
                        GenerateRPC(g, file, outputDir)
                }
@@ -59,7 +61,7 @@ func TestGenerateFromFile(t *testing.T) {
        // remove directory created during test
        defer os.RemoveAll(testOutputDir)
 
-       err := GenerateFromFile("testdata/acl.api.json", testOutputDir, Options{})
+       err := GenerateFromFile("vppapi/testdata/acl.api.json", testOutputDir, Options{FilesToGenerate: []string{"acl"}})
        Expect(err).ShouldNot(HaveOccurred())
        fileInfo, err := os.Stat(testOutputDir + "/acl/acl.ba.go")
        Expect(err).ShouldNot(HaveOccurred())
@@ -70,17 +72,17 @@ func TestGenerateFromFile(t *testing.T) {
 func TestGenerateFromFileInputError(t *testing.T) {
        RegisterTestingT(t)
 
-       err := GenerateFromFile("testdata/nonexisting.json", testOutputDir, Options{})
+       err := GenerateFromFile("vppapi/testdata/nonexisting.json", testOutputDir, Options{})
        Expect(err).Should(HaveOccurred())
-       Expect(err.Error()).To(ContainSubstring("invalid input file name"))
+       Expect(err.Error()).To(ContainSubstring("unsupported"))
 }
 
 func TestGenerateFromFileReadJsonError(t *testing.T) {
        RegisterTestingT(t)
 
-       err := GenerateFromFile("testdata/input-read-json-error.json", testOutputDir, Options{})
+       err := GenerateFromFile("vppapi/testdata/input-read-json-error.json", testOutputDir, Options{})
        Expect(err).Should(HaveOccurred())
-       Expect(err.Error()).To(ContainSubstring("invalid input file name"))
+       Expect(err.Error()).To(ContainSubstring("unsupported"))
 }
 
 func TestGenerateFromFileGeneratePackageError(t *testing.T) {
@@ -94,7 +96,138 @@ func TestGenerateFromFileGeneratePackageError(t *testing.T) {
                os.RemoveAll(testOutputDir)
        }()
 
-       err := GenerateFromFile("testdata/input-generate-error.json", testOutputDir, Options{})
+       err := GenerateFromFile("vppapi/testdata/input-generate-error.json", testOutputDir, Options{})
+       Expect(err).Should(HaveOccurred())
+}
+
+func TestGeneratedParseAddress(t *testing.T) {
+       RegisterTestingT(t)
+
+       var data = []struct {
+               input  string
+               result ip_types.Address
+       }{
+               {"192.168.0.1", ip_types.Address{
+                       Af: ip_types.ADDRESS_IP4,
+                       Un: ip_types.AddressUnionIP4(ip_types.IP4Address{192, 168, 0, 1}),
+               }},
+               {"aac1:0:ab45::", ip_types.Address{
+                       Af: ip_types.ADDRESS_IP6,
+                       Un: ip_types.AddressUnionIP6(ip_types.IP6Address{170, 193, 0, 0, 171, 69, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}),
+               }},
+       }
+
+       for _, entry := range data {
+               t.Run(entry.input, func(t *testing.T) {
+                       parsedAddress, err := ip_types.ParseAddress(entry.input)
+                       Expect(err).ShouldNot(HaveOccurred())
+                       Expect(parsedAddress).To(Equal(entry.result))
+
+                       originAddress := parsedAddress.ToString()
+                       Expect(originAddress).To(Equal(entry.input))
+               })
+       }
+}
+
+func TestGeneratedParseAddressError(t *testing.T) {
+       RegisterTestingT(t)
+
+       _, err := ip_types.ParseAddress("malformed_ip")
+       Expect(err).Should(HaveOccurred())
+}
+
+func TestGeneratedParsePrefix(t *testing.T) {
+       RegisterTestingT(t)
+
+       var data = []struct {
+               input  string
+               result ip_types.Prefix
+       }{
+               {"192.168.0.1/24", ip_types.Prefix{
+                       Address: ip_types.Address{
+                               Af: ip_types.ADDRESS_IP4,
+                               Un: ip_types.AddressUnionIP4(ip_types.IP4Address{192, 168, 0, 1}),
+                       },
+                       Len: 24,
+               }},
+               {"192.168.0.1", ip_types.Prefix{
+                       Address: ip_types.Address{
+                               Af: ip_types.ADDRESS_IP4,
+                               Un: ip_types.AddressUnionIP4(ip_types.IP4Address{192, 168, 0, 1}),
+                       },
+                       Len: 32,
+               }},
+               {"aac1:0:ab45::/96", ip_types.Prefix{
+                       Address: ip_types.Address{
+                               Af: ip_types.ADDRESS_IP6,
+                               Un: ip_types.AddressUnionIP6(ip_types.IP6Address{170, 193, 0, 0, 171, 69, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}),
+                       },
+                       Len: 96,
+               }},
+               {"aac1:0:ab45::", ip_types.Prefix{
+                       Address: ip_types.Address{
+                               Af: ip_types.ADDRESS_IP6,
+                               Un: ip_types.AddressUnionIP6(ip_types.IP6Address{170, 193, 0, 0, 171, 69, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}),
+                       },
+                       Len: 128,
+               }},
+       }
+
+       for _, entry := range data {
+               t.Run(entry.input, func(t *testing.T) {
+                       parsedAddress, err := ip_types.ParsePrefix(entry.input)
+                       Expect(err).ShouldNot(HaveOccurred())
+                       Expect(parsedAddress).To(Equal(entry.result))
+
+                       // Parsed IP without prefix receives a default one
+                       // so the input data must be adjusted
+                       if entry.result.Address.Af == ip_types.ADDRESS_IP4 && !strings.Contains(entry.input, "/") {
+                               entry.input = entry.input + "/32"
+                       }
+                       if entry.result.Address.Af == ip_types.ADDRESS_IP6 && !strings.Contains(entry.input, "/") {
+                               entry.input = entry.input + "/128"
+                       }
+                       originAddress := parsedAddress.ToString()
+                       Expect(originAddress).To(Equal(entry.input))
+               })
+       }
+}
+
+func TestGeneratedParsePrefixError(t *testing.T) {
+       RegisterTestingT(t)
+
+       _, err := ip_types.ParsePrefix("malformed_ip")
+       Expect(err).Should(HaveOccurred())
+}
+
+func TestGeneratedParseMAC(t *testing.T) {
+       RegisterTestingT(t)
+
+       var data = []struct {
+               input  string
+               result interfaces.MacAddress
+       }{
+               {"b7:b9:bb:a1:5c:af", interfaces.MacAddress{183, 185, 187, 161, 92, 175}},
+               {"47:4b:c7:3e:06:c8", interfaces.MacAddress{71, 75, 199, 62, 6, 200}},
+               {"a7:cc:9f:10:18:e3", interfaces.MacAddress{167, 204, 159, 16, 24, 227}},
+       }
+
+       for _, entry := range data {
+               t.Run(entry.input, func(t *testing.T) {
+                       parsedMac, err := interfaces.ParseMAC(entry.input)
+                       Expect(err).ShouldNot(HaveOccurred())
+                       Expect(parsedMac).To(Equal(entry.result))
+
+                       originAddress := parsedMac.ToString()
+                       Expect(originAddress).To(Equal(entry.input))
+               })
+       }
+}
+
+func TestGeneratedParseMACError(t *testing.T) {
+       RegisterTestingT(t)
+
+       _, err := interfaces.ParseMAC("malformed_mac")
        Expect(err).Should(HaveOccurred())
 }
 
@@ -147,7 +280,7 @@ func TestGetContextInterfaceJson(t *testing.T) {
        // prepare writer
        writer := bufio.NewWriter(outFile)
        Expect(writer.Buffered()).To(BeZero())
-       err = generatePackage(testCtx, writer)
+       err = generateFileBinapi(testCtx, writer)
        Expect(err).ShouldNot(HaveOccurred())
 }
 
@@ -313,7 +446,7 @@ func TestGeneratePackageHeader(t *testing.T) {
        // prepare writer
        writer := bufio.NewWriter(outFile)
        Expect(writer.Buffered()).To(BeZero())
-       generateHeader(testCtx, writer, inFile)
+       generatePackageHeader(testCtx, writer, inFile)
        Expect(writer.Buffered()).ToNot(BeZero())
 }