ikev2: add support for custom ipsec-over-udp port
[vpp.git] / src / vnet / ipsec / ipsec_cli.c
index 7ab85d4..7779e79 100644 (file)
 #include <vnet/api_errno.h>
 #include <vnet/ip/ip.h>
 #include <vnet/interface.h>
+#include <vnet/fib/fib.h>
+#include <vnet/ipip/ipip.h>
 
 #include <vnet/ipsec/ipsec.h>
+#include <vnet/ipsec/ipsec_tun.h>
 
 static clib_error_t *
 set_interface_spd_command_fn (vlib_main_t * vm,
@@ -32,6 +35,7 @@ set_interface_spd_command_fn (vlib_main_t * vm,
   u32 sw_if_index = (u32) ~ 0;
   u32 spd_id;
   int is_add = 1;
+  clib_error_t *error = NULL;
 
   if (!unformat_user (input, unformat_line_input, line_input))
     return 0;
@@ -43,14 +47,18 @@ set_interface_spd_command_fn (vlib_main_t * vm,
   else if (unformat (line_input, "del"))
     is_add = 0;
   else
-    return clib_error_return (0, "parse error: '%U'",
-                             format_unformat_error, line_input);
-
-  unformat_free (line_input);
+    {
+      error = clib_error_return (0, "parse error: '%U'",
+                                format_unformat_error, line_input);
+      goto done;
+    }
 
   ipsec_set_interface_spd (vm, sw_if_index, spd_id, is_add);
 
-  return 0;
+done:
+  unformat_free (line_input);
+
+  return error;
 }
 
 /* *INDENT-OFF* */
@@ -68,113 +76,91 @@ ipsec_sa_add_del_command_fn (vlib_main_t * vm,
                             vlib_cli_command_t * cmd)
 {
   unformat_input_t _line_input, *line_input = &_line_input;
-  ipsec_sa_t sa;
-  int is_add = ~0;
-  u8 *ck = 0, *ik = 0;
-
-  memset (&sa, 0, sizeof (sa));
+  ip46_address_t tun_src = { }, tun_dst =
+  {
+  };
+  ipsec_crypto_alg_t crypto_alg;
+  ipsec_integ_alg_t integ_alg;
+  ipsec_protocol_t proto;
+  ipsec_sa_flags_t flags;
+  clib_error_t *error;
+  ipsec_key_t ck = { 0 };
+  ipsec_key_t ik = { 0 };
+  u32 id, spi, salt;
+  int is_add, rv;
+
+  salt = 0;
+  error = NULL;
+  is_add = 0;
+  flags = IPSEC_SA_FLAG_NONE;
+  proto = IPSEC_PROTOCOL_ESP;
+  integ_alg = IPSEC_INTEG_ALG_NONE;
+  crypto_alg = IPSEC_CRYPTO_ALG_NONE;
 
   if (!unformat_user (input, unformat_line_input, line_input))
     return 0;
 
   while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT)
     {
-      if (unformat (line_input, "add %u", &sa.id))
+      if (unformat (line_input, "add %u", &id))
        is_add = 1;
-      else if (unformat (line_input, "del %u", &sa.id))
+      else if (unformat (line_input, "del %u", &id))
        is_add = 0;
-      else if (unformat (line_input, "spi %u", &sa.spi))
+      else if (unformat (line_input, "spi %u", &spi))
+       ;
+      else if (unformat (line_input, "salt 0x%x", &salt))
        ;
       else if (unformat (line_input, "esp"))
-       sa.protocol = IPSEC_PROTOCOL_ESP;
+       proto = IPSEC_PROTOCOL_ESP;
       else if (unformat (line_input, "ah"))
-       //sa.protocol = IPSEC_PROTOCOL_AH;
-       return clib_error_return (0, "unsupported security protocol 'AH'");
-      else
-       if (unformat (line_input, "crypto-key %U", unformat_hex_string, &ck))
-       sa.crypto_key_len = vec_len (ck);
-      else
-       if (unformat
-           (line_input, "crypto-alg %U", unformat_ipsec_crypto_alg,
-            &sa.crypto_alg))
-       {
-         if (sa.crypto_alg < IPSEC_CRYPTO_ALG_AES_CBC_128 ||
-             sa.crypto_alg >= IPSEC_CRYPTO_N_ALG)
-           return clib_error_return (0, "unsupported crypto-alg: '%U'",
-                                     format_ipsec_crypto_alg, sa.crypto_alg);
-       }
-      else
-       if (unformat (line_input, "integ-key %U", unformat_hex_string, &ik))
-       sa.integ_key_len = vec_len (ik);
-      else if (unformat (line_input, "integ-alg %U", unformat_ipsec_integ_alg,
-                        &sa.integ_alg))
-       {
-#if DPDK_CRYPTO==1
-         if (sa.integ_alg < IPSEC_INTEG_ALG_NONE ||
-#else
-         if (sa.integ_alg < IPSEC_INTEG_ALG_SHA1_96 ||
-#endif
-             sa.integ_alg >= IPSEC_INTEG_N_ALG)
-           return clib_error_return (0, "unsupported integ-alg: '%U'",
-                                     format_ipsec_integ_alg, sa.integ_alg);
-       }
-      else if (unformat (line_input, "tunnel-src %U",
-                        unformat_ip4_address, &sa.tunnel_src_addr.ip4))
-       sa.is_tunnel = 1;
-      else if (unformat (line_input, "tunnel-dst %U",
-                        unformat_ip4_address, &sa.tunnel_dst_addr.ip4))
-       sa.is_tunnel = 1;
+       proto = IPSEC_PROTOCOL_AH;
+      else if (unformat (line_input, "crypto-key %U",
+                        unformat_ipsec_key, &ck))
+       ;
+      else if (unformat (line_input, "crypto-alg %U",
+                        unformat_ipsec_crypto_alg, &crypto_alg))
+       ;
+      else if (unformat (line_input, "integ-key %U", unformat_ipsec_key, &ik))
+       ;
+      else if (unformat (line_input, "integ-alg %U",
+                        unformat_ipsec_integ_alg, &integ_alg))
+       ;
       else if (unformat (line_input, "tunnel-src %U",
-                        unformat_ip6_address, &sa.tunnel_src_addr.ip6))
+                        unformat_ip46_address, &tun_src, IP46_TYPE_ANY))
        {
-         sa.is_tunnel = 1;
-         sa.is_tunnel_ip6 = 1;
+         flags |= IPSEC_SA_FLAG_IS_TUNNEL;
+         if (!ip46_address_is_ip4 (&tun_src))
+           flags |= IPSEC_SA_FLAG_IS_TUNNEL_V6;
        }
       else if (unformat (line_input, "tunnel-dst %U",
-                        unformat_ip6_address, &sa.tunnel_dst_addr.ip6))
+                        unformat_ip46_address, &tun_dst, IP46_TYPE_ANY))
+       ;
+      else if (unformat (line_input, "udp-encap"))
+       flags |= IPSEC_SA_FLAG_UDP_ENCAP;
+      else
        {
-         sa.is_tunnel = 1;
-         sa.is_tunnel_ip6 = 1;
+         error = clib_error_return (0, "parse error: '%U'",
+                                    format_unformat_error, line_input);
+         goto done;
        }
-      else
-       return clib_error_return (0, "parse error: '%U'",
-                                 format_unformat_error, line_input);
-    }
-
-#if DPDK_CRYPTO==1
-  /*Special cases, aes-gcm-128 encryption */
-  if (sa.crypto_alg == IPSEC_CRYPTO_ALG_AES_GCM_128)
-    {
-      if (sa.integ_alg != IPSEC_INTEG_ALG_NONE
-         && sa.integ_alg != IPSEC_INTEG_ALG_AES_GCM_128)
-       return clib_error_return (0,
-                                 "unsupported: aes-gcm-128 crypto-alg needs none as integ-alg");
-      else                     /*set integ-alg internally to aes-gcm-128 */
-       sa.integ_alg = IPSEC_INTEG_ALG_AES_GCM_128;
     }
-  else if (sa.integ_alg == IPSEC_INTEG_ALG_AES_GCM_128)
-    return clib_error_return (0, "unsupported integ-alg: aes-gcm-128");
-  else if (sa.integ_alg == IPSEC_INTEG_ALG_NONE)
-    return clib_error_return (0, "unsupported integ-alg: none");
-#endif
 
-  unformat_free (line_input);
-
-  if (sa.crypto_key_len > sizeof (sa.crypto_key))
-    sa.crypto_key_len = sizeof (sa.crypto_key);
-
-  if (sa.integ_key_len > sizeof (sa.integ_key))
-    sa.integ_key_len = sizeof (sa.integ_key);
-
-  if (ck)
-    strncpy ((char *) sa.crypto_key, (char *) ck, sa.crypto_key_len);
+  if (is_add)
+    rv = ipsec_sa_add_and_lock (id, spi, proto, crypto_alg,
+                               &ck, integ_alg, &ik, flags,
+                               0, clib_host_to_net_u32 (salt),
+                               &tun_src, &tun_dst, NULL,
+                               IPSEC_UDP_PORT_NONE);
+  else
+    rv = ipsec_sa_unlock_id (id);
 
-  if (ik)
-    strncpy ((char *) sa.integ_key, (char *) ik, sa.integ_key_len);
+  if (rv)
+    error = clib_error_return (0, "failed");
 
-  ipsec_add_del_sa (vm, &sa, is_add);
+done:
+  unformat_free (line_input);
 
-  return 0;
+  return error;
 }
 
 /* *INDENT-OFF* */
@@ -194,6 +180,7 @@ ipsec_spd_add_del_command_fn (vlib_main_t * vm,
   unformat_input_t _line_input, *line_input = &_line_input;
   u32 spd_id = ~0;
   int is_add = ~0;
+  clib_error_t *error = NULL;
 
   if (!unformat_user (input, unformat_line_input, line_input))
     return 0;
@@ -207,18 +194,25 @@ ipsec_spd_add_del_command_fn (vlib_main_t * vm,
       else if (unformat (line_input, "%u", &spd_id))
        ;
       else
-       return clib_error_return (0, "parse error: '%U'",
-                                 format_unformat_error, line_input);
+       {
+         error = clib_error_return (0, "parse error: '%U'",
+                                    format_unformat_error, line_input);
+         goto done;
+       }
     }
 
-  unformat_free (line_input);
-
   if (spd_id == ~0)
-    return clib_error_return (0, "please specify SPD ID");
+    {
+      error = clib_error_return (0, "please specify SPD ID");
+      goto done;
+    }
 
   ipsec_add_del_spd (vm, spd_id, is_add);
 
-  return 0;
+done:
+  unformat_free (line_input);
+
+  return error;
 }
 
 /* *INDENT-OFF* */
@@ -238,15 +232,14 @@ ipsec_policy_add_del_command_fn (vlib_main_t * vm,
 {
   unformat_input_t _line_input, *line_input = &_line_input;
   ipsec_policy_t p;
-  int is_add = 0;
-  int is_ip_any = 1;
-  u32 tmp, tmp2;
+  int rv, is_add = 0;
+  u32 tmp, tmp2, stat_index;
+  clib_error_t *error = NULL;
+  u32 is_outbound;
 
-  memset (&p, 0, sizeof (p));
+  clib_memset (&p, 0, sizeof (p));
   p.lport.stop = p.rport.stop = ~0;
-  p.laddr.stop.ip4.as_u32 = p.raddr.stop.ip4.as_u32 = (u32) ~ 0;
-  p.laddr.stop.ip6.as_u64[0] = p.laddr.stop.ip6.as_u64[1] = (u64) ~ 0;
-  p.raddr.stop.ip6.as_u64[0] = p.raddr.stop.ip6.as_u64[1] = (u64) ~ 0;
+  is_outbound = 0;
 
   if (!unformat_user (input, unformat_line_input, line_input))
     return 0;
@@ -260,9 +253,9 @@ ipsec_policy_add_del_command_fn (vlib_main_t * vm,
       else if (unformat (line_input, "spd %u", &p.id))
        ;
       else if (unformat (line_input, "inbound"))
-       p.is_outbound = 0;
+       is_outbound = 0;
       else if (unformat (line_input, "outbound"))
-       p.is_outbound = 1;
+       is_outbound = 1;
       else if (unformat (line_input, "priority %d", &p.priority))
        ;
       else if (unformat (line_input, "protocol %u", &tmp))
@@ -273,31 +266,32 @@ ipsec_policy_add_del_command_fn (vlib_main_t * vm,
             &p.policy))
        {
          if (p.policy == IPSEC_POLICY_ACTION_RESOLVE)
-           return clib_error_return (0, "unsupported action: 'resolve'");
+           {
+             error = clib_error_return (0, "unsupported action: 'resolve'");
+             goto done;
+           }
        }
       else if (unformat (line_input, "sa %u", &p.sa_id))
        ;
       else if (unformat (line_input, "local-ip-range %U - %U",
                         unformat_ip4_address, &p.laddr.start.ip4,
                         unformat_ip4_address, &p.laddr.stop.ip4))
-       is_ip_any = 0;
+       ;
       else if (unformat (line_input, "remote-ip-range %U - %U",
                         unformat_ip4_address, &p.raddr.start.ip4,
                         unformat_ip4_address, &p.raddr.stop.ip4))
-       is_ip_any = 0;
+       ;
       else if (unformat (line_input, "local-ip-range %U - %U",
                         unformat_ip6_address, &p.laddr.start.ip6,
                         unformat_ip6_address, &p.laddr.stop.ip6))
        {
          p.is_ipv6 = 1;
-         is_ip_any = 0;
        }
       else if (unformat (line_input, "remote-ip-range %U - %U",
                         unformat_ip6_address, &p.raddr.start.ip6,
                         unformat_ip6_address, &p.raddr.stop.ip6))
        {
          p.is_ipv6 = 1;
-         is_ip_any = 0;
        }
       else if (unformat (line_input, "local-port-range %u - %u", &tmp, &tmp2))
        {
@@ -311,19 +305,36 @@ ipsec_policy_add_del_command_fn (vlib_main_t * vm,
          p.rport.stop = tmp2;
        }
       else
-       return clib_error_return (0, "parse error: '%U'",
-                                 format_unformat_error, line_input);
+       {
+         error = clib_error_return (0, "parse error: '%U'",
+                                    format_unformat_error, line_input);
+         goto done;
+       }
     }
 
-  unformat_free (line_input);
+  rv = ipsec_policy_mk_type (is_outbound, p.is_ipv6, p.policy, &p.type);
 
-  ipsec_add_del_policy (vm, &p, is_add);
-  if (is_ip_any)
+  if (rv)
     {
-      p.is_ipv6 = 1;
-      ipsec_add_del_policy (vm, &p, is_add);
+      error = clib_error_return (0, "unsupported policy type for:",
+                                " outboud:%s %s action:%U",
+                                (is_outbound ? "yes" : "no"),
+                                (p.is_ipv6 ? "IPv4" : "IPv6"),
+                                format_ipsec_policy_action, p.policy);
+      goto done;
     }
-  return 0;
+
+  rv = ipsec_add_del_policy (vm, &p, is_add, &stat_index);
+
+  if (!rv)
+    vlib_cli_output (vm, "policy-index:%d", stat_index);
+  else
+    vlib_cli_output (vm, "error:%d", rv);
+
+done:
+  unformat_free (line_input);
+
+  return error;
 }
 
 /* *INDENT-OFF* */
@@ -335,314 +346,361 @@ VLIB_CLI_COMMAND (ipsec_policy_add_del_command, static) = {
 };
 /* *INDENT-ON* */
 
+static void
+ipsec_sa_show_all (vlib_main_t * vm, ipsec_main_t * im, u8 detail)
+{
+  u32 sai;
+
+  /* *INDENT-OFF* */
+  pool_foreach_index (sai, im->sad, ({
+    vlib_cli_output(vm, "%U", format_ipsec_sa, sai,
+                    (detail ? IPSEC_FORMAT_DETAIL : IPSEC_FORMAT_BRIEF));
+  }));
+  /* *INDENT-ON* */
+}
+
+static void
+ipsec_spd_show_all (vlib_main_t * vm, ipsec_main_t * im)
+{
+  u32 spdi;
+
+  /* *INDENT-OFF* */
+  pool_foreach_index (spdi, im->spds, ({
+    vlib_cli_output(vm, "%U", format_ipsec_spd, spdi);
+  }));
+  /* *INDENT-ON* */
+}
+
+static void
+ipsec_spd_bindings_show_all (vlib_main_t * vm, ipsec_main_t * im)
+{
+  u32 spd_id, sw_if_index;
+  ipsec_spd_t *spd;
+
+  vlib_cli_output (vm, "SPD Bindings:");
+
+  /* *INDENT-OFF* */
+  hash_foreach(sw_if_index, spd_id, im->spd_index_by_sw_if_index, ({
+    spd = pool_elt_at_index (im->spds, spd_id);
+    vlib_cli_output (vm, "  %d -> %U", spd->id,
+                     format_vnet_sw_if_index_name, im->vnet_main,
+                     sw_if_index);
+  }));
+  /* *INDENT-ON* */
+}
+
+static walk_rc_t
+ipsec_tun_protect_show_one (index_t itpi, void *ctx)
+{
+  vlib_cli_output (ctx, "%U", format_ipsec_tun_protect_index, itpi);
+
+  return (WALK_CONTINUE);
+}
+
+static void
+ipsec_tunnel_show_all (vlib_main_t * vm)
+{
+  ipsec_tun_protect_walk (ipsec_tun_protect_show_one, vm);
+}
+
 static clib_error_t *
-set_ipsec_sa_key_command_fn (vlib_main_t * vm,
-                            unformat_input_t * input,
-                            vlib_cli_command_t * cmd)
+show_ipsec_command_fn (vlib_main_t * vm,
+                      unformat_input_t * input, vlib_cli_command_t * cmd)
 {
-  unformat_input_t _line_input, *line_input = &_line_input;
-  ipsec_sa_t sa;
-  u8 *ck = 0, *ik = 0;
+  ipsec_main_t *im = &ipsec_main;
 
-  memset (&sa, 0, sizeof (sa));
+  ipsec_sa_show_all (vm, im, 0);
+  ipsec_spd_show_all (vm, im);
+  ipsec_spd_bindings_show_all (vm, im);
+  ipsec_tun_protect_walk (ipsec_tun_protect_show_one, vm);
 
-  if (!unformat_user (input, unformat_line_input, line_input))
-    return 0;
+  return 0;
+}
 
-  while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT)
+/* *INDENT-OFF* */
+VLIB_CLI_COMMAND (show_ipsec_command, static) = {
+    .path = "show ipsec all",
+    .short_help = "show ipsec all",
+    .function = show_ipsec_command_fn,
+};
+/* *INDENT-ON* */
+
+static clib_error_t *
+show_ipsec_sa_command_fn (vlib_main_t * vm,
+                         unformat_input_t * input, vlib_cli_command_t * cmd)
+{
+  ipsec_main_t *im = &ipsec_main;
+  u32 sai = ~0;
+  u8 detail = 0;
+
+  while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
     {
-      if (unformat (line_input, "%u", &sa.id))
+      if (unformat (input, "%u", &sai))
        ;
+      if (unformat (input, "detail"))
+       detail = 1;
       else
-       if (unformat (line_input, "crypto-key %U", unformat_hex_string, &ck))
-       sa.crypto_key_len = vec_len (ck);
+       break;
+    }
+
+  if (~0 == sai)
+    ipsec_sa_show_all (vm, im, detail);
+  else
+    vlib_cli_output (vm, "%U", format_ipsec_sa, sai,
+                    IPSEC_FORMAT_DETAIL | IPSEC_FORMAT_INSECURE);
+
+  return 0;
+}
+
+static clib_error_t *
+clear_ipsec_sa_command_fn (vlib_main_t * vm,
+                          unformat_input_t * input, vlib_cli_command_t * cmd)
+{
+  ipsec_main_t *im = &ipsec_main;
+  u32 sai = ~0;
+
+  while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
+    {
+      if (unformat (input, "%u", &sai))
+       ;
       else
-       if (unformat (line_input, "integ-key %U", unformat_hex_string, &ik))
-       sa.integ_key_len = vec_len (ik);
+       break;
+    }
+
+  if (~0 == sai)
+    {
+      /* *INDENT-OFF* */
+      pool_foreach_index (sai, im->sad, ({
+        ipsec_sa_clear(sai);
+      }));
+      /* *INDENT-ON* */
+    }
+  else
+    {
+      if (pool_is_free_index (im->sad, sai))
+       return clib_error_return (0, "unknown SA index: %d", sai);
       else
-       return clib_error_return (0, "parse error: '%U'",
-                                 format_unformat_error, line_input);
+       ipsec_sa_clear (sai);
     }
 
-  unformat_free (line_input);
+  return 0;
+}
 
-  if (sa.crypto_key_len > sizeof (sa.crypto_key))
-    sa.crypto_key_len = sizeof (sa.crypto_key);
+/* *INDENT-OFF* */
+VLIB_CLI_COMMAND (show_ipsec_sa_command, static) = {
+    .path = "show ipsec sa",
+    .short_help = "show ipsec sa [index]",
+    .function = show_ipsec_sa_command_fn,
+};
 
-  if (sa.integ_key_len > sizeof (sa.integ_key))
-    sa.integ_key_len = sizeof (sa.integ_key);
+VLIB_CLI_COMMAND (clear_ipsec_sa_command, static) = {
+    .path = "clear ipsec sa",
+    .short_help = "clear ipsec sa [index]",
+    .function = clear_ipsec_sa_command_fn,
+};
+/* *INDENT-ON* */
 
-  if (ck)
-    strncpy ((char *) sa.crypto_key, (char *) ck, sa.crypto_key_len);
+static clib_error_t *
+show_ipsec_spd_command_fn (vlib_main_t * vm,
+                          unformat_input_t * input, vlib_cli_command_t * cmd)
+{
+  ipsec_main_t *im = &ipsec_main;
+  u8 show_bindings = 0;
+  u32 spdi = ~0;
 
-  if (ik)
-    strncpy ((char *) sa.integ_key, (char *) ik, sa.integ_key_len);
+  while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
+    {
+      if (unformat (input, "%u", &spdi))
+       ;
+      else if (unformat (input, "bindings"))
+       show_bindings = 1;
+      else
+       break;
+    }
 
-  ipsec_set_sa_key (vm, &sa);
+  if (show_bindings)
+    ipsec_spd_bindings_show_all (vm, im);
+  else if (~0 != spdi)
+    vlib_cli_output (vm, "%U", format_ipsec_spd, spdi);
+  else
+    ipsec_spd_show_all (vm, im);
 
   return 0;
 }
 
 /* *INDENT-OFF* */
-VLIB_CLI_COMMAND (set_ipsec_sa_key_command, static) = {
-    .path = "set ipsec sa",
-    .short_help =
-    "set ipsec sa <id> crypto-key <key> integ-key <key>",
-    .function = set_ipsec_sa_key_command_fn,
+VLIB_CLI_COMMAND (show_ipsec_spd_command, static) = {
+    .path = "show ipsec spd",
+    .short_help = "show ipsec spd [index]",
+    .function = show_ipsec_spd_command_fn,
 };
 /* *INDENT-ON* */
 
 static clib_error_t *
-show_ipsec_command_fn (vlib_main_t * vm,
-                      unformat_input_t * input, vlib_cli_command_t * cmd)
+show_ipsec_tunnel_command_fn (vlib_main_t * vm,
+                             unformat_input_t * input,
+                             vlib_cli_command_t * cmd)
+{
+  ipsec_tunnel_show_all (vm);
+
+  return 0;
+}
+
+/* *INDENT-OFF* */
+VLIB_CLI_COMMAND (show_ipsec_tunnel_command, static) = {
+    .path = "show ipsec tunnel",
+    .short_help = "show ipsec tunnel",
+    .function = show_ipsec_tunnel_command_fn,
+};
+/* *INDENT-ON* */
+
+static clib_error_t *
+ipsec_show_backends_command_fn (vlib_main_t * vm,
+                               unformat_input_t * input,
+                               vlib_cli_command_t * cmd)
 {
-  ipsec_spd_t *spd;
-  ipsec_sa_t *sa;
-  ipsec_policy_t *p;
   ipsec_main_t *im = &ipsec_main;
-  u32 *i;
-  ipsec_tunnel_if_t *t;
-  vnet_hw_interface_t *hi;
+  u32 verbose = 0;
 
+  (void) unformat (input, "verbose %u", &verbose);
+
+  vlib_cli_output (vm, "IPsec AH backends available:");
+  u8 *s = format (NULL, "%=25s %=25s %=10s\n", "Name", "Index", "Active");
+  ipsec_ah_backend_t *ab;
   /* *INDENT-OFF* */
-  pool_foreach (sa, im->sad, ({
-    if (sa->id) {
-      vlib_cli_output(vm, "sa %u spi %u mode %s protocol %s", sa->id, sa->spi,
-                      sa->is_tunnel ? "tunnel" : "transport",
-                      sa->protocol ? "esp" : "ah");
-      if (sa->protocol == IPSEC_PROTOCOL_ESP) {
-        vlib_cli_output(vm, "  crypto alg %U%s%U integrity alg %U%s%U",
-                        format_ipsec_crypto_alg, sa->crypto_alg,
-                        sa->crypto_alg ? " key " : "",
-                        format_hex_bytes, sa->crypto_key, sa->crypto_key_len,
-                        format_ipsec_integ_alg, sa->integ_alg,
-                        sa->integ_alg ? " key " : "",
-                        format_hex_bytes, sa->integ_key, sa->integ_key_len);
-      }
-      if (sa->is_tunnel && sa->is_tunnel_ip6) {
-        vlib_cli_output(vm, "  tunnel src %U dst %U",
-                        format_ip6_address, &sa->tunnel_src_addr.ip6,
-                        format_ip6_address, &sa->tunnel_dst_addr.ip6);
-      } else if (sa->is_tunnel) {
-        vlib_cli_output(vm, "  tunnel src %U dst %U",
-                        format_ip4_address, &sa->tunnel_src_addr.ip4,
-                        format_ip4_address, &sa->tunnel_dst_addr.ip4);
-      }
+  pool_foreach (ab, im->ah_backends, {
+    s = format (s, "%=25s %=25u %=10s\n", ab->name, ab - im->ah_backends,
+                ab - im->ah_backends == im->ah_current_backend ? "yes" : "no");
+    if (verbose) {
+        vlib_node_t *n;
+        n = vlib_get_node (vm, ab->ah4_encrypt_node_index);
+        s = format (s, "     enc4 %s (next %d)\n", n->name, ab->ah4_encrypt_next_index);
+        n = vlib_get_node (vm, ab->ah4_decrypt_node_index);
+        s = format (s, "     dec4 %s (next %d)\n", n->name, ab->ah4_decrypt_next_index);
+        n = vlib_get_node (vm, ab->ah6_encrypt_node_index);
+        s = format (s, "     enc6 %s (next %d)\n", n->name, ab->ah6_encrypt_next_index);
+        n = vlib_get_node (vm, ab->ah6_decrypt_node_index);
+        s = format (s, "     dec6 %s (next %d)\n", n->name, ab->ah6_decrypt_next_index);
     }
-  }));
+  });
   /* *INDENT-ON* */
-
+  vlib_cli_output (vm, "%v", s);
+  _vec_len (s) = 0;
+  vlib_cli_output (vm, "IPsec ESP backends available:");
+  s = format (s, "%=25s %=25s %=10s\n", "Name", "Index", "Active");
+  ipsec_esp_backend_t *eb;
   /* *INDENT-OFF* */
-  pool_foreach (spd, im->spds, ({
-    vlib_cli_output(vm, "spd %u", spd->id);
-
-    vlib_cli_output(vm, " outbound policies");
-    vec_foreach(i, spd->ipv4_outbound_policies)
-      {
-        p = pool_elt_at_index(spd->policies, *i);
-        vlib_cli_output(vm, "  priority %d action %U protocol %s%s",
-                        p->priority,
-                        format_ipsec_policy_action, p->policy,
-                        p->protocol ?
-                          format(0, "%U", format_ip_protocol, p->protocol) :
-                          (u8 *) "any",
-                        p->policy == IPSEC_POLICY_ACTION_PROTECT ?
-                          format(0, " sa %u", p->sa_id) :
-                          (u8 *) "");
-        vlib_cli_output(vm, "   local addr range %U - %U port range %u - %u",
-                        format_ip4_address, &p->laddr.start.ip4,
-                        format_ip4_address, &p->laddr.stop.ip4,
-                        p->lport.start, p->lport.stop);
-        vlib_cli_output(vm, "   remte addr range %U - %U port range %u - %u",
-                        format_ip4_address, &p->raddr.start.ip4,
-                        format_ip4_address, &p->raddr.stop.ip4,
-                        p->rport.start, p->rport.stop);
-        vlib_cli_output(vm, "   packets %u bytes %u", p->counter.packets,
-                        p->counter.bytes);
-      };
-    vec_foreach(i, spd->ipv6_outbound_policies)
-      {
-        p = pool_elt_at_index(spd->policies, *i);
-        vlib_cli_output(vm, "  priority %d action %U protocol %s%s",
-                        p->priority,
-                        format_ipsec_policy_action, p->policy,
-                        p->protocol ?
-                          format(0, "%U", format_ip_protocol, p->protocol) :
-                          (u8 *) "any",
-                        p->policy == IPSEC_POLICY_ACTION_PROTECT ?
-                          format(0, " sa %u", p->sa_id) :
-                          (u8 *) "");
-        vlib_cli_output(vm, "   local addr range %U - %U port range %u - %u",
-                        format_ip6_address, &p->laddr.start.ip6,
-                        format_ip6_address, &p->laddr.stop.ip6,
-                        p->lport.start, p->lport.stop);
-        vlib_cli_output(vm, "   remote addr range %U - %U port range %u - %u",
-                        format_ip6_address, &p->raddr.start.ip6,
-                        format_ip6_address, &p->raddr.stop.ip6,
-                        p->rport.start, p->rport.stop);
-        vlib_cli_output(vm, "   packets %u bytes %u", p->counter.packets,
-                        p->counter.bytes);
-      };
-    vlib_cli_output(vm, " inbound policies");
-    vec_foreach(i, spd->ipv4_inbound_protect_policy_indices)
-      {
-        p = pool_elt_at_index(spd->policies, *i);
-        vlib_cli_output(vm, "  priority %d action %U protocol %s%s",
-                        p->priority,
-                        format_ipsec_policy_action, p->policy,
-                        p->protocol ?
-                          format(0, "%U", format_ip_protocol, p->protocol) :
-                          (u8 *) "any",
-                        p->policy == IPSEC_POLICY_ACTION_PROTECT ?
-                          format(0, " sa %u", p->sa_id) :
-                          (u8 *) "");
-        vlib_cli_output(vm, "   local addr range %U - %U port range %u - %u",
-                        format_ip4_address, &p->laddr.start.ip4,
-                        format_ip4_address, &p->laddr.stop.ip4,
-                        p->lport.start, p->lport.stop);
-        vlib_cli_output(vm, "   remte addr range %U - %U port range %u - %u",
-                        format_ip4_address, &p->raddr.start.ip4,
-                        format_ip4_address, &p->raddr.stop.ip4,
-                        p->rport.start, p->rport.stop);
-        vlib_cli_output(vm, "   packets %u bytes %u", p->counter.packets,
-                        p->counter.bytes);
-      };
-    vec_foreach(i, spd->ipv4_inbound_policy_discard_and_bypass_indices)
-      {
-        p = pool_elt_at_index(spd->policies, *i);
-        vlib_cli_output(vm, "  priority %d action %U protocol %s%s",
-                        p->priority,
-                        format_ipsec_policy_action, p->policy,
-                        p->protocol ?
-                          format(0, "%U", format_ip_protocol, p->protocol) :
-                          (u8 *) "any",
-                        p->policy == IPSEC_POLICY_ACTION_PROTECT ?
-                          format(0, " sa %u", p->sa_id) :
-                          (u8 *) "");
-        vlib_cli_output(vm, "   local addr range %U - %U port range %u - %u",
-                        format_ip4_address, &p->laddr.start.ip4,
-                        format_ip4_address, &p->laddr.stop.ip4,
-                        p->lport.start, p->lport.stop);
-        vlib_cli_output(vm, "   remte addr range %U - %U port range %u - %u",
-                        format_ip4_address, &p->raddr.start.ip4,
-                        format_ip4_address, &p->raddr.stop.ip4,
-                        p->rport.start, p->rport.stop);
-        vlib_cli_output(vm, "   packets %u bytes %u", p->counter.packets,
-                        p->counter.bytes);
-      };
-    vec_foreach(i, spd->ipv6_inbound_protect_policy_indices)
-      {
-        p = pool_elt_at_index(spd->policies, *i);
-        vlib_cli_output(vm, "  priority %d action %U protocol %s%s",
-                        p->priority,
-                        format_ipsec_policy_action, p->policy,
-                        p->protocol ?
-                          format(0, "%U", format_ip_protocol, p->protocol) :
-                          (u8 *) "any",
-                        p->policy == IPSEC_POLICY_ACTION_PROTECT ?
-                          format(0, " sa %u", p->sa_id) :
-                          (u8 *) "");
-        vlib_cli_output(vm, "   local addr range %U - %U port range %u - %u",
-                        format_ip6_address, &p->laddr.start.ip6,
-                        format_ip6_address, &p->laddr.stop.ip6,
-                        p->lport.start, p->lport.stop);
-        vlib_cli_output(vm, "   remote addr range %U - %U port range %u - %u",
-                        format_ip6_address, &p->raddr.start.ip6,
-                        format_ip6_address, &p->raddr.stop.ip6,
-                        p->rport.start, p->rport.stop);
-        vlib_cli_output(vm, "   packets %u bytes %u", p->counter.packets,
-                        p->counter.bytes);
-      };
-    vec_foreach(i, spd->ipv6_inbound_policy_discard_and_bypass_indices)
-      {
-        p = pool_elt_at_index(spd->policies, *i);
-        vlib_cli_output(vm, "  priority %d action %U protocol %s%s",
-                        p->priority,
-                        format_ipsec_policy_action, p->policy,
-                        p->protocol ?
-                          format(0, "%U", format_ip_protocol, p->protocol) :
-                          (u8 *) "any",
-                        p->policy == IPSEC_POLICY_ACTION_PROTECT ?
-                          format(0, " sa %u", p->sa_id) :
-                          (u8 *) "");
-        vlib_cli_output(vm, "   local addr range %U - %U port range %u - %u",
-                        format_ip6_address, &p->laddr.start.ip6,
-                        format_ip6_address, &p->laddr.stop.ip6,
-                        p->lport.start, p->lport.stop);
-        vlib_cli_output(vm, "   remote addr range %U - %U port range %u - %u",
-                        format_ip6_address, &p->raddr.start.ip6,
-                        format_ip6_address, &p->raddr.stop.ip6,
-                        p->rport.start, p->rport.stop);
-        vlib_cli_output(vm, "   packets %u bytes %u", p->counter.packets,
-                        p->counter.bytes);
-      };
-  }));
+  pool_foreach (eb, im->esp_backends, {
+    s = format (s, "%=25s %=25u %=10s\n", eb->name, eb - im->esp_backends,
+                eb - im->esp_backends == im->esp_current_backend ? "yes"
+                                                                 : "no");
+    if (verbose) {
+        vlib_node_t *n;
+        n = vlib_get_node (vm, eb->esp4_encrypt_node_index);
+        s = format (s, "     enc4 %s (next %d)\n", n->name, eb->esp4_encrypt_next_index);
+        n = vlib_get_node (vm, eb->esp4_decrypt_node_index);
+        s = format (s, "     dec4 %s (next %d)\n", n->name, eb->esp4_decrypt_next_index);
+        n = vlib_get_node (vm, eb->esp6_encrypt_node_index);
+        s = format (s, "     enc6 %s (next %d)\n", n->name, eb->esp6_encrypt_next_index);
+        n = vlib_get_node (vm, eb->esp6_decrypt_node_index);
+        s = format (s, "     dec6 %s (next %d)\n", n->name, eb->esp6_decrypt_next_index);
+    }
+  });
   /* *INDENT-ON* */
+  vlib_cli_output (vm, "%v", s);
 
-  vlib_cli_output (vm, "tunnel interfaces");
-  /* *INDENT-OFF* */
-  pool_foreach (t, im->tunnel_interfaces, ({
-    if (t->hw_if_index == ~0)
-      continue;
-    hi = vnet_get_hw_interface (im->vnet_main, t->hw_if_index);
-    vlib_cli_output(vm, "  %s seq", hi->name);
-    sa = pool_elt_at_index(im->sad, t->output_sa_index);
-    vlib_cli_output(vm, "   seq %u seq-hi %u esn %u anti-replay %u",
-                    sa->seq, sa->seq_hi, sa->use_esn, sa->use_anti_replay);
-    vlib_cli_output(vm, "   local-spi %u local-ip %U", sa->spi,
-                    format_ip4_address, &sa->tunnel_src_addr.ip4);
-    vlib_cli_output(vm, "   local-crypto %U %U",
-                    format_ipsec_crypto_alg, sa->crypto_alg,
-                    format_hex_bytes, sa->crypto_key, sa->crypto_key_len);
-    vlib_cli_output(vm, "   local-integrity %U %U",
-                    format_ipsec_integ_alg, sa->integ_alg,
-                    format_hex_bytes, sa->integ_key, sa->integ_key_len);
-    sa = pool_elt_at_index(im->sad, t->input_sa_index);
-    vlib_cli_output(vm, "   last-seq %u last-seq-hi %u esn %u anti-replay %u window %U",
-                    sa->last_seq, sa->last_seq_hi, sa->use_esn,
-                    sa->use_anti_replay,
-                    format_ipsec_replay_window, sa->replay_window);
-    vlib_cli_output(vm, "   remote-spi %u remote-ip %U", sa->spi,
-                    format_ip4_address, &sa->tunnel_src_addr.ip4);
-    vlib_cli_output(vm, "   remote-crypto %U %U",
-                    format_ipsec_crypto_alg, sa->crypto_alg,
-                    format_hex_bytes, sa->crypto_key, sa->crypto_key_len);
-    vlib_cli_output(vm, "   remote-integrity %U %U",
-                    format_ipsec_integ_alg, sa->integ_alg,
-                    format_hex_bytes, sa->integ_key, sa->integ_key_len);
-  }));
-  /* *INDENT-ON* */
+  vec_free (s);
   return 0;
 }
 
 /* *INDENT-OFF* */
-VLIB_CLI_COMMAND (show_ipsec_command, static) = {
-    .path = "show ipsec",
-    .short_help = "show ipsec",
-    .function = show_ipsec_command_fn,
+VLIB_CLI_COMMAND (ipsec_show_backends_command, static) = {
+    .path = "show ipsec backends",
+    .short_help = "show ipsec backends",
+    .function = ipsec_show_backends_command_fn,
 };
 /* *INDENT-ON* */
 
 static clib_error_t *
-clear_ipsec_counters_command_fn (vlib_main_t * vm,
+ipsec_select_backend_command_fn (vlib_main_t * vm,
                                 unformat_input_t * input,
                                 vlib_cli_command_t * cmd)
 {
+  unformat_input_t _line_input, *line_input = &_line_input;
   ipsec_main_t *im = &ipsec_main;
-  ipsec_spd_t *spd;
-  ipsec_policy_t *p;
+  clib_error_t *error;
+  u32 backend_index;
 
-  /* *INDENT-OFF* */
-  pool_foreach (spd, im->spds, ({
-    pool_foreach(p, spd->policies, ({
-      p->counter.packets = p->counter.bytes = 0;
-    }));
-  }));
-  /* *INDENT-ON* */
+  error = ipsec_rsc_in_use (im);
+
+  if (error)
+    return error;
+
+  /* Get a line of input. */
+  if (!unformat_user (input, unformat_line_input, line_input))
+    return 0;
+
+  if (unformat (line_input, "ah"))
+    {
+      if (unformat (line_input, "%u", &backend_index))
+       {
+         if (ipsec_select_ah_backend (im, backend_index) < 0)
+           {
+             return clib_error_return (0, "Invalid AH backend index `%u'",
+                                       backend_index);
+           }
+       }
+      else
+       {
+         return clib_error_return (0, "Invalid backend index `%U'",
+                                   format_unformat_error, line_input);
+       }
+    }
+  else if (unformat (line_input, "esp"))
+    {
+      if (unformat (line_input, "%u", &backend_index))
+       {
+         if (ipsec_select_esp_backend (im, backend_index) < 0)
+           {
+             return clib_error_return (0, "Invalid ESP backend index `%u'",
+                                       backend_index);
+           }
+       }
+      else
+       {
+         return clib_error_return (0, "Invalid backend index `%U'",
+                                   format_unformat_error, line_input);
+       }
+    }
+  else
+    {
+      return clib_error_return (0, "Unknown input `%U'",
+                               format_unformat_error, line_input);
+    }
 
   return 0;
 }
 
+/* *INDENT-OFF* */
+VLIB_CLI_COMMAND (ipsec_select_backend_command, static) = {
+    .path = "ipsec select backend",
+    .short_help = "ipsec select backend <ah|esp> <backend index>",
+    .function = ipsec_select_backend_command_fn,
+};
+
+/* *INDENT-ON* */
+
+static clib_error_t *
+clear_ipsec_counters_command_fn (vlib_main_t * vm,
+                                unformat_input_t * input,
+                                vlib_cli_command_t * cmd)
+{
+  vlib_clear_combined_counters (&ipsec_spd_policy_counters);
+  vlib_clear_combined_counters (&ipsec_sa_counters);
+
+  return (NULL);
+}
+
 /* *INDENT-OFF* */
 VLIB_CLI_COMMAND (clear_ipsec_counters_command, static) = {
     .path = "clear ipsec counters",
@@ -651,18 +709,45 @@ VLIB_CLI_COMMAND (clear_ipsec_counters_command, static) = {
 };
 /* *INDENT-ON* */
 
+static u32
+ipsec_tun_mk_local_sa_id (u32 ti)
+{
+  return (0x80000000 | ti);
+}
+
+static u32
+ipsec_tun_mk_remote_sa_id (u32 ti)
+{
+  return (0xc0000000 | ti);
+}
+
 static clib_error_t *
 create_ipsec_tunnel_command_fn (vlib_main_t * vm,
                                unformat_input_t * input,
                                vlib_cli_command_t * cmd)
 {
   unformat_input_t _line_input, *line_input = &_line_input;
-  ipsec_add_del_tunnel_args_t a;
+  ip46_address_t local_ip = ip46_address_initializer;
+  ip46_address_t remote_ip = ip46_address_initializer;
+  ip_address_t nh = IP_ADDRESS_V4_ALL_0S;
+  ipsec_crypto_alg_t crypto_alg = IPSEC_CRYPTO_ALG_NONE;
+  ipsec_integ_alg_t integ_alg = IPSEC_INTEG_ALG_NONE;
+  ipsec_sa_flags_t flags;
+  u32 local_spi, remote_spi, salt, table_id, fib_index;
+  u32 instance = ~0;
   int rv;
   u32 num_m_args = 0;
-
-  memset (&a, 0, sizeof (a));
-  a.is_add = 1;
+  u8 ipv4_set = 0;
+  u8 ipv6_set = 0;
+  u8 is_add = 1;
+  clib_error_t *error = NULL;
+  ipsec_key_t rck = { 0 };
+  ipsec_key_t lck = { 0 };
+  ipsec_key_t lik = { 0 };
+  ipsec_key_t rik = { 0 };
+
+  table_id = 0;
+  flags = IPSEC_SA_FLAG_NONE;
 
   /* Get a line of input. */
   if (!unformat_user (input, unformat_line_input, line_input))
@@ -671,121 +756,277 @@ create_ipsec_tunnel_command_fn (vlib_main_t * vm,
   while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT)
     {
       if (unformat
-         (line_input, "local-ip %U", unformat_ip4_address, &a.local_ip))
-       num_m_args++;
+         (line_input, "local-ip %U", unformat_ip46_address, &local_ip,
+          IP46_TYPE_ANY))
+       {
+         ip46_address_is_ip4 (&local_ip) ? (ipv4_set = 1) : (ipv6_set = 1);
+         num_m_args++;
+       }
       else
        if (unformat
-           (line_input, "remote-ip %U", unformat_ip4_address, &a.remote_ip))
-       num_m_args++;
-      else if (unformat (line_input, "local-spi %u", &a.local_spi))
+           (line_input, "remote-ip %U", unformat_ip46_address, &remote_ip,
+            IP46_TYPE_ANY))
+       {
+         ip46_address_is_ip4 (&remote_ip) ? (ipv4_set = 1) : (ipv6_set = 1);
+         num_m_args++;
+       }
+      else if (unformat (line_input, "local-spi %u", &local_spi))
        num_m_args++;
-      else if (unformat (line_input, "remote-spi %u", &a.remote_spi))
+      else if (unformat (line_input, "remote-spi %u", &remote_spi))
        num_m_args++;
+      else if (unformat (line_input, "salt 0x%x", &salt))
+       ;
+      else if (unformat (line_input, "udp-encap"))
+       flags |= IPSEC_SA_FLAG_UDP_ENCAP;
+      else if (unformat (line_input, "use-esn"))
+       flags |= IPSEC_SA_FLAG_USE_ESN;
+      else if (unformat (line_input, "use-anti-replay"))
+       flags |= IPSEC_SA_FLAG_USE_ANTI_REPLAY;
+      else if (unformat (line_input, "instance %u", &instance))
+       ;
+      else if (unformat (line_input, "tx-table %u", &table_id))
+       ;
+      else
+       if (unformat
+           (line_input, "local-crypto-key %U", unformat_ipsec_key, &lck))
+       ;
+      else
+       if (unformat
+           (line_input, "remote-crypto-key %U", unformat_ipsec_key, &rck))
+       ;
+      else if (unformat (line_input, "crypto-alg %U",
+                        unformat_ipsec_crypto_alg, &crypto_alg))
+       ;
+      else
+       if (unformat
+           (line_input, "local-integ-key %U", unformat_ipsec_key, &lik))
+       ;
+      else
+       if (unformat
+           (line_input, "remote-integ-key %U", unformat_ipsec_key, &rik))
+       ;
+      else if (unformat (line_input, "integ-alg %U",
+                        unformat_ipsec_integ_alg, &integ_alg))
+       ;
       else if (unformat (line_input, "del"))
-       a.is_add = 0;
+       is_add = 0;
+      else if (unformat (line_input, "nh &U", unformat_ip_address, &nh))
+       ;
       else
-       return clib_error_return (0, "unknown input `%U'",
-                                 format_unformat_error, input);
+       {
+         error = clib_error_return (0, "unknown input `%U'",
+                                    format_unformat_error, line_input);
+         goto done;
+       }
     }
-  unformat_free (line_input);
 
   if (num_m_args < 4)
-    return clib_error_return (0, "mandatory argument(s) missing");
+    {
+      error = clib_error_return (0, "mandatory argument(s) missing");
+      goto done;
+    }
+
+  if (ipv4_set && ipv6_set)
+    return clib_error_return (0, "both IPv4 and IPv6 addresses specified");
 
-  rv = ipsec_add_del_tunnel_if (&a);
+  fib_index = fib_table_find (fib_ip_proto (ipv6_set), table_id);
+
+  if (~0 == fib_index)
+    {
+      rv = VNET_API_ERROR_NO_SUCH_FIB;
+      goto done;
+    }
+
+  if (is_add)
+    {
+      // remote = input, local = output
+      u32 sw_if_index;
+
+      /* create an ip-ip tunnel, then the two SA, then bind them */
+      rv =
+       ipip_add_tunnel (ipv6_set ? IPIP_TRANSPORT_IP6 : IPIP_TRANSPORT_IP4,
+                        instance, &local_ip, &remote_ip, fib_index,
+                        TUNNEL_ENCAP_DECAP_FLAG_NONE, IP_DSCP_CS0,
+                        TUNNEL_MODE_P2P, &sw_if_index);
+      rv |=
+       ipsec_sa_add_and_lock (ipsec_tun_mk_local_sa_id (sw_if_index),
+                              local_spi, IPSEC_PROTOCOL_ESP, crypto_alg,
+                              &lck, integ_alg, &lik, flags, table_id,
+                              clib_host_to_net_u32 (salt), &local_ip,
+                              &remote_ip, NULL, IPSEC_UDP_PORT_NONE);
+      rv |=
+       ipsec_sa_add_and_lock (ipsec_tun_mk_remote_sa_id (sw_if_index),
+                              remote_spi, IPSEC_PROTOCOL_ESP, crypto_alg,
+                              &rck, integ_alg, &rik,
+                              (flags | IPSEC_SA_FLAG_IS_INBOUND), table_id,
+                              clib_host_to_net_u32 (salt), &remote_ip,
+                              &local_ip, NULL, IPSEC_UDP_PORT_NONE);
+      rv |=
+       ipsec_tun_protect_update_one (sw_if_index, &nh,
+                                     ipsec_tun_mk_local_sa_id (sw_if_index),
+                                     ipsec_tun_mk_remote_sa_id
+                                     (sw_if_index));
+    }
+  else
+    rv = 0;
 
   switch (rv)
     {
     case 0:
       break;
     case VNET_API_ERROR_INVALID_VALUE:
-      if (a.is_add)
-       return clib_error_return (0,
-                                 "IPSec tunnel interface already exists...");
-      else
-       return clib_error_return (0, "IPSec tunnel interface not exists...");
+      error = clib_error_return (0,
+                                "IPSec tunnel interface already exists...");
+      goto done;
     default:
-      return clib_error_return (0, "ipsec_register_interface returned %d",
-                               rv);
+      error = clib_error_return (0, "ipsec_register_interface returned %d",
+                                rv);
+      goto done;
     }
 
-  return 0;
+done:
+  unformat_free (line_input);
+
+  return error;
 }
 
 /* *INDENT-OFF* */
 VLIB_CLI_COMMAND (create_ipsec_tunnel_command, static) = {
   .path = "create ipsec tunnel",
-  .short_help = "create ipsec tunnel local-ip <addr> local-spi <spi> remote-ip <addr> remote-spi <spi>",
+  .short_help = "create ipsec tunnel local-ip <addr> local-spi <spi> "
+      "remote-ip <addr> remote-spi <spi> [instance <inst_num>] [udp-encap] [use-esn] [use-anti-replay] "
+      "[tx-table <table-id>]",
   .function = create_ipsec_tunnel_command_fn,
 };
 /* *INDENT-ON* */
 
 static clib_error_t *
-set_interface_key_command_fn (vlib_main_t * vm,
-                             unformat_input_t * input,
-                             vlib_cli_command_t * cmd)
+ipsec_tun_protect_cmd (vlib_main_t * vm,
+                      unformat_input_t * input, vlib_cli_command_t * cmd)
 {
   unformat_input_t _line_input, *line_input = &_line_input;
-  ipsec_main_t *im = &ipsec_main;
-  ipsec_if_set_key_type_t type = IPSEC_IF_SET_KEY_TYPE_NONE;
-  u32 hw_if_index = (u32) ~ 0;
-  u32 alg;
-  u8 *key = 0;
+  u32 sw_if_index, is_del, sa_in, sa_out, *sa_ins = NULL;
+  ip_address_t peer = { };
+  vnet_main_t *vnm;
+
+  is_del = 0;
+  sw_if_index = ~0;
+  vnm = vnet_get_main ();
 
   if (!unformat_user (input, unformat_line_input, line_input))
     return 0;
 
   while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT)
     {
-      if (unformat (line_input, "%U",
-                   unformat_vnet_hw_interface, im->vnet_main, &hw_if_index))
+      if (unformat (line_input, "del"))
+       is_del = 1;
+      else if (unformat (line_input, "add"))
+       is_del = 0;
+      else if (unformat (line_input, "sa-in %d", &sa_in))
+       vec_add1 (sa_ins, sa_in);
+      else if (unformat (line_input, "sa-out %d", &sa_out))
        ;
-      else
-       if (unformat
-           (line_input, "local crypto %U", unformat_ipsec_crypto_alg, &alg))
-       type = IPSEC_IF_SET_KEY_TYPE_LOCAL_CRYPTO;
-      else
-       if (unformat
-           (line_input, "remote crypto %U", unformat_ipsec_crypto_alg, &alg))
-       type = IPSEC_IF_SET_KEY_TYPE_REMOTE_CRYPTO;
-      else
-       if (unformat
-           (line_input, "local integ %U", unformat_ipsec_integ_alg, &alg))
-       type = IPSEC_IF_SET_KEY_TYPE_LOCAL_INTEG;
-      else
-       if (unformat
-           (line_input, "remote integ %U", unformat_ipsec_integ_alg, &alg))
-       type = IPSEC_IF_SET_KEY_TYPE_REMOTE_INTEG;
-      else if (unformat (line_input, "%U", unformat_hex_string, &key))
+      else if (unformat (line_input, "%U",
+                        unformat_vnet_sw_interface, vnm, &sw_if_index))
+       ;
+      else if (unformat (line_input, "%U", unformat_ip_address, &peer))
        ;
       else
-       return clib_error_return (0, "parse error: '%U'",
-                                 format_unformat_error, line_input);
+       return (clib_error_return (0, "unknown input '%U'",
+                                  format_unformat_error, line_input));
     }
 
+  if (!is_del)
+    ipsec_tun_protect_update (sw_if_index, &peer, sa_out, sa_ins);
+
   unformat_free (line_input);
+  return NULL;
+}
 
-  if (type == IPSEC_IF_SET_KEY_TYPE_NONE)
-    return clib_error_return (0, "unknown key type");
+/**
+ * Protect tunnel with IPSEC
+ */
+/* *INDENT-OFF* */
+VLIB_CLI_COMMAND (ipsec_tun_protect_cmd_node, static) =
+{
+  .path = "ipsec tunnel protect",
+  .function = ipsec_tun_protect_cmd,
+  .short_help = "ipsec tunnel protect <interface> input-sa <SA> output-sa <SA>",
+    // this is not MP safe
+};
+/* *INDENT-ON* */
 
-  if (alg > 0 && vec_len (key) == 0)
-    return clib_error_return (0, "key is not specified");
 
-  if (hw_if_index == (u32) ~ 0)
-    return clib_error_return (0, "interface not specified");
+static clib_error_t *
+ipsec_tun_protect_show (vlib_main_t * vm,
+                       unformat_input_t * input, vlib_cli_command_t * cmd)
+{
+  ipsec_tun_protect_walk (ipsec_tun_protect_show_one, vm);
 
-  ipsec_set_interface_key (im->vnet_main, hw_if_index, type, alg, key);
-  vec_free (key);
+  return NULL;
+}
 
-  return 0;
+/**
+ * show IPSEC tunnel protection
+ */
+/* *INDENT-OFF* */
+VLIB_CLI_COMMAND (ipsec_tun_protect_show_node, static) =
+{
+  .path = "show ipsec protect",
+  .function = ipsec_tun_protect_show,
+  .short_help =  "show ipsec protect",
+};
+/* *INDENT-ON* */
+
+static clib_error_t *
+ipsec_tun_protect_hash_show (vlib_main_t * vm,
+                            unformat_input_t * input,
+                            vlib_cli_command_t * cmd)
+{
+  ipsec_main_t *im = &ipsec_main;
+
+  {
+    ipsec_tun_lkup_result_t value;
+    ipsec4_tunnel_key_t key;
+
+    vlib_cli_output (vm, "IPv4:");
+
+    /* *INDENT-OFF* */
+    hash_foreach(key.as_u64, value.as_u64, im->tun4_protect_by_key,
+    ({
+      vlib_cli_output (vm, " %U", format_ipsec4_tunnel_key, &key);
+      vlib_cli_output (vm, "  tun:%d sa:%d", value.tun_index, value.sa_index);
+    }));
+    /* *INDENT-ON* */
+  }
+
+  {
+    ipsec_tun_lkup_result_t value;
+    ipsec6_tunnel_key_t *key;
+
+    vlib_cli_output (vm, "IPv6:");
+
+    /* *INDENT-OFF* */
+    hash_foreach_mem(key, value.as_u64, im->tun6_protect_by_key,
+    ({
+      vlib_cli_output (vm, " %U", format_ipsec6_tunnel_key, key);
+      vlib_cli_output (vm, "  tun:%d sa:%d", value.tun_index, value.sa_index);
+    }));
+    /* *INDENT-ON* */
+  }
+
+  return NULL;
 }
 
+/**
+ * show IPSEC tunnel protection hash tables
+ */
 /* *INDENT-OFF* */
-VLIB_CLI_COMMAND (set_interface_key_command, static) = {
-    .path = "set interface ipsec key",
-    .short_help =
-    "set interface ipsec key <int> <local|remote> <crypto|integ> <key type> <key>",
-    .function = set_interface_key_command_fn,
+VLIB_CLI_COMMAND (ipsec_tun_protect_hash_show_node, static) =
+{
+  .path = "show ipsec protect-hash",
+  .function = ipsec_tun_protect_hash_show,
+  .short_help =  "show ipsec protect-hash",
 };
 /* *INDENT-ON* */