Remove c-11 memcpy checks from perf-critical code
[vpp.git] / src / vnet / l2 / l2_learn.c
index faed0d6..e473657 100644 (file)
 #include <vppinfra/error.h>
 #include <vppinfra/hash.h>
 
+#ifndef CLIB_MARCH_VARIANT
+l2learn_main_t l2learn_main;
+#endif
+
 /**
  * @file
  * @brief Ethernet Bridge Learning.
@@ -78,7 +82,7 @@ _(MISS,              "L2 learn misses")                       \
 _(MAC_MOVE,          "L2 mac moves")                   \
 _(MAC_MOVE_VIOLATE,  "L2 mac move violations")         \
 _(LIMIT,             "L2 not learned due to limit")    \
-_(HIT,               "L2 learn hits")                  \
+_(HIT_UPDATE,        "L2 learn hit updates")           \
 _(FILTER_DROP,       "L2 filter mac drops")
 
 typedef enum
@@ -113,83 +117,80 @@ l2learn_process (vlib_node_runtime_t * node,
                 u32 sw_if_index0,
                 l2fib_entry_key_t * key0,
                 l2fib_entry_key_t * cached_key,
-                u32 * bucket0,
-                l2fib_entry_result_t * result0, u32 * next0, u8 timestamp)
+                u32 * count,
+                l2fib_entry_result_t * result0, u16 * next0, u8 timestamp)
 {
-  u32 feature_bitmap;
-
   /* Set up the default next node (typically L2FWD) */
-
-  /* Remove ourself from the feature bitmap */
-  feature_bitmap = vnet_buffer (b0)->l2.feature_bitmap & ~L2INPUT_FEAT_LEARN;
-
-  /* Save for next feature graph nodes */
-  vnet_buffer (b0)->l2.feature_bitmap = feature_bitmap;
-
-  /* Determine the next node */
-  *next0 = feat_bitmap_get_next_node_index (msm->feat_next_node_index,
-                                           feature_bitmap);
+  *next0 = vnet_l2_feature_next (b0, msm->feat_next_node_index,
+                                L2INPUT_FEAT_LEARN);
 
   /* Check mac table lookup result */
-
   if (PREDICT_TRUE (result0->fields.sw_if_index == sw_if_index0))
     {
-      /*
-       * The entry was in the table, and the sw_if_index matched, the normal case
-       */
-      counter_base[L2LEARN_ERROR_HIT] += 1;
-      if (PREDICT_FALSE (result0->fields.timestamp != timestamp))
-       result0->fields.timestamp = timestamp;
-      if (PREDICT_FALSE
-         (result0->fields.int_sn != vnet_buffer (b0)->l2.int_sn))
-       result0->fields.int_sn = vnet_buffer (b0)->l2.int_sn;
-      if (PREDICT_FALSE (result0->fields.bd_sn != vnet_buffer (b0)->l2.bd_sn))
-       result0->fields.bd_sn = vnet_buffer (b0)->l2.bd_sn;
+      /* Entry in L2FIB with matching sw_if_index matched - normal fast path */
+      u32 dtime = timestamp - result0->fields.timestamp;
+      u32 dsn = result0->fields.sn.as_u16 - vnet_buffer (b0)->l2.l2fib_sn;
+      u32 check = (dtime && vnet_buffer (b0)->l2.bd_age) || dsn;
+
+      if (PREDICT_TRUE (check == 0))
+       return;                 /* MAC entry up to date */
+      if (l2fib_entry_result_is_set_AGE_NOT (result0))
+       return;                 /* Static MAC always age_not */
+      if (msm->global_learn_count > msm->global_learn_limit)
+       return;                 /* Above learn limit - do not update */
+
+      /* Limit updates per l2-learn node call to avoid prolonged update burst
+       * as dtime advance over 1 minute mark, unless more than 1 min behind
+       * or SN obsolete */
+      if ((*count > 2) && (dtime == 1) && (dsn == 0))
+       return;
+
+      counter_base[L2LEARN_ERROR_HIT_UPDATE] += 1;
+      *count += 1;
     }
   else if (result0->raw == ~0)
     {
-
-      /* The entry was not in table, so add it  */
-
+      /* Entry not in L2FIB - add it  */
       counter_base[L2LEARN_ERROR_MISS] += 1;
 
-      if (msm->global_learn_count == msm->global_learn_limit)
+      if (msm->global_learn_count >= msm->global_learn_limit)
        {
          /*
           * Global limit reached. Do not learn the mac but forward the packet.
           * In the future, limits could also be per-interface or bridge-domain.
           */
          counter_base[L2LEARN_ERROR_LIMIT] += 1;
-         goto done;
-
-       }
-      else
-       {
-         BVT (clib_bihash_kv) kv;
-         /* It is ok to learn */
-
-         result0->raw = 0;     /* clear all fields */
-         result0->fields.sw_if_index = sw_if_index0;
-         result0->fields.timestamp = timestamp;
-         result0->fields.bd_sn = vnet_buffer (b0)->l2.bd_sn;
-         result0->fields.int_sn = vnet_buffer (b0)->l2.int_sn;
-         kv.key = key0->raw;
-         kv.value = result0->raw;
-
-         BV (clib_bihash_add_del) (msm->mac_table, &kv, 1 /* is_add */ );
-
-         cached_key->raw = ~0; /* invalidate the cache */
-         msm->global_learn_count++;
+         return;
        }
 
+      /* Do not learn if mac is 0 */
+      l2fib_entry_key_t key = *key0;
+      key.fields.bd_index = 0;
+      if (key.raw == 0)
+       return;
+
+      /* It is ok to learn */
+      msm->global_learn_count++;
+      result0->raw = 0;                /* clear all fields */
+      result0->fields.sw_if_index = sw_if_index0;
+      if (msm->client_pid != 0)
+       l2fib_entry_result_set_LRN_EVT (result0);
+      else
+       l2fib_entry_result_clear_LRN_EVT (result0);
     }
   else
     {
+      /* Entry in L2FIB with different sw_if_index - mac move or filter */
+      if (l2fib_entry_result_is_set_FILTER (result0))
+       {
+         ASSERT (result0->fields.sw_if_index == ~0);
+         /* drop packet because lookup matched a filter mac entry */
+         b0->error = node->errors[L2LEARN_ERROR_FILTER_DROP];
+         *next0 = L2LEARN_NEXT_DROP;
+         return;
+       }
 
-      /* The entry was in the table, but with the wrong sw_if_index mapping (mac move) */
-      counter_base[L2LEARN_ERROR_MAC_MOVE] += 1;
-
-      if (result0->fields.static_mac)
+      if (l2fib_entry_result_is_set_STATIC (result0))
        {
          /*
           * Don't overwrite a static mac
@@ -197,45 +198,42 @@ l2learn_process (vlib_node_runtime_t * node,
           */
          b0->error = node->errors[L2LEARN_ERROR_MAC_MOVE_VIOLATE];
          *next0 = L2LEARN_NEXT_DROP;
+         return;
        }
-      else
-       {
-         /*
-          * Update the entry
-          * TODO: may want to rate limit mac moves
-          * TODO: check global/bridge domain/interface learn limits
-          */
-         BVT (clib_bihash_kv) kv;
-
-         result0->raw = 0;     /* clear all fields */
-         result0->fields.sw_if_index = sw_if_index0;
-         result0->fields.timestamp = timestamp;
-         result0->fields.bd_sn = vnet_buffer (b0)->l2.bd_sn;
-         result0->fields.int_sn = vnet_buffer (b0)->l2.int_sn;
 
-         kv.key = key0->raw;
-         kv.value = result0->raw;
-
-         cached_key->raw = ~0; /* invalidate the cache */
-
-         BV (clib_bihash_add_del) (msm->mac_table, &kv, 1 /* is_add */ );
+      /*
+       * TODO: may want to rate limit mac moves
+       * TODO: check global/bridge domain/interface learn limits
+       */
+      result0->fields.sw_if_index = sw_if_index0;
+      if (l2fib_entry_result_is_set_AGE_NOT (result0))
+       {
+         /* The mac was provisioned */
+         msm->global_learn_count++;
+         l2fib_entry_result_clear_AGE_NOT (result0);
        }
+      if (msm->client_pid != 0)
+       l2fib_entry_result_set_bits (result0,
+                                    (L2FIB_ENTRY_RESULT_FLAG_LRN_EVT |
+                                     L2FIB_ENTRY_RESULT_FLAG_LRN_MOV));
+      else
+       l2fib_entry_result_clear_bits (result0,
+                                      (L2FIB_ENTRY_RESULT_FLAG_LRN_EVT |
+                                       L2FIB_ENTRY_RESULT_FLAG_LRN_MOV));
+      counter_base[L2LEARN_ERROR_MAC_MOVE] += 1;
     }
 
-  if (result0->fields.filter)
-    {
-      /* drop packet because lookup matched a filter mac entry */
+  /* Update the entry */
+  result0->fields.timestamp = timestamp;
+  result0->fields.sn.as_u16 = vnet_buffer (b0)->l2.l2fib_sn;
 
-      if (*next0 != L2LEARN_NEXT_DROP)
-       {
-         /* if we're not already dropping the packet, do it now */
-         b0->error = node->errors[L2LEARN_ERROR_FILTER_DROP];
-         *next0 = L2LEARN_NEXT_DROP;
-       }
-    }
+  BVT (clib_bihash_kv) kv;
+  kv.key = key0->raw;
+  kv.value = result0->raw;
+  BV (clib_bihash_add_del) (msm->mac_table, &kv, 1 /* is_add */ );
 
-done:
-  return;
+  /* Invalidate the cache */
+  cached_key->raw = ~0;
 }
 
 
@@ -243,8 +241,7 @@ static_always_inline uword
 l2learn_node_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
                     vlib_frame_t * frame, int do_trace)
 {
-  u32 n_left_from, *from, *to_next;
-  l2learn_next_t next_index;
+  u32 n_left, *from;
   l2learn_main_t *msm = &l2learn_main;
   vlib_node_t *n = vlib_get_node (vm, l2learn_node.index);
   u32 node_counter_base_index = n->error_heap_index;
@@ -252,225 +249,177 @@ l2learn_node_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
   l2fib_entry_key_t cached_key;
   l2fib_entry_result_t cached_result;
   u8 timestamp = (u8) (vlib_time_now (vm) / 60);
+  u32 count = 0;
+  vlib_buffer_t *bufs[VLIB_FRAME_SIZE], **b;
+  u16 nexts[VLIB_FRAME_SIZE], *next;
 
   from = vlib_frame_vector_args (frame);
-  n_left_from = frame->n_vectors;      /* number of packets to process */
-  next_index = node->cached_next_index;
+  n_left = frame->n_vectors;   /* number of packets to process */
+  vlib_get_buffers (vm, from, bufs, n_left);
+  next = nexts;
+  b = bufs;
 
   /* Clear the one-entry cache in case mac table was updated */
   cached_key.raw = ~0;
   cached_result.raw = ~0;      /* warning be gone */
 
-  while (n_left_from > 0)
+  while (n_left > 8)
     {
-      u32 n_left_to_next;
-
-      /* get space to enqueue frame to graph node "next_index" */
-      vlib_get_next_frame (vm, node, next_index, to_next, n_left_to_next);
-
-      while (n_left_from >= 8 && n_left_to_next >= 4)
+      u32 sw_if_index0, sw_if_index1, sw_if_index2, sw_if_index3;
+      const ethernet_header_t *h0, *h1, *h2, *h3;
+      l2fib_entry_key_t key0, key1, key2, key3;
+      l2fib_entry_result_t result0, result1, result2, result3;
+
+      /* Prefetch next iteration. */
+      {
+       /* buffer header is read and written, so use LOAD
+        * prefetch */
+       vlib_prefetch_buffer_header (b[4], LOAD);
+       vlib_prefetch_buffer_header (b[5], LOAD);
+       vlib_prefetch_buffer_header (b[6], LOAD);
+       vlib_prefetch_buffer_header (b[7], LOAD);
+
+       CLIB_PREFETCH (b[4]->data, CLIB_CACHE_LINE_BYTES, LOAD);
+       CLIB_PREFETCH (b[5]->data, CLIB_CACHE_LINE_BYTES, LOAD);
+       CLIB_PREFETCH (b[6]->data, CLIB_CACHE_LINE_BYTES, LOAD);
+       CLIB_PREFETCH (b[7]->data, CLIB_CACHE_LINE_BYTES, LOAD);
+      }
+
+      /* RX interface handles */
+      sw_if_index0 = vnet_buffer (b[0])->sw_if_index[VLIB_RX];
+      sw_if_index1 = vnet_buffer (b[1])->sw_if_index[VLIB_RX];
+      sw_if_index2 = vnet_buffer (b[2])->sw_if_index[VLIB_RX];
+      sw_if_index3 = vnet_buffer (b[3])->sw_if_index[VLIB_RX];
+
+      /* Process 4 x pkts */
+
+      h0 = vlib_buffer_get_current (b[0]);
+      h1 = vlib_buffer_get_current (b[1]);
+      h2 = vlib_buffer_get_current (b[2]);
+      h3 = vlib_buffer_get_current (b[3]);
+
+      if (do_trace)
        {
-         u32 bi0, bi1, bi2, bi3;
-         vlib_buffer_t *b0, *b1, *b2, *b3;
-         u32 next0, next1, next2, next3;
-         u32 sw_if_index0, sw_if_index1, sw_if_index2, sw_if_index3;
-         ethernet_header_t *h0, *h1, *h2, *h3;
-         l2fib_entry_key_t key0, key1, key2, key3;
-         l2fib_entry_result_t result0, result1, result2, result3;
-         u32 bucket0, bucket1, bucket2, bucket3;
-
-         /* Prefetch next iteration. */
-         {
-           vlib_buffer_t *p4, *p5, *p6, *p7;;
-
-           p4 = vlib_get_buffer (vm, from[4]);
-           p5 = vlib_get_buffer (vm, from[5]);
-           p6 = vlib_get_buffer (vm, from[6]);
-           p7 = vlib_get_buffer (vm, from[7]);
-
-           vlib_prefetch_buffer_header (p4, LOAD);
-           vlib_prefetch_buffer_header (p5, LOAD);
-           vlib_prefetch_buffer_header (p6, LOAD);
-           vlib_prefetch_buffer_header (p7, LOAD);
-
-           CLIB_PREFETCH (p4->data, CLIB_CACHE_LINE_BYTES, STORE);
-           CLIB_PREFETCH (p5->data, CLIB_CACHE_LINE_BYTES, STORE);
-           CLIB_PREFETCH (p6->data, CLIB_CACHE_LINE_BYTES, STORE);
-           CLIB_PREFETCH (p7->data, CLIB_CACHE_LINE_BYTES, STORE);
-         }
-
-         /* speculatively enqueue b0 and b1 to the current next frame */
-         /* bi is "buffer index", b is pointer to the buffer */
-         to_next[0] = bi0 = from[0];
-         to_next[1] = bi1 = from[1];
-         to_next[2] = bi2 = from[2];
-         to_next[3] = bi3 = from[3];
-         from += 4;
-         to_next += 4;
-         n_left_from -= 4;
-         n_left_to_next -= 4;
-
-         b0 = vlib_get_buffer (vm, bi0);
-         b1 = vlib_get_buffer (vm, bi1);
-         b2 = vlib_get_buffer (vm, bi2);
-         b3 = vlib_get_buffer (vm, bi3);
-
-         /* RX interface handles */
-         sw_if_index0 = vnet_buffer (b0)->sw_if_index[VLIB_RX];
-         sw_if_index1 = vnet_buffer (b1)->sw_if_index[VLIB_RX];
-         sw_if_index2 = vnet_buffer (b2)->sw_if_index[VLIB_RX];
-         sw_if_index3 = vnet_buffer (b3)->sw_if_index[VLIB_RX];
-
-         /* Process 4 x pkts */
-
-         h0 = vlib_buffer_get_current (b0);
-         h1 = vlib_buffer_get_current (b1);
-         h2 = vlib_buffer_get_current (b2);
-         h3 = vlib_buffer_get_current (b3);
-
-         if (do_trace)
+         if (b[0]->flags & VLIB_BUFFER_IS_TRACED)
            {
-             if (b0->flags & VLIB_BUFFER_IS_TRACED)
-               {
-                 l2learn_trace_t *t =
-                   vlib_add_trace (vm, node, b0, sizeof (*t));
-                 t->sw_if_index = sw_if_index0;
-                 t->bd_index = vnet_buffer (b0)->l2.bd_index;
-                 clib_memcpy (t->src, h0->src_address, 6);
-                 clib_memcpy (t->dst, h0->dst_address, 6);
-               }
-             if (b1->flags & VLIB_BUFFER_IS_TRACED)
-               {
-                 l2learn_trace_t *t =
-                   vlib_add_trace (vm, node, b1, sizeof (*t));
-                 t->sw_if_index = sw_if_index1;
-                 t->bd_index = vnet_buffer (b1)->l2.bd_index;
-                 clib_memcpy (t->src, h1->src_address, 6);
-                 clib_memcpy (t->dst, h1->dst_address, 6);
-               }
-             if (b2->flags & VLIB_BUFFER_IS_TRACED)
-               {
-                 l2learn_trace_t *t =
-                   vlib_add_trace (vm, node, b2, sizeof (*t));
-                 t->sw_if_index = sw_if_index2;
-                 t->bd_index = vnet_buffer (b2)->l2.bd_index;
-                 clib_memcpy (t->src, h2->src_address, 6);
-                 clib_memcpy (t->dst, h2->dst_address, 6);
-               }
-             if (b3->flags & VLIB_BUFFER_IS_TRACED)
-               {
-                 l2learn_trace_t *t =
-                   vlib_add_trace (vm, node, b3, sizeof (*t));
-                 t->sw_if_index = sw_if_index3;
-                 t->bd_index = vnet_buffer (b3)->l2.bd_index;
-                 clib_memcpy (t->src, h3->src_address, 6);
-                 clib_memcpy (t->dst, h3->dst_address, 6);
-               }
+             l2learn_trace_t *t =
+               vlib_add_trace (vm, node, b[0], sizeof (*t));
+             t->sw_if_index = sw_if_index0;
+             t->bd_index = vnet_buffer (b[0])->l2.bd_index;
+             clib_memcpy_fast (t->src, h0->src_address, 6);
+             clib_memcpy_fast (t->dst, h0->dst_address, 6);
            }
-
-         /* process 4 pkts */
-         vlib_node_increment_counter (vm, l2learn_node.index,
-                                      L2LEARN_ERROR_L2LEARN, 4);
-
-         l2fib_lookup_4 (msm->mac_table, &cached_key, &cached_result,
-                         h0->src_address,
-                         h1->src_address,
-                         h2->src_address,
-                         h3->src_address,
-                         vnet_buffer (b0)->l2.bd_index,
-                         vnet_buffer (b1)->l2.bd_index,
-                         vnet_buffer (b2)->l2.bd_index,
-                         vnet_buffer (b3)->l2.bd_index,
-                         &key0, &key1, &key2, &key3,
-                         &bucket0, &bucket1, &bucket2, &bucket3,
-                         &result0, &result1, &result2, &result3);
-
-         l2learn_process (node, msm, &em->counters[node_counter_base_index],
-                          b0, sw_if_index0, &key0, &cached_key,
-                          &bucket0, &result0, &next0, timestamp);
-
-         l2learn_process (node, msm, &em->counters[node_counter_base_index],
-                          b1, sw_if_index1, &key1, &cached_key,
-                          &bucket1, &result1, &next1, timestamp);
-
-         l2learn_process (node, msm, &em->counters[node_counter_base_index],
-                          b2, sw_if_index2, &key2, &cached_key,
-                          &bucket2, &result2, &next2, timestamp);
-
-         l2learn_process (node, msm, &em->counters[node_counter_base_index],
-                          b3, sw_if_index3, &key3, &cached_key,
-                          &bucket3, &result3, &next3, timestamp);
-
-         /* verify speculative enqueues, maybe switch current next frame */
-         /* if next0==next1==next_index then nothing special needs to be done */
-         vlib_validate_buffer_enqueue_x4 (vm, node, next_index,
-                                          to_next, n_left_to_next,
-                                          bi0, bi1, bi2, bi3,
-                                          next0, next1, next2, next3);
-       }
-
-      while (n_left_from > 0 && n_left_to_next > 0)
-       {
-         u32 bi0;
-         vlib_buffer_t *b0;
-         u32 next0;
-         u32 sw_if_index0;
-         ethernet_header_t *h0;
-         l2fib_entry_key_t key0;
-         l2fib_entry_result_t result0;
-         u32 bucket0;
-
-         /* speculatively enqueue b0 to the current next frame */
-         bi0 = from[0];
-         to_next[0] = bi0;
-         from += 1;
-         to_next += 1;
-         n_left_from -= 1;
-         n_left_to_next -= 1;
-
-         b0 = vlib_get_buffer (vm, bi0);
-
-         sw_if_index0 = vnet_buffer (b0)->sw_if_index[VLIB_RX];
-
-         h0 = vlib_buffer_get_current (b0);
-
-         if (do_trace && PREDICT_FALSE (b0->flags & VLIB_BUFFER_IS_TRACED))
+         if (b[1]->flags & VLIB_BUFFER_IS_TRACED)
            {
-             l2learn_trace_t *t = vlib_add_trace (vm, node, b0, sizeof (*t));
-             t->sw_if_index = sw_if_index0;
-             t->bd_index = vnet_buffer (b0)->l2.bd_index;
-             clib_memcpy (t->src, h0->src_address, 6);
-             clib_memcpy (t->dst, h0->dst_address, 6);
+             l2learn_trace_t *t =
+               vlib_add_trace (vm, node, b[1], sizeof (*t));
+             t->sw_if_index = sw_if_index1;
+             t->bd_index = vnet_buffer (b[1])->l2.bd_index;
+             clib_memcpy_fast (t->src, h1->src_address, 6);
+             clib_memcpy_fast (t->dst, h1->dst_address, 6);
+           }
+         if (b[2]->flags & VLIB_BUFFER_IS_TRACED)
+           {
+             l2learn_trace_t *t =
+               vlib_add_trace (vm, node, b[2], sizeof (*t));
+             t->sw_if_index = sw_if_index2;
+             t->bd_index = vnet_buffer (b[2])->l2.bd_index;
+             clib_memcpy_fast (t->src, h2->src_address, 6);
+             clib_memcpy_fast (t->dst, h2->dst_address, 6);
            }
+         if (b[3]->flags & VLIB_BUFFER_IS_TRACED)
+           {
+             l2learn_trace_t *t =
+               vlib_add_trace (vm, node, b[3], sizeof (*t));
+             t->sw_if_index = sw_if_index3;
+             t->bd_index = vnet_buffer (b[3])->l2.bd_index;
+             clib_memcpy_fast (t->src, h3->src_address, 6);
+             clib_memcpy_fast (t->dst, h3->dst_address, 6);
+           }
+       }
 
-         /* process 1 pkt */
-         vlib_node_increment_counter (vm, l2learn_node.index,
-                                      L2LEARN_ERROR_L2LEARN, 1);
+      /* process 4 pkts */
+      vlib_node_increment_counter (vm, l2learn_node.index,
+                                  L2LEARN_ERROR_L2LEARN, 4);
+
+      l2fib_lookup_4 (msm->mac_table, &cached_key, &cached_result,
+                     h0->src_address,
+                     h1->src_address,
+                     h2->src_address,
+                     h3->src_address,
+                     vnet_buffer (b[0])->l2.bd_index,
+                     vnet_buffer (b[1])->l2.bd_index,
+                     vnet_buffer (b[2])->l2.bd_index,
+                     vnet_buffer (b[3])->l2.bd_index,
+                     &key0, &key1, &key2, &key3,
+                     &result0, &result1, &result2, &result3);
+
+      l2learn_process (node, msm, &em->counters[node_counter_base_index],
+                      b[0], sw_if_index0, &key0, &cached_key,
+                      &count, &result0, next, timestamp);
+
+      l2learn_process (node, msm, &em->counters[node_counter_base_index],
+                      b[1], sw_if_index1, &key1, &cached_key,
+                      &count, &result1, next + 1, timestamp);
+
+      l2learn_process (node, msm, &em->counters[node_counter_base_index],
+                      b[2], sw_if_index2, &key2, &cached_key,
+                      &count, &result2, next + 2, timestamp);
+
+      l2learn_process (node, msm, &em->counters[node_counter_base_index],
+                      b[3], sw_if_index3, &key3, &cached_key,
+                      &count, &result3, next + 3, timestamp);
+
+      next += 4;
+      b += 4;
+      n_left -= 4;
+    }
 
+  while (n_left > 0)
+    {
+      u32 sw_if_index0;
+      ethernet_header_t *h0;
+      l2fib_entry_key_t key0;
+      l2fib_entry_result_t result0;
 
-         l2fib_lookup_1 (msm->mac_table, &cached_key, &cached_result,
-                         h0->src_address, vnet_buffer (b0)->l2.bd_index,
-                         &key0, &bucket0, &result0);
+      sw_if_index0 = vnet_buffer (b[0])->sw_if_index[VLIB_RX];
 
-         l2learn_process (node, msm, &em->counters[node_counter_base_index],
-                          b0, sw_if_index0, &key0, &cached_key,
-                          &bucket0, &result0, &next0, timestamp);
+      h0 = vlib_buffer_get_current (b[0]);
 
-         /* verify speculative enqueue, maybe switch current next frame */
-         vlib_validate_buffer_enqueue_x1 (vm, node, next_index,
-                                          to_next, n_left_to_next,
-                                          bi0, next0);
+      if (do_trace && PREDICT_FALSE (b[0]->flags & VLIB_BUFFER_IS_TRACED))
+       {
+         l2learn_trace_t *t = vlib_add_trace (vm, node, b[0], sizeof (*t));
+         t->sw_if_index = sw_if_index0;
+         t->bd_index = vnet_buffer (b[0])->l2.bd_index;
+         clib_memcpy_fast (t->src, h0->src_address, 6);
+         clib_memcpy_fast (t->dst, h0->dst_address, 6);
        }
 
-      vlib_put_next_frame (vm, node, next_index, n_left_to_next);
+      /* process 1 pkt */
+      vlib_node_increment_counter (vm, l2learn_node.index,
+                                  L2LEARN_ERROR_L2LEARN, 1);
+
+
+      l2fib_lookup_1 (msm->mac_table, &cached_key, &cached_result,
+                     h0->src_address, vnet_buffer (b[0])->l2.bd_index,
+                     &key0, &result0);
+
+      l2learn_process (node, msm, &em->counters[node_counter_base_index],
+                      b[0], sw_if_index0, &key0, &cached_key,
+                      &count, &result0, next, timestamp);
+
+      next += 1;
+      b += 1;
+      n_left -= 1;
     }
 
+  vlib_buffer_enqueue_to_next (vm, node, from, nexts, frame->n_vectors);
+
   return frame->n_vectors;
 }
 
-static uword
-l2learn_node_fn (vlib_main_t * vm,
-                vlib_node_runtime_t * node, vlib_frame_t * frame)
+VLIB_NODE_FN (l2learn_node) (vlib_main_t * vm,
+                            vlib_node_runtime_t * node, vlib_frame_t * frame)
 {
   if (PREDICT_FALSE ((node->flags & VLIB_NODE_FLAG_TRACE)))
     return l2learn_node_inline (vm, node, frame, 1 /* do_trace */ );
@@ -479,7 +428,6 @@ l2learn_node_fn (vlib_main_t * vm,
 
 /* *INDENT-OFF* */
 VLIB_REGISTER_NODE (l2learn_node,static) = {
-  .function = l2learn_node_fn,
   .name = "l2-learn",
   .vector_size = sizeof (u32),
   .format_trace = format_l2learn_trace,
@@ -498,8 +446,9 @@ VLIB_REGISTER_NODE (l2learn_node,static) = {
 };
 /* *INDENT-ON* */
 
-VLIB_NODE_FUNCTION_MULTIARCH (l2learn_node, l2learn_node_fn)
-     clib_error_t *l2learn_init (vlib_main_t * vm)
+#ifndef CLIB_MARCH_VARIANT
+clib_error_t *
+l2learn_init (vlib_main_t * vm)
 {
   l2learn_main_t *mp = &l2learn_main;
 
@@ -520,7 +469,7 @@ VLIB_NODE_FUNCTION_MULTIARCH (l2learn_node, l2learn_node_fn)
    * Set the default number of dynamically learned macs to the number
    * of buckets.
    */
-  mp->global_learn_limit = L2FIB_NUM_BUCKETS * 16;
+  mp->global_learn_limit = L2LEARN_DEFAULT_LIMIT;
 
   return 0;
 }
@@ -602,6 +551,8 @@ l2learn_config (vlib_main_t * vm, unformat_input_t * input)
 
 VLIB_CONFIG_FUNCTION (l2learn_config, "l2learn");
 
+#endif
+
 
 /*
  * fd.io coding-style-patch-verification: ON