tap: implement sw_interface_tap_v2_dump filtering by sw_if_index

[vpp.git] / test / vpp_devices.py

diff --git a/test/vpp_devices.py b/test/vpp_devices.py
index 7e18eca..9e272ca 100644 (file)
--- a/test/vpp_devices.py
+++ b/test/vpp_devices.py
@@ -14,16 +14,14 @@ class VppTAPInterface(VppInterface):
         self._mac_addr = mac_addr
 
     def get_vpp_dump(self):
-        dump = self._test.vapi.sw_interface_tap_v2_dump()
-        for entry in dump:
-            if entry.sw_if_index == self.sw_if_index:
-                return entry
+        dump = self._test.vapi.sw_interface_tap_v2_dump(
+            sw_if_index=self.sw_if_index)
+        return dump
 
     def add_vpp_config(self):
-        use_random_mac = True if self._mac_addr else False
         reply = self._test.vapi.tap_create_v2(
             id=self._tap_id,
-            use_random_mac=use_random_mac,
+            use_random_mac=bool(self._mac_addr),
             mac_address=self._mac_addr)
         self.set_sw_if_index(reply.sw_if_index)
         self._test.registry.register(self, self.test.logger)
@@ -33,9 +31,7 @@ class VppTAPInterface(VppInterface):
 
     def query_vpp_config(self):
         dump = self.get_vpp_dump()
-        if dump:
-            return True
-        return False
+        return bool(dump)
 
     def object_id(self):
         return "tap-%s" % self._tap_id