X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=blobdiff_plain;f=src%2Fvnet%2Fdevices%2Ftap%2Ftap.c;h=e17d01d88b1655faf98dcdd84e34a448c2ea9395;hp=a1cb69d2cf6be3ebe2b3158379037d112eba2ef1;hb=b49bc1ae6;hpb=ba0061feba13a11fc1c1af551bc4c26eccbd2f2c

diff --git a/src/vnet/devices/tap/tap.c b/src/vnet/devices/tap/tap.c
index a1cb69d2cf6..e17d01d88b1 100644
--- a/src/vnet/devices/tap/tap.c
+++ b/src/vnet/devices/tap/tap.c
@@ -91,6 +91,7 @@ tap_free (vlib_main_t * vm, virtio_if_t * vif)
 {
   virtio_main_t *mm = &virtio_main;
   tap_main_t *tm = &tap_main;
+  clib_error_t *err = 0;
   int i;
 
   /* *INDENT-OFF* */
@@ -102,6 +103,9 @@ tap_free (vlib_main_t * vm, virtio_if_t * vif)
     virtio_vring_free_tx (vm, vif, TX_QUEUE (i));
   /* *INDENT-ON* */
 
+  _IOCTL (vif->tap_fd, TUNSETPERSIST, (void *) (uintptr_t) 0);
+  tap_log_dbg (vif, "TUNSETPERSIST: unset");
+error:
   if (vif->tap_fd != -1)
     close (vif->tap_fd);
 
@@ -131,6 +135,7 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args)
   int i;
   int old_netns_fd = -1;
   struct ifreq ifr = {.ifr_flags = IFF_TAP | IFF_NO_PI | IFF_VNET_HDR };
+  struct ifreq get_ifr = {.ifr_flags = 0 };
   size_t hdrsz;
   struct vhost_memory *vhost_mem = 0;
   virtio_if_t *vif = 0;
@@ -170,10 +175,39 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args)
   vif->num_rxqs = args->num_rx_queues;
   num_q_pairs = clib_max (vif->num_rxqs, vif->num_txqs);
 
-  if (ethernet_mac_address_is_zero (args->host_mac_addr.bytes))
-    ethernet_mac_address_generate (args->host_mac_addr.bytes);
-  clib_memcpy (vif->host_mac_addr, args->host_mac_addr.bytes, 6);
-
+  if (args->tap_flags & TAP_FLAG_ATTACH)
+    {
+      if (args->host_if_name != NULL)
+	{
+	  host_if_name = (char *) args->host_if_name;
+	  clib_memcpy (ifr.ifr_name, host_if_name,
+		       clib_min (IFNAMSIZ, strlen (host_if_name)));
+	}
+      else
+	{
+	  args->rv = VNET_API_ERROR_NO_MATCHING_INTERFACE;
+	  err = clib_error_return (0, "host_if_name is not provided");
+	  goto error;
+	}
+      if (args->host_namespace)
+	{
+	  old_netns_fd = open ("/proc/self/ns/net", O_RDONLY);
+	  if ((nfd = open_netns_fd ((char *) args->host_namespace)) == -1)
+	    {
+	      args->rv = VNET_API_ERROR_SYSCALL_ERROR_2;
+	      args->error = clib_error_return_unix (0, "open_netns_fd '%s'",
+						    args->host_namespace);
+	      goto error;
+	    }
+	  if (setns (nfd, CLONE_NEWNET) == -1)
+	    {
+	      args->rv = VNET_API_ERROR_SYSCALL_ERROR_3;
+	      args->error = clib_error_return_unix (0, "setns '%s'",
+						    args->host_namespace);
+	      goto error;
+	    }
+	}
+    }
   if ((vif->tap_fd = tfd = open ("/dev/net/tun", O_RDWR | O_NONBLOCK)) < 0)
     {
       args->rv = VNET_API_ERROR_SYSCALL_ERROR_2;
@@ -235,6 +269,33 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args)
       goto error;
     }
 
+  /*
+   * unset the persistence when attaching to existing
+   * interface
+   */
+  if (args->tap_flags & TAP_FLAG_ATTACH)
+    {
+      _IOCTL (tfd, TUNSETPERSIST, (void *) (uintptr_t) 0);
+      tap_log_dbg (vif, "TUNSETPERSIST: unset");
+    }
+
+  /* set the persistence */
+  if (args->tap_flags & TAP_FLAG_PERSIST)
+    {
+      _IOCTL (tfd, TUNSETPERSIST, (void *) (uintptr_t) 1);
+      tap_log_dbg (vif, "TUNSETPERSIST: set");
+
+      /* verify persistence is set, read the flags */
+      _IOCTL (tfd, TUNGETIFF, (void *) &get_ifr);
+      tap_log_dbg (vif, "TUNGETIFF: flags 0x%lx", get_ifr.ifr_flags);
+      if ((get_ifr.ifr_flags & IFF_PERSIST) == 0)
+	{
+	  args->rv = VNET_API_ERROR_SYSCALL_ERROR_2;
+	  args->error = clib_error_return (0, "persistence not supported");
+	  goto error;
+	}
+    }
+
   tap_log_dbg (vif, "TUNSETVNETHDRSZ: fd %d vnet_hdr_sz %u", tfd, hdrsz);
   _IOCTL (tfd, TUNSETVNETHDRSZ, &hdrsz);
 
@@ -245,13 +306,6 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args)
   tap_log_dbg (vif, "TUNSETOFFLOAD: fd %d offload 0x%lx", tfd, offload);
   _IOCTL (tfd, TUNSETOFFLOAD, offload);
 
-  clib_memset (&ifr, 0, sizeof (ifr));
-  ifr.ifr_addr.sa_family = ARPHRD_ETHER;
-  clib_memcpy (ifr.ifr_hwaddr.sa_data, vif->host_mac_addr, 6);
-  tap_log_dbg (vif, "SIOCSIFHWADDR: fd %d hwaddr %U", tfd,
-	       format_hex_bytes, ifr.ifr_hwaddr.sa_data, 6);
-  _IOCTL (tfd, SIOCSIFHWADDR, (void *) &ifr);
-
   /* open vhost-net fd for each queue pair and set ownership */
   for (i = 0; i < num_q_pairs; i++)
     {
@@ -302,46 +356,46 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args)
 
   virtio_set_net_hdr_size (vif);
 
-  /* if namespace is specified, all further netlink messages should be executed
-     after we change our net namespace */
-  if (args->host_namespace)
+  if (!(args->tap_flags & TAP_FLAG_ATTACH))
     {
-      old_netns_fd = open ("/proc/self/ns/net", O_RDONLY);
-      if ((nfd = open_netns_fd ((char *) args->host_namespace)) == -1)
-	{
-	  args->rv = VNET_API_ERROR_SYSCALL_ERROR_2;
-	  args->error = clib_error_return_unix (0, "open_netns_fd '%s'",
-						args->host_namespace);
-	  goto error;
-	}
-      args->error = vnet_netlink_set_link_netns (vif->ifindex, nfd,
-						 host_if_name);
-      if (args->error)
+      /* if namespace is specified, all further netlink messages should be executed
+         after we change our net namespace */
+      if (args->host_namespace)
 	{
-	  args->rv = VNET_API_ERROR_NETLINK_ERROR;
-	  goto error;
-	}
-      if (setns (nfd, CLONE_NEWNET) == -1)
-	{
-	  args->rv = VNET_API_ERROR_SYSCALL_ERROR_3;
-	  args->error = clib_error_return_unix (0, "setns '%s'",
-						args->host_namespace);
-	  goto error;
-	}
-      if ((vif->ifindex = if_nametoindex (host_if_name)) == 0)
-	{
-	  args->rv = VNET_API_ERROR_SYSCALL_ERROR_3;
-	  args->error = clib_error_return_unix (0, "if_nametoindex '%s'",
-						host_if_name);
-	  goto error;
+	  old_netns_fd = open ("/proc/self/ns/net", O_RDONLY);
+	  if ((nfd = open_netns_fd ((char *) args->host_namespace)) == -1)
+	    {
+	      args->rv = VNET_API_ERROR_SYSCALL_ERROR_2;
+	      args->error = clib_error_return_unix (0, "open_netns_fd '%s'",
+						    args->host_namespace);
+	      goto error;
+	    }
+	  args->error = vnet_netlink_set_link_netns (vif->ifindex, nfd,
+						     host_if_name);
+	  if (args->error)
+	    {
+	      args->rv = VNET_API_ERROR_NETLINK_ERROR;
+	      goto error;
+	    }
+	  if (setns (nfd, CLONE_NEWNET) == -1)
+	    {
+	      args->rv = VNET_API_ERROR_SYSCALL_ERROR_3;
+	      args->error = clib_error_return_unix (0, "setns '%s'",
+						    args->host_namespace);
+	      goto error;
+	    }
+	  if ((vif->ifindex = if_nametoindex (host_if_name)) == 0)
+	    {
+	      args->rv = VNET_API_ERROR_SYSCALL_ERROR_3;
+	      args->error = clib_error_return_unix (0, "if_nametoindex '%s'",
+						    host_if_name);
+	      goto error;
+	    }
 	}
-    }
-  else
-    {
-      if (host_if_name)
+      else if (host_if_name)
 	{
-	  args->error = vnet_netlink_set_link_name (vif->ifindex,
-						    host_if_name);
+	  args->error =
+	    vnet_netlink_set_link_name (vif->ifindex, host_if_name);
 	  if (args->error)
 	    {
 	      args->rv = VNET_API_ERROR_NETLINK_ERROR;
@@ -350,15 +404,14 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args)
 	}
     }
 
-  if (!ethernet_mac_address_is_zero (args->host_mac_addr.bytes))
+  if (ethernet_mac_address_is_zero (args->host_mac_addr.bytes))
+    ethernet_mac_address_generate (args->host_mac_addr.bytes);
+  args->error = vnet_netlink_set_link_addr (vif->ifindex,
+					    args->host_mac_addr.bytes);
+  if (args->error)
     {
-      args->error = vnet_netlink_set_link_addr (vif->ifindex,
-						args->host_mac_addr.bytes);
-      if (args->error)
-	{
-	  args->rv = VNET_API_ERROR_NETLINK_ERROR;
-	  goto error;
-	}
+      args->rv = VNET_API_ERROR_NETLINK_ERROR;
+      goto error;
     }
 
   if (args->host_bridge)
@@ -423,18 +476,6 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args)
 	}
     }
 
-  /* switch back to old net namespace */
-  if (args->host_namespace)
-    {
-      if (setns (old_netns_fd, CLONE_NEWNET) == -1)
-	{
-	  args->rv = VNET_API_ERROR_SYSCALL_ERROR_2;
-	  args->error = clib_error_return_unix (0, "setns '%s'",
-						args->host_namespace);
-	  goto error;
-	}
-    }
-
   if (args->host_mtu_set)
     {
       args->error =
@@ -458,6 +499,18 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args)
       args->host_mtu_size = tm->host_mtu_size;
     }
 
+  /* switch back to old net namespace */
+  if (args->host_namespace)
+    {
+      if (setns (old_netns_fd, CLONE_NEWNET) == -1)
+	{
+	  args->rv = VNET_API_ERROR_SYSCALL_ERROR_2;
+	  args->error = clib_error_return_unix (0, "setns '%s'",
+						args->host_namespace);
+	  goto error;
+	}
+    }
+
   for (i = 0; i < num_q_pairs; i++)
     {
       if (i < vif->num_rxqs && (args->error =
@@ -633,6 +686,7 @@ error:
       args->rv = VNET_API_ERROR_SYSCALL_ERROR_3;
     }
 
+  tap_log_err (vif, "%U", format_clib_error, args->error);
   tap_free (vm, vif);
 done:
   if (vhost_mem)