bfd: fix buffer leak when cannot send periodic packets 97/39997/2
authorAlexander Chernavin <achernavin@netgate.com>
Thu, 23 Nov 2023 11:36:09 +0000 (11:36 +0000)
committerMatthew Smith <mgsmith@netgate.com>
Mon, 27 Nov 2023 18:53:43 +0000 (18:53 +0000)
commit1f4023d55d7a9c777465d24065e91fc076602fb0
tree413836dd691b4fac95f0bbd7575bc5125e5567f3
parenta2be1cffbea8a41bb9cdfdfbfa4c530f345b16a9
bfd: fix buffer leak when cannot send periodic packets

When a periodic BFD packet cannot be sent because the interface is
disabled, the allocated buffer needs to be freed. This currently will
occur for IPv4 sessions. However, buffers will leak for IPv6 sessions as
in this case, bfd_transport_control_frame() and bfd_transport_udp6()
will not indicate failure.

With this fix, stop always returning success in bfd_transport_udp6() and
start returning the actual return value.

Type: fix
Change-Id: I5fa4d9206e32cccae3053ef24966d80e2022fc81
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
src/vnet/bfd/bfd_udp.c