VPP-74 Fix signedness issue when terminal resizes 04/1204/1
authorChris Luke <chrisy@flirble.org>
Thu, 19 May 2016 18:23:25 +0000 (14:23 -0400)
committerChris Luke <chrisy@flirble.org>
Thu, 19 May 2016 18:35:03 +0000 (14:35 -0400)
commit270b6dee8c1f7686ee4c13d55d3aa2cd6c788c3f
tree8e24522b7b6bad16ba791fcd76eb98e86a901aed
parentfd9014a1846d832dfa91e0a7b3495d7954863f5d
VPP-74 Fix signedness issue when terminal resizes

When re-locating our current viewport into the pager buffer we need to
verify that the new viewport is within the boundaries of the index.
This condition is considered very rare, but nontheless the check is needed.

Unfortunately I assumed the variable was signed; it is not, and the
subtraction can in some cases cause the value to be negative. This is
therefore a bonafide semantic error that may cause problems.

This patch reworks the logic to avoid having to change it to be signed.

Change-Id: I26f0747d38dcc43dd9c092d50f2489b122009e7b
Signed-off-by: Chris Luke <chrisy@flirble.org>
vlib/vlib/unix/cli.c