svm_fifo rework to avoid contention on cursize 23/18223/13
authorSirshak Das <sirshak.das@arm.com>
Tue, 5 Feb 2019 07:33:33 +0000 (01:33 -0600)
committerFlorin Coras <florin.coras@gmail.com>
Tue, 16 Apr 2019 19:33:21 +0000 (19:33 +0000)
commit28aa539f7da7b172d0f35ea9a63f3986939477f7
treebe856eb44878b604b2fc93beffb7268db77b457b
parent39d04099467414175803273433c95a96c0276252
svm_fifo rework to avoid contention on cursize

Problems Addressed:
- Contention of cursize by producer and consumer.
- Reduce the no of modulo operations.

Changes:
- Synchronization between producer and consumer changed from cursize
  to head and tail indexes
  Implications: reduces the usable size of fifo by 1.
- Using weaker memory ordering C++11 atomics to access head and tail
  based on producer and consumer role.
- Head and tail indexes are unsigned 32 bit integers. Additions and
  subtraction on them are implicit 32 bit Modulo operation.
- Adding weaker memory ordering variants of max_enq, max_deq, is_empty
  and is_full Using them appropriately in all places.

Perfomance improvement (iperf3 via Hoststack):

iperf3 Server: Marvell ThunderX2(AArch64) - iperf3 Client: Skylake(x86)
   ~6%(256 rxd/txd) - ~11%(2048 rxd/txd)

Change-Id: I1d484e000e437430fdd5a819657d1c6b62443018
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
22 files changed:
src/plugins/tlsmbedtls/tls_mbedtls.c
src/plugins/tlsopenssl/tls_openssl.c
src/plugins/unittest/tcp_test.c
src/svm/svm_fifo.c
src/svm/svm_fifo.h
src/svm/svm_fifo_segment.c
src/tests/vnet/session/tcp_echo.c
src/tests/vnet/session/udp_echo.c
src/vcl/vcl_private.c
src/vcl/vppcom.c
src/vnet/session-apps/echo_client.c
src/vnet/session-apps/echo_server.c
src/vnet/session-apps/http_server.c
src/vnet/session-apps/proxy.c
src/vnet/session/application_interface.h
src/vnet/session/application_worker.c
src/vnet/session/session.c
src/vnet/session/session.h
src/vnet/session/session_node.c
src/vnet/tcp/tcp_input.c
src/vnet/udp/udp_input.c
src/vppinfra/atomics.h