Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 48ac1c2) | patch
fib: refresh adj pointer after fib_walk_sync due to possible realloc 79/24679/2
authorSteven Luong <sluong@cisco.com>
Thu, 30 Jan 2020 17:11:18 +0000 (09:11 -0800)
committerNeale Ranns <nranns@cisco.com>
Mon, 3 Feb 2020 10:45:37 +0000 (10:45 +0000)
commit3d5f6229bccf77fcf7e0e17ab4f1b361fedd1b2b
tree4a9c6352c07fd6bcf3433208e579388f774e3c02tree | snapshot
parent48ac1c2b2e973814d0ea991dddc9602c406acb10commit | diff
fib: refresh adj pointer after fib_walk_sync due to possible realloc

fib_walk_sync may call adj_alloc which may cause adj_pool to expand. When
that happens, any previous frame which still use the old adj pointer needs to
refresh. Failure to do so may access or update to the old adj memory
unintentionally and crash mysteriously.

Type: fix
Ticket: VPPSUPP-54

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I173dec4c5ce81c6e26c4fe011b894a7345901b24
src/vnet/adj/adj_nbr.c diff | blob | history
src/vnet/ip-neighbor/ip_neighbor.c diff | blob | history
Vector Packet Processing