misc: fix coverity warnings 14/25214/3
authorDave Barach <dave@barachs.net>
Mon, 17 Feb 2020 14:13:26 +0000 (09:13 -0500)
committerFlorin Coras <florin.coras@gmail.com>
Mon, 17 Feb 2020 17:18:18 +0000 (17:18 +0000)
commit47d41ad62c5d6008e72d2e9c137cf8f49ca86353
treea21f871a26f97c6a47fbfbae4b4d67f27c6036f5
parenta316744bc5e003d0fa4c8aff82c619b300115f02
misc: fix coverity warnings

Add an ALWAYS_ASSERT (...) macro, to (a) shut up coverity, and (b)
check the indicated condition in production images.

As in:
 p = hash_get(...);
 ALWAYS_ASSERT(p) /* was ASSERT(p) */
 elt = pool_elt_at_index(pool, p[0]);

This may not be the best way to handle a specific case, but failure to
check return values at all followed by e.g. a pointer dereference
isn't ok.

Type: fix
Ticket: VPP-1837
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ia97c641cefcfb7ea7d77ea5a55ed4afea0345acb
src/plugins/gtpu/gtpu.c
src/vnet/dpo/load_balance_map.c
src/vnet/fib/fib_attached_export.c
src/vnet/geneve/encap.c
src/vnet/geneve/geneve.c
src/vnet/ipsec/ipsec_output.c
src/vnet/session/application_worker.c
src/vnet/vxlan-gbp/vxlan_gbp.c
src/vnet/vxlan-gpe/vxlan_gpe.c
src/vnet/vxlan/vxlan.c
src/vppinfra/error_bootstrap.h