Refactor fragile msg macro W and W2 to not burry return control flow. 86/4986/4
authorJon Loeliger <jdl@netgate.com>
Wed, 1 Feb 2017 18:31:41 +0000 (12:31 -0600)
committerDave Barach <openvpp@barachs.net>
Thu, 2 Feb 2017 17:32:27 +0000 (17:32 +0000)
commit56c7b01e163c233030359781d7e60f4553e90c51
tree6d6ce1f179fdbfa2c2919ac082984fd0bf426f7f
parent1f9191f6efa5f2e0284c194f920093201b27ef81
Refactor fragile msg macro W and W2 to not burry return control flow.

Instead, have them accept and assign a return paramter leaving
the return control flow up to the caller.  Clean up otherwise
misleading returns present even after "NOT REACHED" comments.

Change-Id: I0861921f73ab65d55b95eabd27514f0129152723
Signed-off-by: Jon Loeliger <jdl@netgate.com>
13 files changed:
build-root/emacs-lisp/plugin-test-skel.el
src/examples/sample-plugin/sample/sample_test.c
src/plugins/acl/acl_test.c
src/plugins/flowperpkt/flowperpkt_test.c
src/plugins/ioam/export-vxlan-gpe/vxlan_gpe_ioam_export_test.c
src/plugins/ioam/export/ioam_export_test.c
src/plugins/ioam/lib-pot/pot_test.c
src/plugins/ioam/lib-trace/trace_test.c
src/plugins/ioam/lib-vxlan-gpe/vxlan_gpe_test.c
src/plugins/lb/lb_test.c
src/plugins/snat/snat_test.c
src/vat/api_format.c
src/vlibapi/vat_helper_macros.h