Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 5fa4525) | patch
ip-neighbor: fix ip6_ra_cmd 63/25463/4
authorDave Barach <dave@barachs.net>
Wed, 26 Feb 2020 13:02:58 +0000 (08:02 -0500)
committerFlorin Coras <florin.coras@gmail.com>
Wed, 26 Feb 2020 20:05:57 +0000 (20:05 +0000)
commit7249b90ab21c20138907e692dcb6032aea9e2f0f
treeedc02cf0532e55cf93117ef92da5aaba5271e02etree | snapshot
parent5fa4525543b212dd04b4f687722bf7feb1eeb6f9commit | diff
ip-neighbor: fix ip6_ra_cmd

The option parsing loop had "break" statements included in each
'if (unformat (line_input, "this-option ...") option_values=xxx;'
statement.

Result: the code would silently ignore all but the first
option. Probably broken forever, not easy to spot because the code
looks OK even though it's badly broken.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I667bee85b4ca654b53fb3af421f957957ed0f0f8
src/vnet/ip6-nd/ip6_ra.c diff | blob | history
Vector Packet Processing