Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 4555bb4) | patch
VPP-1337: Dangling reference be gone! 13/13413/1
authorDave Barach <dave@barachs.net>
Wed, 11 Jul 2018 00:22:43 +0000 (20:22 -0400)
committerDave Barach <dave@barachs.net>
Wed, 11 Jul 2018 00:24:42 +0000 (20:24 -0400)
commitc1dccc5c1195acc037a3d8816098b9bd47881d01
treea0372013499332facc64ff4068ffc249834cebb1tree | snapshot
parent4555bb4ffa750ff5c50f030851fb21881ce285bbcommit | diff
VPP-1337: Dangling reference be gone!

Freeing the prefix and address vectors after signalling them from
dhcpv6_client_node_fn to either the pd or iana report processes is
absolutely wrong. The code has appeared to work by luck.

This took three full days' worth of expert effort to root cause - in
the context of an unrelated patch - and about one minute to fix.

Change-Id: Ie589ab1a70ae83441ab4e8b6618a6d405741f53f
Signed-off-by: Dave Barach <dave@barachs.net>
src/vnet/dhcp/dhcp6_client_common_dp.c diff | blob | history
src/vnet/dhcp/dhcp6_ia_na_client_dp.c diff | blob | history
src/vnet/dhcp/dhcp6_pd_client_dp.c diff | blob | history
Vector Packet Processing