vppinfra: fix sparse_vec_index() returning non-zero index for some nonexistent elements 79/18579/6
authorAndrew Yourtchenko <ayourtch@gmail.com>
Thu, 28 Mar 2019 19:36:56 +0000 (20:36 +0100)
committerDamjan Marion <dmarion@me.com>
Tue, 2 Apr 2019 06:54:43 +0000 (06:54 +0000)
commitd1a12ef820608516d6b9f76fe0e4ad8c7a04629c
treec25cf10827836a6ce6dbc074d5c644e602a7694f
parenta4b10e5e86bac8464253beb14c1c57b120b57a09
vppinfra: fix sparse_vec_index() returning non-zero index for some nonexistent elements

If we are testing for an index whose membership bitmask happens to sit in LSB of uword,
and there is nothing else set in that uword in the member bitmask, the shortcut path
returning the valid index is taken even if the element with a given index doesn't
exist in the sparse vector. This happens because the count of leading zeroes on the
value of 0 is zero, which is equal to the value taken modulo bitsize uword.

Take care of that case.

Also add unittests showing the problem and verifying that sparse_vec_index2 does not
have the same issue.

Change-Id: I19117e13817c3e5de579b9250bb741de42491985
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
src/plugins/unittest/CMakeLists.txt
src/plugins/unittest/sparse_vec_test.c [new file with mode: 0644]
src/vppinfra/sparse_vec.h
test/test_sparse_vec.py [new file with mode: 0644]