Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 09cdea6) | patch
wireguard: prevent stacksmashing on poorly formed base64 keys 43/35343/2
authorJon Loeliger <jdl@netgate.com>
Wed, 16 Feb 2022 16:52:56 +0000 (10:52 -0600)
committerMatthew Smith <mgsmith@netgate.com>
Tue, 22 Feb 2022 18:21:41 +0000 (18:21 +0000)
commitd9d77076b01347dfc1dd98cee80a298729ce9b85
tree00da8a595d601f14a0c9763472a22371b658772etree | snapshot
parent09cdea643aa181d833df15b8c96c3a812320761acommit | diff
wireguard: prevent stacksmashing on poorly formed base64 keys

Integer math on 32 bytes of base64 data might yield 33 bytes
of data in some poorly formed user input of private key values.
Rather than smashing the stack (detected) and aborting, simply
allow for the possible yet irrelevant 33-rd byte of data.

Type: fix
Fixes: edca1325cf296bd0f5ff422fc12de2ce7a7bad88
Change-Id: I42acfbf3e8fbb3d517e21c53d4f80459d4800e9d
Signed-off-by: Jon Loeliger <jdl@netgate.com>
src/plugins/wireguard/wireguard_cli.c diff | blob | history
Vector Packet Processing