fib: FIB crash removing labelled route (VPP-1818) 36/24436/2
authorNeale Ranns <nranns@cisco.com>
Mon, 20 Jan 2020 02:28:00 +0000 (02:28 +0000)
committerNeale Ranns <nranns@cisco.com>
Wed, 22 Jan 2020 21:04:58 +0000 (21:04 +0000)
commitda5dedfe33ca3cafb4cd6d90d34219d31cf69acb
tree78b9e094e862e348c1ba3fa26683898b6dc2759f
parentc0c4eec3bc309bcc656eade82f17754875f9ed7c
fib: FIB crash removing labelled route (VPP-1818)

Type: fix

The crash occured trying to retreive a NULL path list to walk the path
extensions. A walk shoul not be required, because there should be no
extensins, since all paths are removed. The problem is that when the
paths were added, they were not sorted, hence neither were the
extensions and when they were updated, duplicate extensions were added,
and hence a path removal did not remove them all.
Fix is to make sure paths are sorted.

Change-Id: I069d937de8e7bc8aae3d92f588db4daff727d863
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 257749c40946a9269140d322e374d74c3b6eefb8)
src/vnet/fib/fib_table.c