Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 7ec120e) | patch
api: mark api_trace_command_fn thread-safe 93/24493/1
authorDave Barach <dave@barachs.net>
Thu, 23 Jan 2020 13:44:40 +0000 (08:44 -0500)
committerDave Barach <dave@barachs.net>
Thu, 23 Jan 2020 13:55:43 +0000 (08:55 -0500)
commitf66f88383848565f65db3029b4c4fbfc424906e1
tree7f0261c7f425c78f543de7a1624864231667d07dtree | snapshot
parent7ec120e8dd8ab366fab27eca4e6402f213e24cc8commit | diff
api: mark api_trace_command_fn thread-safe

Binary API trace replay with multiple worker threads depends in many
cases on worker thread graph replica maintenance. If we (implicitly)
assert a worker thread barrier at the debug CLI level, all graph
replica changes are deferred until the replay operation completes. If
an interface is deleted, the wheels may fall off.

Type: fix
Ticket: VPP-1824

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9b07d43f8501caa5519e5ff9ae4c19dc2661cc84
src/vlibmemory/vlib_api_cli.c diff | blob | history
Vector Packet Processing