Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 40a5da8) | patch
tcp: terminate options with nops 88/30488/3
authorFlorin Coras <fcoras@cisco.com>
Fri, 18 Dec 2020 21:30:45 +0000 (13:30 -0800)
committerFlorin Coras <florin.coras@gmail.com>
Mon, 21 Dec 2020 15:16:57 +0000 (15:16 +0000)
commitf9e500e81698bbe7f78f65792e934ad6a16fa602
tree357b837bbe95385b17938eb05ecfde02a9aa0b72tree | snapshot
parent40a5da8e96a910287001e9db119d1f0134fc9fb8commit | diff
tcp: terminate options with nops

On the one hand, make sure options are terminated with NOPs to avoid
issues with clients that can't parse options that don't end on an u32
boundary. On the other, make sure the padding is rfc compliant. If
options end with EOL the padding should be zeros. The current change
does not use EOL so the padding is NOPs.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I608056707ef9658ca90b9c095e84a0689d8000d7
src/vnet/tcp/tcp_packet.h diff | blob | history
Vector Packet Processing