api: improve api string safety 48/24848/10
authorJakub Grajciar <jgrajcia@cisco.com>
Fri, 7 Feb 2020 10:30:26 +0000 (11:30 +0100)
committerOle Trøan <otroan@employees.org>
Wed, 26 Feb 2020 08:51:03 +0000 (08:51 +0000)
commit2dbee9361e74d03727a8b618ba80a5e28c006011
tree443b6c39e99e0e46b62ef0dfd002e31bb1fa7665
parent8e755a16a71c55555f12381c8a12e22ae7138536
api: improve api string safety

- Remove vl_api_from_api_string
  to prevent use of not nul-terminated strings.
- Rename vl_api_from_api_to_vec -> vl_api_from_api_to_new_vec
  to imply a new vector is created. NOT nul terminated.
- Add vl_api_from_api_to_new_c_string. Returns
  nul terminated string in a new vector.
- Add vl_api_c_string_to_api_string. Convert nul terminated
  string to vl_api_string_t
- Add vl_api_vec_to_api_string. Convert NON nul terminated
  vector to vl_api_string_t

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Iadd59b612c0d960a34ad0dd07a9d17f56435c6ea
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
15 files changed:
src/plugins/http_static/http_static_test.c
src/plugins/ioam/lib-pot/pot_api.c
src/plugins/ioam/lib-pot/pot_test.c
src/plugins/memif/memif_test.c
src/tools/vppapigen/vppapigen_c.py
src/vat/api_format.c
src/vlibapi/api_shared.c
src/vlibapi/api_types.h
src/vnet/devices/tap/tapv2_api.c
src/vnet/interface_api.c
src/vnet/ip/punt_api.c
src/vpp/api/api.c
src/vpp/api/custom_dump.c
test/ext/vapi_c_test.c
test/test_punt.py