From: Dave Barach <dave@barachs.net>
Date: Mon, 6 Apr 2020 14:19:18 +0000 (-0400)
Subject: vat: fix static analysis warning
X-Git-Tag: v20.09-rc0~268
X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff_plain;h=032a5e3da0f4350390d97d6011160fe0d34a8d6e

vat: fix static analysis warning

Type: fix
Ticket: VPP-1837

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ia46f865082dcf0cf06af99a7c958c4a5b02193ce
---

diff --git a/src/vat/json_format.h b/src/vat/json_format.h
index 154fb3df04b..d2fab9020b3 100644
--- a/src/vat/json_format.h
+++ b/src/vat/json_format.h
@@ -93,8 +93,9 @@ static_always_inline void
 vat_json_set_string_copy (vat_json_node_t * json, const u8 * str)
 {
   u8 *ns = NULL;
-  vec_validate (ns, strlen ((const char *) str));
-  strcpy ((char *) ns, (const char *) str);
+  int len = strlen ((const char *) str);
+  vec_validate (ns, len);
+  strncpy ((char *) ns, (const char *) str, len + 1);
   vec_add1 (ns, '\0');
   vat_json_set_string (json, ns);
 }