From: Dave Barach <dave@barachs.net>
Date: Wed, 12 Feb 2020 19:42:57 +0000 (-0500)
Subject: classify: fix "show classify filter" debug CLI
X-Git-Tag: v20.09-rc0~603
X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff_plain;h=104112f2d412a4576b5e0d3bbb20665d2b5bd615

classify: fix "show classify filter" debug CLI

Null pointer bug, memory leak. D'oh!

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ic2865757ed9cbb7f48d23c7c30b64299eb5f6674
---

diff --git a/src/vnet/classify/vnet_classify.c b/src/vnet/classify/vnet_classify.c
index 165d4fc0316..bf030241f68 100755
--- a/src/vnet/classify/vnet_classify.c
+++ b/src/vnet/classify/vnet_classify.c
@@ -2065,7 +2065,6 @@ show_classify_filter_command_fn (vlib_main_t * vm,
 
       if (verbose)
 	{
-	  u8 *s = 0;
 	  u32 table_index;
 
 	  for (j = 0; j < vec_len (set->table_indices); j++)
@@ -2082,8 +2081,7 @@ show_classify_filter_command_fn (vlib_main_t * vm,
 	}
       else
 	{
-	  u8 *s = 0;
-	  table_index = set->table_indices[0];
+	  table_index = set->table_indices ? set->table_indices[0] : ~0;
 
 	  if (table_index != ~0)
 	    s = format (s, " %u", table_index);