From: Neale Ranns <nranns@cisco.com>
Date: Tue, 20 Nov 2018 17:06:25 +0000 (-0800)
Subject: IPSEC: remove duplicate memcy
X-Git-Tag: v19.04-rc0~368
X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff_plain;h=3553abaec54c2784bc6fdccc890411d586c3997e

IPSEC: remove duplicate memcy

Change-Id: If91257fa23ba74c09e5c3b5528eb2fd4c4b36b6a
Signed-off-by: Neale Ranns <nranns@cisco.com>
---

diff --git a/src/vnet/ipsec/ipsec.c b/src/vnet/ipsec/ipsec.c
index 8ebc57956bb..bb62560cccf 100644
--- a/src/vnet/ipsec/ipsec.c
+++ b/src/vnet/ipsec/ipsec.c
@@ -195,14 +195,12 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
 	  if (policy->is_ipv6)
 	    {
 	      vec_add1 (spd->ipv6_outbound_policies, policy_index);
-	      clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
 	      vec_sort_with_function (spd->ipv6_outbound_policies,
 				      ipsec_spd_entry_sort);
 	    }
 	  else
 	    {
 	      vec_add1 (spd->ipv4_outbound_policies, policy_index);
-	      clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
 	      vec_sort_with_function (spd->ipv4_outbound_policies,
 				      ipsec_spd_entry_sort);
 	    }
@@ -215,7 +213,6 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
 		{
 		  vec_add1 (spd->ipv6_inbound_protect_policy_indices,
 			    policy_index);
-		  clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
 		  vec_sort_with_function
 		    (spd->ipv6_inbound_protect_policy_indices,
 		     ipsec_spd_entry_sort);
@@ -225,7 +222,6 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
 		  vec_add1
 		    (spd->ipv6_inbound_policy_discard_and_bypass_indices,
 		     policy_index);
-		  clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
 		  vec_sort_with_function
 		    (spd->ipv6_inbound_policy_discard_and_bypass_indices,
 		     ipsec_spd_entry_sort);
@@ -237,7 +233,6 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
 		{
 		  vec_add1 (spd->ipv4_inbound_protect_policy_indices,
 			    policy_index);
-		  clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
 		  vec_sort_with_function
 		    (spd->ipv4_inbound_protect_policy_indices,
 		     ipsec_spd_entry_sort);
@@ -247,7 +242,6 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
 		  vec_add1
 		    (spd->ipv4_inbound_policy_discard_and_bypass_indices,
 		     policy_index);
-		  clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
 		  vec_sort_with_function
 		    (spd->ipv4_inbound_policy_discard_and_bypass_indices,
 		     ipsec_spd_entry_sort);