From: Florin Coras <fcoras@cisco.com>
Date: Fri, 7 Dec 2018 02:24:19 +0000 (-0800)
Subject: tcp: improve check for invalid sack blocks
X-Git-Tag: v19.04-rc0~206
X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff_plain;h=ab86f86e7c29393fa1da81b5f86296bd5fcb7420

tcp: improve check for invalid sack blocks

Change-Id: Ic6a6202a2d5aca33eee7fc6ff8eeaa1db9b58525
Signed-off-by: Florin Coras <fcoras@cisco.com>
---

diff --git a/src/vnet/tcp/tcp_input.c b/src/vnet/tcp/tcp_input.c
index 0e915505d37..dff18029155 100644
--- a/src/vnet/tcp/tcp_input.c
+++ b/src/vnet/tcp/tcp_input.c
@@ -905,7 +905,9 @@ tcp_rcv_sacks (tcp_connection_t * tc, u32 ack)
     {
       if (seq_lt (blk->start, blk->end)
 	  && seq_gt (blk->start, tc->snd_una)
-	  && seq_gt (blk->start, ack) && seq_leq (blk->end, tc->snd_una_max))
+	  && seq_gt (blk->start, ack)
+	  && seq_lt (blk->start, tc->snd_una_max)
+	  && seq_leq (blk->end, tc->snd_una_max))
 	{
 	  blk++;
 	  continue;