From: Matthew Smith Date: Tue, 3 Dec 2019 18:41:53 +0000 (-0600) Subject: ip: populate ip_reassembly_get_reply correctly X-Git-Tag: v20.05-rc0~279 X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff_plain;h=b3174dfe8f62168d9f279ef1267b876e2b35d807 ip: populate ip_reassembly_get_reply correctly Type: fix Fixes: de34c35fc The API handler for requests to retrieve IP reassembly settings was modified to support shallow virtual reassembly. It retrieves settings into local variables now instead of directly into the reply message. The fields in the reply message were not being populated using those variables. So the reply message was being sent with all 0's, except in the is_ip6 field. Also, the max_reassembly length field in the reply message was not being populated. Change-Id: I80b071340fdc190c3a0b1f7294a03f14b6e00ecc Signed-off-by: Matthew Smith --- diff --git a/src/vnet/ip/ip_api.c b/src/vnet/ip/ip_api.c index 0f9e3709643..3440c657502 100644 --- a/src/vnet/ip/ip_api.c +++ b/src/vnet/ip/ip_api.c @@ -2795,10 +2795,11 @@ vl_api_ip_reassembly_get_t_handler (vl_api_ip_reassembly_get_t * mp) } break; } - rmp->timeout_ms = clib_host_to_net_u32 (rmp->timeout_ms); - rmp->max_reassemblies = clib_host_to_net_u32 (rmp->max_reassemblies); + rmp->timeout_ms = clib_host_to_net_u32 (timeout_ms); + rmp->max_reassemblies = clib_host_to_net_u32 (max_reassemblies); + rmp->max_reassembly_length = clib_host_to_net_u32 (max_reassembly_length); rmp->expire_walk_interval_ms = - clib_host_to_net_u32 (rmp->expire_walk_interval_ms); + clib_host_to_net_u32 (expire_walk_interval_ms); vl_api_send_msg (rp, (u8 *) rmp); }