From: Florin Coras <fcoras@cisco.com>
Date: Fri, 10 Apr 2020 02:01:51 +0000 (+0000)
Subject: udp: fix local node no port error counter
X-Git-Tag: v20.09-rc0~227
X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff_plain;h=bc1a1a7347d689aa7043d4d7f15a7db657230216

udp: fix local node no port error counter

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie0c5a86aedfa38fdcbb835aee7c9e91d59b222d6
---

diff --git a/src/vnet/udp/udp_local.c b/src/vnet/udp/udp_local.c
index 748ad73bddb..1451cc3a0ad 100644
--- a/src/vnet/udp/udp_local.c
+++ b/src/vnet/udp/udp_local.c
@@ -61,7 +61,6 @@ udp46_local_inline (vlib_main_t * vm,
 {
   udp_main_t *um = &udp_main;
   __attribute__ ((unused)) u32 n_left_from, next_index, *from, *to_next;
-  word n_no_listener = 0;
   u8 punt_unknown = is_ip4 ? um->punt_unknown4 : um->punt_unknown6;
   u16 *next_by_dst_port = (is_ip4 ?
 			   um->next_by_dst_port4 : um->next_by_dst_port6);
@@ -187,8 +186,8 @@ udp46_local_inline (vlib_main_t * vm,
 					       ICMP4_destination_unreachable,
 					       ICMP4_destination_unreachable_port_unreachable,
 					       0);
+		  b0->error = node->errors[UDP_ERROR_NO_LISTENER];
 		  next0 = UDP_LOCAL_NEXT_ICMP;
-		  n_no_listener++;
 		}
 	      else
 		{
@@ -196,8 +195,8 @@ udp46_local_inline (vlib_main_t * vm,
 					       ICMP6_destination_unreachable,
 					       ICMP6_destination_unreachable_port_unreachable,
 					       0);
+		  b0->error = node->errors[UDP_ERROR_NO_LISTENER];
 		  next0 = UDP_LOCAL_NEXT_ICMP;
-		  n_no_listener++;
 		}
 	    }
 	  else
@@ -225,8 +224,8 @@ udp46_local_inline (vlib_main_t * vm,
 					       ICMP4_destination_unreachable,
 					       ICMP4_destination_unreachable_port_unreachable,
 					       0);
+		  b1->error = node->errors[UDP_ERROR_NO_LISTENER];
 		  next1 = UDP_LOCAL_NEXT_ICMP;
-		  n_no_listener++;
 		}
 	      else
 		{
@@ -234,8 +233,8 @@ udp46_local_inline (vlib_main_t * vm,
 					       ICMP6_destination_unreachable,
 					       ICMP6_destination_unreachable_port_unreachable,
 					       0);
+		  b1->error = node->errors[UDP_ERROR_NO_LISTENER];
 		  next1 = UDP_LOCAL_NEXT_ICMP;
-		  n_no_listener++;
 		}
 	    }
 	  else
@@ -331,8 +330,8 @@ udp46_local_inline (vlib_main_t * vm,
 						   ICMP4_destination_unreachable,
 						   ICMP4_destination_unreachable_port_unreachable,
 						   0);
+		      b0->error = node->errors[UDP_ERROR_NO_LISTENER];
 		      next0 = UDP_LOCAL_NEXT_ICMP;
-		      n_no_listener++;
 		    }
 		  else
 		    {
@@ -340,8 +339,8 @@ udp46_local_inline (vlib_main_t * vm,
 						   ICMP6_destination_unreachable,
 						   ICMP6_destination_unreachable_port_unreachable,
 						   0);
+		      b0->error = node->errors[UDP_ERROR_NO_LISTENER];
 		      next0 = UDP_LOCAL_NEXT_ICMP;
-		      n_no_listener++;
 		    }
 		}
 	      else
@@ -377,8 +376,6 @@ udp46_local_inline (vlib_main_t * vm,
 
       vlib_put_next_frame (vm, node, next_index, n_left_to_next);
     }
-  vlib_error_count (vm, node->node_index, UDP_ERROR_NO_LISTENER,
-		    n_no_listener);
   return from_frame->n_vectors;
 }