From: Benoît Ganne <bganne@cisco.com>
Date: Thu, 16 Apr 2020 10:40:04 +0000 (+0200)
Subject: ipsec: fix use-after-free
X-Git-Tag: v20.09-rc0~200
X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff_plain;h=ea9bc28592473e24c6dff85735e7e101a9dde4d4

ipsec: fix use-after-free

Type: fix

Change-Id: I1068ff1d03883addb5fe1005a8b608eab17e4168
Signed-off-by: Benoît Ganne <bganne@cisco.com>
---

diff --git a/src/vnet/ipsec/ipsec_tun.c b/src/vnet/ipsec/ipsec_tun.c
index 268f7783ebf..23598b7b085 100644
--- a/src/vnet/ipsec/ipsec_tun.c
+++ b/src/vnet/ipsec/ipsec_tun.c
@@ -817,8 +817,8 @@ static void
 ipsec_tun_protect_adj_delegate_adj_deleted (adj_delegate_t * ad)
 {
   /* remove our delegate */
-  adj_delegate_remove (ad->ad_adj_index, ipsec_tun_adj_delegate_type);
   ipsec_tun_protect_add_adj (ad->ad_adj_index, INDEX_INVALID);
+  adj_delegate_remove (ad->ad_adj_index, ipsec_tun_adj_delegate_type);
 }
 
 static void