From: Dave Barach <dave@barachs.net>
Date: Thu, 19 Jul 2018 16:29:45 +0000 (-0400)
Subject: Fix coverity warning / legitimate minor bug
X-Git-Tag: v18.10-rc1~568
X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff_plain;h=ed2fe93fd1ee7bfdad54f323946d76da91aa3398

Fix coverity warning / legitimate minor bug

Of the form "if ((foo & 0x10) == 1)", as opposed to
"if (foo & 0x10)"

Change-Id: I6a6d276aeed4af7c1c6c78546ee68d598d54d7db
Signed-off-by: Dave Barach <dave@barachs.net>
---

diff --git a/src/vppinfra/dlmalloc.c b/src/vppinfra/dlmalloc.c
index 8acea8bc2bf..2199d876e91 100644
--- a/src/vppinfra/dlmalloc.c
+++ b/src/vppinfra/dlmalloc.c
@@ -4133,7 +4133,7 @@ int mspace_enable_disable_trace (mspace msp, int enable)
   mstate ms = (mstate)msp;
   int was_enabled = 0;
 
-  if (use_trace(ms) == 1)
+  if (use_trace(ms))
     was_enabled = 1;
 
   if (enable)