From: Paul Vinciguerra <pvinci@vinciconsulting.com>
Date: Wed, 26 Dec 2018 23:27:10 +0000 (-0800)
Subject: vpp_papi:  MACAddress equals fails in unittest.
X-Git-Tag: v19.04-rc0~73
X-Git-Url: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff_plain;h=fe4827c97d375d5849aa5db863030af48069bdc2

vpp_papi:  MACAddress equals fails in unittest.

Before:
    EqualsAssertionError:  :: MACAddress(11:22:33:44:55:66) != MACAddress(11:22:33:44:55:66)
    ----------------------------------------------------------------------
    Ran 1 test in 0.002s
    FAILED (failures=1)
    MACAddress(11:22:33:44:55:66) != MACAddress(11:22:33:44:55:66)

After:

    ----------------------------------------------------------------------
    Ran 1 test in 0.001s
    OK

Change-Id: I89896a823b8f8a861813dabf23e7c9207e4fabb6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
---

diff --git a/src/vpp-api/python/vpp_papi/macaddress.py b/src/vpp-api/python/vpp_papi/macaddress.py
index a1003812003..5005fa8d92e 100644
--- a/src/vpp-api/python/vpp_papi/macaddress.py
+++ b/src/vpp-api/python/vpp_papi/macaddress.py
@@ -52,3 +52,14 @@ class MACAddress():
 
     def __repr__(self):
         return '%s(%s)' % (self.__class__.__name__, self.mac_string)
+
+    def __eq__(self, other):
+        if not isinstance(other, MACAddress):
+            return NotImplemented
+        return self.mac_binary == other.mac_binary
+
+    def __ne__(self, other):
+        return not self == other
+
+    def __hash__(self):
+        return hash(self.mac_binary)
diff --git a/src/vpp-api/python/vpp_papi/tests/test_macaddress.py b/src/vpp-api/python/vpp_papi/tests/test_macaddress.py
new file mode 100644
index 00000000000..08e365afd92
--- /dev/null
+++ b/src/vpp-api/python/vpp_papi/tests/test_macaddress.py
@@ -0,0 +1,10 @@
+import unittest
+from vpp_papi import MACAddress
+
+
+class TestMacAddress(unittest.TestCase):
+
+    def test_eq(self):
+        mac = '11:22:33:44:55:66'
+        self.assertEqual(MACAddress(mac),
+                         MACAddress(mac))