vpp.git
5 years agoIPSEC: API modernisation 38/17138/9
Neale Ranns [Thu, 10 Jan 2019 05:22:20 +0000 (21:22 -0800)]
IPSEC: API modernisation

- use enums to enumerate the algoritms and protocols that are supported
- use address_t types to simplify encode/deocde
- use typedefs of entry objects to get consistency between add/del API and dump

Change-Id: I7e7c58c06a150e2439633ba9dca58bc1049677ee
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agovcl: improve handling of close on rw 53/17153/6
Florin Coras [Wed, 30 Jan 2019 04:11:58 +0000 (20:11 -0800)]
vcl: improve handling of close on rw

Change-Id: Ie01a37612d7e3e0d0bad0f0aa9583b3ed411f46f
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agodocs: Instructions for using vmxnet3 on mac 71/17171/2
jdenisco [Wed, 30 Jan 2019 15:43:43 +0000 (10:43 -0500)]
docs: Instructions for using vmxnet3 on mac

Change-Id: Ie6770e3a3801a23a6eb64cf1699ef0018eab6445
Signed-off-by: jdenisco <jdenisco@cisco.com>
5 years agoUpdate version (19.01) for API changes script 87/17187/2
Andrew Yourtchenko [Mon, 21 Jan 2019 15:50:47 +0000 (16:50 +0100)]
Update version (19.01) for API changes script

Change-Id: I9c39b5076d366b3455a875df32765b2cb8f3eca2
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit 02da3a792ce1a7b4cdc3f0c9aa3434aadc726d06)

5 years agoVTL: Makefile: Don't install pip twice. 34/17034/4
Paul Vinciguerra [Thu, 24 Jan 2019 02:16:08 +0000 (18:16 -0800)]
VTL: Makefile: Don't install pip twice.

Pip is installed via virtualenv. No need to reinstall it again.

Change-Id: I45bea1f9db841ca4309b763ab852623180937727
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoextras: vfctl script - bind VF to vfio-pci after VF is created 15/17215/1
Damjan Marion [Thu, 31 Jan 2019 18:41:50 +0000 (19:41 +0100)]
extras: vfctl script - bind VF to vfio-pci after VF is created

Change-Id: If6ed71a5f7217363d8e1b2f7a7f20fe4cfdb58af
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoassert on double-free in debug build 76/17176/3
Klement Sekera [Wed, 30 Jan 2019 17:29:28 +0000 (18:29 +0100)]
assert on double-free in debug build

The assert allows easier debugging in gdb by aborting instead of exiting
cleanly. Also a core is generated so a stack trace can be obtained.

Change-Id: I2d05488c4522f4d4570fdfe0283130eb4c853d2a
Signed-off-by: Klement Sekera <ksekera@cisco.com>
5 years agopci: get the number of interrupts 87/17087/9
Mohsin Kazmi [Fri, 25 Jan 2019 15:57:24 +0000 (15:57 +0000)]
pci: get the number of interrupts

Change-Id: I2cfb81b3c8809d027a3ee5f5f570668e60be08ef
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agobuffers: reinitialize metadata, add additional validation 01/17201/2
Damjan Marion [Thu, 31 Jan 2019 11:29:39 +0000 (12:29 +0100)]
buffers: reinitialize metadata, add additional validation

- DPDK overwrites metadata as part of rte_pktmbuf_init(...) so we need
  reinitialize it

- additional checks added to ensure ref_count is never < 1

Change-Id: Ida336f81c4723e8f2e0ad4a70cb7b1ecfff978a0
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoDHCP-test: more robust sleep check 84/17084/2
Neale Ranns [Fri, 25 Jan 2019 14:37:15 +0000 (06:37 -0800)]
DHCP-test: more robust sleep check

Change-Id: I48c382797239dc305e01cc35124140d6ce16149a
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agobuffers: add missing ref_count = 1 in drivers 85/17185/1
Damjan Marion [Wed, 30 Jan 2019 21:15:28 +0000 (22:15 +0100)]
buffers: add missing ref_count = 1 in drivers

Change-Id: I6aa030429c1740f7376e95daf82fce49efa6716b
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agovirtio: fix the device order (legacy or modern) 66/17166/2
Mohsin Kazmi [Wed, 30 Jan 2019 13:36:57 +0000 (13:36 +0000)]
virtio: fix the device order (legacy or modern)

Change-Id: I60f88d50f062b004e6dea487bd627d303d0a5e75
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agoUse IP and MAC API types for neighbors 38/14138/13
Neale Ranns [Fri, 10 Aug 2018 12:30:06 +0000 (05:30 -0700)]
Use IP and MAC API types for neighbors

use address_t and mac_address_t for IPv6 and ARP entries
and all other API calls in ip.api aprat from the route ones,
that will follow in a separate commit

Change-Id: I67161737c2184d3f8fc1e79ebd2b55121c5b0191
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoMPLS tunnel; fix crash when deleting non-existant path 67/17167/2
Neale Ranns [Wed, 30 Jan 2019 14:00:19 +0000 (06:00 -0800)]
MPLS tunnel; fix crash when deleting non-existant path

in the case the tunnel is the only user of the shared path list
then removing its dependency removes the path list. hence lock the list

Change-Id: I18318441698ceac16715b1826266a7d19dcd76e1
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agobuffers: major cleanup and improvements 38/16638/28
Damjan Marion [Mon, 21 Jan 2019 10:48:34 +0000 (11:48 +0100)]
buffers: major cleanup and improvements

This patch introduces following changes:
- deprecated free lists which are not used and not compatible
  with external buffer managers (i.e. DPDK)
- introduces native support for per-numa buffer pools
- significantly improves performance of buffer alloc and free

Change-Id: I4a8e723ae47056717afd6cac0efe87cb731b5be7
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoipsec: fix check support functions 63/17163/2
Klement Sekera [Wed, 30 Jan 2019 10:11:23 +0000 (11:11 +0100)]
ipsec: fix check support functions

Change-Id: If94c57fbb07a7376a9f2873e1489c00b28152620
Signed-off-by: Klement Sekera <ksekera@cisco.com>
5 years agovls: support passive listeners 33/17133/9
Florin Coras [Mon, 28 Jan 2019 23:54:27 +0000 (15:54 -0800)]
vls: support passive listeners

If an application worker calls listen on a session, vpp registers the
worker to the listener's work load balance group and, as new connections
are accepted, it may potentially push accept notifications to it.

There are however applications, like nginx, that on some workers may
never accept new connections on a session they've started listening on.
To avoid accumulating accept events on such workers, this patch adds
support for passive listeners. That is, workers that have started
listening on a session but then never call accept or epoll/select on
that listener.

Change-Id: I007e6dcb54fc88a0e3aab3c6e2a3d1ef135cbd58
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agolisp: set reachable flag in map-register 51/17151/3
Florin Coras [Wed, 30 Jan 2019 01:30:29 +0000 (17:30 -0800)]
lisp: set reachable flag in map-register

Change-Id: I9faaa321113e435844931247f23dbc1d190cc9da
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoldp: initialize clib time 52/17152/3
Florin Coras [Wed, 30 Jan 2019 05:28:16 +0000 (21:28 -0800)]
ldp: initialize clib time

Change-Id: Ie598443f024a677a9c6938b3f3634960fd712b09
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agotest_syslog.py: pep8 overtab 46/17146/2
Ed Kern [Tue, 29 Jan 2019 21:28:05 +0000 (14:28 -0700)]
test_syslog.py: pep8 overtab

nit tab fix for pep8

Change-Id: I81f62bf5f547497c9aabfb3180ef24f50b7c3283
Signed-off-by: Ed Kern <ejk@cisco.com>
5 years agoVTL: Fix pep8 test/test_syslog.py 45/17145/2
Paul Vinciguerra [Tue, 29 Jan 2019 20:27:16 +0000 (12:27 -0800)]
VTL: Fix pep8 test/test_syslog.py

Change-Id: I8894a7a8f2be117a4c1cec9ce5134a1572da7ec7
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agovirtio: Support legacy and transitional virtio devices 27/17127/2
Mohsin Kazmi [Mon, 28 Jan 2019 19:30:21 +0000 (19:30 +0000)]
virtio: Support legacy and transitional virtio devices

Change-Id: Ib1316482dd7b1ae3c27c7eeb55839ed8af9ca162
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agovls: multi-process and multi-threaded apps improvements 71/17071/13
Florin Coras [Fri, 18 Jan 2019 16:37:13 +0000 (08:37 -0800)]
vls: multi-process and multi-threaded apps improvements

- More fine tuning for multi-process applications.
- Experimental support for multi-thread apps. This is meant for app
  whose threads are not vcl workers and the sessions are shared between
  them.

Change-Id: Ie07651da5f2cdcf39f5dead5431f50ad39cf3f74
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoFix error while compiling using 'vlib/vlib.h' dependencie. 32/17132/3
Dmitry Vakhrushev [Mon, 28 Jan 2019 22:34:22 +0000 (17:34 -0500)]
Fix error while compiling using 'vlib/vlib.h' dependencie.

This variable without any needed 'define' becoming unused.

Change-Id: I661a75a78dba03abb861ed918ad1e634a8ecd0af
Signed-off-by: Dmitry Vakhrushev <dmitry@netgate.com>
5 years agomake test: remove generic imports 37/17137/1
Klement Sekera [Tue, 29 Jan 2019 10:38:08 +0000 (11:38 +0100)]
make test: remove generic imports

Change-Id: I55b89f0d9fb082c7763b64b09ab14573468c6704
Signed-off-by: Klement Sekera <ksekera@cisco.com>
5 years agocmake: fix out-of-git-tree build 25/17125/2
Damjan Marion [Mon, 28 Jan 2019 16:55:59 +0000 (17:55 +0100)]
cmake: fix out-of-git-tree build

Change-Id: Ib94637ec09799c23f3179599b54a2be6e2768425
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoupdate openssl TLS async to align with openssl master branch 00/17100/4
Ping Yu [Mon, 28 Jan 2019 08:12:08 +0000 (03:12 -0500)]
update openssl TLS async to align with openssl master branch

Need to align with 3.0.0 version

Change-Id: I4e8aec1f1226ce09963a9bbb3a9170d1863059ec
Signed-off-by: Ping Yu <ping.yu@intel.com>
5 years agoFix issues with order of NAT commands before set VRF table on an interface 61/16961/15
Dmitry Vakhrushev [Tue, 22 Jan 2019 10:28:53 +0000 (05:28 -0500)]
Fix issues with order of NAT commands before set VRF table on an interface

Outside FIB index doesn't change in this case. We register
callback for changing of outside FIB if table binding is changed
on an interface.

Change-Id: I1ebbd7c3c547fc999089db07abd2019734395a6e
Signed-off-by: Dmitry Vakhrushev <dmitry@netgate.com>
5 years agoAdd Ipsec IKE support to openssl 3.0.0 master branch 01/17101/2
Ping Yu [Mon, 28 Jan 2019 08:27:51 +0000 (03:27 -0500)]
Add Ipsec IKE support to openssl 3.0.0 master branch

Change-Id: I7bd43f57d23b1ecf031530c4a7508f949ddf616f
Signed-off-by: Ping Yu <ping.yu@intel.com>
5 years agoLess intrusive way to capture numa_node and cpu_id changes 14/17114/2
Damjan Marion [Mon, 28 Jan 2019 12:41:27 +0000 (13:41 +0100)]
Less intrusive way to capture numa_node and cpu_id changes

Change-Id: I3a33fb81f31ed473811e9e7a6197b81135913865
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoFix issue with cpu_id and numa_code captured too early 99/17099/2
Damjan Marion [Sun, 27 Jan 2019 16:54:11 +0000 (17:54 +0100)]
Fix issue with cpu_id and numa_code captured too early

Change-Id: I79b213b34c6071d14acf1922f89037a4a5a36c45
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agosession: properly initialize accepted/connected msgs 98/17098/2
Florin Coras [Sat, 26 Jan 2019 22:33:26 +0000 (14:33 -0800)]
session: properly initialize accepted/connected msgs

Change-Id: I36b3ae56e6ca160081c892367fd6a979751fe717
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoperfmon: collect data on selected thread(s) 95/17095/4
Dave Barach [Sat, 26 Jan 2019 14:50:26 +0000 (09:50 -0500)]
perfmon: collect data on selected thread(s)

Add missing pre-input node runtime fork and refork code.
unix-epoll-input runs on all threads; each instance needs its own
runtime stats.

Change-Id: I16b02e42d0c95f863161176c4bb9f9917bef809d
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agocmake: parse DPDK config without compilation 96/17096/3
Damjan Marion [Sat, 26 Jan 2019 17:50:29 +0000 (18:50 +0100)]
cmake: parse DPDK config without compilation

Previous scheme was not cross-compile friendly...

Change-Id: Ib103b136231673157a02b8750312aa6073052c7e
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoRun vpp-configure on change to cmake config files. 90/16990/4
Burt Silverman [Wed, 23 Jan 2019 02:55:02 +0000 (21:55 -0500)]
Run vpp-configure on change to cmake config files.

Modify the dirs assignment in configure_check_timestamp to
add the build-data/platforms/$(PLATFORM).mk file, all the CMakeLists.txt
files in the $(PACKAGE_SOURCE) tree, and the $(PACKAGE_SOURCE)/cmake
directory.
(For example, for package vpp, $(PACKAGE_SOURCE) is <Top of Tree>/src).
Note that in an earlier era there was no build-data/platforms directory and
no CMakeLists.txt files.
Also, we tacitly assume that $(SOURCE_PATH_BUILD_DATA_DIRS) is only one
directory whereas ebuild has been used in environments where there are two
treetops.

Change-Id: I761219adbdb4c7e675bb12b3e7f052db68f0294c
Signed-off-by: Burt Silverman <burtms@gmail.com>
5 years agovcl: add api to expose worker message queues epfd 91/17091/2
Florin Coras [Fri, 25 Jan 2019 21:19:56 +0000 (13:19 -0800)]
vcl: add api to expose worker message queues epfd

This only works if vcl is configured to do eventd based message queue
notifications, instead of condvars. For that, add "use-mq-eventfd" to
vcl startup conf.

Change-Id: Id0f0288a40ec7d3daef7370f8b88420425867ab6
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agocmake: add support for linking with DPDK shared libs 94/17094/1
Damjan Marion [Sat, 26 Jan 2019 13:12:25 +0000 (14:12 +0100)]
cmake: add support for linking with DPDK shared libs

Change-Id: I3423191c53ab6100ee9ecc4e24b06506ff1b25c8
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agodeprecate tapcli 73/17073/4
Damjan Marion [Fri, 25 Jan 2019 07:39:04 +0000 (08:39 +0100)]
deprecate tapcli

Change-Id: I82dceaa27a7b0c96de077cf283e4f64aa426f271
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoMPLS-tunnel: show output to display the tunnel name correctly 81/17081/2
Neale Ranns [Fri, 25 Jan 2019 11:18:27 +0000 (03:18 -0800)]
MPLS-tunnel: show output to display the tunnel name correctly

Change-Id: I1554d9a4d6e4a4007cda9d0f83b03feb8fdbe853
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoIPSEC: tests use opbject registry 75/17075/3
Neale Ranns [Thu, 24 Jan 2019 12:52:25 +0000 (04:52 -0800)]
IPSEC: tests use opbject registry

this means we test the dumps - to some extent

Change-Id: I8d90745701012012b41a7b3aaf9be97b4dd2bdf8
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agotcp_echo: support all ctrl msgs and io cleanup 72/17072/4
Florin Coras [Fri, 25 Jan 2019 07:22:37 +0000 (23:22 -0800)]
tcp_echo: support all ctrl msgs and io cleanup

Change-Id: I74d69b8d686ad2395267eaee38cf3a7efc76d127
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agopg: bugfix for pg paylod hdr-size 38/17038/2
Kingwel Xie [Thu, 24 Jan 2019 08:24:26 +0000 (03:24 -0500)]
pg: bugfix for pg paylod hdr-size

it was specified to 0 after https://gerrit.fd.io/r/16909
causes unformat_pg_ip4_header to wrongly set ip header len.

do more check when assigning e->lsb_bit_offset to avoid
negative value

Change-Id: Ib772c7135cdeb355f0d60f1ee11602f6b5a0ff21
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
5 years agoIP6 FIB: walk table for dump (VPP-1553) 77/17077/2
Neale Ranns [Fri, 25 Jan 2019 08:51:09 +0000 (00:51 -0800)]
IP6 FIB: walk table for dump (VPP-1553)

Change-Id: Iaa57ace6df96bfacd1235c80ec7bb08e5f335530
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agocmake: execute git from src directory 80/17080/2
Damjan Marion [Fri, 25 Jan 2019 10:22:58 +0000 (11:22 +0100)]
cmake: execute git from src directory

Thanks Eliot....

Change-Id: I19c9557bf827d4a5b2af344f6f4eedf25cda86d7
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoperfmon: enable pmc event before reading rdpmc index 69/17069/2
Damjan Marion [Thu, 24 Jan 2019 19:24:33 +0000 (20:24 +0100)]
perfmon: enable pmc event before reading rdpmc index

Change-Id: I9b0a101e5d78c10257e3c5d8f5573c3eb29bfdef
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agosession/vcl: support worker ownership change for listeners 28/17028/3
Florin Coras [Wed, 23 Jan 2019 17:21:30 +0000 (09:21 -0800)]
session/vcl: support worker ownership change for listeners

Change-Id: I2ad54b20b96f10b009c3e651b2a2f885577ca5b6
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agomove misc-drop-errors to vnet 70/17070/1
Dave Barach [Thu, 24 Jan 2019 20:12:53 +0000 (15:12 -0500)]
move misc-drop-errors to vnet

thanks, Eliot...

Change-Id: I8d8fee09bf1fe24933e6ef4e126dba8e22fe62b1
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoIPSEC Tests: to per-test setup and tearDown 27/17027/3
Neale Ranns [Wed, 23 Jan 2019 16:16:17 +0000 (08:16 -0800)]
IPSEC Tests: to per-test setup and tearDown

don't do the setup and teardown in class methods so that with
each test the config is added and deleted. that way we test that
delete actually removes state.
more helpful error codes from VPP for existing IPSEC state.

Change-Id: I5de1578f73b935b420d4cdd85aa98d5fdcc682f6
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoadd "Mtrie mheap usage" in "show ip fib memory" 61/16761/3
Lollita Liu [Fri, 11 Jan 2019 10:23:12 +0000 (05:23 -0500)]
add "Mtrie mheap usage" in "show ip fib memory"
Adding "Mtrie mheap usage" in output of "show ip fib memory" command, for displaying the total Mtrie Mheap usage together with memery usage of each node and each table

Change-Id: I2bcc570924e44a2b406f69cfc2f2f8d5abb61a39
Signed-off-by: Lollita Liu <lollita.liu@ericsson.com>
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoperfmon plugin: 2-way parallel stat collection 61/17061/2
Dave Barach [Thu, 24 Jan 2019 15:34:24 +0000 (10:34 -0500)]
perfmon plugin: 2-way parallel stat collection

As a FUD reduction measure, this patch implements 2-way parallel
counter collection. Synthetic stat component counter pairs run at the
same time. Running two counters (of any kind) at the same time
naturally reduces the aggregate time required by an approximate
factor-of-2, depending on whether an even or odd number of stats have
been requested.

I don't completely buy the argument that computing synthetic stats
such as instructions-per-clock will be inaccurate if component counter
values are collected sequentially. Given uniform traffic pattern, it
must make no difference.

As the collection interval increases, the difference between serial
and parallel component counter collection will approach zero, see also
the Central Limit theorem.

Change-Id: I36ebdcf125e8882cca8a1929ec58f17fba1ad8f1
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agobuffers: fix vector types 58/17058/2
Damjan Marion [Thu, 24 Jan 2019 14:36:57 +0000 (15:36 +0100)]
buffers: fix vector types

Change-Id: I9df96264e30806ac3daf7121f314f34f06232413
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
5 years agoavf: fix queue enable issue 57/17057/2
Damjan Marion [Thu, 24 Jan 2019 13:41:35 +0000 (14:41 +0100)]
avf: fix queue enable issue

It is actually a bitmap....

Change-Id: Ie359e085df3f371512f773600f8d7460b2232b3e
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
5 years agovirtio: Minor fixes and header cleanup 69/16969/2
Mohsin Kazmi [Tue, 22 Jan 2019 13:05:00 +0000 (13:05 +0000)]
virtio: Minor fixes and header cleanup

Change-Id: I2e5fd45abcd07e9eda6184587889bdcd9613a159
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agobond: packet drops on VPP bond interface [VPP-1544] 68/16868/3
Steven [Thu, 17 Jan 2019 23:11:29 +0000 (15:11 -0800)]
bond: packet drops on VPP bond interface [VPP-1544]

We register callback for VNET_HW_INTERFACE_LINK_UP_DOWN_FUNCTION and
VNET_SW_INTERFACE_ADMIN_UP_DOWN_FUNCTION to add and remove the slave
interface from the bond interface accordingly. For static bonding without
lacp, one would think that it is good enough to put the slave interface into
the ective slave set as soon as it is configured. Wrong, sometimes the slave
interface is configured to be part of the bonding without ever bringing up the
hardware carrier or setting the admin state to up. In that case, we send
traffic to the "dead" slave interface.

The fix is to make sure both the carrier and admin state are up before we put
the slave into the active set for forwarding traffic.

Change-Id: I93b1c36d5481ca76cc8b87e8ca1b375ca3bd453b
Signed-off-by: Steven <sluong@cisco.com>
5 years agobuffers: wrap vlib_buffer_t to union and expose vector types 26/17026/3
Damjan Marion [Wed, 23 Jan 2019 15:52:10 +0000 (16:52 +0100)]
buffers: wrap vlib_buffer_t to union and expose vector types

Change-Id: I1c12e2941cae198ededbb65eb5be51a4eabe2c1b
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agopg: cli improvement 09/16909/6
Kingwel Xie [Sun, 20 Jan 2019 03:49:26 +0000 (22:49 -0500)]
pg: cli improvement

1. show packet-generator verbose, display all edit-groups and hdr-size
2. unformat_pg_payload, always mark payload hdr-size as 0
3. packet-generator now can change rate/limit/size at runtime
4. validate_stream checks buffer min-size/max-size against all edit
   groups' header size
5. remove incorrect max packet size limit check in validate_stream(...)

Change-Id: Ic45e4f2b98bc0fd7330e0b480dd677fa3c69a677
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agocmake: fix debian preinst script 18/17018/1
Damjan Marion [Wed, 23 Jan 2019 14:58:53 +0000 (15:58 +0100)]
cmake: fix debian preinst script

Change-Id: I312beccb1bb6c02d6356bc9b8247178f11b8feb0
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoInitialize gc_mark_timestamp to zero to avoid garbage values. 78/16978/2
Brian Nesbitt [Tue, 22 Jan 2019 14:47:53 +0000 (14:47 +0000)]
Initialize gc_mark_timestamp to zero to avoid garbage values.

Change-Id: Ib3f030e906da9828fdad27e19b9efb0c349b0734
Signed-off-by: Brian Nesbitt <brian.nesbitt@owmobility.com>
5 years agovppinfra: add CLIB_CACHE_LINE_ROUND() macro 09/17009/2
Damjan Marion [Wed, 23 Jan 2019 11:51:36 +0000 (12:51 +0100)]
vppinfra: add CLIB_CACHE_LINE_ROUND() macro

Change-Id: Ic141162acaf39878ab978a997e3f6757d4f7c240
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agopmalloc: don't iterate if there is no enough free space 08/17008/1
Damjan Marion [Wed, 23 Jan 2019 11:50:24 +0000 (12:50 +0100)]
pmalloc: don't iterate if there is no enough free space

Change-Id: I975d46a82e9f884a9cd0ac2bd5f57181695f4124
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agovirtio: Add support for logging 67/16967/2
Mohsin Kazmi [Mon, 21 Jan 2019 15:19:39 +0000 (15:19 +0000)]
virtio: Add support for logging

Change-Id: Ieadf0a97379ed8b17241e454895c4e5e195dc52f
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agoAH encrypt; don't double enqueue nor emit clib_warnings when seq-num max exceeded 77/16977/2
Neale Ranns [Tue, 22 Jan 2019 14:42:23 +0000 (06:42 -0800)]
AH encrypt; don't double enqueue nor emit clib_warnings when seq-num max exceeded

Change-Id: Id5b47f78521a0cbedf7bd2c72babfb2ffe9fa67d
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agolisp: cli for marking local mappings authoritative 49/16949/2
Florin Coras [Tue, 22 Jan 2019 01:36:28 +0000 (17:36 -0800)]
lisp: cli for marking local mappings authoritative

Change-Id: I92af6455b50a49de4c912737fcd3b7787dd31de0
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoIP route local and connected 98/16998/2
Neale Ranns [Wed, 23 Jan 2019 08:36:16 +0000 (00:36 -0800)]
IP route local and connected

allow routes that are local and connected to be added via the API.
this emulates the addition of a second address in the same subnet
added to an interface.

Change-Id: Ib18a08c26956be9a07b3360664210c8cf6734c84
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agovcl: generate epoll events only if requested 89/16989/4
Florin Coras [Wed, 23 Jan 2019 03:05:52 +0000 (19:05 -0800)]
vcl: generate epoll events only if requested

Change-Id: I6e96607f09c18755eead2c7099e1f546bdae7b88
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoVTL: Test against latest version of syslog_rfc5424_parser. 92/16992/1
Paul Vinciguerra [Wed, 23 Jan 2019 03:58:47 +0000 (19:58 -0800)]
VTL: Test against latest version of syslog_rfc5424_parser.

The latest version moved to lark from pyparsing.  The developers were
kind enough to verify that their new grammar works with our tests.

Change-Id: I260b7e4641f6e283862f706c1e52199e28facc5c
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agogbp: fix inlining issue 79/16979/1
Damjan Marion [Tue, 22 Jan 2019 15:07:27 +0000 (16:07 +0100)]
gbp: fix inlining issue

Change-Id: Idbbe5996a5749733a904433b57cba7ab63fdbbcb
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoGBP: Sclass to src-epg conversions 52/16952/3
Neale Ranns [Tue, 22 Jan 2019 07:34:18 +0000 (23:34 -0800)]
GBP: Sclass to src-epg conversions

Change-Id: Ica88268fd6a6ee01da7e9219bb4e81f22ed2fd4b
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agovirtio: Add api support in vat 78/16878/5
Mohsin Kazmi [Fri, 18 Jan 2019 10:50:00 +0000 (11:50 +0100)]
virtio: Add api support in vat

Change-Id: I46ec5ba03d61c1fe0aba92f649f43746b5292cc3
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agocmake: supress 'Set runtime path of' noise while generatig deb packages 59/16959/2
Damjan Marion [Tue, 22 Jan 2019 10:14:46 +0000 (11:14 +0100)]
cmake: supress 'Set runtime path of' noise while generatig deb packages

Change-Id: Ib8ddce2d56034152a390ca2d3b9784673a77d2e3
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agocmake: fix debian package dependencies 55/16955/3
Damjan Marion [Tue, 22 Jan 2019 09:48:30 +0000 (10:48 +0100)]
cmake: fix debian package dependencies

Change-Id: Ib27c43a561dd000f8361ff732e76c6297a7ba900
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agocmake: place include/ and share/ in /usr (debian packages) 56/16956/3
Damjan Marion [Tue, 22 Jan 2019 09:28:29 +0000 (10:28 +0100)]
cmake: place include/ and share/ in /usr (debian packages)

Change-Id: I980b76fb766d5734d4e822409a11ed09a06108a6
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoNAT: ipfix call optimization 57/16957/2
Filip Varga [Tue, 22 Jan 2019 08:43:44 +0000 (00:43 -0800)]
NAT: ipfix call optimization

Change-Id: I84dfdbb727fb765fcaa7fb0099cbdd7ef7dbcc10
Signed-off-by: Filip Varga <fivarga@cisco.com>
5 years agoVTL: VppTestResult: Must implement empty constructor. 43/16843/2
Paul Vinciguerra [Wed, 16 Jan 2019 19:12:50 +0000 (11:12 -0800)]
VTL: VppTestResult: Must implement empty constructor.

Subclasses of (unittest.TestResult|unittest.TextTestResult) must implement an empty constructor.

The standard python library unittests depend on the empty constructor.

Change-Id: I6d1bd2e7d6996d85a9da66cb7d40af0ed3c30e2b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agocmake: don't set SONAME for plugins 51/16951/2
Damjan Marion [Tue, 22 Jan 2019 08:11:50 +0000 (09:11 +0100)]
cmake: don't set SONAME for plugins

Change-Id: I8cd782bb36a4c063afa312002192c254fd51bf5e
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agocmake: package-deb target uses terminal 50/16950/2
Damjan Marion [Tue, 22 Jan 2019 08:10:16 +0000 (09:10 +0100)]
cmake: package-deb target uses terminal

Change-Id: I81b686cc1911c2ff52ead15c8199bdf9430fe59b
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoVOM: GBP bridge domain flags 22/16922/2
Neale Ranns [Thu, 10 Jan 2019 16:00:22 +0000 (08:00 -0800)]
VOM: GBP bridge domain flags

Change-Id: Ib5e4a850e127dda51318ffe82ef2622b980bc947
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoVTL: test/lisp.py Fix recursion error. 14/16914/3
Paul Vinciguerra [Mon, 21 Jan 2019 00:36:01 +0000 (16:36 -0800)]
VTL: test/lisp.py Fix recursion error.

Accessing priority causes a recursion error.

Change-Id: Ic8cc5c9e198b7da955bc24ea116e9826004cad5e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVTL: test/lisp.py. Add missing method: object_id(). 15/16915/2
Paul Vinciguerra [Mon, 21 Jan 2019 01:11:48 +0000 (17:11 -0800)]
VTL: test/lisp.py.  Add missing method: object_id().

Change-Id: I7609a7b173cbfc1de10b346cc8075bca5a40ef3a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agovirtio: Native virtio driver 85/15085/34
Mohsin Kazmi [Tue, 23 Oct 2018 16:00:47 +0000 (18:00 +0200)]
virtio: Native virtio driver

Change-Id: Id7fccf2f805e578fb05032aeb2b649a74c3c0e56
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agoVPP-1549 Add missing counter name. 44/16944/2
Paul Vinciguerra [Mon, 21 Jan 2019 16:48:21 +0000 (08:48 -0800)]
VPP-1549 Add missing counter name.

show interface

              Name               Idx    State  MTU (L3/IP4/IP6/MPLS)     Counter          Count
local0                            0     down          0/0/0/0
pg0                               1     down         9000/0/0/0     rx packets                   582
                                                                    rx bytes                   34051
                                                                    tx packets                     4
                                                                    tx bytes                     364
                                                                    drops                        323
                                                                    ip6                            1
                                                                    (nil)                        580

----
show interface
              Name               Idx    State  MTU (L3/IP4/IP6/MPLS)     Counter          Count
local0                            0     down          0/0/0/0
pg0                               1     down         9000/0/0/0     rx packets                   582
                                                                    rx bytes                   34051
                                                                    tx packets                     4
                                                                    tx bytes                     364
                                                                    drops                        323
                                                                    ip6                            1
                                                                    mpls                         580

Change-Id: I3dcde4799764277535baf42f855e4e8bb48c0d02
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoldp: add support for TCP_CONGESTION sockopts (VPP-1550) 45/16945/3
Florin Coras [Mon, 21 Jan 2019 17:03:10 +0000 (09:03 -0800)]
ldp: add support for TCP_CONGESTION sockopts (VPP-1550)

Change-Id: I0fcf3385cc4fb96f000b84d5f880f74131c0d60f
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agodoxygen formatting fix: prevent stray examples appearing in the docs 43/16943/2
Andrew Yourtchenko [Mon, 21 Jan 2019 15:01:41 +0000 (16:01 +0100)]
doxygen formatting fix: prevent stray examples appearing in the docs

The 'example' keyword triggers the creation of very out-of-context
example in the "Examples" top level of documentation. Rename the
keyword in the comment so the comment is still readable, but
does not trigger the doxygen.

Change-Id: Iecbdc236918f9178a034817aa6cea7ab6b2c1654
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit 1705599efe5eec09c09d2214da776d92d0e4f1cf)

5 years agocmake: fix missing install() lines for startup.conf and 80-vpp.conf 38/16938/2
Damjan Marion [Mon, 21 Jan 2019 15:35:13 +0000 (16:35 +0100)]
cmake: fix missing install() lines for startup.conf and 80-vpp.conf

Change-Id: I5bbd44fb1ce5923350bcf1a42b1d85131eaa3747
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoFix LB lookup table failed issue 16/16916/2
Hongjun Ni [Mon, 21 Jan 2019 10:07:11 +0000 (18:07 +0800)]
Fix LB lookup table failed issue

Change-Id: Icd21f456089c72c91a8328f963bf47a8c7725195
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
5 years agoNAT: VPP-1537 IPFIX per worker processing 75/16875/7
Filip Varga [Mon, 21 Jan 2019 08:05:03 +0000 (00:05 -0800)]
NAT: VPP-1537 IPFIX per worker processing

Change-Id: I428bd25a513eb9fe65bea56572fea8cab7c51681
Signed-off-by: Filip Varga <fivarga@cisco.com>
5 years agoSimplify test/util.py:ppp. 32/16732/3
Paul Vinciguerra [Wed, 9 Jan 2019 05:36:39 +0000 (21:36 -0800)]
Simplify test/util.py:ppp.

Change-Id: I10596335c7e8f51afc4bcee75132b7a25ebf2a4e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVTL: Add **kwargs to VppTestRunner constructor. 96/16796/3
Paul Vinciguerra [Mon, 14 Jan 2019 05:32:37 +0000 (21:32 -0800)]
VTL: Add **kwargs to VppTestRunner constructor.

        Subclasses should accept **kwargs to ensure compatibility as the
        interface changes.

https://github.com/python/cpython/blob/master/Lib/unittest/runner.py#L133

Change-Id: Ia64ffd88899d207a5422f066700d2f7f9c77622e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agocrypto-input: fix crash bug 19/16619/4
Kingwel Xie [Wed, 26 Dec 2018 02:31:28 +0000 (21:31 -0500)]
crypto-input: fix crash bug

as this node is refactored in new style with
vlib_buffer_enqueue_to_next, we have to check if the 'count'
is greater than 0. otherise, the next_index would be invalid
then lead to a crash

Change-Id: If7c323b59c02b5c16bd9d77b65c946512cc972c1
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
5 years agodpdk: add buffer.h 07/16907/3
Damjan Marion [Sun, 20 Jan 2019 01:02:51 +0000 (02:02 +0100)]
dpdk: add buffer.h

Change-Id: I998658ad7860b23425444e218ce2e1ec655b885a
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agobuffers: remove VLIB_BUFFER_DEFAULT_FREE_LIST macro and fl->n_data_bytes 08/16908/4
Damjan Marion [Sun, 20 Jan 2019 01:24:53 +0000 (02:24 +0100)]
buffers: remove VLIB_BUFFER_DEFAULT_FREE_LIST macro and fl->n_data_bytes

Change-Id: I0ba5175be077c40556f2a3ce629c5bbcd71e0a81
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agobuffers: remove vlib_buffer_delete_free_list 06/16906/2
Damjan Marion [Sun, 20 Jan 2019 00:48:05 +0000 (01:48 +0100)]
buffers: remove vlib_buffer_delete_free_list

Change-Id: I5fe01e918b534d1ac1d47f0d7610536f45c3158c
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agobuffers: don't init metadata, as it is already initialized 04/16904/3
Damjan Marion [Sat, 19 Jan 2019 23:11:22 +0000 (00:11 +0100)]
buffers: don't init metadata, as it is already initialized

Change-Id: Ia083050389853c25b069f0f8286d50d3f4aef527
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agobuffers: keep buffer_main in vlib_main_t 03/16903/3
Damjan Marion [Sat, 19 Jan 2019 23:03:56 +0000 (00:03 +0100)]
buffers: keep buffer_main in vlib_main_t

Change-Id: I3bb1d9f83dd08f4b93acd4a281bfec0674e39c2e
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoStore numa-noda and cpu-index in vlib_main_t 02/16902/3
Damjan Marion [Sat, 19 Jan 2019 22:45:36 +0000 (23:45 +0100)]
Store numa-noda and cpu-index in vlib_main_t

Change-Id: If88ccd965122b9318a39a8d71b53334cd1fd81e4
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoRework of debian packaging 82/16882/14
Damjan Marion [Fri, 18 Jan 2019 12:28:22 +0000 (13:28 +0100)]
Rework of debian packaging

Change-Id: Ifede85d3af36f3ee6c6f8f92dcf5db0ed8f1bfeb
Signed-off-by: Damjan Marion <damarion@cisco.com>
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agofix data_length in IpSec API call (VPP-1548) 69/16869/5
Michal Cmarada [Fri, 18 Jan 2019 11:51:08 +0000 (12:51 +0100)]
fix data_length in IpSec API call (VPP-1548)

Change-Id: Idb2839f6082bd2e052be2bc5417f0ebb43d1c0a6
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
5 years agolog: bug fix register class compare mismatch 71/16771/3
Su Wang [Fri, 11 Jan 2019 17:46:05 +0000 (12:46 -0500)]
log: bug fix register class compare mismatch

1. Otherwise, the log classes with same prefix, e.g. "abc" and
   "abc-de" will all be registered into log class "abc";
2. Minor improvement for test log help string.

Change-Id: I8d93be5e8fa67db6012198b3442a9e2bddcb744a
Signed-off-by: Su Wang <su.z.wang@ericsson.com>
5 years agominor fixup in map doc (people -> seconds) 11/16911/1
Jim Thompson [Sun, 20 Jan 2019 06:44:43 +0000 (00:44 -0600)]
minor fixup in map doc (people -> seconds)

Change-Id: I151c1afac2133ad32ad7779a59fffafee4b9de60
Signed-off-by: Jim Thompson <jim@netgate.com>
5 years agotcp: fix debugging without cc stats (VPP-1547) 05/16905/4
Florin Coras [Sun, 20 Jan 2019 00:45:13 +0000 (16:45 -0800)]
tcp: fix debugging without cc stats (VPP-1547)

Change-Id: I376856fcadce570bb555064435f5876eefb2befa
Signed-off-by: Florin Coras <fcoras@cisco.com>