vpp.git
5 years agodeprecate tapcli 73/17073/4
Damjan Marion [Fri, 25 Jan 2019 07:39:04 +0000 (08:39 +0100)]
deprecate tapcli

Change-Id: I82dceaa27a7b0c96de077cf283e4f64aa426f271
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoMPLS-tunnel: show output to display the tunnel name correctly 81/17081/2
Neale Ranns [Fri, 25 Jan 2019 11:18:27 +0000 (03:18 -0800)]
MPLS-tunnel: show output to display the tunnel name correctly

Change-Id: I1554d9a4d6e4a4007cda9d0f83b03feb8fdbe853
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoIPSEC: tests use opbject registry 75/17075/3
Neale Ranns [Thu, 24 Jan 2019 12:52:25 +0000 (04:52 -0800)]
IPSEC: tests use opbject registry

this means we test the dumps - to some extent

Change-Id: I8d90745701012012b41a7b3aaf9be97b4dd2bdf8
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agotcp_echo: support all ctrl msgs and io cleanup 72/17072/4
Florin Coras [Fri, 25 Jan 2019 07:22:37 +0000 (23:22 -0800)]
tcp_echo: support all ctrl msgs and io cleanup

Change-Id: I74d69b8d686ad2395267eaee38cf3a7efc76d127
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agopg: bugfix for pg paylod hdr-size 38/17038/2
Kingwel Xie [Thu, 24 Jan 2019 08:24:26 +0000 (03:24 -0500)]
pg: bugfix for pg paylod hdr-size

it was specified to 0 after https://gerrit.fd.io/r/16909
causes unformat_pg_ip4_header to wrongly set ip header len.

do more check when assigning e->lsb_bit_offset to avoid
negative value

Change-Id: Ib772c7135cdeb355f0d60f1ee11602f6b5a0ff21
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
5 years agoIP6 FIB: walk table for dump (VPP-1553) 77/17077/2
Neale Ranns [Fri, 25 Jan 2019 08:51:09 +0000 (00:51 -0800)]
IP6 FIB: walk table for dump (VPP-1553)

Change-Id: Iaa57ace6df96bfacd1235c80ec7bb08e5f335530
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agocmake: execute git from src directory 80/17080/2
Damjan Marion [Fri, 25 Jan 2019 10:22:58 +0000 (11:22 +0100)]
cmake: execute git from src directory

Thanks Eliot....

Change-Id: I19c9557bf827d4a5b2af344f6f4eedf25cda86d7
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoperfmon: enable pmc event before reading rdpmc index 69/17069/2
Damjan Marion [Thu, 24 Jan 2019 19:24:33 +0000 (20:24 +0100)]
perfmon: enable pmc event before reading rdpmc index

Change-Id: I9b0a101e5d78c10257e3c5d8f5573c3eb29bfdef
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agosession/vcl: support worker ownership change for listeners 28/17028/3
Florin Coras [Wed, 23 Jan 2019 17:21:30 +0000 (09:21 -0800)]
session/vcl: support worker ownership change for listeners

Change-Id: I2ad54b20b96f10b009c3e651b2a2f885577ca5b6
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agomove misc-drop-errors to vnet 70/17070/1
Dave Barach [Thu, 24 Jan 2019 20:12:53 +0000 (15:12 -0500)]
move misc-drop-errors to vnet

thanks, Eliot...

Change-Id: I8d8fee09bf1fe24933e6ef4e126dba8e22fe62b1
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoIPSEC Tests: to per-test setup and tearDown 27/17027/3
Neale Ranns [Wed, 23 Jan 2019 16:16:17 +0000 (08:16 -0800)]
IPSEC Tests: to per-test setup and tearDown

don't do the setup and teardown in class methods so that with
each test the config is added and deleted. that way we test that
delete actually removes state.
more helpful error codes from VPP for existing IPSEC state.

Change-Id: I5de1578f73b935b420d4cdd85aa98d5fdcc682f6
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoadd "Mtrie mheap usage" in "show ip fib memory" 61/16761/3
Lollita Liu [Fri, 11 Jan 2019 10:23:12 +0000 (05:23 -0500)]
add "Mtrie mheap usage" in "show ip fib memory"
Adding "Mtrie mheap usage" in output of "show ip fib memory" command, for displaying the total Mtrie Mheap usage together with memery usage of each node and each table

Change-Id: I2bcc570924e44a2b406f69cfc2f2f8d5abb61a39
Signed-off-by: Lollita Liu <lollita.liu@ericsson.com>
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoperfmon plugin: 2-way parallel stat collection 61/17061/2
Dave Barach [Thu, 24 Jan 2019 15:34:24 +0000 (10:34 -0500)]
perfmon plugin: 2-way parallel stat collection

As a FUD reduction measure, this patch implements 2-way parallel
counter collection. Synthetic stat component counter pairs run at the
same time. Running two counters (of any kind) at the same time
naturally reduces the aggregate time required by an approximate
factor-of-2, depending on whether an even or odd number of stats have
been requested.

I don't completely buy the argument that computing synthetic stats
such as instructions-per-clock will be inaccurate if component counter
values are collected sequentially. Given uniform traffic pattern, it
must make no difference.

As the collection interval increases, the difference between serial
and parallel component counter collection will approach zero, see also
the Central Limit theorem.

Change-Id: I36ebdcf125e8882cca8a1929ec58f17fba1ad8f1
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agobuffers: fix vector types 58/17058/2
Damjan Marion [Thu, 24 Jan 2019 14:36:57 +0000 (15:36 +0100)]
buffers: fix vector types

Change-Id: I9df96264e30806ac3daf7121f314f34f06232413
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
5 years agoavf: fix queue enable issue 57/17057/2
Damjan Marion [Thu, 24 Jan 2019 13:41:35 +0000 (14:41 +0100)]
avf: fix queue enable issue

It is actually a bitmap....

Change-Id: Ie359e085df3f371512f773600f8d7460b2232b3e
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
5 years agovirtio: Minor fixes and header cleanup 69/16969/2
Mohsin Kazmi [Tue, 22 Jan 2019 13:05:00 +0000 (13:05 +0000)]
virtio: Minor fixes and header cleanup

Change-Id: I2e5fd45abcd07e9eda6184587889bdcd9613a159
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agobond: packet drops on VPP bond interface [VPP-1544] 68/16868/3
Steven [Thu, 17 Jan 2019 23:11:29 +0000 (15:11 -0800)]
bond: packet drops on VPP bond interface [VPP-1544]

We register callback for VNET_HW_INTERFACE_LINK_UP_DOWN_FUNCTION and
VNET_SW_INTERFACE_ADMIN_UP_DOWN_FUNCTION to add and remove the slave
interface from the bond interface accordingly. For static bonding without
lacp, one would think that it is good enough to put the slave interface into
the ective slave set as soon as it is configured. Wrong, sometimes the slave
interface is configured to be part of the bonding without ever bringing up the
hardware carrier or setting the admin state to up. In that case, we send
traffic to the "dead" slave interface.

The fix is to make sure both the carrier and admin state are up before we put
the slave into the active set for forwarding traffic.

Change-Id: I93b1c36d5481ca76cc8b87e8ca1b375ca3bd453b
Signed-off-by: Steven <sluong@cisco.com>
5 years agobuffers: wrap vlib_buffer_t to union and expose vector types 26/17026/3
Damjan Marion [Wed, 23 Jan 2019 15:52:10 +0000 (16:52 +0100)]
buffers: wrap vlib_buffer_t to union and expose vector types

Change-Id: I1c12e2941cae198ededbb65eb5be51a4eabe2c1b
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agopg: cli improvement 09/16909/6
Kingwel Xie [Sun, 20 Jan 2019 03:49:26 +0000 (22:49 -0500)]
pg: cli improvement

1. show packet-generator verbose, display all edit-groups and hdr-size
2. unformat_pg_payload, always mark payload hdr-size as 0
3. packet-generator now can change rate/limit/size at runtime
4. validate_stream checks buffer min-size/max-size against all edit
   groups' header size
5. remove incorrect max packet size limit check in validate_stream(...)

Change-Id: Ic45e4f2b98bc0fd7330e0b480dd677fa3c69a677
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agocmake: fix debian preinst script 18/17018/1
Damjan Marion [Wed, 23 Jan 2019 14:58:53 +0000 (15:58 +0100)]
cmake: fix debian preinst script

Change-Id: I312beccb1bb6c02d6356bc9b8247178f11b8feb0
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoInitialize gc_mark_timestamp to zero to avoid garbage values. 78/16978/2
Brian Nesbitt [Tue, 22 Jan 2019 14:47:53 +0000 (14:47 +0000)]
Initialize gc_mark_timestamp to zero to avoid garbage values.

Change-Id: Ib3f030e906da9828fdad27e19b9efb0c349b0734
Signed-off-by: Brian Nesbitt <brian.nesbitt@owmobility.com>
5 years agovppinfra: add CLIB_CACHE_LINE_ROUND() macro 09/17009/2
Damjan Marion [Wed, 23 Jan 2019 11:51:36 +0000 (12:51 +0100)]
vppinfra: add CLIB_CACHE_LINE_ROUND() macro

Change-Id: Ic141162acaf39878ab978a997e3f6757d4f7c240
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agopmalloc: don't iterate if there is no enough free space 08/17008/1
Damjan Marion [Wed, 23 Jan 2019 11:50:24 +0000 (12:50 +0100)]
pmalloc: don't iterate if there is no enough free space

Change-Id: I975d46a82e9f884a9cd0ac2bd5f57181695f4124
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agovirtio: Add support for logging 67/16967/2
Mohsin Kazmi [Mon, 21 Jan 2019 15:19:39 +0000 (15:19 +0000)]
virtio: Add support for logging

Change-Id: Ieadf0a97379ed8b17241e454895c4e5e195dc52f
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agoAH encrypt; don't double enqueue nor emit clib_warnings when seq-num max exceeded 77/16977/2
Neale Ranns [Tue, 22 Jan 2019 14:42:23 +0000 (06:42 -0800)]
AH encrypt; don't double enqueue nor emit clib_warnings when seq-num max exceeded

Change-Id: Id5b47f78521a0cbedf7bd2c72babfb2ffe9fa67d
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agolisp: cli for marking local mappings authoritative 49/16949/2
Florin Coras [Tue, 22 Jan 2019 01:36:28 +0000 (17:36 -0800)]
lisp: cli for marking local mappings authoritative

Change-Id: I92af6455b50a49de4c912737fcd3b7787dd31de0
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoIP route local and connected 98/16998/2
Neale Ranns [Wed, 23 Jan 2019 08:36:16 +0000 (00:36 -0800)]
IP route local and connected

allow routes that are local and connected to be added via the API.
this emulates the addition of a second address in the same subnet
added to an interface.

Change-Id: Ib18a08c26956be9a07b3360664210c8cf6734c84
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agovcl: generate epoll events only if requested 89/16989/4
Florin Coras [Wed, 23 Jan 2019 03:05:52 +0000 (19:05 -0800)]
vcl: generate epoll events only if requested

Change-Id: I6e96607f09c18755eead2c7099e1f546bdae7b88
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoVTL: Test against latest version of syslog_rfc5424_parser. 92/16992/1
Paul Vinciguerra [Wed, 23 Jan 2019 03:58:47 +0000 (19:58 -0800)]
VTL: Test against latest version of syslog_rfc5424_parser.

The latest version moved to lark from pyparsing.  The developers were
kind enough to verify that their new grammar works with our tests.

Change-Id: I260b7e4641f6e283862f706c1e52199e28facc5c
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agogbp: fix inlining issue 79/16979/1
Damjan Marion [Tue, 22 Jan 2019 15:07:27 +0000 (16:07 +0100)]
gbp: fix inlining issue

Change-Id: Idbbe5996a5749733a904433b57cba7ab63fdbbcb
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoGBP: Sclass to src-epg conversions 52/16952/3
Neale Ranns [Tue, 22 Jan 2019 07:34:18 +0000 (23:34 -0800)]
GBP: Sclass to src-epg conversions

Change-Id: Ica88268fd6a6ee01da7e9219bb4e81f22ed2fd4b
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agovirtio: Add api support in vat 78/16878/5
Mohsin Kazmi [Fri, 18 Jan 2019 10:50:00 +0000 (11:50 +0100)]
virtio: Add api support in vat

Change-Id: I46ec5ba03d61c1fe0aba92f649f43746b5292cc3
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agocmake: supress 'Set runtime path of' noise while generatig deb packages 59/16959/2
Damjan Marion [Tue, 22 Jan 2019 10:14:46 +0000 (11:14 +0100)]
cmake: supress 'Set runtime path of' noise while generatig deb packages

Change-Id: Ib8ddce2d56034152a390ca2d3b9784673a77d2e3
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agocmake: fix debian package dependencies 55/16955/3
Damjan Marion [Tue, 22 Jan 2019 09:48:30 +0000 (10:48 +0100)]
cmake: fix debian package dependencies

Change-Id: Ib27c43a561dd000f8361ff732e76c6297a7ba900
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agocmake: place include/ and share/ in /usr (debian packages) 56/16956/3
Damjan Marion [Tue, 22 Jan 2019 09:28:29 +0000 (10:28 +0100)]
cmake: place include/ and share/ in /usr (debian packages)

Change-Id: I980b76fb766d5734d4e822409a11ed09a06108a6
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoNAT: ipfix call optimization 57/16957/2
Filip Varga [Tue, 22 Jan 2019 08:43:44 +0000 (00:43 -0800)]
NAT: ipfix call optimization

Change-Id: I84dfdbb727fb765fcaa7fb0099cbdd7ef7dbcc10
Signed-off-by: Filip Varga <fivarga@cisco.com>
5 years agoVTL: VppTestResult: Must implement empty constructor. 43/16843/2
Paul Vinciguerra [Wed, 16 Jan 2019 19:12:50 +0000 (11:12 -0800)]
VTL: VppTestResult: Must implement empty constructor.

Subclasses of (unittest.TestResult|unittest.TextTestResult) must implement an empty constructor.

The standard python library unittests depend on the empty constructor.

Change-Id: I6d1bd2e7d6996d85a9da66cb7d40af0ed3c30e2b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agocmake: don't set SONAME for plugins 51/16951/2
Damjan Marion [Tue, 22 Jan 2019 08:11:50 +0000 (09:11 +0100)]
cmake: don't set SONAME for plugins

Change-Id: I8cd782bb36a4c063afa312002192c254fd51bf5e
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agocmake: package-deb target uses terminal 50/16950/2
Damjan Marion [Tue, 22 Jan 2019 08:10:16 +0000 (09:10 +0100)]
cmake: package-deb target uses terminal

Change-Id: I81b686cc1911c2ff52ead15c8199bdf9430fe59b
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoVOM: GBP bridge domain flags 22/16922/2
Neale Ranns [Thu, 10 Jan 2019 16:00:22 +0000 (08:00 -0800)]
VOM: GBP bridge domain flags

Change-Id: Ib5e4a850e127dda51318ffe82ef2622b980bc947
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoVTL: test/lisp.py Fix recursion error. 14/16914/3
Paul Vinciguerra [Mon, 21 Jan 2019 00:36:01 +0000 (16:36 -0800)]
VTL: test/lisp.py Fix recursion error.

Accessing priority causes a recursion error.

Change-Id: Ic8cc5c9e198b7da955bc24ea116e9826004cad5e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVTL: test/lisp.py. Add missing method: object_id(). 15/16915/2
Paul Vinciguerra [Mon, 21 Jan 2019 01:11:48 +0000 (17:11 -0800)]
VTL: test/lisp.py.  Add missing method: object_id().

Change-Id: I7609a7b173cbfc1de10b346cc8075bca5a40ef3a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agovirtio: Native virtio driver 85/15085/34
Mohsin Kazmi [Tue, 23 Oct 2018 16:00:47 +0000 (18:00 +0200)]
virtio: Native virtio driver

Change-Id: Id7fccf2f805e578fb05032aeb2b649a74c3c0e56
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agoVPP-1549 Add missing counter name. 44/16944/2
Paul Vinciguerra [Mon, 21 Jan 2019 16:48:21 +0000 (08:48 -0800)]
VPP-1549 Add missing counter name.

show interface

              Name               Idx    State  MTU (L3/IP4/IP6/MPLS)     Counter          Count
local0                            0     down          0/0/0/0
pg0                               1     down         9000/0/0/0     rx packets                   582
                                                                    rx bytes                   34051
                                                                    tx packets                     4
                                                                    tx bytes                     364
                                                                    drops                        323
                                                                    ip6                            1
                                                                    (nil)                        580

----
show interface
              Name               Idx    State  MTU (L3/IP4/IP6/MPLS)     Counter          Count
local0                            0     down          0/0/0/0
pg0                               1     down         9000/0/0/0     rx packets                   582
                                                                    rx bytes                   34051
                                                                    tx packets                     4
                                                                    tx bytes                     364
                                                                    drops                        323
                                                                    ip6                            1
                                                                    mpls                         580

Change-Id: I3dcde4799764277535baf42f855e4e8bb48c0d02
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoldp: add support for TCP_CONGESTION sockopts (VPP-1550) 45/16945/3
Florin Coras [Mon, 21 Jan 2019 17:03:10 +0000 (09:03 -0800)]
ldp: add support for TCP_CONGESTION sockopts (VPP-1550)

Change-Id: I0fcf3385cc4fb96f000b84d5f880f74131c0d60f
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agodoxygen formatting fix: prevent stray examples appearing in the docs 43/16943/2
Andrew Yourtchenko [Mon, 21 Jan 2019 15:01:41 +0000 (16:01 +0100)]
doxygen formatting fix: prevent stray examples appearing in the docs

The 'example' keyword triggers the creation of very out-of-context
example in the "Examples" top level of documentation. Rename the
keyword in the comment so the comment is still readable, but
does not trigger the doxygen.

Change-Id: Iecbdc236918f9178a034817aa6cea7ab6b2c1654
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit 1705599efe5eec09c09d2214da776d92d0e4f1cf)

5 years agocmake: fix missing install() lines for startup.conf and 80-vpp.conf 38/16938/2
Damjan Marion [Mon, 21 Jan 2019 15:35:13 +0000 (16:35 +0100)]
cmake: fix missing install() lines for startup.conf and 80-vpp.conf

Change-Id: I5bbd44fb1ce5923350bcf1a42b1d85131eaa3747
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoFix LB lookup table failed issue 16/16916/2
Hongjun Ni [Mon, 21 Jan 2019 10:07:11 +0000 (18:07 +0800)]
Fix LB lookup table failed issue

Change-Id: Icd21f456089c72c91a8328f963bf47a8c7725195
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
5 years agoNAT: VPP-1537 IPFIX per worker processing 75/16875/7
Filip Varga [Mon, 21 Jan 2019 08:05:03 +0000 (00:05 -0800)]
NAT: VPP-1537 IPFIX per worker processing

Change-Id: I428bd25a513eb9fe65bea56572fea8cab7c51681
Signed-off-by: Filip Varga <fivarga@cisco.com>
5 years agoSimplify test/util.py:ppp. 32/16732/3
Paul Vinciguerra [Wed, 9 Jan 2019 05:36:39 +0000 (21:36 -0800)]
Simplify test/util.py:ppp.

Change-Id: I10596335c7e8f51afc4bcee75132b7a25ebf2a4e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVTL: Add **kwargs to VppTestRunner constructor. 96/16796/3
Paul Vinciguerra [Mon, 14 Jan 2019 05:32:37 +0000 (21:32 -0800)]
VTL: Add **kwargs to VppTestRunner constructor.

        Subclasses should accept **kwargs to ensure compatibility as the
        interface changes.

https://github.com/python/cpython/blob/master/Lib/unittest/runner.py#L133

Change-Id: Ia64ffd88899d207a5422f066700d2f7f9c77622e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agocrypto-input: fix crash bug 19/16619/4
Kingwel Xie [Wed, 26 Dec 2018 02:31:28 +0000 (21:31 -0500)]
crypto-input: fix crash bug

as this node is refactored in new style with
vlib_buffer_enqueue_to_next, we have to check if the 'count'
is greater than 0. otherise, the next_index would be invalid
then lead to a crash

Change-Id: If7c323b59c02b5c16bd9d77b65c946512cc972c1
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
5 years agodpdk: add buffer.h 07/16907/3
Damjan Marion [Sun, 20 Jan 2019 01:02:51 +0000 (02:02 +0100)]
dpdk: add buffer.h

Change-Id: I998658ad7860b23425444e218ce2e1ec655b885a
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agobuffers: remove VLIB_BUFFER_DEFAULT_FREE_LIST macro and fl->n_data_bytes 08/16908/4
Damjan Marion [Sun, 20 Jan 2019 01:24:53 +0000 (02:24 +0100)]
buffers: remove VLIB_BUFFER_DEFAULT_FREE_LIST macro and fl->n_data_bytes

Change-Id: I0ba5175be077c40556f2a3ce629c5bbcd71e0a81
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agobuffers: remove vlib_buffer_delete_free_list 06/16906/2
Damjan Marion [Sun, 20 Jan 2019 00:48:05 +0000 (01:48 +0100)]
buffers: remove vlib_buffer_delete_free_list

Change-Id: I5fe01e918b534d1ac1d47f0d7610536f45c3158c
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agobuffers: don't init metadata, as it is already initialized 04/16904/3
Damjan Marion [Sat, 19 Jan 2019 23:11:22 +0000 (00:11 +0100)]
buffers: don't init metadata, as it is already initialized

Change-Id: Ia083050389853c25b069f0f8286d50d3f4aef527
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agobuffers: keep buffer_main in vlib_main_t 03/16903/3
Damjan Marion [Sat, 19 Jan 2019 23:03:56 +0000 (00:03 +0100)]
buffers: keep buffer_main in vlib_main_t

Change-Id: I3bb1d9f83dd08f4b93acd4a281bfec0674e39c2e
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoStore numa-noda and cpu-index in vlib_main_t 02/16902/3
Damjan Marion [Sat, 19 Jan 2019 22:45:36 +0000 (23:45 +0100)]
Store numa-noda and cpu-index in vlib_main_t

Change-Id: If88ccd965122b9318a39a8d71b53334cd1fd81e4
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoRework of debian packaging 82/16882/14
Damjan Marion [Fri, 18 Jan 2019 12:28:22 +0000 (13:28 +0100)]
Rework of debian packaging

Change-Id: Ifede85d3af36f3ee6c6f8f92dcf5db0ed8f1bfeb
Signed-off-by: Damjan Marion <damarion@cisco.com>
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agofix data_length in IpSec API call (VPP-1548) 69/16869/5
Michal Cmarada [Fri, 18 Jan 2019 11:51:08 +0000 (12:51 +0100)]
fix data_length in IpSec API call (VPP-1548)

Change-Id: Idb2839f6082bd2e052be2bc5417f0ebb43d1c0a6
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
5 years agolog: bug fix register class compare mismatch 71/16771/3
Su Wang [Fri, 11 Jan 2019 17:46:05 +0000 (12:46 -0500)]
log: bug fix register class compare mismatch

1. Otherwise, the log classes with same prefix, e.g. "abc" and
   "abc-de" will all be registered into log class "abc";
2. Minor improvement for test log help string.

Change-Id: I8d93be5e8fa67db6012198b3442a9e2bddcb744a
Signed-off-by: Su Wang <su.z.wang@ericsson.com>
5 years agominor fixup in map doc (people -> seconds) 11/16911/1
Jim Thompson [Sun, 20 Jan 2019 06:44:43 +0000 (00:44 -0600)]
minor fixup in map doc (people -> seconds)

Change-Id: I151c1afac2133ad32ad7779a59fffafee4b9de60
Signed-off-by: Jim Thompson <jim@netgate.com>
5 years agotcp: fix debugging without cc stats (VPP-1547) 05/16905/4
Florin Coras [Sun, 20 Jan 2019 00:45:13 +0000 (16:45 -0800)]
tcp: fix debugging without cc stats (VPP-1547)

Change-Id: I376856fcadce570bb555064435f5876eefb2befa
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agosession: add support for vrf in session unformat (VPP-1546) 01/16901/3
Florin Coras [Sat, 19 Jan 2019 19:29:18 +0000 (11:29 -0800)]
session: add support for vrf in session unformat (VPP-1546)

Change-Id: Ic5ba751c2bd2db9af4a21d3db40cc305d1208c30
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoFix GCC 8 compiler warnings on strncpy's truncated copy on debian distro 98/16898/1
Steven Luong [Sat, 19 Jan 2019 06:53:18 +0000 (22:53 -0800)]
Fix GCC 8 compiler warnings on strncpy's truncated copy on debian distro

For some reason, GCC 8 in debian is pickier than GCC 8 in ubuntu. It complains
about things in strncpy like this

/home/sluong/vpp/src/vlib/linux/pci.c:485:7: error: ‘strncpy’ output may be
truncated copying 15 bytes from a string of length 255 [-Werror=stringop-truncation]
       strncpy (ifr.ifr_name, e->d_name, sizeof (ifr.ifr_name) - 1);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sluong/vpp/src/vlib/linux/pci.c: At top level:

It also complains similar things in string_test.c

The fix in pci.c is to convert strncpy to use clib_strncpy
The fix in string_test.c is condiational compile the complained code for GCC 8.

Change-Id: Ic9341ca54ed7407210502197a28283bc42c26662
Signed-off-by: Steven Luong <sluong@cisco.com>
5 years agobuffers: remove free-list information from buffer metadata 94/16894/4
Damjan Marion [Fri, 18 Jan 2019 19:45:30 +0000 (20:45 +0100)]
buffers: remove free-list information from buffer metadata

Change-Id: I6048c6a51efa826ac333f7d15919cb87dd766d74
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agobuffers: remove freelist argument from vlib_buffer_add_data 93/16893/4
Damjan Marion [Fri, 18 Jan 2019 19:24:44 +0000 (20:24 +0100)]
buffers: remove freelist argument from vlib_buffer_add_data

Change-Id: Idb224b807373128b78dc46f177b2d2e0ed288349
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoAdd vlib_buffer_copy_indices inline function 92/16892/4
Damjan Marion [Fri, 18 Jan 2019 19:03:41 +0000 (20:03 +0100)]
Add vlib_buffer_copy_indices inline function

This reverts commit 1e59f9ddbdda14591967e1d66eab8623f9ba58e4.

Change-Id: Iae1d372b887e170d28cac2fe4c61325ee5a5894a
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agocmake: print all flags 59/16859/7
Damjan Marion [Thu, 17 Jan 2019 17:25:11 +0000 (18:25 +0100)]
cmake: print all flags

Change-Id: Ie80ed430d8c9e2b8fe736402d357ac8b190ca6b7
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoLook for plugins in target triplet subdir 79/16879/3
Damjan Marion [Fri, 18 Jan 2019 16:09:44 +0000 (17:09 +0100)]
Look for plugins in target triplet subdir

Change-Id: I3bab0ab05b4f552ad64392439fb48409ab0ab8c0
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agodeprecate clib_memcpy64_x4 91/16891/3
Damjan Marion [Fri, 18 Jan 2019 18:56:09 +0000 (19:56 +0100)]
deprecate clib_memcpy64_x4

Storing buffer in local template seems to be better option....

Change-Id: I1a2fdd68cb956f99a5b36d2cd810fc623e089bcf
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agotcp: allow data in passive open ack (VPP-1545) 95/16895/1
Florin Coras [Fri, 18 Jan 2019 20:12:29 +0000 (12:12 -0800)]
tcp: allow data in passive open ack (VPP-1545)

Change-Id: Iceb99d3f8b7029bd1b1e9ebafb1e0b3790c573e4
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoVTL: Fix sphinx doc generation. 94/16794/3
Paul Vinciguerra [Sun, 13 Jan 2019 19:33:52 +0000 (11:33 -0800)]
VTL: Fix sphinx doc generation.

Remove unnecessary envvar magic for sphinx builds.
Just provide the proper mock objects.

Change-Id: I151513eb47d2f71cf221651145dbcdc153448772
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVTL: Use latest version of syslog_rfc5424_parser (0.2.0) released: 190117 81/16881/2
Paul Vinciguerra [Fri, 18 Jan 2019 16:20:31 +0000 (08:20 -0800)]
VTL: Use latest version of syslog_rfc5424_parser (0.2.0) released: 190117

Upstream changes not compatable with: https://gerrit.fd.io/r/#/c/16797/

Running tests using custom test runner
Active filters: file=test_syslog.py, class=None, function=None
Adding tests from directory tree /vpp/test
1 out of 914 tests match specified filters
Not running extended tests (some tests will be skipped)
==============================================================================
Syslog Protocol Test Cases
==============================================================================
Syslog Protocol test                                                     OK

==============================================================================
TEST RESULTS:
     Scheduled tests: 1
      Executed tests: 1
        Passed tests: 1
==============================================================================

Test run was successful

Change-Id: I42f86ae3e7f062c0343025ba16bc6e8d2c34ed50
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agovcl: move forking logic to vls 28/16828/11
Florin Coras [Tue, 15 Jan 2019 16:03:17 +0000 (08:03 -0800)]
vcl: move forking logic to vls

Change-Id: I721542aca139d7908a4f917629856f82cae79962
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoVTL: Don't swallow exceptions from syslog_rfc5424_parser 14/16814/2
Paul Vinciguerra [Mon, 14 Jan 2019 16:51:17 +0000 (08:51 -0800)]
VTL: Don't swallow exceptions from syslog_rfc5424_parser

Change-Id: I4e93073ceb7b75476e847ae8d56301770c8b264f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVOM: ip-mroute inspect register handler fix 57/16857/2
Neale Ranns [Thu, 17 Jan 2019 16:28:58 +0000 (08:28 -0800)]
VOM: ip-mroute inspect register handler fix

Change-Id: I57689446005da00fa064e2938cfe55a9e1cef9fc
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agocmake: initial cross-compilation support 15/16815/7
Damjan Marion [Mon, 14 Jan 2019 23:36:03 +0000 (00:36 +0100)]
cmake: initial cross-compilation support

Change-Id: Ib9c2aba1eda08a22465441e33553b9b744c79d56
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agotls: preallocate app sessions on connect/accept 19/16819/3
Florin Coras [Tue, 15 Jan 2019 07:33:46 +0000 (23:33 -0800)]
tls: preallocate app sessions on connect/accept

Avoid allocating session and possibly reallocating thread session pool
on builtin session rx.

Change-Id: I70e7c604678b44ce8d22603489e247a2c5faa439
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agovcl/session: replicate events for shared sessions 16/16816/5
Florin Coras [Tue, 15 Jan 2019 01:23:11 +0000 (17:23 -0800)]
vcl/session: replicate events for shared sessions

Change-Id: I7fb5402d4a530b5f2ffd9bb5787632099f4b4189
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoVTL: Move doc generation and linting to python3. 93/16793/2
Paul Vinciguerra [Sun, 13 Jan 2019 18:36:17 +0000 (10:36 -0800)]
VTL: Move doc generation and linting to python3.

* running linting/pycodestyle under python3 provides the additional benefit
  of access to the python3 AST.

Change-Id: I659dbd2733471285867be95eec078f7415aa0bcd
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoDOC ONLY: wireshark dissector upstreamed 54/16854/1
Dave Barach [Thu, 17 Jan 2019 14:30:43 +0000 (09:30 -0500)]
DOC ONLY: wireshark dissector upstreamed

Remove the last remnant from extra/wireshark, update the Sphinx docs

Change-Id: I5886557f17192475c03fcb0dfde581e1e63cea5c
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoFix ASSERT usage issue in cryptodev 44/16844/2
Simon Zhang [Thu, 17 Jan 2019 02:32:48 +0000 (10:32 +0800)]
Fix ASSERT usage issue in cryptodev

Change-Id: I764c6565f96e0cb9078503e54e3cf3bb3fd9ff3f
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
5 years agocmake3 exsit in epel(centos), install epel-release 21/16821/2
drenfong.wang [Tue, 15 Jan 2019 08:24:26 +0000 (08:24 +0000)]
cmake3 exsit in epel(centos), install epel-release

Change-Id: Ide06350dfb083ec25a52f6ef79f106abd80ccdbc
Signed-off-by: drenfong.wang <drenfong.wang@intel.com>
5 years agovmbus: fix strncpy related warnings 41/16841/2
Stephen Hemminger [Wed, 16 Jan 2019 18:08:39 +0000 (10:08 -0800)]
vmbus: fix strncpy related warnings

The code that was manipulating interface names with ifreq was
causing warnings about possible truncation and non terminated
strings.

These are warnings only since kernel would allow a interface
name > 15 characters anyway.

Change-Id: I794a94fe310b8568403d4e3523c61d53468a6f02
Reported-by: Burt Silverman <burtms@gmail.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
5 years agopci: fix strncpy warnings 40/16840/2
Stephen Hemminger [Wed, 16 Jan 2019 18:23:16 +0000 (10:23 -0800)]
pci: fix strncpy warnings

Doing strncpy(ifr.ifr_name, s, sizeof(ifr.ifr_name)) will cause
a warning about string truncation with GCC 8 (and other tools).
Fix this by using sizeof(ifr.ifr_name) - 1. Also, there is no
need to manually zero the end of the string since the whole
ifr structure is already zeroed by memset.

Change-Id: I9440d602ecdd9f8592b69bab2e77479146d00d76
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
5 years agofix dpdk cryptodev enable issue 33/16833/3 v19.04-rc0
Simon Zhang [Wed, 16 Jan 2019 08:09:33 +0000 (16:09 +0800)]
fix dpdk cryptodev enable issue

Change-Id: I47d021522cfc92cfb3877449333cbf31022c06f4
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
5 years agoNAT: Fixed issues with dropping reverse packets with output-feature. 38/16838/1
Dmitry Vakhrushev [Wed, 16 Jan 2019 14:44:03 +0000 (09:44 -0500)]
NAT: Fixed issues with dropping reverse packets with output-feature.

Fixed NAT issues with dropping reverse packets in case NAT worked
in 'endpoint-dependent' mode and outside interface has FIB different
from 0 when the output-feature is set.

In this case, the out2in_ed dynamic hash key was not being created
correctly.

Change-Id: I6362967f4b09a375a4606eedaa8e264795b25453
Signed-off-by: Dmitry Vakhrushev <dmitry@netgate.com>
5 years agomake test: raise packet tracing limit to 1000 26/16826/4
Klement Sekera [Tue, 15 Jan 2019 12:25:09 +0000 (13:25 +0100)]
make test: raise packet tracing limit to 1000

Change-Id: I4309cefe13ee861342e7962c7652919a47748656
Signed-off-by: Klement Sekera <ksekera@cisco.com>
5 years agoDOC ONLY: update readme.md 36/16836/1
Dave Barach [Wed, 16 Jan 2019 13:21:16 +0000 (08:21 -0500)]
DOC ONLY: update readme.md

Remove the source code, replace with reference to the upstreamed
patch.

Change-Id: I6f5430b1e9804530afbec1805353852e1da745d6
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agovmxnet3: add numa support and link speed 31/16831/1
Steven [Tue, 15 Jan 2019 17:26:18 +0000 (09:26 -0800)]
vmxnet3: add numa support and link speed

Allocate physmem on the same numa
set link speed
cap vmxnet3 support version to 3 if the device supports higher version

Change-Id: Id47dd83b0da53e623fd6cf3ad010e58158b1ab15
Signed-off-by: Steven <sluong@cisco.com>
5 years agoapi_helper_macro mp->pid is network endian 20/16720/4
Ole Troan [Mon, 7 Jan 2019 21:17:31 +0000 (22:17 +0100)]
api_helper_macro mp->pid is network endian

Change-Id: I7d2385b9e9bf5a62f3e9382ca2627a74a4e30785
Signed-off-by: Ole Troan <ot@cisco.com>
5 years agoVTL: vpp_papi_provider: Don't shortcircuit vpp_papi jasonfile detection. 92/16792/3
Paul Vinciguerra [Sun, 13 Jan 2019 18:26:05 +0000 (10:26 -0800)]
VTL: vpp_papi_provider: Don't shortcircuit vpp_papi jasonfile detection.

The detection login in vpp_papi is significantly more advanced than
the implementation in vpp_papi_provider.

Let's take full advantage of it and ensure consistent behavior.

Change-Id: I786e6d5f4588a0d74e863cce1b0bc1a93fa0e614
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVTL: Allow running simple unittest.TestCases. 95/16795/12
Paul Vinciguerra [Mon, 14 Jan 2019 00:09:10 +0000 (16:09 -0800)]
VTL:  Allow running simple unittest.TestCases.

It came to my attention that Ole added a simple test in:
https://gerrit.fd.io/r/#/c/16381/ and the framework forced him
to launch an instance of VPP to test the formatting of a mac address.

This change allows the test framework to run standard unittest.TestCases
without the need to spawn a VPP instance.

Change-Id: I56651ab27c4c6bf920081a526f168a743d643201
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVTL: New version of pyparsing breaks tests. 97/16797/2
Paul Vinciguerra [Mon, 14 Jan 2019 06:00:46 +0000 (22:00 -0800)]
VTL: New version of pyparsing breaks tests.

Specify use of version <2.3.1 released Jan 13, 2019

Change-Id: I23cfb802a677956b77897e0c2b690fac50e18541
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoremove useless line in dpdk cryptodev 29/16729/2
Simon Zhang [Wed, 9 Jan 2019 01:25:18 +0000 (09:25 +0800)]
remove useless line in dpdk cryptodev

Change-Id: I2ef33c7c15b3eb1f55bbfd5cbdd230d6a4d58936
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
5 years agobonding: support custom interface IDs 65/16465/8
Alexander Chernavin [Thu, 13 Dec 2018 14:08:09 +0000 (09:08 -0500)]
bonding: support custom interface IDs

Change-Id: I78fe58144fa3ba2e1c7135897a13a2541f235c91
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
5 years agodpdk: show hardware may display the wrong information for rss active 66/16766/2
Steven [Fri, 11 Jan 2019 16:29:41 +0000 (08:29 -0800)]
dpdk: show hardware may display the wrong information for rss active

Some dpdk driver does not support rte_eth_dev_rss_hash_conf_get. When that
happens, we display whatever that was in the stack variable for rss_hf which
is confusing.

The fix is to clear rss_hf prior to the call.

Before the fix
--------------
DBGvpp# sh hard
              Name                Idx   Link  Hardware
format_dpdk_device:599: rte_eth_dev_rss_hash_conf_get returned -95
GigabitEthernet13/0/0              2     up   GigabitEthernet13/0/0
  Link speed: 10 Gbps
  Ethernet address 00:0c:29:c4:8c:eb
  VMware VMXNET3
  ...
    rss avail:         ipv4 ipv4-tcp ipv6 ipv6-tcp
    rss active:        ipv4 ipv4-frag ipv4-tcp ipv4-udp ipv4-other

After the fix
-------------
DBGvpp# sh hard
              Name                Idx   Link  Hardware
format_dpdk_device:600: rte_eth_dev_rss_hash_conf_get returned -95
GigabitEthernet13/0/0              2     up   GigabitEthernet13/0/0
  Link speed: 10 Gbps
  Ethernet address 00:0c:29:c4:8c:eb
  VMware VMXNET3
  ..
    rss avail:         ipv4 ipv4-tcp ipv6 ipv6-tcp
    rss active:        none

Change-Id: If8f8327f0012eecc8d23cd7f3f9cc581ca025654
Signed-off-by: Steven <sluong@cisco.com>
5 years agosession: generate wrong thread errors instead of crashing 58/16758/4
Florin Coras [Thu, 10 Jan 2019 20:42:47 +0000 (12:42 -0800)]
session: generate wrong thread errors instead of crashing

Change-Id: I7e59ae718d2722c49d42b22a0874e1645a191e89
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoFix custom-dump for gre_add_del_tunnel: src and dst IPs 67/16767/2
Igor Mikhailov (imichail) [Fri, 11 Jan 2019 21:59:04 +0000 (13:59 -0800)]
Fix custom-dump for gre_add_del_tunnel: src and dst IPs

Change-Id: I747ca01dc8df9fb5e11168ec46979c4a1f1baa7c
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>