Neale Ranns [Tue, 5 Mar 2019 12:22:08 +0000 (04:22 -0800)]
GBP: per-group EP retention policy
Change-Id: I3ed4e2e92f74f15b07fcd3e7fbc3fa8718d5249d
Signed-off-by: Neale Ranns <nranns@cisco.com>
Filip Tehlar [Mon, 4 Mar 2019 17:21:59 +0000 (09:21 -0800)]
gre: migrate old MULTIARCH macros to VLIB_NODE_FN
Change-Id: I0f6b9f306f2323216ba64b694e8fdfa116e6cc9c
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Mon, 4 Mar 2019 22:11:25 +0000 (14:11 -0800)]
L2: ARP term - learn but don't send response to GARPs
Change-Id: I766767d27f37493dc9f2bde1297c1b620cd1e321
Signed-off-by: Neale Ranns <nranns@cisco.com>
Ole Troan [Mon, 4 Mar 2019 22:55:43 +0000 (23:55 +0100)]
test framework: Fix wrapper functions to match API message names.
In preparation to remove the wrappers in vpp_papi_provider.py, ensure
names used in tests match the actual API message names.
Change-Id: I230ca4eb75aa727ff68d702e085a2edbbc6b6d19
Signed-off-by: Ole Troan <ot@cisco.com>
Neale Ranns [Mon, 4 Mar 2019 13:44:42 +0000 (13:44 +0000)]
IPSEC: script to bounce IPSEC traffic through a pipe to test encrypt and decrpyt
Change-Id: I262a9412951b5df616920a8fad16c61eae96d0cc
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Mon, 4 Mar 2019 13:52:54 +0000 (08:52 -0500)]
Fix 2x overconsumption of debug cli input bugs
Change-Id: I658489dc9cf437ff43d9c69a896c9fe4e01ec38e
Signed-off-by: Dave Barach <dave@barachs.net>
Ole Troan [Thu, 28 Feb 2019 19:20:47 +0000 (20:20 +0100)]
test framework: add factory function and default parameters
This is the first step to be able to remove all the API message
wrappers in vpp_papi_provider.py. This allows to remove all
functions that do not override parameters (different from zero),
and a separate dictionary for messages requiring different defaults.
The general requirement is that all new tests should use named
arguments directly. Not positional arguments through the wrapper.
Note when removing functions, the calls in vpp_papi_provider
wrappers do not necessarily follow message order.
Change-Id: If64916c07f8622c138db3a9d7c4a98b93a058e68
Signed-off-by: Ole Troan <ot@cisco.com>
Jakub Grajciar [Mon, 4 Mar 2019 11:42:19 +0000 (12:42 +0100)]
libmemif: Connection request APIs
Add APIs that allow changing reconnect timer and request connection.
First connection request is automatically sent once slave interface is created.
Change-Id: Ie3558b7b94a780b046755f7f0ac6c3dcf07633e4
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Filip Tehlar [Mon, 4 Mar 2019 11:03:13 +0000 (03:03 -0800)]
devices: migrate old MULTIARCH macros to VLIB_NODE_FN
Change-Id: I911fb3f1c6351b37580c5dbde6939a549431a92d
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Mon, 4 Mar 2019 12:21:28 +0000 (04:21 -0800)]
GBP: return appropriate error code if tranport mode subnet has no interface
Change-Id: Ic230b332a01c36454c11d0b6515ec256bd0fd5c6
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Mon, 4 Mar 2019 10:20:04 +0000 (02:20 -0800)]
GBP: Global config for EP retention
Change-Id: I9508c67b494b5edecb2bc393a53e7d47c2574978
Signed-off-by: Neale Ranns <nranns@cisco.com>
Filip Tehlar [Mon, 4 Mar 2019 10:52:54 +0000 (02:52 -0800)]
adj: migrate old MULTIARCH macros to VLIB_NODE_FN
Change-Id: Iac92a6d15e1feef4d97b8db09fc60901dc9f7880
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Damjan Marion [Thu, 28 Feb 2019 22:16:11 +0000 (23:16 +0100)]
buffers: support cases where numa node memory is not available
Change-Id: I550ef893e41d86310d4e5af16d6100b8e557b68a
Signed-off-by: Damjan Marion <damarion@cisco.com>
Vijayabhaskar Katamreddy [Sat, 2 Mar 2019 03:57:06 +0000 (19:57 -0800)]
Hash and handoff reassembly fragments
in the following two scenarios
1. When fragments arrive in multiple interfaces and endup in different threads
2. When fragments arrive in same interafce but in different queues due to interface RSS doesnt have the ability to place fragments in the right queues
Change-Id: I9f9a8a4085692055ef6823d634c8e19ff3daea05
Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Filip Tehlar [Thu, 28 Feb 2019 12:36:10 +0000 (04:36 -0800)]
stats: fix crash on early init
Change-Id: I911b5070f544c3556ad1ca584d42689c00cc38f3
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Mon, 4 Mar 2019 09:14:24 +0000 (01:14 -0800)]
GBP: fix and print GBP BD flags
Change-Id: If3fe2752c9339049123ff4674e3a29449b520374
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Sun, 3 Mar 2019 22:56:05 +0000 (14:56 -0800)]
session: remove svm_segment_index from session struct
Change-Id: I42ef9ee38f93600a0d6f2699b1b2a0a201fcec9c
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Mon, 4 Mar 2019 00:08:51 +0000 (16:08 -0800)]
svm: avoid heap push/pop on fifo free
Change-Id: Id6a7698da0c7b43313554d736c4df60b820beb80
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Mon, 4 Mar 2019 00:46:52 +0000 (16:46 -0800)]
session: eventfd for mq only for bapi socket transport
Change-Id: I9badb376aa31fc2c7c452a16cc4dc997a8a66d97
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Mon, 4 Mar 2019 01:56:48 +0000 (17:56 -0800)]
vcl: remove unused fields and structures
Change-Id: I49a95c4e2eb17e5a6ab514dde2505294a4c01353
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Mon, 4 Mar 2019 09:37:43 +0000 (01:37 -0800)]
GBP: fix UT after multi-arch change
Change-Id: I09c400d71b3c973341fd79fe9b6709592d96822c
Signed-off-by: Neale Ranns <nranns@cisco.com>
Filip Tehlar [Thu, 28 Feb 2019 10:51:47 +0000 (02:51 -0800)]
gbp: migrate old MULTIARCH macros to VLIB_NODE_FN
Change-Id: I3b10caa447b796172f787df8fcbb92f2b4dd2803
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Florin Coras [Sat, 2 Mar 2019 18:47:47 +0000 (10:47 -0800)]
session: remove deprecated binary apis
Change-Id: Ia1a628498fa3b639b6b1508f65c6aea1806f73ec
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Sat, 2 Mar 2019 01:12:02 +0000 (17:12 -0800)]
session: notify app of segment removal
Change-Id: I3774f7ffd14be73e9bbbf4cdd6d3b22f24fee730
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Sat, 2 Mar 2019 03:26:31 +0000 (19:26 -0800)]
session: fix unlisten with invalid handles
Change-Id: I6fbfa06e3df9988254561bf1a770084028117005
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 1 Mar 2019 21:00:58 +0000 (13:00 -0800)]
session: cleanup/rename functions
- remove unused functions
- rename old "stream" functions
Change-Id: Icbb03daa9f9f1c58b5be5c38aa8a9cbcf9159b47
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 1 Mar 2019 20:41:21 +0000 (12:41 -0800)]
session: cleanup session event types
Change-Id: I87bdf705341dd760f0be907a663aa64140977d39
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Thu, 28 Feb 2019 20:49:45 +0000 (12:49 -0800)]
tcp: allow future acks if in window
Change-Id: I84ad1830b8db43f6031cf2876cd94f6a71216b83
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Fri, 1 Mar 2019 18:35:55 +0000 (10:35 -0800)]
Tests: Trivial fox use of 'is'.
'is' evaluates diffently depending on the value.
>>> x=-10
>>> x is -10
False
>>> x=10
>>> x is 10
True
>>>
Change-Id: If72ec7c47e3e95180a4d08a773984253c80154d6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Neale Ranns [Thu, 28 Feb 2019 12:03:58 +0000 (12:03 +0000)]
IPSEC: tunnel-input; don't load the HW interface struct
also fix the stats to include all the data in the tunnel.
And don't load the SA.
Change-Id: I7cd2e8d879f19683175fd0de78a606a2836e6da2
Signed-off-by: Neale Ranns <nranns@cisco.com>
Filip Tehlar [Wed, 27 Feb 2019 16:44:26 +0000 (08:44 -0800)]
nsh: fix load failure
Change-Id: I687ddba41bc80e2fbb39ebc30449ced7254e45f8
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Filip Tehlar [Tue, 26 Feb 2019 12:53:38 +0000 (04:53 -0800)]
gtpu: migrate old MULTIARCH macros to VLIB_NODE_FN
Change-Id: Id6e82910f8d991e355d3f26222eea4ac3ab091b1
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Matthew Smith [Thu, 28 Feb 2019 16:33:12 +0000 (10:33 -0600)]
dpdk: update mlx[45] linking options
Upstream DPDK changed the names of the options to use dlopen()
with libibverbs and libmlx[45] from RTE_LIBRTE_MLX[45]_DLOPEN_DEPS
to RTE_IBVERBS_LINK_DLOPEN (handles both mlx4 and mlx5).
VPP's build option to enable this configuration when building DPDK
no longer worked starting when VPP moved to DPDK 19.02. Update VPP's
build options to enable the correct option name.
Change-Id: I8e34e1d3fc4ee8aac4fd6f2a7d27177f2b0dea50
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Filip Tehlar [Fri, 1 Mar 2019 11:18:58 +0000 (03:18 -0800)]
ioam: migrate old MULTIARCH macros to VLIB_NODE_FN
Change-Id: Icb919a053b35ef62f958c60c725d3aae4c32358f
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Filip Tehlar [Thu, 28 Feb 2019 13:58:56 +0000 (05:58 -0800)]
pppoe: migrate old MULTIARCH macros to VLIB_NODE_FN
Change-Id: I0af8104f6d35820aa39d22cd23d4f9211d61faa0
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Fri, 1 Mar 2019 15:16:40 +0000 (07:16 -0800)]
VOM: mprefix and mpath encode fixes
Change-Id: Id3c281e680683c7267c9db66cc806fed58c8cfcb
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Wed, 27 Feb 2019 15:55:46 +0000 (07:55 -0800)]
session: refactor local connects
- Switches local connects to cut-thru transport
- Removes local sessions as a separate session type
Change-Id: I997c6355d8c8e4f2110678f785b0f5d96bba47f7
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Fri, 1 Mar 2019 10:27:46 +0000 (02:27 -0800)]
VOM: vxlan-tunnel mcast interface fix
Change-Id: Ica6a0b4133ccc1997ef0547274982d0cc9761724
Signed-off-by: Neale Ranns <nranns@cisco.com>
Paul Vinciguerra [Thu, 28 Feb 2019 17:00:09 +0000 (09:00 -0800)]
Tests: Remove all wildcard imports.
They mask dependencies and confuse third party tools.
Change-Id: I24ee16bfa0d746a8e8cb99891ba8b20523048b69
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Thu, 28 Feb 2019 23:34:00 +0000 (15:34 -0800)]
Tests: Refactor duplicated code.
Naveen suggested earlier today that we should refactor duplicate code.
This commit kicks off the effort.
Change-Id: I855b0f40d41d1f3a2e673f3b254b76b596409656
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Dave Barach [Thu, 28 Feb 2019 22:52:57 +0000 (17:52 -0500)]
Save signum and faulting address in static variables
Comes in handy when looking at core files from optimized images.
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I45c8400d15614d5a04a3dcfb9b7daccab47ab446
Igor Mikhailov (imichail) [Tue, 26 Feb 2019 19:53:18 +0000 (11:53 -0800)]
Fix API return code in case of error.
Change-Id: I22f866bacbc9c6e3abb0405f5c5a205910cec17b
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
Ole Troan [Tue, 26 Feb 2019 21:14:13 +0000 (22:14 +0100)]
stats: Add node names in /sys/nodes/names
Change-Id: I9c92d51cc0e9dccf3c3726c4de8d7f15537778c9
Signed-off-by: Ole Troan <ot@cisco.com>
Paul Vinciguerra [Fri, 1 Mar 2019 00:37:16 +0000 (16:37 -0800)]
MAINTAINERS: Add Paul Vinciguerra to test/
Change-Id: Id8a48299eb26f62561b54aa4d240d312f47a952d
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Wed, 27 Feb 2019 04:39:44 +0000 (20:39 -0800)]
vpp_papi.py: Change VppEnum from explicit metaclass to metaclass wrapper/decorator.
Change-Id: Iab41bb972e3c7ec005a1a13d5a25f654ae8c3932
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Thu, 28 Feb 2019 17:06:31 +0000 (09:06 -0800)]
test/vpp_ip_route.py: Trivial. Remove duplicate key.
Change-Id: I2c347daeecd5441b8fe3e3f7527a8e21844668d0
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Naveen Joy [Thu, 28 Feb 2019 16:46:41 +0000 (08:46 -0800)]
Remove unused imports from hooks
Change-Id: I087b057da526c18f8cce1902dcb594dd5ce0a4b8
Signed-off-by: Naveen Joy <najoy@cisco.com>
Ole Troan [Tue, 26 Feb 2019 15:37:03 +0000 (16:37 +0100)]
stats: Add interface name to sw_if_index as /if/names
Expose interface name to sw_if_index table as a directory node in the stats segment.
Change-Id: Ie50e4af01997d141880f02e3a8496bfeb91b9944
Signed-off-by: Ole Troan <ot@cisco.com>
Neale Ranns [Thu, 28 Feb 2019 08:41:26 +0000 (00:41 -0800)]
VOM: child accessors on GBP route domain
Change-Id: I7b74b0b98b2c427bf29bb1d2932044d9924588cb
Signed-off-by: Neale Ranns <nranns@cisco.com>
Filip Tehlar [Tue, 26 Feb 2019 15:28:33 +0000 (07:28 -0800)]
l2e: Migrate old MULTIARCH macros to VLIB_NODE_FN
Change-Id: I55f45d84212e2293e3798dff6850d86d75414d02
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Tue, 19 Feb 2019 10:10:13 +0000 (02:10 -0800)]
MPLS: tunnel delete crash
Change-Id: I4adf713f4a1d596b9c8a78b79b5df2c7eb0c56f0
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Mon, 25 Feb 2019 14:32:02 +0000 (14:32 +0000)]
TEST: IPSEC NAT-T with UDP header
Change-Id: I5ef8b3f4be40a7a0b0f1cb90dc0e15a4711e8664
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Fri, 22 Feb 2019 21:11:38 +0000 (13:11 -0800)]
session: refactor local/cut-through listens
Introduce a cut-through transport as replacement to local sessions. This
first patch removes the per app local listener pools and switches local
listeners to sessions with cut-through transport.
Change-Id: I98b20c25bc5df5f4110bf66f76c650a973032618
Signed-off-by: Florin Coras <fcoras@cisco.com>
jdenisco [Tue, 26 Feb 2019 14:19:24 +0000 (09:19 -0500)]
Fix centos build and build documentation
Change-Id: I326204d26b613254e39c6a0ffe9f9491981ba3c3
Signed-off-by: jdenisco <jdenisco@cisco.com>
Dave Barach [Wed, 27 Feb 2019 17:36:28 +0000 (12:36 -0500)]
VPP-1576: fix Coverity issues
Change-Id: I8b59b2e1c0525abf4b0492e50a7af57df4cd3ce2
Signed-off-by: Dave Barach <dave@barachs.net>
Dave Barach [Wed, 27 Feb 2019 15:14:01 +0000 (10:14 -0500)]
DOC ONLY: update bug report section
More detail on why it's important to supply .debs or .rpms which
precisely match core files. Probably won't help, but we can try...
Change-Id: I7842eaea0ef921b934e84b7f18f6a333b1381292
Signed-off-by: Dave Barach <dave@barachs.net>
Steven Luong [Wed, 27 Feb 2019 16:19:27 +0000 (08:19 -0800)]
string_test: The dark side of coverity
Me: "Mr Coverity, I thought I fixed the dead code warning just few days ago in
this file. Why are you still complaining about the same stuff to me?"
Mr. Coverity: "Duh! But you are supposed to fix all occurences in the same file."
Me: "Mr. Coverity, I didn't see you flag the warning in the other places last
time?"
Mr. Coverity: "Shh! That is the secret of my dark side!"
Change-Id: I565eccd90bf1bb39c9881664d361f83396ca8bcc
Signed-off-by: Steven Luong <sluong@cisco.com>
Neale Ranns [Wed, 27 Feb 2019 10:16:20 +0000 (10:16 +0000)]
IKEv2 plugin export fixes
Change-Id: If6b0edb0dd242e0ef6953c8f4c1826eb80b9e1cc
Signed-off-by: Neale Ranns <nranns@cisco.com>
Matus Fabian [Tue, 26 Feb 2019 17:05:23 +0000 (09:05 -0800)]
NAT44: active-passive HA (VPP-1571)
session synchronization so that we can build a plain active-passive HA NAT pair
Change-Id: I21db200491081ca46b7af3e82afc677c1985abf4
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Damjan Marion [Tue, 26 Feb 2019 16:15:48 +0000 (17:15 +0100)]
Fix crash in barrier sync when vlib_worker_threads is zero
Change-Id: I6819dd9dbfc15c17740bdb98b51bdd639ef8c4d2
Signed-off-by: Damjan Marion <damarion@cisco.com>
Steven Luong [Wed, 27 Feb 2019 00:45:54 +0000 (16:45 -0800)]
vmxnet3: RSS support
Configurable up to 16 RX queues per interface. Default is 1.
Change-Id: If9e2beffeb7e7dc8c2264b4db902132b2fea02c1
Signed-off-by: Steven Luong <sluong@cisco.com>
Dave Barach [Tue, 26 Feb 2019 22:04:40 +0000 (17:04 -0500)]
VPP-1574: minimize RPC barrier sync calls
Grab the thread barrier across a set of RPCs, to greatly increase
efficiency. Avoids running afoul of the barrier sync holddown
timer.
Change-Id: I782dfdb1bed398b290169c83266681c9edd57a3f
Signed-off-by: Dave Barach <dave@barachs.net>
Filip Tehlar [Tue, 26 Feb 2019 10:59:07 +0000 (02:59 -0800)]
nsh: migrate old MUTIARCH macros to VLIB_NODE_FN
Change-Id: Iafe8b3a38f2a7d7571e60db91608d8130bb07cb3
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Ole Troan [Tue, 26 Feb 2019 12:10:56 +0000 (13:10 +0100)]
stats: buffer gauge callbacks use index instead of name.
Change-Id: I500b8e72d7e021b9564dad0ffc087cb0e1ceb96f
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Tue, 26 Feb 2019 17:03:16 +0000 (18:03 +0100)]
vppapigen: Expose "option version" in generated JSON file.
Change-Id: Iaa78ee181589584885b0f377eafb89e603718bd4
Signed-off-by: Ole Troan <ot@cisco.com>
Florin Coras [Mon, 25 Feb 2019 23:17:28 +0000 (15:17 -0800)]
session: fix local binds
Change-Id: I1d92bec29c718de7a517bbbb335d09c68c221c71
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Sun, 25 Nov 2018 05:46:05 +0000 (21:46 -0800)]
VPP-1508 Python3 abstract classes
Update the syntax to support abstract classes in python 2 and python 3.
Depends on: new style classes -- https://gerrit.fd.io/r/16166
Change-Id: Iad2c1240149f38b3faca1b37ab95d3d210e1daee
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Steven Luong [Mon, 25 Feb 2019 20:10:53 +0000 (12:10 -0800)]
vmxnet3: lro/tso and rx checksum
Add lro/tso and rx checksum support. lro/tso is configured via startup.conf
vmxnet3 { lro }
It is disable by default due to not all versions of ESXi supports it.
Change-Id: Icf224ff528884ecd9e655b4fcf4481194e8c5a63
Signed-off-by: Steven Luong <sluong@cisco.com>
Dave Barach [Mon, 25 Feb 2019 20:27:28 +0000 (15:27 -0500)]
Move pcap rx/tx trace code out of the dpdk plugin
Moved code to the ethernet input node, and the interface output
path(s). Since we no longer skip ethernet-input, there's no reason
for device drivers to know anything about pcap rx tracing, etc.
Change-Id: I08d32fb1b90cbee1bd4f609837d533e047b36fa4
Signed-off-by: Dave Barach <dave@barachs.net>
Artem Belov [Tue, 26 Feb 2019 01:47:34 +0000 (01:47 +0000)]
Fix vpp crashing when attempting to run in kubernetes Pod
mmap does not fail but writing to mapped memory is causing sigbus.
Change-Id: I5135f32eede67fccb4aaa07a501cd262d254ed8d
Signed-off-by: Artem Belov <artem.belov@xored.com>
Paul Vinciguerra [Wed, 20 Feb 2019 17:51:54 +0000 (09:51 -0800)]
make test: Stop downloading pip.
Use the installed version of pip. If a newer version of pip is needed,
it can be specified in requirements.txt. This is to improve idempotence
by providing some control over upstream changes.
Change-Id: I07b7651f8ddba6005bf85d11fef9e3343ee2dcd2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Wed, 28 Nov 2018 19:34:21 +0000 (11:34 -0800)]
make test: Add exception handling around subprocess.
This cleans up exception catching to identify oserrors. By raising the
specific exception closer to the offending call, we get additional stack history
and can add clearer error logging to assist in troubleshooting.
Change-Id: I592e4d46844b822a816485bf54910f8daed92088
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Jon Loeliger [Fri, 15 Feb 2019 18:06:11 +0000 (12:06 -0600)]
DSLITE: Fix dslite_get_b4_addr_reply message type.
Fix what appears to be a cut-n-past error.
Change-Id: I71ee32c1b0d2dc38ed3df4bd24ec4248005a6008
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Paul Vinciguerra [Mon, 26 Nov 2018 00:09:26 +0000 (16:09 -0800)]
VPP-1508 python tests: unicode
Change unicode references to use text_type
Change-Id: Ia71c16e3235bc509abd3b1c651ae125f892ab108
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Jon Loeliger [Thu, 21 Feb 2019 19:29:51 +0000 (13:29 -0600)]
Remove fake MAP domain 0 entry.
Problematic:
- It didn't have its counters initialized, so vpp crashed
during a "show map stat"
- Not all the tests for "are there any domains" actually
accounted for the fake entry at pool slot 0.
- Dump details happily returned its bogus entry.
Change-Id: I57aaa9f63917686334fd4a9fa7bc80044bf1718c
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Paul Vinciguerra [Tue, 26 Feb 2019 02:55:28 +0000 (18:55 -0800)]
vpp-papi: Only install enum34 for python<=3.4.
Change-Id: I20d7c8c1a59b3a9aa016bec860289b7aef4ce06b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Dave Barach [Mon, 25 Feb 2019 21:48:57 +0000 (16:48 -0500)]
Fix broken ASSERT
Fix "make TEST=test_vcl test-debug" ASSERT failures.
Change-Id: I58a67b12806660973c8def0e598ef0c5b296eec5
Signed-off-by: Dave Barach <dave@barachs.net>
Neale Ranns [Mon, 25 Feb 2019 17:23:15 +0000 (09:23 -0800)]
VOM: GBP table IDs in GBP route-domain create
Change-Id: I606b28dfb820f8f19e338c7642bfe0e4c116ca58
Signed-off-by: Neale Ranns <nranns@cisco.com>
Jakub Grajciar [Thu, 21 Feb 2019 11:01:31 +0000 (12:01 +0100)]
Remote Test: fix serialization (dict, Enum)
Change-Id: Ia3f8616cbf424c7f2d29d16cf7a457be6cd1b33a
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Neale Ranns [Mon, 25 Feb 2019 10:28:29 +0000 (10:28 +0000)]
IKEv2 to plugin
for easy integration with ptoducts running their own Ike stack.
Without the VPP IKE plugin loaded, the product is free to handle
IKE packets as it pleases.
Change-Id: Id0839f4d58b797f4c2da0382eb499fc08b05f66f
Signed-off-by: Neale Ranns <nranns@cisco.com>
Klement Sekera [Wed, 13 Feb 2019 10:01:32 +0000 (11:01 +0100)]
buffer chain linearization
Rewrite vlib_buffer_chain_linearize function so that it works as intended.
Linearize buffer chains coming out of reassembly to work around some
dpdk-tx issues. Note that this is not a complete workaround
as a sufficiently large packet will still cause the resulting chain to
be too long.
Drop features from reassembly code which relies on knowing which and how
many buffers were freed during linearization, buffer counts and tracing
capabilities for these cases.
Change-Id: Ic65de53ecb5c78cd96b178033f6a576ab4060ed1
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Steven Luong [Thu, 24 Jan 2019 06:20:19 +0000 (22:20 -0800)]
vhoat: potential crash in map_guest_mem using debug image
map_guest_mem may be called from worker-thread/dataplane. It has a call
to vlib_log and may crash inside vlib_log's ASSERT statement
/* make sure we are running on the main thread to avoid use in dataplane
code, for dataplane logging consider use of event-logger */
ASSERT (vlib_get_thread_index () == 0);
The fix is to convert the vlib_log call in map_guest_map to event logger
Change-Id: Iaaf6d86782aa8a18d25e0209f22dc31f04668d56
Signed-off-by: Steven Luong <sluong@cisco.com>
jdenisco [Tue, 19 Feb 2019 21:25:05 +0000 (16:25 -0500)]
Add support for 19.01
Change-Id: I8583f6f6432d8d7c449f43d62d8707a1718f3240
Signed-off-by: jdenisco <jdenisco@cisco.com>
Florin Coras [Fri, 22 Feb 2019 21:11:38 +0000 (13:11 -0800)]
session: separate local session logic
Move local session to separate header and source files. First step to
refactoring local sessions.
Change-Id: I280fdfef20ba8a0977d15c1c8ce030ea2fb72dde
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 22 Feb 2019 17:07:20 +0000 (09:07 -0800)]
tcp: keep snd sack block free list
Instead of constantly reallocating the new sack block list, keep the old
one as a reusable free list.
Change-Id: Iad79a72204f97b96352c1c6eea66c2839a35cfe6
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven Luong [Fri, 22 Feb 2019 19:11:14 +0000 (11:11 -0800)]
Makefile: fix missing help instruction
make pkg-deb-debug and make vom-pkg-deb-debug were missing in the help
instruction
Change-Id: Ic49a7c29b3394ee9fc259bd40ecf0611470125c6
Signed-off-by: Steven Luong <sluong@cisco.com>
Filip Tehlar [Fri, 22 Feb 2019 13:05:53 +0000 (05:05 -0800)]
stats: add buffer gauges
Change-Id: I7f7a459f25d64ea5fa36e30d7dccc667bc19c5a9
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Fri, 22 Feb 2019 18:33:21 +0000 (10:33 -0800)]
VOM: GBP use singular instance if shared-ptr is set
Change-Id: I845e0aa0b657b7a4745c158c4c510f604f4502bb
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 22 Feb 2019 07:34:59 +0000 (23:34 -0800)]
IPSEC: header exports
Change-Id: I7d48a4e236c6e7b11b0c9750a30fb68e829d64a5
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 22 Feb 2019 12:40:53 +0000 (12:40 +0000)]
Callback functions must have the correct signature
Change-Id: I642823bdc3c7006a0b719ec1e3a9cd75b2b37253
Signed-off-by: Neale Ranns <nranns@cisco.com>
Marco Varlese [Fri, 22 Feb 2019 13:18:48 +0000 (14:18 +0100)]
Maintainers list update
Change-Id: I133ad79bac79c50caefed01c638f26ec9b3cd6c3
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Damjan Marion [Fri, 22 Feb 2019 16:25:00 +0000 (17:25 +0100)]
avf: fix eat own tail issue on tx
Change-Id: Ie14ca18bab47ac6765ff0799475d0c2a4d936f90
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Fri, 22 Feb 2019 14:15:57 +0000 (06:15 -0800)]
VOM: mroute dump debug level fix
Change-Id: Ice8c3e76857ee35c079d72d6697e6a3fbc99b7aa
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 22 Feb 2019 08:44:40 +0000 (00:44 -0800)]
VOM: De-template the ACL code.
there's something going wrong with the dependency ordering.
i have added hacks in the past, but these are not reliable
across compiler versions.
Change-Id: I34b4aae4c7ed7beaa424cd692ff34cba21ba802a
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 22 Feb 2019 12:56:14 +0000 (12:56 +0000)]
GBP: include sclass in format EPG
Change-Id: I6cbc7dafcc59aa67d79c718d88f67d71ee97b4b6
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 22 Feb 2019 10:48:25 +0000 (02:48 -0800)]
VOM: fix tests and namespacify l2_vtr
Change-Id: Ie59220a622c3a5195485cd6857b45f57d6eeaf95
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 22 Feb 2019 07:25:17 +0000 (23:25 -0800)]
GBP: remove testing asserts
Change-Id: I27ba13b3501debd4dcbda5df05afdcfc497f608f
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Fri, 22 Feb 2019 00:46:24 +0000 (16:46 -0800)]
tcp: send enough dupacks to cover all sack holes
Make sure we send enough dupacks to cover all the holes created in the
last frame received. Also make sure we send all the blocks, not just the
first.
Change-Id: I9597a34ac14473d1cc3ad07d65bc37043e3d0582
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 22 Feb 2019 04:04:15 +0000 (20:04 -0800)]
session/vcl: fix coverity warnings
Change-Id: I9b0e6d65255e516cf5bf18757d4769176ef76e92
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven Luong [Thu, 21 Feb 2019 22:55:52 +0000 (14:55 -0800)]
tapv2: coverity strikes back
while https://gerrit.fd.io/r/#/c/16590/ fixed the leaked fd which coverity
reported at that time, new coverity run reports simailar leaked fd in a
different goto punt path. It would be nice if coverity reported both of them
at the same time. Or perhaps it did and I just missed it. Anyway, the new fix
is to put the close (fd) statement prior to the return of tap_create_if routine
which should catch all goto's.
Change-Id: I0a51ed3710e32d5d74c9cd9b5066a667153e2f9d
Signed-off-by: Steven Luong <sluong@cisco.com>
Code Review / vpp.git / log