vpp.git
7 years agoVPP-241: Add custom dump functions for LISP 31/2231/4
Filip Tehlar [Fri, 5 Aug 2016 15:21:38 +0000 (17:21 +0200)]
VPP-241: Add custom dump functions for LISP

Change-Id: I4ad86190b8f23a992a00f536492ba4f8caefeb43
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoAdd DPDK definition to DOXYGEN 43/2243/1
Keith Burns (alagalah) [Sat, 6 Aug 2016 21:36:10 +0000 (14:36 -0700)]
Add DPDK definition to DOXYGEN

Change-Id: I04e8663b49b5f706940b7aada0a7c2cae913a82b
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-242: Fix wrong checking of LISP Proxy-ITR mode 38/2238/1
Filip Tehlar [Sat, 6 Aug 2016 09:32:19 +0000 (11:32 +0200)]
VPP-242: Fix wrong checking of LISP Proxy-ITR mode

Change-Id: I89c9e52ecf0d053a278a78e57c9e589798b4cb7f
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-237 Coding standards cleanup 37/2237/1
Dave Barach [Fri, 5 Aug 2016 22:09:54 +0000 (18:09 -0400)]
VPP-237 Coding standards cleanup

Change-Id: I239143f920285050ad85244ece6893236195534f
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-223 Document vppinfra/bitmap.h 34/2234/1
Dave Barach [Fri, 5 Aug 2016 18:36:27 +0000 (14:36 -0400)]
VPP-223 Document vppinfra/bitmap.h

Change-Id: I259a5b716bd8a7abdb0e6bf778432f034338ffdc
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agovpp-189 Clean up more coverity warnings 29/2229/1
Dave Barach [Fri, 5 Aug 2016 14:10:18 +0000 (10:10 -0400)]
vpp-189 Clean up more coverity warnings

Time to make the donuts

Change-Id: I528937800f7daefce19723dda0216e58d857942c
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 Clean up more coverity warnings 22/2222/2
Dave Barach [Thu, 4 Aug 2016 22:58:05 +0000 (18:58 -0400)]
VPP-189 Clean up more coverity warnings

Change-Id: I1b971ab326dc334a4743fd7d4184cef106b0523d
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-197: LISP Source/Dest control plane support 13/2213/5
Filip Tehlar [Tue, 2 Aug 2016 17:37:26 +0000 (19:37 +0200)]
VPP-197: LISP Source/Dest control plane support

Change-Id: I0db53af96b925ec0d975dd77f471804b61351aec
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoUpdate coding style for hash_foreach_mem 20/2220/2
Keith Burns (alagalah) [Thu, 4 Aug 2016 16:27:23 +0000 (09:27 -0700)]
Update coding style for hash_foreach_mem

Change-Id: I2f336331463cedb2703150b003761e5c6e4431e8
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-237 vpp-api-test coding style cleanup 16/2216/1
Dave Barach [Thu, 4 Aug 2016 14:15:08 +0000 (10:15 -0400)]
VPP-237 vpp-api-test coding style cleanup

Change-Id: I50a5412463e9346149a7504344a68c8b5762dc97
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoENIC driver patch for PKT_RX_VLAN_PKT packet flag backward compatibility 09/2209/2
John Lo [Thu, 4 Aug 2016 02:45:48 +0000 (22:45 -0400)]
ENIC driver patch for PKT_RX_VLAN_PKT packet flag backward compatibility

The PKT_RX_VLAN_PKT flag will be totally obsolete by 16.11. We still need
this ENIC driver patch for 16.07.

Change-Id: I287035525d2d1b5313e88e9e74b6310536de2c32
Signed-off-by: John Lo <loj@cisco.com>
7 years agoLISP multihoming API changes and cleanup 05/2205/3
Florin Coras [Tue, 2 Aug 2016 00:31:03 +0000 (02:31 +0200)]
LISP multihoming API changes and cleanup

Change-Id: I106352a6da0fad2b91dc8593f8d6d664af3113a8
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-166 Documentation changes for ip4_forward.c 85/2185/6
Keith Burns (alagalah) [Tue, 2 Aug 2016 13:24:59 +0000 (06:24 -0700)]
VPP-166 Documentation changes for ip4_forward.c

Change-Id: Ia9f80bea9ca8a94430ed37ececbe4434f9f5ad48
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-226 - adding UDP TCP to port-range 98/2198/8
Keith Burns (alagalah) [Tue, 2 Aug 2016 18:57:37 +0000 (11:57 -0700)]
VPP-226 - adding UDP TCP to port-range

Change-Id: I5f4261279dcdbb03e182b18d05602407c0e55f89
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-166 Documentation changes for ip4.h/lookup.h 84/2184/3
Keith Burns (alagalah) [Tue, 2 Aug 2016 12:40:20 +0000 (05:40 -0700)]
VPP-166 Documentation changes for ip4.h/lookup.h

Change-Id: Ia9f18b0eeba3a7cee35e66dbd15d3efb567acfc6
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-180 Clean up multi-socket / multi-chunk mempool discovery 96/2196/4
Dave Barach [Tue, 2 Aug 2016 17:31:31 +0000 (13:31 -0400)]
VPP-180 Clean up multi-socket / multi-chunk mempool discovery

Change the default DPDK version to 16.07, and rename the indicated
patch directory. Use the native vhost-user driver.

Change-Id: Ie3d17e90e363ce86f0233b58c152de683b5d9456
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoLISP API/VAT cleanup 70/2170/4
Florin Coras [Tue, 2 Aug 2016 00:31:03 +0000 (02:31 +0200)]
LISP API/VAT cleanup

- cleaned up some of the LISP APIs
- added support for mac in dp APIs

Change-Id: I11d419a30d73ddbf6554768d6dc2a09cc5a6e072
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-233: disallow array[0] in reply messages 01/2201/2
Marek Gradzki [Wed, 3 Aug 2016 08:32:50 +0000 (10:32 +0200)]
VPP-233: disallow array[0] in reply messages

- updates jvpp generator to raise exception
  if array[0] is present in reply/detail/counter message

- fixes vpe.api reply/detail/counter messages
  that use incorrect variable array syntax.

Additional info:

Variable arrays in reply/detail/counter messages needs to have
lenght defined in other variable within the message.
The other variable can have any name, so it is impossible to
generate Java/Python code handling.

New syntax introduced by
https://gerrit.fd.io/r/#/c/1617/
fixes the problem:

u32 some_var;
XX array[some_var];

Change-Id: I0af50f1ef1d94d95b56d9326d4e944e72b4edcdd
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoAPI support for src/dst based routing policy in LISP 97/2197/1
Filip Tehlar [Tue, 2 Aug 2016 17:32:25 +0000 (19:32 +0200)]
API support for src/dst based routing policy in LISP

Change-Id: I0ae90f884378acabeda310a6431c89f3ec195d0e
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-229: fix NPE in JNI array handling 48/2148/3
Marek Gradzki [Mon, 1 Aug 2016 05:59:06 +0000 (07:59 +0200)]
VPP-229: fix NPE in JNI array handling

Change-Id: Ieb5182a7a3612e09bd2b28eb6a4abbdb4d29d34b
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoFix for broken vagrant installs when using Vagrant 1.8.5. 69/2169/3
Thomas F Herbert [Mon, 1 Aug 2016 22:33:48 +0000 (18:33 -0400)]
Fix for broken vagrant installs when using Vagrant 1.8.5.

I upgraded Fedora23 which installed kernel 4.6.4 which in turn required
VirtualBox 5.1.2 which in turn required Vagrant 1.8.5.

Workaround for a change in Vagrant 1.8.5 that breaks Centos. The
newer version of Vagrant doesn't chmod the ssh directory before trying to copy
new public key during installs. This will be fixed upstream in Vagrant 1.8.6.
Bug doesn't affect Ubuntu because it uses a different umask whereas Centos uses
0002.

Change-Id: I8108d4cc208fc47fa69f8a5cf27b2bba7e34293e
Signed-off-by: Thomas F Herbert <therbert@redhat.com>
7 years agoVPP: Fixed dpdk-16.07 BAD checksum error 72/2172/1
Sachin [Tue, 2 Aug 2016 06:05:48 +0000 (11:35 +0530)]
VPP: Fixed dpdk-16.07 BAD checksum error

     - Updated tarball name and checksum value

Change-Id: If06581285e506859bd1edb516b690e963c7de5d0
Signed-off-by: Sachin <sachin.saxena@nxp.com>
7 years agoVPP-226 IPv4 src-address + port range checker 42/942/25
Dave Barach [Sat, 30 Apr 2016 14:25:32 +0000 (10:25 -0400)]
VPP-226 IPv4 src-address + port range checker

Change-Id: Ia251e9d7d53e894a5666109f69e9626d27ea74cb
Signed-off-by: Dave Barach <dave@barachs.net>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoFix new LISP Coverity warnings 61/2161/4
Florin Coras [Mon, 1 Aug 2016 13:35:20 +0000 (15:35 +0200)]
Fix new LISP Coverity warnings

Change-Id: I60ef5218110e596f77d11e3949284a7a7af7dedb
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoUpdate CSIT test 160727 -> 160731 66/2166/1
Jan [Mon, 1 Aug 2016 15:37:37 +0000 (17:37 +0200)]
Update CSIT test 160727 -> 160731

- update of CSIT operational branch to be user for VPP-patch test

Change-Id: I4c5200fbf0fcdc2f8fef2913a9b9a5981a6ecec1
Signed-off-by: Jan <jgelety@cisco.com>
7 years agoJvpp: add handling for mising unsigned array types 47/2147/1
Marek Gradzki [Mon, 1 Aug 2016 05:41:16 +0000 (07:41 +0200)]
Jvpp: add handling for mising unsigned array types

Change-Id: I239082622ceabdd1d0a7b6b6489a2789096a01fc
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoInitial L2 LISP support 42/2142/4
Florin Coras [Thu, 21 Jul 2016 23:45:30 +0000 (01:45 +0200)]
Initial L2 LISP support

This introduces support for layer 2 overlays with LISP. Similarly to L3,
all tenant packets to be encapsulated are captured by an interface, but
the mapping (layer binding) instead of being between an L3 VRF and a
LISP VNI, it is between and an L2 bridge domain and a VNI. At a high
level, this results in two important properties:
1) the source and destinations of all packets flooded in the
   bridge-domain are mapped via the LISP control plane and the replies are
   converted into data-plane tunnels tracked via a LISP specific
   source/dest L2 FIB
2) All packets reaching the interface and matching a source/dest L2 LISP
   FIB entry are L3 (IP4/6) encapsulated.

This is solely a unicast feature, therefore at this time ARPs are not
handled in any special way.

Change-Id: I0b7badcd7c6d5166db07d4acd2cc4ae7fba3e18e
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoAddition of u16[] to JVPP generator 46/2146/1
Keith Burns (alagalah) [Sat, 30 Jul 2016 18:43:14 +0000 (11:43 -0700)]
Addition of u16[] to JVPP generator

Change-Id: I8d746cfae4d64ae200ff0053de23b80ee951c290
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-189: Fix another batch of coverity warnings 45/2145/1
Dave Barach [Sat, 30 Jul 2016 15:01:18 +0000 (11:01 -0400)]
VPP-189: Fix another batch of coverity warnings

Change-Id: I2b13894cca950ddb6732714f3acc180443552b5f
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoRemove per-worker destination frame queue 96/2096/2
Damjan Marion [Tue, 26 Jul 2016 17:55:29 +0000 (19:55 +0200)]
Remove per-worker destination frame queue

This frame queue is not part of the dpdk code anymore,
so it can be removed. It will save some space in the
1st cacelineof dpdk device data struct.

Change-Id: If839861961548750601400a511a609be7ae84b30
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoenic: fix bug introduced with scatter rx 40/2140/2
Shesha Sreenivasamurthy [Fri, 29 Jul 2016 19:42:43 +0000 (12:42 -0700)]
enic: fix bug introduced with scatter rx

    Author: Nelson Escobar <neescoba@cisco.com>
    Date:   Mon Jun 13 17:24:41 2016 -0700

    We did not properly set the rq pointers we pass up to dpdk when
    rx scatter was introduced.  This resulted in segfaults whenever
    more than one rq was being used.

Change-Id: I77a9793ea9035baa1ada77d3af7bc83baf58d097
Signed-off-by: Shesha Sreenivasamurthy <shesha@cisco.com>
7 years agoLISP - fix bug in ip_prefix_normalize_ip6 36/2136/2
Andrej Kozemcak [Fri, 29 Jul 2016 13:18:14 +0000 (15:18 +0200)]
LISP - fix bug in ip_prefix_normalize_ip6

- fix bug
- refactoring code

Change-Id: I2c330f3fbdead567b65c889cfffc2562d99b61db
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoplugins/vcgn-plugin: Fix vpp hang with pthread spinlock 82/2082/2
Michael Qiu [Fri, 8 Jul 2016 07:28:41 +0000 (15:28 +0800)]
plugins/vcgn-plugin: Fix vpp hang with pthread spinlock

Currently, pthread spinlock is initialized in macro ASSERT, thus
the spinlock only will be initialized when CLIB_ASSERT_ENABLE is true.
But CLIB_ASSERT_ENABLE depends on CLIB_DEBUG been set.

Mostly, CLIB_DEBUG is zero, so spinlock will never been initialized,
which will lead vpp hang when try to hold the lock.

This patch fix this issue.

Change-Id: If01982b5df849834ccbc705f8e9291f2b6c32d0a
Signed-off-by: Michael Qiu <qiudayu@chinac.com>
7 years agoplugin/vcgn:Remove local defined ip4_interface_first_address 81/2081/2
Michael Qiu [Thu, 7 Jul 2016 03:28:27 +0000 (11:28 +0800)]
plugin/vcgn:Remove local defined ip4_interface_first_address

Function ip4_interface_first_address has been defined in
vnet/ip/ip4.h, and result an compile issue.

  CC       vcgn/cnat_ipv4_icmp_error_outside_input.lo
  CC       vcgn/cnat_logging.lo
vcgn/cnat_logging.c:361:1: error: conflicting types for 'ip4_interface_first_address'
 ip4_interface_first_address (ip4_main_t * im, u32 sw_if_index)
 ^
In file included from /usr/include/vnet/ip/ip.h:57:0,
                 from vcgn/cnat_logging.c:24:
/usr/include/vnet/ip/ip4.h:390:1: note: previous declaration of 'ip4_interface_first_address' was here
 ip4_interface_first_address (ip4_main_t * im, u32 sw_if_index,
 ^
make: *** [vcgn/cnat_logging.lo] Error 1

Change-Id: I1165c9bb778263c195ed34ab438dcb27dfd207bc
Signed-off-by: Michael Qiu <qiudayu@chinac.com>
7 years agoVPP-142 Follow up fix for shared_count of indirect adjacencies 21/2121/2
John Lo [Thu, 28 Jul 2016 22:41:45 +0000 (18:41 -0400)]
VPP-142 Follow up fix for shared_count of indirect adjacencies

Clean up dead code path added in previous attempt.

Change-Id: Ib95b07bfd7699496f6808da97200993e2104d796
Signed-off-by: John Lo <loj@cisco.com>
7 years agoVPP-189 More coverity bug fixes 20/2120/3
Dave Barach [Thu, 28 Jul 2016 21:55:30 +0000 (17:55 -0400)]
VPP-189 More coverity bug fixes

Change-Id: I6e9290b26b1e74fc5652b689c8d5cc2972ac11d5
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-223 Bounded-index extensible hash documentation 08/2108/3
Dave Barach [Wed, 27 Jul 2016 20:58:51 +0000 (16:58 -0400)]
VPP-223 Bounded-index extensible hash documentation

Change-Id: If162252062014dbd8ef44f7f10649d54d9a288b0
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoAdd IP adjacency registration function 07/2107/3
Pierre Pfister [Wed, 27 Jul 2016 16:46:11 +0000 (17:46 +0100)]
Add IP adjacency registration function

Given that it is possible and easy to add dynamic
IP adjacencies, it might be helpful to have an explicit
call to do so.
This way, additional information such as how to display
the adjacency can be provided at the same time.

Change-Id: I5c735ae45ed763560352f637e3462f2931dc97d9
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoEdit eid table dump 55/1955/5
Andrej Kozemcak [Wed, 13 Jul 2016 11:01:01 +0000 (13:01 +0200)]
Edit eid table dump

- change output from eid table
- add eid filter:
all - dump all eid
local - dump local eid
remote - dump remote eid

Change-Id: Ifaaad8abf44cf70c4c22d05252e501456f1f1083
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoLISP - Bug fix, can`t remove static remote mapping 59/2059/6
Andrej Kozemcak [Fri, 22 Jul 2016 10:54:12 +0000 (12:54 +0200)]
LISP - Bug fix, can`t remove static remote mapping

Fix bug, can`t remove static remote mapping,
small update in LISP remote mapping API.

Change-Id: Ide32485a1a0d2cf08829d544500fa2755214b8cc
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoEdit Lisp locator_set API 85/1785/22
Andrej Kozemcak [Mon, 20 Jun 2016 06:47:57 +0000 (08:47 +0200)]
Edit Lisp locator_set API

Change the output format of lisp locator_set API.
Create new API for lisp locator.
Change lisp_enable_disable_status_dump -> show_lisp_status, not use dump
function.

Change-Id: Ie2024cbf5e55b22ba077266220bf8584d5cac07a
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoVPE_API small fix for LISP locator_set 11/2111/2
Andrej Kozemcak [Thu, 28 Jul 2016 07:22:03 +0000 (09:22 +0200)]
VPE_API small fix for LISP locator_set

- add documentation
- use new feature in vpe_api

Change-Id: I2708383aa886494d948feea1869c3fabae94c7bf
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoUpdate CSIT test 160710 -> 160727 10/2110/1
Andrej Kozemcak [Thu, 28 Jul 2016 07:26:23 +0000 (09:26 +0200)]
Update CSIT test 160710 -> 160727

Change-Id: Ia6e4e951a409a3b8caef16bb62d9969ae030b667
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoVPP-210: Clearer error codes in vlib-api for API trace save 05/2105/2
root [Wed, 27 Jul 2016 15:01:31 +0000 (08:01 -0700)]
VPP-210: Clearer error codes in vlib-api for API trace save

Change-Id: Ic02eaaaa8cf7a0f1c75eca8e3b87956d5e9045e7
Signed-off-by: root <calvin.ference@gmail.com>
7 years agoVPP-189 coverity warning cleanups 04/2104/3
Dave Barach [Wed, 27 Jul 2016 14:00:58 +0000 (10:00 -0400)]
VPP-189 coverity warning cleanups

Change-Id: Ia4fbf4352119504e022b89d10d44a5259d94f316
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVhost-User: Fix bind sockaddr length 71/2071/4
Pierre Pfister [Mon, 25 Jul 2016 13:32:02 +0000 (14:32 +0100)]
Vhost-User: Fix bind sockaddr length

The sockaddr length argument provided to bind was wrong.
This patch also adds an error message in the CLI when the
vhost-user add function fails.

Change-Id: Ib4466accffe49c8c3f4951ebf3a83a24529f6a5b
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVAT add_locator_set api support multiple locators 02/2102/2
Andrej Kozemcak [Wed, 27 Jul 2016 08:33:38 +0000 (10:33 +0200)]
VAT add_locator_set api support multiple locators

Change-Id: I22df3d4407bd7fdd953783f00605380a2d6fb46e
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoVPP-214: IPSec cli/api vector ck and ik initialization 99/2099/1
Matus Fabian [Wed, 27 Jul 2016 06:54:07 +0000 (23:54 -0700)]
VPP-214: IPSec cli/api vector ck and ik initialization

Change-Id: I34e19d1feb350c47987b9764b642ef9baa000581
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoVPP-223 General documentation updates 93/2093/1
Chris Luke [Tue, 26 Jul 2016 17:06:10 +0000 (13:06 -0400)]
VPP-223 General documentation updates

Per the TWS session...

- Some simple treatment of the contents of pool.h
- Changing some \brief commands to @brief. (will do a more
  complete pass at this later.)

Change-Id: I050ee69c59c4b572ac295b5f86940b7f4c934cd9
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoVPP-165 Update directory list in README 90/2090/3
Chris Luke [Tue, 26 Jul 2016 16:02:46 +0000 (12:02 -0400)]
VPP-165 Update directory list in README

Change-Id: I7bc983860d6cc40f264e509e74b92978667324bc
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoFix missing include dirs in doxygen 88/2088/2
Chris Luke [Mon, 25 Jul 2016 23:58:27 +0000 (19:58 -0400)]
Fix missing include dirs in doxygen

Also allow a developer to alter the directories scanned at runtime to
facilitate shorter run-times when writing documentation.

Change-Id: I2a09519661a3abe1fbc0cfc294000934852af951
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agopolicer classify 69/1669/8
Matus Fabian [Mon, 20 Jun 2016 15:10:42 +0000 (08:10 -0700)]
policer classify

JIRA: VPP-114

If the classifier finds a matching entry, it sends packet to the policer,
packet should be pre-colored for color-aware policers.

Change-Id: I10cb53b49907137769418f230df2cab577d0f3a0
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoFix coverity warnings 86/2086/1
Dave Barach [Tue, 26 Jul 2016 14:30:50 +0000 (10:30 -0400)]
Fix coverity warnings

Change-Id: I37131f2d814a608fe9098daff83ff395f7ce99d7
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFix Coverty warning in lisp_add_del_map_resolver_command_fn 80/2080/1
Florin Coras [Tue, 26 Jul 2016 10:12:17 +0000 (12:12 +0200)]
Fix Coverty warning in lisp_add_del_map_resolver_command_fn

Change-Id: I074d9e026ae42aa14caedc56287816ab64968425
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoAuthor: Dave Barach <dave@barachs.net> 79/2079/2
Dave Barach [Mon, 25 Jul 2016 20:13:00 +0000 (16:13 -0400)]
Author: Dave Barach <dave@barachs.net>
--- log message follows this line --
Coverity: fix minor bug in test code

Change-Id: I5921874b4902fc7fe140a9b22852e7d18583e7ae
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-142 - Follow up fix for shared_count in indirect adjacencies 78/2078/1
John Lo [Mon, 25 Jul 2016 18:34:48 +0000 (14:34 -0400)]
VPP-142 - Follow up fix for shared_count in indirect adjacencies

Change-Id: Ia2d0351ffd40c75cbf9611e00a7e111189ad70b5
Signed-off-by: John Lo <loj@cisco.com>
7 years agoVPP-108: fix buffer overrun 63/2063/1
Dave Barach [Sat, 23 Jul 2016 23:25:37 +0000 (19:25 -0400)]
VPP-108: fix buffer overrun

Probably not seen (yet) in practice due to the message ring allocation
scheme.

Change-Id: I7f01b5c09e0a172ad43ec3b8416e2791cada6122
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 Fix 137 coverity no-op issues from vpeapigen 62/2062/3
Chris Luke [Fri, 22 Jul 2016 13:40:19 +0000 (09:40 -0400)]
VPP-189 Fix 137 coverity no-op issues from vpeapigen

vpeapigen is not properly detecting no-op endian swap operations (on u8
or u8[] types) which in turn causes Coverity to currently report ~137
minor issues from the generated vpe.api.h file.

This patch makes vpeapigen comment out those no-op situations thus:

    /* a->interface_name[0..63] = a->interface_name[0..63] (no-op) */
    /* a->admin_up_down = a->admin_up_down (no-op) */

Change-Id: Ifbc5c93e1939206656e0515b528a4d167c539fd2
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoAdd DPDK 16.07 support (rc3 based) 38/2038/2
Damjan Marion [Wed, 13 Jul 2016 20:44:18 +0000 (22:44 +0200)]
Add DPDK 16.07 support (rc3 based)

DPDK vhost-user support is disabled due to significan changes
in the DPDK vhost-user code which are not compatible with current
VPP code.

Change-Id: I3f0d28cb75f6370282ec7e33d57cbfb77e1a3ce1
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoHONEYCOMB-83: Add Gre Feature 51/2051/3
Hongjun Ni [Fri, 22 Jul 2016 10:19:19 +0000 (18:19 +0800)]
HONEYCOMB-83: Add Gre Feature

PatchSet 3: use clib_memcpy for copy.
PatchSet 2: use clib_memcpy() to copy IP address.
PatchSet 1: Support IPv6 interface for GRE API.

Change-Id: I80ee4b61df15da7fd851b682a97d5d49f89568b7
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
7 years agoAdd support for Chelsio T540-CR and T580-CR 41/2041/5
Damjan Marion [Thu, 21 Jul 2016 12:22:59 +0000 (05:22 -0700)]
Add support for Chelsio T540-CR and T580-CR

Change-Id: Ibe927027c2aea6f2d85a9c50bf462c552b63861c
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAs interface is set to L3 mode, reset its output_node_index for l2-output 49/2049/2
John Lo [Thu, 21 Jul 2016 18:54:05 +0000 (14:54 -0400)]
As interface is set to L3 mode, reset its output_node_index for l2-output

As an interface is changed from L2 bridging/xconenct to L3 mode, reset the
output_node_index for l2-output for the interface's sw_if_index. The reset
needs to be done in case the sw_if_index of this interface is freed and
reused for another interface type afterwards. Otherwise, the stale output
node may be used by l2-output for this sw_if_index and result in undesirable
behavior including the possibility of VPP crash.

Change-Id: Idd91d288c7643f0a1975a6787fcc330d03a7fac7
Signed-off-by: John Lo <loj@cisco.com>
7 years agoImprove interface naming for NICs ports sharing same PCI ID 40/2040/4
Damjan Marion [Thu, 21 Jul 2016 10:42:37 +0000 (03:42 -0700)]
Improve interface naming for NICs ports sharing same PCI ID

Change-Id: I68d708f5dd76dc7a46c3c8634aa8f18c515177e5
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoUpdating gitignore for generated plugins folder 43/2043/2
Keith Burns (alagalah) [Thu, 21 Jul 2016 13:12:13 +0000 (06:12 -0700)]
Updating gitignore for generated plugins folder

Change-Id: I266db9f4667c4f720d6109fad5c4d31eb182ed30
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoRename reused LISP interfaces 19/2019/2
Florin Coras [Tue, 19 Jul 2016 14:27:08 +0000 (16:27 +0200)]
Rename reused LISP interfaces

Change-Id: I0efb4c488ea18504a87c845f8fe399f0333d5be2
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoFix CLI for adding LISP fwd entries 21/2021/2
Florin Coras [Tue, 19 Jul 2016 13:27:58 +0000 (15:27 +0200)]
Fix CLI for adding LISP fwd entries

Change-Id: Ib707d252e624e3c1c4ac261fd3cef17b097633e5
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agol2_rw preload starts where data is 64/1964/3
Pierre Pfister [Fri, 15 Jul 2016 07:41:04 +0000 (08:41 +0100)]
l2_rw preload starts where data is

Change-Id: I8819f78dedb02abd38ae0c404e9524ebde12191f
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agotapcli: Use error counter for buffer allocation error 65/1965/3
Pierre Pfister [Fri, 15 Jul 2016 07:44:10 +0000 (08:44 +0100)]
tapcli: Use error counter for buffer allocation error

Change-Id: Ic51a0d17918de56869cfd4a371054fb380000089
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agobuild-root/vagrant: Fix SSE4.x for VB 31/2031/2
Ray [Wed, 20 Jul 2016 12:13:18 +0000 (13:13 +0100)]
build-root/vagrant: Fix SSE4.x for VB

Number of users are reporting issues using VPP with Vagrant and the
VirtualBox provider. VPP quits complaining that SSE support is not enabled.

This change explicity enables SSE4.x support in the VirtualBox VM.

Change-Id: Ia26dc43276aae4179609febfd705d868fa3e07c6
Signed-off-by: Ray <ray.kinsella@intel.com>
7 years agoAdd API calls for packet generator 39/1939/4
Pavel Kotucek [Tue, 12 Jul 2016 08:18:26 +0000 (10:18 +0200)]
Add API calls for packet generator

Added new API to:
- create packet generator interface
- enable packet generator per stream or all
- capture into file

Change-Id: I0e6c1f28069853e4b26f0dc9d282353b0b7f6512
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
7 years agoVPP-123: remove japi (the old Java API) 33/2033/4
Marek Gradzki [Wed, 20 Jul 2016 12:53:48 +0000 (14:53 +0200)]
VPP-123: remove japi (the old Java API)

MANUAL_JAVA flag (used only by the japi)
was also removed.

Change-Id: Ied21521b2410af1c357afb04cbf9e849632ddc5f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoENIC driver update to init mbuf data offset to RTE_PKTMBUF_HEADROOM 37/2037/1
John Lo [Wed, 20 Jul 2016 20:14:57 +0000 (16:14 -0400)]
ENIC driver update to init mbuf data offset to RTE_PKTMBUF_HEADROOM

Change-Id: I19e3e2b28c45d9f7efdd791d6dab126f6508df3e
Signed-off-by: John Lo <loj@cisco.com>
7 years agoAdd new lisp API - Show pitr 32/2032/1
Andrej Kozemcak [Mon, 18 Jul 2016 11:55:37 +0000 (13:55 +0200)]
Add new lisp API - Show pitr

VAT API:
   - show_lisp_pitr
CLI API:
   - show lisp pitr

Change-Id: Ibd31cb09efc34a49b439338e9467faf7a151f2cd
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoL2TP: Add option for custom fib id for outgoing encapsulated packets 67/1967/3
Pierre Pfister [Fri, 15 Jul 2016 08:19:39 +0000 (09:19 +0100)]
L2TP: Add option for custom fib id for outgoing encapsulated packets

If a custom fib ID is used (different from ~0), the associated
fib is used to forward outgoing encapsulated packets.
Otherwise, the fib used is the same as for any packet
received on the original RX interface (L2TP does not modify RX interface index).

Change-Id: I4533d5f7fa432c78c937d3acdd802d0d1c92a0c7
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoIP6 forward: Add ND route when next-hop is unknown link local 56/1856/4
Pierre Pfister [Tue, 5 Jul 2016 14:36:26 +0000 (15:36 +0100)]
IP6 forward: Add ND route when next-hop is unknown link local

Indirect routes have been recently added. When the next-hop is not known,
an indirect route is automatically installed instead. But it makes no
sense to add an indirect route for a link-local next-hop addresses.

Instead, it may make sense to add an ND entry to the
yet-to-be-met neighbor.

Also corrected some indentation.

Change-Id: Ia83c9cd1feafac742680745e82c6faf9f2e1e536
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoILA: Add direction option to disable ila2sir or sir2ila 28/2028/1
Pierre Pfister [Wed, 20 Jul 2016 07:39:38 +0000 (08:39 +0100)]
ILA: Add direction option to disable ila2sir or sir2ila

In a ILA router use case as described by the draft, it is proposed
to disable ILA to SIR translation and do SIR to ILA only.

Change-Id: I8d0980bb75c8d925c1d1aa4563030919dd220620
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVPP-203 Find the relative next node index by node names 22/2022/1
Keith Burns (alagalah) [Tue, 19 Jul 2016 21:47:43 +0000 (14:47 -0700)]
VPP-203 Find the relative next node index by node names

vat# get_next_index node-name vxlan4-input next-node-name l2-input
next node index 1

Change-Id: Ib71be8a408d08d59b0ed7dfb6ada9711cf29bd69
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoOn bonded interface admin-down, should stop all slave links 91/1991/3
John Lo [Mon, 18 Jul 2016 22:06:14 +0000 (18:06 -0400)]
On bonded interface admin-down, should stop all slave links

When bonded interface is set to admin down, all slave links should
also be stopped or they will continue to receive packets and then
be dropped because bonded interface is down.

Also remove setting bonded interface L3 packet size limit to that of
slave on startup - it is not needed and can cause undesirable side
effect if its value become incompatible with bonded interface MTU.

Change-Id: Ibdd8acac0ca41a867131441eb26518592bb7d98a
Signed-off-by: John Lo <loj@cisco.com>
7 years agoFix CLI to add LISP interface 08/2008/3
Florin Coras [Tue, 19 Jul 2016 09:52:35 +0000 (11:52 +0200)]
Fix CLI to add LISP interface

Change-Id: Id59a5f3dcea46679deb759a8e4af187125f33cbd
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoTap: Fix hardware address assignment 84/1984/3
Mohsin KAZMI [Mon, 18 Jul 2016 14:57:40 +0000 (16:57 +0200)]
Tap: Fix hardware address assignment

[VPP-200]: Previously, VPP set the same hardware address to tap interface as of
Linux side tap interface, if neither hardware address nor 'random'
keyword were given explicitly on VPP command line during tap creation or
modification, which was default case.

This patch makes sure to set the different hardware addresses randomly
as default case. While one can set unique hardware address or similar to
one at Linux side using VPP tap command line.

Change-Id: Ie0a82f3706834e87426d66c6e869ec4edfefe932
Signed-off-by: Mohsin KAZMI <sykazmi@cisco.com>
7 years agoAdd uid/gid config parameters to shared-vm database map operator 86/1986/1
Dave Barach [Mon, 18 Jul 2016 18:23:36 +0000 (14:23 -0400)]
Add uid/gid config parameters to shared-vm database map operator

So vpp_get_metrics and similar will not need to run as root

Change-Id: I635e830834c82990ad84ddaae06f2e50e55fd616
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFix "show hardware" CLI display for bonded interface may corrupt heap 85/1985/2
John Lo [Mon, 18 Jul 2016 16:20:09 +0000 (12:20 -0400)]
Fix "show hardware" CLI display for bonded interface may corrupt heap

Change-Id: Ie379844047b6402884653d3fd682010a1d09d14a
Signed-off-by: John Lo <loj@cisco.com>
7 years agoFix local eid API in VAT 83/1983/1
Florin Coras [Mon, 18 Jul 2016 15:06:20 +0000 (17:06 +0200)]
Fix local eid API in VAT

Change-Id: I14fb0378944db5bf7a8843b4dc361de748659ece
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoUse oper-160710 CSIT branch for 'verify' jobs 63/1963/3
Miroslav Miklus [Fri, 15 Jul 2016 07:22:48 +0000 (09:22 +0200)]
Use oper-160710 CSIT branch for 'verify' jobs

Change-Id: I798a1f4168a6d3e60fc9f115b33cd7a5b2782df6
Signed-off-by: Miroslav Miklus <mmiklus@cisco.com>
7 years agoOutput format change from "vlan 802.1q" to "802.1q vlan", addition to VPP-111 81/1981/1
marek zavodsky [Mon, 18 Jul 2016 08:59:57 +0000 (10:59 +0200)]
Output format change from "vlan 802.1q" to "802.1q vlan", addition to VPP-111

Change-Id: Ieac14c88e6f0d2d88da1fe47f981fa33ae6f7c23
Signed-off-by: marek zavodsky <mazavods@gmail.com>
7 years agoImprove "indent foo.c" prep script 79/1979/2
Dave Barach [Sun, 17 Jul 2016 15:52:10 +0000 (11:52 -0400)]
Improve "indent foo.c" prep script

Change-Id: Ibb569b745954a11fb9c7751ad2d4140b922478fe
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-187: Standardized retvalue types in vpe.api 75/1975/2
Calvin [Fri, 15 Jul 2016 19:07:58 +0000 (15:07 -0400)]
VPP-187: Standardized retvalue types in vpe.api

Change-Id: I0cb0d2588a824c0fa040bbc5a30c3bb8be96aa0f
Signed-off-by: Calvin <calvin.ference@gmail.com>
7 years agoAdd ILA plugin 78/1978/2
Pierre Pfister [Sat, 16 Jul 2016 07:51:16 +0000 (08:51 +0100)]
Add ILA plugin

This plugin is implementation of Identifier Locator Addressing (ILA)
per IETF draft-herbert-nvo3-ila-2

Change-Id: I5d5f8fb55c490f358f628bceb5f57e7e7408e6ed
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
Signed-off-by: Wolfgang <wolfgang.beck01@gmail.com>
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAdd DPDK patches for i40e vPMD (ptype and ip checksum offload) 77/1977/2
Damjan Marion [Sat, 16 Jul 2016 15:47:22 +0000 (17:47 +0200)]
Add DPDK patches for i40e vPMD (ptype and ip checksum offload)

Change-Id: Idf38ee8f8cfc31be62fcf0b828832b2f06876815
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years ago- fixed misleading indentation (fixes compilation error on gcc versio 6.1.1) 76/1976/1
Wolfgang [Sat, 16 Jul 2016 09:23:43 +0000 (11:23 +0200)]
- fixed misleading indentation (fixes compilation error on gcc versio 6.1.1)

Change-Id: I7f666a5fb9dac3cac88633d01e1941dac7cc012d
Signed-off-by: Wolfgang Beck <wolfgang.beck01@gmail.com>
7 years agovhost-user: Reset virt-queue info when a vhost interface is disconnected. 62/1962/3
Steve Shin [Thu, 14 Jul 2016 19:06:01 +0000 (12:06 -0700)]
vhost-user: Reset virt-queue info when a vhost interface is disconnected.

When a vhost interface is disconneted, virt-queue info should be cleaned up.
This will avoid any potential vpp crash due to unmmaped memory access.

Change-Id: Ia20153da9eb45412bb41d76ef66ede175ea6fef1
Signed-off-by: Steve Shin <jonshin@cisco.com>
7 years agoAdd a command line utility to display critical vpp engine metrics 61/1961/3
Dave Barach [Thu, 14 Jul 2016 14:05:37 +0000 (07:05 -0700)]
Add a command line utility to display critical vpp engine metrics

vector rate, aggregate rx rate, [configurable] significant error rate

Change-Id: If0b7316a62cb8478d1466f1c9a9903d6df2a6ca0
Signed-off-by: Dave Barach <openvpp@barachs.net>
7 years agoShow 802.1q/802.1ah details in the trace output, fixes VPP-111 46/1746/5
marek zavodsky [Thu, 7 Jul 2016 01:16:10 +0000 (03:16 +0200)]
Show 802.1q/802.1ah details in the trace output, fixes VPP-111

added one line to dpdk-input trace to display vlan tci when PKT_RX_VLAN_PKT flag set
cleaned trace output of af_packet node. Added formatter for vlan_tci.
Merged with John Lo's ethernet trace extension:
Decode both dot1q and dot1ad VLAN tags in ethernet format function
and show what type of vlan tag it is.

dpdk-input & ethernet trace output example of ARP:

00:00:41:545481: dpdk-input
  TenGigabitEthernet8/0/1 rx queue 0
  buffer 0x10f2e: current data 0, length 60, free-list 0, totlen-nifb 0, trace 0x1
  PKT MBUF: port 4, nb_segs 1, pkt_len 60
    buf_len 2176, data_len 60, ol_flags 0x1, data_off 128, phys_addr 0x70e38ac0
    packet_type 0x0
    Packet Offload Flags
      PKT_RX_VLAN_PKT (0x0001) RX packet is a 802.1q VLAN packet ID 100
  ARP: 8c:60:4f:dd:ca:81 -> ff:ff:ff:ff:ff:ff vlan 802.1q id 100
  request, type ethernet/IP4, address size 6/4
  8c:60:4f:dd:ca:81/172.16.110.1 -> ff:ff:ff:ff:ff:ff/172.16.110.10
00:00:41:545492: ethernet-input
  ARP: 8c:60:4f:dd:ca:81 -> ff:ff:ff:ff:ff:ff vlan 802.1q id 100
00:00:41:545499: error-drop
  ethernet-input: unknown vlan

Change-Id: Iae67a945fda4aa2f24032e305a24544dd182b065
Signed-off-by: marek zavodsky <mazavods@gmail.com>
7 years agoVPP-189 Addtional fixes for last coverity fix in linux_pci.c 58/1958/3
John Lo [Wed, 13 Jul 2016 22:13:02 +0000 (18:13 -0400)]
VPP-189 Addtional fixes for last coverity fix in linux_pci.c

Fix VPP startup problem where it cannot attach to a combination
of 3 Intel igb 1GE ports and 2 Intel ixgbe 10GE ports whose PCI
addresses are specified in the DPDK section of VPP startup
config file as follows:
dpdk { dev 0000:02:00.1 dev 0000:02:00.2 dev 0000:02:00.3
       dev 0000:05:00.0 dev 0000:05:00.1 }

Change-Id: Ibb12f9e9a9184d00da51a49961772ac3a42a2d1d
Signed-off-by: John Lo <loj@cisco.com>
7 years agoAdd API dump call for vrf/vni mapping to vpp-api-test 52/1952/2
Filip Tehlar [Wed, 13 Jul 2016 11:17:15 +0000 (13:17 +0200)]
Add API dump call for vrf/vni mapping to vpp-api-test

Change-Id: I7a028ce9ddf21bd3a7d4991ba1be05e5e74202d6
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoAdd plugins debian packaging 53/1953/1
Damjan Marion [Wed, 13 Jul 2016 11:42:33 +0000 (13:42 +0200)]
Add plugins debian packaging

New debian package "vpp-plugins" is created with enabled plugins.

Change-Id: I8920178e8874f12e075858001ec44257dfaf497d
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agopacket-generator: various fixes 46/1946/1
Damjan Marion [Tue, 12 Jul 2016 19:58:19 +0000 (21:58 +0200)]
packet-generator: various fixes

Change-Id: I8f1be9a501574ff4d5024ed0d632392708716e77
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoShow cli for plugin path, name filter and loaded plugins 36/1936/2
Shwetha Bhandari [Mon, 11 Jul 2016 22:08:54 +0000 (23:08 +0100)]
Show cli for plugin path, name filter and loaded plugins

Change-Id: If6ab5f08bcdcf5e24bb8b31926894d2a56cb6c14
Signed-off-by: Shwetha Bhandari <shwethab@cisco.com>
7 years agopolicer action 27/1327/6
Matus Fabian [Tue, 31 May 2016 14:33:29 +0000 (07:33 -0700)]
policer action

JIRA: VPP-90

Policer allows you to specify the action to be taken on a packet:
    conform-action (green color)
    exceed-action (yellow color)
    violate-action (red color)
Action to take on packets:
    drop - drops the packet
    transmit - transmits the packet, the packet is not altered
    mark-and-transmit <DSCP> - sets the DSCP value and transmits the packet

Change-Id: I59c037e55e7e2a9fc9b9752e92426f3977f5587b
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoAdd incrementing MAC / count support for the l2fib_add_del API 37/1937/2
Dave Barach [Mon, 11 Jul 2016 23:48:42 +0000 (16:48 -0700)]
Add incrementing MAC / count support for the l2fib_add_del API

Change-Id: I1df1cd3d2630baab979e840153f1f109d3ead0c2
Signed-off-by: Dave Barach <openvpp@barachs.net>