vpp.git
7 years agoVPP-240: delete subinterface 14/2514/6
Pavel Kotucek [Fri, 26 Aug 2016 11:35:40 +0000 (13:35 +0200)]
VPP-240: delete subinterface

Added new CLI and API command to delete subinterface.

Change-Id: Ia92a8facc6ad84634bdec430093e6add02ee674e
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
7 years agoFix for vppctl to suppress "load_one_plugin:63: Loaded plugin:" msgs 59/2559/1
Ed Warnicke [Wed, 31 Aug 2016 01:09:24 +0000 (18:09 -0700)]
Fix for vppctl to suppress "load_one_plugin:63: Loaded plugin:" msgs

Change-Id: I06fcb024036b48a6401d2865a2181b122cb32108
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoVPP-365: Fix sending of bd_index in lisp_eid_table_add_del_map 49/2549/3
Filip Tehlar [Tue, 30 Aug 2016 13:05:18 +0000 (15:05 +0200)]
VPP-365: Fix sending of bd_index in lisp_eid_table_add_del_map

Change-Id: I1f8fd65fa33b0bc7ee07aa0eeb5f794a7ede9537
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-364 Add vpp-api/python/build to gitignore 46/2546/3
Florin Coras [Tue, 30 Aug 2016 09:46:11 +0000 (11:46 +0200)]
VPP-364 Add vpp-api/python/build to gitignore

Change-Id: I16a594ad75c085b8d0b74cf2f472f88a655253c0
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-361: Memory leak on delete of VXLAN over IPv6 tunnel 43/2543/2
John Lo [Tue, 30 Aug 2016 04:10:09 +0000 (00:10 -0400)]
VPP-361: Memory leak on delete of VXLAN over IPv6 tunnel

The key for VXLAN over IPv6 tunnel is allocated on create and should
be freed on delete.

Change-Id: I11bdd9465030fed57cc4bbd28dbccdf952633b34
Signed-off-by: John Lo <loj@cisco.com>
7 years agoVPP-353: Fully support LISP negative mappings in API 25/2525/3
Filip Tehlar [Sat, 27 Aug 2016 06:40:26 +0000 (08:40 +0200)]
VPP-353: Fully support LISP negative mappings in API

Change-Id: I71943fb4ae2a2f71bcf1ad73512812edf96c06da
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-360 Allow L2 classify to use dynamic graph arcs 39/2539/1
Dave Barach [Mon, 29 Aug 2016 20:31:47 +0000 (16:31 -0400)]
VPP-360 Allow L2 classify to use dynamic graph arcs

Simple change so we can program L2 classifier per-session next-indices
and per-table miss-next-indices using dynamically-created graph arcs.

Change-Id: I9d4a3c82b83e94557075d56a6842d7075ed58905
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-310 Mapping algorithm compute wrong ea-bits 23/2523/2
Ole Troan [Thu, 25 Aug 2016 10:26:47 +0000 (12:26 +0200)]
VPP-310 Mapping algorithm compute wrong ea-bits

Mapping of IPv4 prefixes ended up writing past IPv6 prefix + EA bits
length.
(Added some unit testing code).

Change-Id: I59893b44eea5cebf00a23afc405832741f84cf4f
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agoVPP-307: Documentation for vnet/vnet/vxlan-gpe 06/2506/4
Keith Burns (alagalah) [Thu, 25 Aug 2016 18:21:39 +0000 (11:21 -0700)]
VPP-307: Documentation for vnet/vnet/vxlan-gpe

Change-Id: Iaab6f4b63ed0d986be1ac0636c692b46098ad54d
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-357 Fix vni for LISP fwd entry removals 21/2521/1
Florin Coras [Thu, 25 Aug 2016 23:47:47 +0000 (19:47 -0400)]
VPP-357 Fix vni for LISP fwd entry removals

Change-Id: I5d20c1939f7a5a142bf696b34143f7ebca6afbcb
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-356: Fix wrong byte order in LISP API 12/2512/2
Filip Tehlar [Fri, 26 Aug 2016 10:44:38 +0000 (12:44 +0200)]
VPP-356: Fix wrong byte order in LISP API

Change-Id: Ib2284025b8394a87f1d5765713adb7070b450cba
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-305: Documentation for vnet/vnet/unix 08/2508/2
Keith Burns (alagalah) [Thu, 25 Aug 2016 20:37:37 +0000 (13:37 -0700)]
VPP-305: Documentation for vnet/vnet/unix

Change-Id: I3f1a225033ecebe0cedfc3466b552176461b76ab
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-329: Add L2 support to lisp_eid_table_map_dump 79/2479/3
Filip Tehlar [Wed, 24 Aug 2016 12:11:07 +0000 (14:11 +0200)]
VPP-329: Add L2 support to lisp_eid_table_map_dump

Change-Id: Idfb115cd1f95394f4a4a569dc34c0488a1d58558
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-271: Coding style cleanup vnet/vnet/snap 00/2500/2
Calvin Ference [Thu, 25 Aug 2016 14:04:09 +0000 (10:04 -0400)]
VPP-271: Coding style cleanup vnet/vnet/snap

Change-Id: I810082b5a4072b11ffd0bcc2917347562deb253a
Signed-off-by: Calvin Ference <cference@inocybe.ca>
7 years agoSave rewrite length for post-rewrite rewind action 91/2491/3
Dave Barach [Wed, 24 Aug 2016 22:36:03 +0000 (18:36 -0400)]
Save rewrite length for post-rewrite rewind action

Change-Id: I5dd52714f8422c15bf78da19bcb63246f9d0103d
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFix vxlan-gpe next protocol value 28/2428/2
Yi Yang [Thu, 18 Aug 2016 06:06:52 +0000 (14:06 +0800)]
Fix vxlan-gpe next protocol value

vxlan4_gpe_rewrite and vxlan6_gpe_rewrite used the fixed value
VXLAN_GPE_PROTOCOL_IP4 for next protocol regardless of vxlan-gpe
port next protocol, this commit fixed it and used the value from
vxlan-gpe port.

Change-Id: I22ba25fbde1c0630960cbcfd196e14231fbf1af3
Signed-off-by: Yi Yang <yi.y.yang@intel.com>
7 years agoAdding python-dev dependency to main Makefile. 93/2493/2
Ole Troan [Wed, 24 Aug 2016 19:10:46 +0000 (21:10 +0200)]
Adding python-dev dependency to main Makefile.

Change-Id: I9968015acfc2cc63f97dee25538a9b3e61fac5b6
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agoVPP-228 VPP-326: MAP: Adding additional API/CLI input parameter checks. 97/2497/3
Ole Troan [Wed, 24 Aug 2016 22:24:08 +0000 (00:24 +0200)]
VPP-228 VPP-326: MAP: Adding additional API/CLI input parameter checks.

Added checks for EA bits length + PSID length > 64.
Removed incorrect check in VAT that required all arguments as mandatory.

Change-Id: I33a138612d199d7c5ce59abe1a7d7ecede3522bc
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agoVPP-328: Add dump call for listing LISP VNIs 77/2477/3
Filip Tehlar [Wed, 24 Aug 2016 09:28:02 +0000 (11:28 +0200)]
VPP-328: Add dump call for listing LISP VNIs

Change-Id: I45c054ad638a0e918dddefa4468ff65452949970
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoFix ip6-rewrite drops when no feature is configured 96/2496/2
AkshayaNadahalli [Thu, 25 Aug 2016 08:55:28 +0000 (10:55 +0200)]
Fix ip6-rewrite drops when no feature is configured

In ip6_rewrite_inline(), only in dual loop next0 and next1 are set to IP6_REWRITE_NEXT_DROP and never updated unless there is an o/p feature configured on it. So any packets processed under dual loop are dropped.
Single loop works fine as next0 is updated correctly.
Fix is to update next node from adjacency under dual packet loop processing.

Change-Id: I902fcc84ed307464d92499f9d37137af660b592c
Signed-off-by: AkshayaNadahalli <anadahal@cisco.com>
7 years agoFix issues with vhost-user when dpdk vhost-user is disabled, fixes VPP-347, VPP-349 80/2480/2
Damjan Marion [Wed, 24 Aug 2016 12:32:39 +0000 (14:32 +0200)]
Fix issues with vhost-user when dpdk vhost-user is disabled, fixes VPP-347, VPP-349

Change-Id: I774bab98e43d55678a67a7708ca50edbbd4cbb06
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP-345: pull in upstream checksum patch for ICMP packets 64/2464/3
Sean Chandler [Mon, 22 Aug 2016 20:32:22 +0000 (16:32 -0400)]
VPP-345: pull in upstream checksum patch for ICMP packets

http://www.dpdk.org/dev/patchwork/patch/15216/

Change-Id: I91b67f3e5c0abff52626e504e2707814ae0c3ed0
Signed-off-by: Sean Chandler <seandchandler@gmail.com>
7 years agoVPP Python language binding - plugin support 78/2178/12
Ole Troan [Mon, 1 Aug 2016 02:59:13 +0000 (04:59 +0200)]
VPP Python language binding - plugin support

- Moved Python generator tool to tools directory
- Added build-vpp-api Makefile target
- Generator now only creates a Python representation of the .api
  the rest of the framework is in the vpp_papi script
- Each plugin has its own namespace.
- Plugin Python files are installed in vpp_papi_plugins for easy
  use inside the build tree.

Change-Id: I272c83bb7e5d5e416bdbd8a790a3cc35c5a04e38
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agoVPP-262: Coding standards cleanup vnet/vnet/llc 83/2483/2
Calvin [Wed, 24 Aug 2016 14:35:59 +0000 (10:35 -0400)]
VPP-262: Coding standards cleanup vnet/vnet/llc

Change-Id: I15d71ecf9e8ed37a52cbbd45cdc0fc4ee87c0e5f
Signed-off-by: Calvin Ference <cference@inocybe.ca>
7 years agoVPP-346 Document the ip feature registration scheme 74/2474/4
Dave Barach [Tue, 23 Aug 2016 19:23:10 +0000 (15:23 -0400)]
VPP-346 Document the ip feature registration scheme

Change-Id: I81a9e963bdeb437ca228f11aaedca8d122be7471
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-340: MAP-T wrong destination address 89/2489/2
Ole Troan [Wed, 24 Aug 2016 14:17:29 +0000 (16:17 +0200)]
VPP-340: MAP-T wrong destination address

The bug was in VAT MAP code parsing a 32 bit integer into a 8 bit
type.  Perhaps we should try to build some defences in
unformat_chech_input() to avoid these errors.

Rebuild.

Change-Id: Iae4959f7e04d889da2e9650a4201c4db15d74201
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agoVPP-321: Fix param order of unformat_lisp_eid_api 50/2450/3
Filip Tehlar [Mon, 22 Aug 2016 10:29:21 +0000 (12:29 +0200)]
VPP-321: Fix param order of unformat_lisp_eid_api

Change-Id: Ib00ca0f0dab4784a3fb34ffd91c18a3940e9a5d5
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-323: Add LISP locator set index to reply API message 34/2334/3
Filip Tehlar [Thu, 11 Aug 2016 10:21:37 +0000 (12:21 +0200)]
VPP-323: Add LISP locator set index to reply API message

Change-Id: Id798f63f4cf1a8aa7a75931bc23d3c7f5d738938
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoFix PCI vendor_id/device_id detection for SR-IOV devices 67/2467/2
Damjan Marion [Mon, 22 Aug 2016 22:53:22 +0000 (00:53 +0200)]
Fix PCI vendor_id/device_id detection for SR-IOV devices

Change-Id: I06ae392c7c8c3b4be7fd46560add442f42927c22
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP-342: Don't allow remote mapping to overwrite local or static mapping 70/2470/2
Filip Tehlar [Tue, 23 Aug 2016 08:52:44 +0000 (10:52 +0200)]
VPP-342: Don't allow remote mapping to overwrite local or static mapping

Change-Id: I9888d7c087da538b81a6a1967edbdf1103cc095a
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agodpdk: Remove obsolete VMXNET3 driver start/stop workaround 66/2466/6
Damjan Marion [Mon, 22 Aug 2016 20:34:38 +0000 (22:34 +0200)]
dpdk: Remove obsolete VMXNET3 driver start/stop workaround

Change-Id: I4f46f2965891b0bd0d69a2c426068b0fb1ba881e
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP-267: Style cleanup for vnet/vnet/pg 45/2445/3
Calvin [Fri, 19 Aug 2016 20:23:14 +0000 (16:23 -0400)]
VPP-267: Style cleanup for vnet/vnet/pg

Change-Id: I6c8bf1dfee7db4b658c2afa4888bcd52b03808fd
Signed-off-by: Calvin <calvin.ference@gmail.com>
7 years agoVPP-270: Code style cleanup for vnet/vnet/ppp 44/2444/2
Calvin [Fri, 19 Aug 2016 17:43:59 +0000 (13:43 -0400)]
VPP-270: Code style cleanup for vnet/vnet/ppp

Change-Id: I637f1860fedb208d7242dc2798b3d55abac891a3
Signed-off-by: Calvin <calvin.ference@gmail.com>
7 years agoRaw export of IP6 packet with iOAM metadata 67/2267/11
Shwetha [Mon, 8 Aug 2016 14:51:04 +0000 (15:51 +0100)]
Raw export of IP6 packet with iOAM metadata
- is enabled on iOAM pop nodes with "set ioam export ipfix collector"
- ioam_export_node Hooks into vlib graph b/n ip6-hop-by-hop node and ip6-pop-hop-by-hop node
- A buffer per worker thread is created for collecting packet data to be exported
- ioam_export_node exports first 3 cachelines by collecting it in a MTU sized frame, slaps on ipfix header for export
- ioam_export_thread process node - checks for unsent record buffers for longer than 20 seconds and exports it
- Added dual loop and prefetch in add, hop-by-hop and pop functions

To be done:
- IPfix template
- Multi collector distribution of ipfix packets
- Port to be configurable

Change-Id: I959b4253036551382562bdaf10a83fd6f2f1c88b
Signed-off-by: Shwetha <shwethab@cisco.com>
7 years agoUpdate CSIT tests 160815 -> 160821 47/2447/1
Jan [Mon, 22 Aug 2016 08:38:35 +0000 (10:38 +0200)]
Update CSIT tests 160815 -> 160821

- update of CSIT operational branch to be used for VPP-patch test

Change-Id: I4791551fa0b161ac0347d992bcda4bc1fb8c74d2
Signed-off-by: Jan <jgelety@cisco.com>
7 years agoVPP-337 Add per interface IN filtering 18/2418/6
Dave Barach [Wed, 17 Aug 2016 15:54:30 +0000 (11:54 -0400)]
VPP-337 Add per interface IN filtering

- ip post-rewrite feature subgraph arc support

Change-Id: Ia4b07197463021ade916326231af246e2559a290
Signed-off-by: Dave Barach <dave@barachs.net>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agovhost-user: unmap previously configured memory if necessary 37/2437/2
Steve Shin [Fri, 19 Aug 2016 00:34:52 +0000 (17:34 -0700)]
vhost-user: unmap previously configured memory if necessary

If there's any memory-mapped region configued previously,
it should be unmapped before setting up a new vhost memory table.
Otherwise, huge page leakage will happen.

Change-Id: I375f603ea303919f1502df44a26a7384ab2ea00e
Signed-off-by: Steve Shin <jonshin@cisco.com>
7 years agotuntap_rx modification to handle jumbo packets ( > 2K bytes) 36/2436/2
Steve Shin [Thu, 18 Aug 2016 15:16:27 +0000 (08:16 -0700)]
tuntap_rx modification to handle jumbo packets ( > 2K bytes)

Change-Id: Iebe30b87457741ac268b24c96fa7ea8ad1e101a6
Signed-off-by: Steve Shin <jonshin@cisco.com>
7 years agoBump of JVPP version for new MASTER. 25/2425/1
Keith Burns (alagalah) [Thu, 18 Aug 2016 00:43:39 +0000 (17:43 -0700)]
Bump of JVPP version for new MASTER.

Change-Id: If03efcea871641e33fa079d3c1c308dc8e23cdcc
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-202: L2-GRE over IPSec 11/2311/5
Matus Fabian [Wed, 10 Aug 2016 08:55:36 +0000 (01:55 -0700)]
VPP-202: L2-GRE over IPSec

GRE encapsulate layer 2 traffic and IPSec encrypt what is encapsulated by GRE.
The whole point of L2-GRE over IPSec is to tunnel layer 2 over GRE and IPSec by
bridging the physical interface with IPSec-GRE tunnel interface.

Change-Id: Ia4cf9ed407bf663770e0d8905c0ad44ce73bd23b
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoVPP-336: Fix build order for jvpp_{core,registry}.la dependency on jvpp_common.la 21/2421/2
Ed Warnicke [Wed, 17 Aug 2016 18:53:08 +0000 (11:53 -0700)]
VPP-336: Fix build order for jvpp_{core,registry}.la dependency on jvpp_common.la

Change-Id: I886d087532d20bf7e6555da44e4e75ee0ca38268
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoCoding standards cleanup in vnet/vnet/devices, fixes VPP-248 19/2419/2
Damjan Marion [Wed, 17 Aug 2016 15:05:46 +0000 (17:05 +0200)]
Coding standards cleanup in vnet/vnet/devices, fixes VPP-248

Change-Id: I35cf89bf1aa54b76294876e9feb0ed0ccc316975
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP-205: documentation update 14/2414/4
Marek Gradzki [Wed, 17 Aug 2016 10:33:50 +0000 (12:33 +0200)]
VPP-205: documentation update

Change-Id: I98e5bdbd0472c2973885defe2712b53d9da8a536
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoVPP-261 Coding standards cleanup - vnet/vnet/lisp-gpe 10/2410/3
Florin Coras [Tue, 16 Aug 2016 21:04:00 +0000 (23:04 +0200)]
VPP-261 Coding standards cleanup - vnet/vnet/lisp-gpe

Change-Id: I1bc2098e79ce753f3d72f05f2fcac9ab00d0d052
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-260 Coding standards cleanup - vnet/vnet/lisp-cp 07/2407/2
Florin Coras [Tue, 16 Aug 2016 19:09:14 +0000 (21:09 +0200)]
VPP-260 Coding standards cleanup - vnet/vnet/lisp-cp

Change-Id: I29b84c44c12ab746e9e61c30efa0ac3418d1a09a
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoFix coverity issues in IPSec code, fixes VPP-189 02/2402/3
Damjan Marion [Tue, 16 Aug 2016 09:27:02 +0000 (11:27 +0200)]
Fix coverity issues in IPSec code, fixes VPP-189

Change-Id: I4e43606884ebad9a84abda779b82417192727ef3
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoCoding standards cleanup - remove trailing whitespace, fixes VPP-332 06/2406/3
Damjan Marion [Tue, 16 Aug 2016 20:53:54 +0000 (22:53 +0200)]
Coding standards cleanup - remove trailing whitespace, fixes VPP-332

Change-Id: I649a17f8fa47599faf438b2e596f53761790d10c
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoCoding standards cleanup in vnet/vnet/devices/dpdk, partially fixes VPP-248 04/2404/2
Damjan Marion [Tue, 16 Aug 2016 16:56:08 +0000 (18:56 +0200)]
Coding standards cleanup in vnet/vnet/devices/dpdk, partially fixes VPP-248

Change-Id: Ie3ee4ccc126c5db9020779cbd06b0d1da99c8411
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP-205: jvpp plugin support. 61/2361/6
Marek Gradzki [Tue, 26 Jul 2016 13:28:22 +0000 (15:28 +0200)]
VPP-205: jvpp plugin support.

Splits jvpp into two jars
jvpp-registry.jar - base jvpp functionality
jvpp-core.jar - Java wrapper for vpe.api

Plugins can be generated the same way jvpp-core.jar is.
Example (nsh):
https://gerrit.fd.io/r/#/c/2118/

Change-Id: I2254f90b2c3e423563bb91bf70877979f1e90a7d
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoVPP-330 Track pending map-requests with a fifo 03/2403/2
Florin Coras [Mon, 15 Aug 2016 17:16:32 +0000 (19:16 +0200)]
VPP-330 Track pending map-requests with a fifo

Change-Id: Icc64abb91047f756c955c880f6f85b26faef666a
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoCreate python package for jvpp generation. 34/1934/17
Ed Warnicke [Mon, 11 Jul 2016 17:29:41 +0000 (10:29 -0700)]
Create python package for jvpp generation.

Change-Id: I2254f90b2c3e423563bb91bf70877979f1e86a6b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoVPP-258: Style change for l2tp 17/2317/3
Calvin [Wed, 10 Aug 2016 15:01:41 +0000 (11:01 -0400)]
VPP-258: Style change for l2tp

Change-Id: Ib456558974820d8d45114b2bbad014a3a3aa2d21
Signed-off-by: Calvin <calvin.ference@gmail.com>
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFix coverity issues in DPDK code, fixes VPP-189 98/2398/2
Damjan Marion [Tue, 16 Aug 2016 11:25:59 +0000 (13:25 +0200)]
Fix coverity issues in DPDK code, fixes VPP-189

Change-Id: Ie2ebb29451200158504bda8c616d57821edbd749
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoFix coverity issues in vhost-user code, fixes VPP-189 97/2397/1
Damjan Marion [Tue, 16 Aug 2016 10:37:24 +0000 (12:37 +0200)]
Fix coverity issues in vhost-user code, fixes VPP-189

Change-Id: Ief95aac5d4451f411dbed8050528708c0b1b7732
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP251 - Code style vnet/vnet/ethernet 93/2393/5
Keith Burns (alagalah) [Tue, 16 Aug 2016 01:33:19 +0000 (18:33 -0700)]
VPP251 - Code style vnet/vnet/ethernet

Change-Id: I3e51ca70a8e1ac7f6584bc5b0271ee4daacc1084
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-266: style change for vnet/vnet/osi 50/2350/4
Calvin [Thu, 11 Aug 2016 18:10:51 +0000 (14:10 -0400)]
VPP-266: style change for vnet/vnet/osi

Change-Id: I6004a96f9f791fb9fbc961440c9988f7a3ca7db0
Signed-off-by: Calvin <calvin.ference@gmail.com>
7 years agoVhost-User: Fix calculate memory region size 33/2333/4
Jianfeng Tan [Thu, 11 Aug 2016 02:17:30 +0000 (02:17 +0000)]
Vhost-User: Fix calculate memory region size

The memory region size calculation is wrong. For example, a region
with size of 1G (hugepage size is also 1G), and offset is zero, use
the previous way to calculate, the ultimate size to mmap and munmap
is 2G, which could lead to segment fault when munmap is executed.

This patch refers the way in DPDK to calculate the region size.

Change-Id: I6f35cde15e2402be0025c556c192b87a46bbf978
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
7 years agoUpdate CSIT tests 160807 -> 160815 86/2386/3
Jan [Mon, 15 Aug 2016 14:56:42 +0000 (16:56 +0200)]
Update CSIT tests 160807 -> 160815

- update of CSIT operational branch to be used for VPP-patch test

Change-Id: Ia9cb275d9471f3c25a02f943d0ace65aec425f8d
Signed-off-by: Jan <jgelety@cisco.com>
7 years agoVPP-257 Coding standards cleanup for vnet/vnet/l2 90/2390/1
Dave Barach [Mon, 15 Aug 2016 19:31:15 +0000 (15:31 -0400)]
VPP-257 Coding standards cleanup for vnet/vnet/l2

Change-Id: Iba5f33675bb2eb806e9becdc42b11da5d3932d55
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-198: LISP map-resolver failover algorithm 42/2042/6
Filip Tehlar [Mon, 18 Jul 2016 15:35:40 +0000 (17:35 +0200)]
VPP-198: LISP map-resolver failover algorithm

Change-Id: Iadd49e58a359a2e58610bd1793818ec8a25d51f1
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-327 Coding standards cleanup for vppinfra 88/2388/1
Dave Barach [Mon, 15 Aug 2016 15:12:27 +0000 (11:12 -0400)]
VPP-327 Coding standards cleanup for vppinfra

Fix additional a few additional deviations reported elsewhere by
checkstyle

Change-Id: I026a8ae1c5b1856bbe3c4a555e1b690e7501b045
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-236 Support 64-bit vector lengths, shared memory segments >4 GB 07/2207/4
Dave Barach [Wed, 3 Aug 2016 18:34:38 +0000 (14:34 -0400)]
VPP-236 Support 64-bit vector lengths, shared memory segments >4 GB

Change-Id: I02aee33e96e7ae32094b9f82f6a667d30bb52f59
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 Fix another batch of coverity warnings 79/2379/1
Dave Barach [Mon, 15 Aug 2016 12:43:41 +0000 (08:43 -0400)]
VPP-189 Fix another batch of coverity warnings

Change-Id: I1d56bc9377db161ae9226e2b2da7c1916c8d1c3b
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-237: Checkstyle script to check for new checkstyle breakage 35/2235/17
Ed Warnicke [Fri, 5 Aug 2016 18:43:58 +0000 (11:43 -0700)]
VPP-237: Checkstyle script to check for new checkstyle breakage

indent is... cantankerous

It sometimes happens that if you run

indent A

resulting in A'

and then

indent A'

you get back A.  Since the check here is premised on being able
to run indent and not see any changed... we have to run it twice
to be sure.

Change-Id: I5b73e02f5996d8a01ec2e46741affbc6d62da6c9
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoVPP-237: indent fixes in prep for checkstyle 56/2356/2
Ed Warnicke [Fri, 12 Aug 2016 18:42:26 +0000 (11:42 -0700)]
VPP-237: indent fixes in prep for checkstyle

Ran indent *twice*

Change-Id: If9c18b81983bb859cc8dc3b415c67cbf318fc618
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoVPP-237: Bracket VL_API_PACKED(...) macros, which indent mangles 53/2353/4
Ed Warnicke [Thu, 11 Aug 2016 20:30:57 +0000 (13:30 -0700)]
VPP-237: Bracket VL_API_PACKED(...) macros, which indent mangles

Change-Id: I208be749350ddb093ecfae149d420f580846c52a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBracket CLIB_PACKED(...) macros, which indent mangles 52/2352/2
Dave Barach [Thu, 11 Aug 2016 20:03:03 +0000 (16:03 -0400)]
Bracket CLIB_PACKED(...) macros, which indent mangles

Change-Id: I39722d7b778e6e0dc5a2d12d005c102845159116
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 fix more coverity warnings 63/2363/1
Dave Barach [Fri, 12 Aug 2016 13:26:47 +0000 (09:26 -0400)]
VPP-189 fix more coverity warnings

Change-Id: If464a5f06ab15eead9eaf12e89792d3761796956
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-223 Add doxygen tags to counter.h 54/2354/2
Dave Barach [Thu, 11 Aug 2016 21:21:02 +0000 (17:21 -0400)]
VPP-223 Add doxygen tags to counter.h

Change-Id: Ifddf37db04b2ecfa7b470cd52e8eaa2211823f3d
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-321: Fix filtering in LISP EID dump call 51/2351/2
Filip Tehlar [Thu, 11 Aug 2016 19:29:30 +0000 (21:29 +0200)]
VPP-321: Fix filtering in LISP EID dump call

Change-Id: Ide5d461cf324c0d9010f20732748d9c71cf6f02e
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP: NXP dpaa2 platform porting to dpdk-16.07 84/2284/2
Sachin [Tue, 9 Aug 2016 09:07:05 +0000 (14:37 +0530)]
VPP: NXP dpaa2 platform porting to dpdk-16.07

This patch will temporary add the "dpaa2" driver support in VPP in-built DPDK v16.07

Change-Id: Ieb7005c73bdb72e5eac88e17c21474479ad087f0
Signed-off-by: Sachin <sachin.saxena@nxp.com>
7 years agoCoverty error: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) 13/2313/2
Ole Troan [Thu, 4 Aug 2016 08:19:17 +0000 (10:19 +0200)]
Coverty error: Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)

While the code is correct (assignment was intended) I have rewritten
it for readability.

Change-Id: I5f6fd7d7377c3904e74de4edfd478322a75af612
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agoVPP-319: Fix handling of ERANGE from getgrnam_r 18/2318/4
Ed Warnicke [Wed, 10 Aug 2016 15:06:10 +0000 (08:06 -0700)]
VPP-319: Fix handling of ERANGE from getgrnam_r

Change-Id: I1c5b3ed678622a0352fb881f2236a514743f3c50
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoDon't re-add *INDENT-OFF* ... *INDENT-ON* tags 48/2348/2
Dave Barach [Thu, 11 Aug 2016 16:13:55 +0000 (12:13 -0400)]
Don't re-add *INDENT-OFF* ... *INDENT-ON* tags

Change-Id: Ifd2249c0152805e7b23c4629acce31634dca6f04
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-130: LoadBal: Add lookup bypass and fix adjacency format function 45/2345/1
Pierre Pfister [Thu, 11 Aug 2016 15:04:05 +0000 (16:04 +0100)]
VPP-130: LoadBal: Add lookup bypass and fix adjacency format function

Change-Id: Ib83c6ba04c41dbb80603c6a08c324d71eb44a102
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoCustom adjacency formatting fix (Revived) 08/2308/3
Pierre Pfister [Thu, 4 Aug 2016 13:25:01 +0000 (14:25 +0100)]
Custom adjacency formatting fix (Revived)

Looks like something strange is going on with indentation.

Change-Id: I8e734a2119a4a744d7ce76ce83ecc7b237828d3b
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVPP-130: MagLev-like Load Balancer 17/2217/9
Pierre Pfister [Thu, 4 Aug 2016 15:13:09 +0000 (16:13 +0100)]
VPP-130: MagLev-like Load Balancer

This plugin provides load balancing for VPP in a way that is largely inspired
from Google's MagLev: http://research.google.com/pubs/pub44824.html

More info in the README.md

Change-Id: I1223f495d5c2d5200808a398504119f2830337e9
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVPP-196 LISP L2/L3 tunnel multihoming 88/2288/6
Florin Coras [Mon, 8 Aug 2016 14:04:26 +0000 (16:04 +0200)]
VPP-196 LISP L2/L3 tunnel multihoming

Change-Id: If96d9ff23a7aacdb684494f854d4029f55837065
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-321: Fix wrong checking of LISP mapping local flag 40/2340/1
Filip Tehlar [Thu, 11 Aug 2016 12:43:19 +0000 (14:43 +0200)]
VPP-321: Fix wrong checking of LISP mapping local flag

Change-Id: Ia1d5a53742a5ebe34566de0a68c2d0a81e002ffa
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoRename DPDK-16.07 patch file from 0007... to 0008... to avoid conflict 25/2325/2
John Lo [Wed, 10 Aug 2016 23:41:34 +0000 (19:41 -0400)]
Rename DPDK-16.07 patch file from 0007... to 0008... to avoid conflict

There are now two 0007... patch files. So renaming one to 0008...

Change-Id: I82ab883db3436b1fce6b169065b257df052fe63c
Signed-off-by: John Lo <loj@cisco.com>
7 years agoVPP-223 Document vlib cooperative multi-tasking threads 24/2324/2
Dave Barach [Wed, 10 Aug 2016 22:38:36 +0000 (18:38 -0400)]
VPP-223 Document vlib cooperative multi-tasking threads

Change-Id: I283963b004ed6d91133e7e36811f75834280bbe7
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 Fix coverity warnings 23/2323/1
Dave Barach [Wed, 10 Aug 2016 20:56:16 +0000 (16:56 -0400)]
VPP-189 Fix coverity warnings

Change-Id: Iea6d338e60a95f7f30c10c2e751d4827e816f700
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 Fix coverity warnings 20/2320/1
Dave Barach [Wed, 10 Aug 2016 15:35:54 +0000 (11:35 -0400)]
VPP-189 Fix coverity warnings

in api_format.c.

Change-Id: Iedc510fe962b6e8fb8614be4038e695b13e12ef9
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-315: Fix "show vxlan-gpe" issue 10/2210/3
Hongjun Ni [Thu, 4 Aug 2016 16:58:20 +0000 (00:58 +0800)]
VPP-315: Fix "show vxlan-gpe" issue

Change-Id: If721d3b701a7182e595ece1294c2767981d29d3e
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
7 years agoVPP-313: Wrong API dump message in vxlan_add_del_tunnel 05/2305/2
John Lo [Wed, 10 Aug 2016 00:53:09 +0000 (20:53 -0400)]
VPP-313: Wrong API dump message in vxlan_add_del_tunnel

Fix API custom-dump format of ip4/ip6 addresses in the message.

Change-Id: I822e036691846ce6a437834df933c44098944c1f
Signed-off-by: John Lo <loj@cisco.com>
7 years agoDPDK: Fix a crash in igb_uio driver when the device is removed. 12/2312/2
Ray Kinsella [Wed, 10 Aug 2016 11:48:06 +0000 (12:48 +0100)]
DPDK: Fix a crash in igb_uio driver when the device is removed.

This crash happens because the device still has MSI configured,
the fix is to free the IRQ. Adding pending further investigation.

Change-Id: Ifcd3404fcc25fe27dcccc67d0dcf9d8f0ec18582
Signed-off-by: Todd Foggoa (tfoggoa) <tfoggoa@cisco.com>
Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
7 years agoTemporarily disable unthrottled log message from DPDK 16.07 06/2306/2
John Lo [Wed, 10 Aug 2016 02:33:51 +0000 (22:33 -0400)]
Temporarily disable unthrottled log message from DPDK 16.07

Patch to prevent the unthrottled message from spilling to syslog and
fill up disk space.

Change-Id: I239ca27a7568182217a675692e0be966fc3486f5
Signed-off-by: John Lo <loj@cisco.com>
7 years agoVPP-314: Vxlan wrong name of decap node 02/2302/1
John Lo [Tue, 9 Aug 2016 23:20:51 +0000 (19:20 -0400)]
VPP-314: Vxlan wrong name of decap node

Fix VXLAN decap node counter update using the correct node index.

Change-Id: Iebfd2bfd97747bc6d0758f4c5829e23ef9899d74
Signed-off-by: John Lo <loj@cisco.com>
7 years agodpdk: allow applications to override rte delay 92/2292/2
Ray [Tue, 9 Aug 2016 17:35:13 +0000 (18:35 +0100)]
dpdk: allow applications to override rte delay

Some applications may wish to define their own implentation of
usec delay other than the existing blocking one. The default
behavior remains unchanged.

Change-Id: I6cb626e7a5d9d985928aa266e522a849d264a2b2
Signed-off-by: Todd Foggoa (tfoggoa) <tfoggoa@cisco.com>
Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
7 years agoVPP-245 Coding standards cleanup for vnet/vnet/cdp 85/2285/2
Dave Barach [Tue, 9 Aug 2016 12:55:49 +0000 (08:55 -0400)]
VPP-245 Coding standards cleanup for vnet/vnet/cdp

Change-Id: I5253c52eace4b635f7791aa019ab01ec55d7fb4d
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoRevert "Custom adjacency formatting fix" 98/2298/1
Keith Burns [Tue, 9 Aug 2016 19:01:52 +0000 (19:01 +0000)]
Revert "Custom adjacency formatting fix"

This reverts commit ffc7ecace8304217104a5eade163aff5f8903935.

Change-Id: I32784a3e7ddf57abb9d70aa1e06884f028d78397
Signed-off-by: Keith Burns <alagalah@gmail.com>
7 years agoCustom adjacency formatting fix 15/2215/3
Pierre Pfister [Thu, 4 Aug 2016 13:25:01 +0000 (14:25 +0100)]
Custom adjacency formatting fix

Looks like something strange is going on with indentation.

Change-Id: I1522caffa3a8a5e3aa00e1169b7469facc505a8d
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVPP-256 - Coding style cleanup vnet/vnet/ipsec 41/2241/3
Keith Burns (alagalah) [Sat, 6 Aug 2016 18:00:56 +0000 (11:00 -0700)]
VPP-256 - Coding style cleanup vnet/vnet/ipsec

Change-Id: Ie9e05e2c74e7843a937870e2c64db0499f03a6a4
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-235: fixed vat help message for sw_interface_set_l2_bridge 08/2208/2
Calvin [Wed, 3 Aug 2016 20:53:13 +0000 (16:53 -0400)]
VPP-235: fixed vat help message for sw_interface_set_l2_bridge

Change-Id: Ie2a771abbd579c4ffd9679c157dcf435d91ebf7b
Signed-off-by: Calvin <calvin.ference@gmail.com>
7 years agoRename flow_report_sample.c/.h files 60/2260/2
Juraj Sloboda [Mon, 8 Aug 2016 06:40:03 +0000 (23:40 -0700)]
Rename flow_report_sample.c/.h files

Change-Id: I1f82e74977de8879dec9859275afc791f0a55606
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
7 years agoVPP-189 - Coverity OVERRUN error in port-range 71/2271/3
Keith Burns (alagalah) [Mon, 8 Aug 2016 17:49:54 +0000 (10:49 -0700)]
VPP-189 - Coverity OVERRUN error in port-range

Change-Id: Ib9f43dffa9d04478d92063b71dd7bef4ac6969f1
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoDPDK: adding patch to init ptype in vmxnet3, e1000 and virtio PMDs 72/2272/2
Ray [Mon, 8 Aug 2016 18:56:07 +0000 (19:56 +0100)]
DPDK: adding patch to init ptype in vmxnet3, e1000 and virtio PMDs

Ensure the packet_type is reset before the buffer is used.
This can cause packets to be mishandled in systems with more than one type of driver in use.

Change-Id: I14ef9bd6be834d66d19bae36122b648450a9f7e6
Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
Signed-off-by: Todd Foggoa (tfoggoa) <tfoggoa@cisco.com>
7 years agoVPP-189 Fix Coverity warnings 73/2273/2
Dave Barach [Mon, 8 Aug 2016 19:13:42 +0000 (15:13 -0400)]
VPP-189 Fix Coverity warnings

Remove a bunch of historical SMP code that we're not using; clean up
coverity warnings as a side-effect.

Change-Id: Ic80d2f87c7fd4e654078cac23ad5ec287a1d7ffe
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-239 Tag packets that hit LISP negative adjacencies 21/2221/2
Florin Coras [Thu, 4 Aug 2016 22:00:19 +0000 (00:00 +0200)]
VPP-239 Tag packets that hit LISP negative adjacencies

Change-Id: I88eaf23791d0a148513cc32262cd79a7f4e25d1f
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-189 Fix new Coverity warnings 32/2232/2
Florin Coras [Fri, 5 Aug 2016 14:57:33 +0000 (16:57 +0200)]
VPP-189 Fix new Coverity warnings

Change-Id: I2a580320118d9ab638d9ac0986544ebad8d50e67
Signed-off-by: Florin Coras <fcoras@cisco.com>